• 0

    posted a message on VisualHeal
    Quote from Pastamancer »

    Messages are guaranteed to arrive in order.


    And the significance of that statement is void, if you appreciate the obvious fact that there is no guarantee as to which order they are transmittet in, since both messages are triggered off the same event, but by two different addons - you cannot imply any order to the sequence of event handlers (i.e. you don't know if HealComm or CastComm's event handler will be called first).

    Quote from Pastamancer »

    HealComm isn't the only library that should be allowed to add additional data if CastComm allows additional data to be added to events.


    IMO You can get everything else you need from the API.

    The test you made, merely compares the differences between using

    1) string.sub in the receiver
    2) instanciating a new array for each message received, while also using string.gmatch and string.gfind.

    Of course no one would write the receiving end so stupidly - basically you're comparing a well designed inflexible solution (1) with an extremely ill designed flexible solution (2). I find this scientifically flawed.

    For a well designed flexible implementation it's entirely plausible to use string.sub for any message as long as you define the length in characters for each field. There are probably other methods too, that would make it just as efficient and fast, and you cannot just pop in a naive approach and compare it like that.

    I don't care to discuss this matter anymore, you can keep CastComm the way it is, it's a nice library, and it serves it's purpose well. I'll keep HealComm the way it is, it serves it's purpose equally well.
    Posted in: General AddOns
  • 0

    posted a message on GotWood?
    Quote from Phanx »

    If you use WowAceUpdater, and like things to be quick and easy, you can convert to standalone libs by following this procedure:

    1. Open WAU.
    2. Use WAU to download and unpack the !!!StandaloneLibraries package. Don't update your other addons yet.
    3. In WAU's File menu (I think that's where it is), select the "Reinstall All Addons" option. It will now re-download all of your addons without embedded libraries.


    This is not how it is done anymore. Check out the WAU wiki, the new version of WAU will automatically handle externals and standalone libraries without using the !!!StandaloneLibraries package.
    Posted in: General AddOns
  • 0

    posted a message on VisualHeal
    Quote from Pastamancer »

    It's not as inefficient as you'd think, especially considering the parsing overhead that would be involved in allowing arbitrary metadata to be added to CastComm messages.


    Well i don't agree, at all. It's inefficient, and you'll need a handler at the receiving end that deals with the fact that you don't know which one of the two messages (pertaining to the same event) that will arrive first. Also every receiving addon (regardless of nature) will have to receive both messages, compare to their defined prefix, and disregard both, which gives a greater overhead than the overhead associated with reading out an optional extra field of a string that is already parsed. And just the simple fact that we're transmitting twice as many messages as we need to; i think that says it all.

    You're arguing that this:
    _,_,name = string.find("C Joe", "^C (.+)")

    Is much faster than this:
    _,_,name = string.find("C Joe:1234", "^C (.+):")

    I really don't see the overhead in that. Then if you need the info, you can just do:
    _,_,name,healsize = string.find("C Joe:1234", "^C (.+):(%d+)")

    It's completely optional. But i'm not the one to decide what direction CastComm should go.

    Quote from Maniacpriest »

    @ xbeeps: Would it be possible to show Hots? If the MT has many hots you could see how much the next ticks heal befor you cast. So it would be more efficient.


    Heal over time buffs are shown on your unit frames. In the future there will (maybe) be an option to show the buffs relevant to healing on the healbar for the target you're currently healing.
    Posted in: General AddOns
  • 0

    posted a message on Consistancey in SVN Lib structure.
    What we really need is someone to write a wiki page describing exactly how to name stuff. Not a tutorial - a definition.
    Posted in: Libraries
  • 0

    posted a message on VisualHeal
    Quote from Pastamancer »

    Edit: On second thought, HealComm could use CastComm and send its own messages in addition.


    That would be inefficient and doesn't improve anything compared to the current situation. CastComm transmits the target of any spell (because this information is not locally available), while HealComm transmits the target of any *healing* spell as well as the size of that healing spell (before debuffs) in one single message.

    Adding this functionality to CastComm will of course increase the size of the library and require the addition of even more externals (for calculating heal sizes), but from a system perspective it is far more efficient computationally, and it will decrease the total amount of messages transmitted.

    I feel that it is only natural to extend CastComm with additional "meta"-data that elaborates the event that is already being conveyed. It's of course your decision, and i'd be (almost) as happy to keep HealComm as a separate libary. I do believe though, that it will improve interoperability to combine these two and also strengthen the position of CastComm as the single source for spell activity information across a party/raid.
    Posted in: General AddOns
  • 0

    posted a message on GarbageFu
    If no one objects, i'll add ItemPrice as an external to FuBar_GarbageFu and do the necessary integration. I see this as the logical route, now that we have a well-maintained and efficient ace2 library for providing item prices.

    If anyone do object, i'll just fork the addon and name it something else. I also assume that the original author has abandoned the addon.

    Any views/comments/objections ?
    Posted in: FuBar AddOns
  • 0

    posted a message on GarbageFu
    This release by Smoere is not working for me. No error, just no prices (?? shown in GarbageFu). I have a working GarbageFu_Vendor.lua file that i have been using for weeks now without any problems (took me 5mins to figure out what to change to support ItemPrice). I was just wondering if i'm the only one who cannot get the "Smoere" release to work. The differences between what i did and what Smoere did are subtle. The main difference is this:

    I do this:

    If GetSellValue then
    return GetSellValue( .....
    end

    Smoere does this:

    return _G.GetSellValue( ....


    I don't see what that _G has to do there. On top of that, Smoere has hard-coded some hacks into the InitVendorAddonOrder function, so that the GetSellValue plugin is treated differently from the others (based on the name), which i find exceptionally dirty. This is certainly not needed, and i imagine that might be the cause of the problem posted by Zidomo.

    Basically i'm asking if i should commit the code i have, overwriting the Smoere release. So please post if you're having problems with it, or if its working perfectly for you (with ItemPrice!!)
    Posted in: FuBar AddOns
  • 0

    posted a message on ItemPriceTooltip - Official Thread
    I'v added support for ItemPrice to GarbageFu many weeks (if not months) ago, simply by adding a few lines of code to the GarbageFu_Vendor.lua file. I didn't embed the libary, i just use the GetSellValue API (so basically any other item price addon that use that will work too). I'm really surprised that support hasn't been added to GarbageFu yet, so i was wondering if i could add it myself to the trunk so others can benefit too, although i have no idea how to contact the author, and ask if it is ok with him.

    In my opinion ItemPrice is the best item price database available both in terms of technical implementation and coverage. I hope that it will stick to vendor prices (from wowhead) and don't go down the slippery road of auction prices, and i certainly wouldn't like to see inter-client communication either (as some have suggested).
    Posted in: General AddOns
  • 0

    posted a message on VisualHeal
    Quote from maia »

    Quote from Pastamancer »

    Quote from Nomad_Wanderer »

    Is this the same healcomm library that grid uses?



    Nope. Grid is using CastComm.


    Without having taken a look at HealComm, I'd like to express my ongoing hopes for a standardized solution for tracking heals. Even if it's initially only addons listening to all currently available spellcast libraries.


    I certainly agree to that. CastComm, as far as i know does not transmit heal size, which is a requirement for VisualHeal. Otherwise it would have to guess, which is mostly impossible to do accurately enough (because of bonus healing, talents and things like that). If you got some good ideas for interoperability i'm open to all suggestions!
    Posted in: General AddOns
  • 0

    posted a message on VisualHeal
    VisualHeal 3.3 has been released. HealComm is now a real external (in trunk/HealCommLib). Changelist for VisualHeal:

    3.3:
    - Added support for Fel Armor.
    - Removed custom scanning tooltip (now uses Gratuity-2.0 for all tooltip scanning).
    - HealComm-2.0 modified to use the new message format. All players must upgrade if they are using VisualHeal release 3.1 or earlier (use '/vh inquiry' or '/vh guildinquiry' to discover the releases used by your group and guild members respectively).

    Posted in: General AddOns
  • 0

    posted a message on Looking for Healing Addon
    Quote from jonsnow »

    Does VisualHeal and Grid use the same commLib ?

    If not, is it possible to make them use the same ?


    No they don't. VisualHeal needs two pieces of information: the healing target and the size of the heal, and the one in Grid only supplies the first one. VisualHeal uses the embedded library HealComm-2.0, which i will release as soon as i figure out how to do just that (someone need to write a guide on how to properly package libraries and set up dependencies and optional dependencies both for addons and externals).
    Posted in: Addon Ideas
  • 0

    posted a message on VisualHeal
    Hi all, i'm the author ;). Since the "transition" to Ace2 the communication part has been delegated to an Ace2 library, named HealComm-2.0. The purpose was to isolate this part of the addon, so that it could be used by any addon, that wants to display some info about healing (specifically i was hoping to be able to integrate it into Pitbull). This has reduced VisualHeal itself to quite a small addon, that uses the services provided by this library as well as a handfull of other standard Ace2 libraries (which has greatly improved the efficiency in this case), to display some usefull info on the screen.

    The plan for the future is to mature the HealComm library which is currently distributed as an internal part of VisualHeal 3.2. Currently it uses the communication format used by VisualHeal so far (prefix "VisualHeal") but it also has built in support for receiving messages in the new HealComm format (prefix "HealComm"). This means that in the near future, HealComm can be changed to also transmit in the new format, and all clients from VisualHeal 3.2 and onwards, will be able to communicate with it still.

    The HealComm library takes care of communication, and keeps a small internal table with info about who is healing who. In addition there is (currently) a single function that parses the table and returns some condensed information, like this:

    totalIncomingHeal, timeToNextHeal, sizeOfNextHeal, nameOfNextHealer = GetIncomingHeal(targetName, endTime)

    This function has existed since VisualHeal was named QuickHeal, in different shapes, but mainly it supplies exactly the information required by the current GUI of VisualHeal. I would like to receive some input on what you would expect of functionality for a library like HealComm - i.e. what kind of function would be needed to condense the information? or maybe it is preferable to just have direct access to the tables?

    When these things are sorted, HealComm will be released like any other library, for use by anyone who like. I will of course continue to develop VisualHeal (and HealComm), and i hope i can find time to also make a plugin for Pitbull.
    Posted in: General AddOns
  • To post a comment, please or register a new account.