• 0

    posted a message on Combuctor: All in one, filterable displays for your inventory and bank
    I won't be including Mr.Plow functionality in Combuctor. Mr.Plow already does a good job at it :)
    Posted in: General AddOns
  • 0

    posted a message on LibStub Errors
    if the bad libstub is loaded first, it will cause an error when the good (1.0) version is loaded, since the bad version does not set LibStub.minor
    Posted in: Libraries
  • 0

    posted a message on LibStub Errors
    Anything using this version of LibStub:
    	-- LibStub is hereby placed in the Public Domain
    	-- Credits: Kaelten, Cladhaire, ckknight, Mikk, Ammo, Nevcairiel, joshborke
    	local LIBSTUB_MAJOR, LIBSTUB_MINOR = "LibStub", 2 -- NEVER MAKE THIS AN SVN REVISION! IT NEEDS TO BE USABLE IN ALL REPOS!
    	local LibStub = _G[LIBSTUB_MAJOR]
    
    	-- Check to see is this version of the stub is obsolete
    	if not LibStub or not LibStub.minors[LIBSTUB_MAJOR] or LibStub.minors[LIBSTUB_MAJOR] < LIBSTUB_MINOR then
    		LibStub = LibStub or {libs = {}, minors = {} }
    		_G[LIBSTUB_MAJOR] = LibStub
    		LibStub.libs[LIBSTUB_MAJOR], LibStub.minors[LIBSTUB_MAJOR] = LibStub, LIBSTUB_MINOR
    
    		-- LibStub:NewLibrary(major, minor)
    		-- major (string) - the major version of the library
    		-- minor (string or number ) - the minor version of the library
    		--
    		-- returns nil if a newer or same version of the lib is already present
    		-- returns empty library object or old library object if upgrade is needed
    		function LibStub:NewLibrary(major, minor)
    			assert(type(major) == "string", "Bad argument #2 to `NewLibrary' (string expected)")
    			minor = assert(tonumber(strmatch(minor, "%d+")), "Minor version must either be a number or contain a number.")
    
    			local oldminor = self.minors[major]
    			if oldminor and oldminor >= minor then return nil end
    			self.minors[major], self.libs[major] = minor, self.libs[major] or {}
    			return self.libs[major], oldminor
    		end
    
    		-- LibStub:GetLibrary(major, [silent])
    		-- major (string) - the major version of the library
    		-- silent (boolean) - if true, library is optional, silently return nil if its not found
    		--
    		-- throws an error if the library can not be found (except silent is set)
    		-- returns the library object if found
    		function LibStub:GetLibrary(major, silent)
    			if not silent and not self.libs[major] then
    				error(("Cannot find a library instance of %q."):format(tostring(major)), 2)
    			end
    			return self.libs[major], self.minors[major]
    		end
    
    		-- LibStub:IterateLibraries()
    		--
    		-- Returns an iterator for the currently registered libraries
    		function LibStub:IterateLibraries()
    			return pairs(self.libs)
    		end
    
    		setmetatable(LibStub, { __call = LibStub.GetLibrary })
    	end

    Does not place nicely with the 1.0 tag of LibStub. Its currently being used in LibDogTag, the LibBabbles, LibGratuity, and probably anything else that is embedding LibStub in file.
    Posted in: Libraries
  • 0

    posted a message on Combuctor: All in one, filterable displays for your inventory and bank
    If it makes you feel better, motes are listed in trade goods in 2.3 :)

    The tabs will never cover 100% of all items; that's why the text search is there. The side tabs are merely meant to be used for what you'd commonly look for.

    One thing I'm thinking about: what are people actually using the quality filter for?
    Posted in: General AddOns
  • 0

    posted a message on Common library for inventory tracking
    Quote from nogudnik »

    Here is what I'm going to propose for the common API method that other mod authors can impleement. This is intended to be the inventory equivalent to http://www.wowwiki.com/API_GetSellValue

    --
    -- @method GetInventoryCount
    -- @brief Determines how many of the provided item are in the inventory of 
    --       all the player's characters in this faction, on this realm.
    -- @param item numeric item id for the item to be searched for
    -- @return the total number of the provided item across all characters. 
    --       This includes the current character.
    --
    count = GetInventoryCount(item)


    Who would use such a function?

    edit because I probably sound mean:
    count = GetInventoryCount(item) seems like its providing too little information. Who has these items, and where are they at (bags, bank, equipped, etc)?
    Posted in: Libraries
  • 0

    posted a message on Combuctor: All in one, filterable displays for your inventory and bank
    Hrm, why on earth is the author of that addon hooking CloseBankFrame instead of watching BANKFRAME_CLOSED
    Posted in: General AddOns
  • 0

    posted a message on Combuctor: All in one, filterable displays for your inventory and bank
    Quote from Purplewedgie »

    Are there any plans on adding the tooltip alt-inventory counts back in (or are they there and another mod is killing them)?

    Yes, I'm just pondering how I should implement the code. Right now its quite CPU intensive, so I wanna reduce that :)
    Posted in: General AddOns
  • 0

    posted a message on Combuctor: All in one, filterable displays for your inventory and bank
    Quote from Flarin »

    Howdy- the Fubar addon BagFu which I use to display the bag count conflicts with the latest version - Combuctor will not display your bank items with this mod enabled.

    /boggle
    Posted in: General AddOns
  • 0

    posted a message on Combuctor: All in one, filterable displays for your inventory and bank
    I don't intend to change the look, unless there's something I want to do that's severely limited by it.
    Posted in: General AddOns
  • 0

    posted a message on ItemPriceTooltip or SellFish?
    ItemPriceTooltip is nice because it has the option for Blizzard formatting (shows the money in the same coin-style format as the vendor frames). Though SellFish I believe has more data (not positive there).

    ItemPriceTooltip and SellFish both use ItemPrice-1.1 and thus use the same data, and SellFish also has a coin style mode.

    The only real difference is that ItemPrice uses Ace2, and SellFish does not.
    Posted in: General Chat
  • 0

    posted a message on Bongos - a mod that lags.. atleast for me.
    What do you mean by "lag"? FPS issues or actual latency? If its the latter, then I can pretty much assure you that Bongos is not the source of the issue.
    Posted in: General Chat
  • 0

    posted a message on Combuctor: All in one, filterable displays for your inventory and bank

    * Preserve settings of "Show Bags" or not, I prefer to always have them shown, and having to re-show them every time I log in is just a minor annoyance.

    This should actually be preserved in the latest alpha.

    Ability to search cross-bags. IE: If I search for "trinket" in my bank on my mage who is an engineer, it doesn't search her Fel Iron Toolbox. It'd be nice if it were able to do that, so I could see all my engineering trinkets at the same time. Perhaps this could be an option, or something... not sure.

    A more generalized search will most likely be handled by some sort of list view, if I do one.

    Again with the specialty bags, I'm curious, is there any way to make it easier to move items around in your bank? Example again: I have an engineering item in my bank, I want to move from a normal bank slot to my engineering bag.

    I'm planning on making it so that when you drag an item onto a tab, it'll attempt to place that item into the first available slot in that tab's bag set. So dragging an item from a normal slot onto the trade tab will place it into one of your trade slots, if there's one available.
    Posted in: General AddOns
  • 0

    posted a message on Combuctor: All in one, filterable displays for your inventory and bank
    I put up a new alpha
    * The bank frame has been doubled in size
    * Frames are now movable. alt + left button to move, alt + right click to reset to being a ui panel
    * Item slot scaling is now capped
    * All the side tab categories should be properly localized, except Quest.
    * Added in automatic display code.

    Next up will be filtering code tweaks, though I really need to write me a 2.3 version of Bongos :)
    Posted in: General AddOns
  • 0

    posted a message on Scrolling Combat Mods
    It takes me all of five minutes to setup MSBT or SCT, though that's what I get for only adjusting throttling and fonts.
    Posted in: General AddOns
  • 0

    posted a message on Combuctor: All in one, filterable displays for your inventory and bank
    Yay for comments :)

    * Icon scaling: I'll be implementing a maximum icon size.
    * Frame positioning: I'll be implementing a way to drag the frame (alt + drag of the menu bar)
    * Item ownership tooltips: Will be added as an option (I might even make it a separate addon to Bagnon_Forever
    * Ammo and slot counts: I'll try out the percentage idea for shards and ammo. Tooltips will give a slightly more detailed breakdown, probably just number of empty slots + number of items.

    Something else to consider, one of my favorite features of Onebag is the "bag break"... instead of mushing all the bag slots together a new row is started when a bag ends. You still get the all at once view, but with a small degree of partitioning. This would only be for the "All"

    Oh and a setting for max columns, Having mostly 18-slut bags I'd prefer 9 cols than 10, that way my bags fit evenly onto two lines each.

    This stuff goes in the 'maybe' pile, since it requires a significant rewrite of my layout code :P

    I don't think you can avoid scrolling in a static window by cutting the content size with categorization. Eventually (if it doesn't already do scrolling) the icons will be tiny. Huge icons are also not very pretty.
    If it does have scrolling I'd much prefer that over scaling.

    The plan right now is to make the bank frame a bit bigger to deal with this, but I really want to avoid scrolling.

    Rarity Filters - Would be nice to have a way to select multiple filters, say if I wanted to look at both epic & rare quality items at once, I could toggle both filters.

    Will be implemented.

    Negatives:
    - Search feature and side tabs are too intrusive and should be optional, togglable, or collapsible.

    The search box will remain at its current position, since there would be dead space there otherwise.

    - I dislike how the search/filter feature works vs. the search feature in Bagnon.

    Can you go into more detail here? Do you mean how Bagnon fades out items, or something else?

    - Side tabs (if left as currently designed) could work like sub-inventories (by filtering). That is, you should be able to drop specific items into them, label them, and pick an icon for them. Right now, the filter 'types' I find to be rather impractical.

    So to go into more detail: I intend for the side filter to be essentially 'bookmarks' for searches. You'll be able to pick an itemType, subType, and/or equip location, though I might also allow search text, too. If those don't work out well enough once 2.3 is out, I'll move on to periodic table categories.

    - The addon overall feels bloated with useless features that are not optional.

    If it makes you feel better, I can assure you that the filtering is optimized enough that it should have nearly zero CPU cost until you actually use it :)

    Is this gonna be "Bagnon NextGen"? Or is it a side-project you started, Tuller?

    Its a separate project. Bagnon is getting the bag frame from Combuctor, and they both share Bagnon_Forever, obviously.

    How about an option to have a text list of inventory? I hate having to always mouse over to find what I need or run a search.

    I actually wrote one up while working on Combuctor. I'm pondering reimplementing the view as an option.
    Posted in: General AddOns
  • To post a comment, please or register a new account.