• 0

    posted a message on Omen2
    It matters because Omen calls UnitDebuff() to get debuff names from the player and from that spellids that it compares to spellids listed in the debuff table, and UnitBuff() to get buff names from the player and from that spellids that it compares to buff spellids listed in the buff table.

    Since the spell is a debuff, UnitBuff() will not return this spell's name when it is on the player. No name returned means that it won't find that this debuff is actually on the player, resulting in the modifier not being applied.

    See CalcBuffMods(line 842) and CalcDebuffMods(line 861) functions both also in ThreatClassModuleCore.lua to see what I mean.
    Posted in: Raid AddOns
  • 0

    posted a message on Omen2
    It should. Then people who receive the debuff will have their threat generation multiplied by 0 properly. This will result in Omen reporting correct results for them while they have the debuff.
    Posted in: Raid AddOns
  • 0

    posted a message on Omen2
    If you look in ThreatClassModuleCore.lua in Threat-2.0 lib you will see fungal bloom is already there(line 218), however it is in the wrong spot.

    The spell is a debuff upon the player, yes it increases the player's crit chances and makes them generate no threat and as such may be considered a buff, but it is a debuff applied upon the player that can not be removed. As to why it is a debuff, my guess is that Blizzard did that on purpose in order to control the fight. Since it is not removable, a raid will most likely be wiped if the main tank receives this debuff. The debuff is obtained by killing a spawned spore during the fight, and it applies this debuff to the 5 nearest people. Controlling who receives this debuff is one major part of the fight.

    Since the spell is a player debuff it should be in the DebuffModifiers table(starting line 258) not the BuffModifiers(starting line 196) table.
    Posted in: Raid AddOns
  • 0

    posted a message on Omen2
    Just a small bug report here:

    We were playing around in Naxxramas the other night. On Loatheb Omen was reporting incorrect threat amounts for the entire raid.

    I believe the problem lies in ThreatClassModuleCore.lua. "Fungal Bloom" is in the BuffModifiers table when it should be in the DebuffModifiers table as it is a debuff upon the player, not a buff.
    Posted in: Raid AddOns
  • To post a comment, please or register a new account.