Authors CurseForge

Quote from Lyn »

ah okay, didn't see that line so ... but it seems the safezone is a lil small or? i mean i have a latency about 106 and its just ~2 px width... with other castbars my safezone would be wider

I reverted two of the earlier commits. Should behave exactly as before now.

Quote from Lyn »

so you just forgot a , ? oO

yes, local _, _ ms = GetNetStats() is the same as: local _, _; ms = GetNetStats();

Quote from p3lim »

Still, 1e3 is more correct than 1e6, just tested (also tested with putting load on my net through torrents etc to see ms scales)

By just changing the "value" from 1e6 to 1e3 you will get. The "new" safe zone math produces the same result as the old one did.

5 sec cast, 50 ms, 100 width, 1e3 = safe zone size: 10
5 sec cast, 50 ms, 100 width, 1e6 = safe zone size: .1
--
5 sec cast, 500 ms, 100 width, 1e3 = safe zone size: 10
5 sec cast, 500 ms, 100 width, 1e6 = safe zone size: 1
--
5 sec cast, 1000 ms, 100 width, 1e3 = safe zone size: 10
5 sec cast, 1000 ms, 100 width, 1e6 = safe zone size: 2
--
5 sec cast, 2000 ms, 100 width, 1e3 = safe zone size: 10
5 sec cast, 2000 ms, 100 width, 1e6 = safe zone size: 4
--
5 sec cast, 3000 ms, 100 width, 1e3 = safe zone size: 10
5 sec cast, 3000 ms, 100 width, 1e6 = safe zone size: 6
==
10 sec cast, 50 ms, 100 width, 1e3 = safe zone size: 10
10 sec cast, 50 ms, 100 width, 1e6 = safe zone size: .05
--
10 sec cast, 500 ms, 100 width, 1e3 = safe zone size: 10
10 sec cast, 500 ms, 100 width, 1e6 = safe zone size: .5
--
10 sec cast, 1000 ms, 100 width, 1e3 = safe zone size: 10
10 sec cast, 1000 ms, 100 width, 1e6 = safe zone size: 1
--
10 sec cast, 2000 ms, 100 width, 1e3 = safe zone size: 10
10 sec cast, 2000 ms, 100 width, 1e6 = safe zone size: 2
--
10 sec cast, 3000 ms, 100 width, 1e3 = safe zone size: 10
10 sec cast, 3000 ms, 100 width, 1e6 = safe zone size: 3

It would probably be better to use the time between the spell cast is sent, and when it starts instead of GetNetStats() however.

Quote from p3lim »

Theres a bug with the target channeling bar.

Should be fixed on latest master.

Quote from Lyn »

you have to change a line in ouf/elements/castbar

-- MADNESS!
			local safeZonePercent = (width / self.max) * (ms / 1e6)

into

-- MADNESS!
			local safeZonePercent = (width / self.max) * (ms / 1e3)

this. (the 1e6)

wrong: http://ixo.no/git/oUF.git/commit/?id=88449f60f5ffb946da1602e16c30939f007f5b80

You also don't need to call RegisterUnitWatch()* on frame that you create. oUF does this internally for you. You DO however have to call it if you have used UnregisterUnitWatch() on a frame, and want it to work as intended afterwards.

* You are calling it on a nil value there also.

there you actually have to use for i=1,5...

I demand that you read the following now: http://lua-users.org/wiki/TablesTutorial
and this: http://lua-users.org/wiki/ForTutorial

Quote from Moon Witch »

I was checking out oBindings. Which I find interesting to say the least. How'd you learn to play with keybinds?

Same way I learned to type a keyboard where the labels don't match the actual keys it produces? I honestly don't know how to answer it. Just remove the bars, and make everything go by muscle memory.

Quote from Moon Witch »

Because when you're levelling your spells (and rotations) change a lot. Though, I am scared that when I try, I will lose every setting on where what goes. (I currently have stance changing. eg. when in shadowform bar 2 shows up, when normal bar 1 and then on scroll up 3 which is pvp. Is that possible with oBindings?

Should work if you use /swapactionbar 1 3 for swapping. Your post slightly confuse me however. Shadowform is a stance so it's actually bar 7.
Anyway, you can use ABS to save your actionbar setup.

I pretty much read "the messenger" as the forum software there \:D/.

Anyway, I believe all 1.1.1 issues now are fixed. So... I'll give you a day to find some new bugs :p.

Quote from Moon Witch »

hate the do-er, not the messenger.

But the messenger is the one allowing already posted messages to be edit, and apparently deleted in the middle of a conversation! :3

I hate forums even more now. :(

Quote from Moon Witch »

I'll shut up after this.

1e3.

local safeZonePercent = (width / self.max) * (ms / 1e6)
-> tomath
safeZonePercent = (250/5) * (50ms/1000000)
safeZonePercent = 50 * 0.00005)
safeZonePercent = 0.0025

Then in your code it would equal 1, since if(safeZonePercent > 1) then safeZonePercent = 1 end
So a red bar might be there, but it'd be microscopic. Mili is 1/1e3 of the standard.

http://ixo.no/git/oUF.git/commit/?id=65dab7c84298bb3d9c08d93b85d34ffc145250c0

for key, object in ipairs(partytarget) do
UnregisterUnitWatch(object)
	object:Hide()
end

partytarget is not a header.

And since this is the fourth time I see this issue this week:
I added :Enable() and :Disable() to the oUF object, which does this for you.

Here's a tips: Editing posts == bad

Anyway: partytargets aren't headers, you can't just hide them. You have to run UnregisterUnitWatch(frame) before you hide them. You also need to run RegisterUnitWatche(frame) to show it again (no need for :Show()).