Authors CurseForge

GatherMate & Modules will do what you want it to do

well.. best way to do this is to write up a spec addendum and specify how this element should interact under most / all cases and then convince a display author to implement it.

LDBIcon is a Lib in it's own right. The minimap icon is controled by the addon itself as part of it's interaction with LDBIcon. So LDB itself is not being told to hide or show the plugin, but the lib is doing it. LDBIcon is unique in that sense.

i find this entire thread rather pointless tbh.

Anyone who needs an on update script is going to write it nearly the same as anyone else. If your needing onupdate scripts for enough frames to need something in the order of a function factory, you are not going to use something like this.

that x = select(1, ...) was part of the Blizzard Combat Log code for a while :\

instead of checking string.len use string.find or string.match IE:

if string.find("[nN][rR][tT]") then
---Whisper Person here
end

benefit with using the pattern functions is that you only have to check the string once.

Quote from Lombra

Yeah, indeed. Preferrably it would be a "show/hide" field rather than "enable/disable". The display should not delete settings for the feed.

main reason this sort of thing wasnt in the origional design is that a user could use several LDB display's (Granted it's not likely). But one could use a minimap style display such as LDBIcon and Bazooka (as i do in SOCD).

The problem happens when you enable the feed, what display should enable?

Quote from Lombra

Mainly because they all display different tooltip info, which may very well be too much to fit in a single tooltip, not to mention annoying to read. I also prefer for them to have their own proper icons (and labels).

then tell the user to go to the display's settings to disable them :)

Quote from Lombra

I've no idea if this is way off as far as design goes, but would some kind of toggle control, to tell displays to show/enable or hide/disable your feed, be reasonable? I have more than one feed in my addon, and they're displayed based on settings. Merging them into a single feed won't be pretty in my case.

Been talked about on occasion, but the response always seems to be that it's a display issue and should be handled by the display.

Why would merging them be ugly in your case?

I'd say scrap it and start over and use 3 seperate sets of functions for local, bank and gbank storage.

could always pass a flag to the function ( ie function arg indicating gbank ) & in the opening lines of the function define 2 generic locals that change depending on if it's local or gbank

function scan(gbank)
    local GetLink = (gbank and GetGuildBankItemLink) or GetContainerItemLink
    local GetItemInfo = (gbank and GetGuildBankItemInfo) or GetContainerItemInfo
    ...
end

From Ace3.lua in Ace3's package (adapted):

local old_CloseSpecialWindows
if not old_CloseSpecialWindows then
	old_CloseSpecialWindows = CloseSpecialWindows
	CloseSpecialWindows = function()
		local found = old_CloseSpecialWindows()
		if frame then
			frame:Hide()
			return true
		end
		return found
	end
end

as the AceGUI's Frame has a :Hide() method, you can use that here or what ever you need.

Quote from Shag

.. from wowace or curseforge (the two sites seem to be backed by the same database...). There is no delete button, all I see is that I can set the addon status to 'Deleted'. But that is not good enough, I want the addons gone completely.

Simply Report the addon to the moderators using the red report icon in the bottom right corner of the page (as if your reporting the addon for something bad, there is an option to report for admin action)

the underscore _ is used as the common "i don't care about that return" variable. Just remember to use a local _ not the global _ ( IE [[ local _, a = someFunc() ]] vs [[ _, a = sumfunc() ]] )

Looks like argument overflow from gsub. Not only does it return the fixed up string but also how many replacements it does. The # of replacements is also passed to the string.find() call and is messing it up.

Try this:

string.find(msg, ( gsub(LOOT_ITEM, "%%s", "(.+)") ) )

Also if you cache those strings ( IE do the gsub on LOOT_ITEM outside of your function) you wouldn't have this problem.