I commited an Ace2'd version to the SVN now after i got permission by Kyahx ( the original author ), so you can get a downloadable version from http://svn.wowace.com/files/ now.
meh, i converted it a few days back to Ace2 as well, been waiting for the Authors permission to update it on the SVN .. anyway i guess it will look kinda the same. i will be submiting my version to the svn in a few hours once i get home.
After updating to the latest revision I get this error with the BottomUIFrame:
Error: Interface\AddOns\oSkin\core.lua:38: attempt to index field `db' (a nil value)
I fixed this error in the SVN. No need to change your addon at all :)
I noticed that you dont get any timestamps on any frame except ChatFrame1 .. so i figured it out.
Change idChat2_Timestamps.lua the last function (AddMessage Hook) to look like this.
function idChat2_Timestamps:AddMessage(frame, text, red, green, blue, id)
local db = idChat2.db.profile
text = text or ''
red = red or ''
green = green or ''
blue = blue or ''
id = id or nil
for i=1,7 do
local cf='ChatFrame'..i
if frame:GetName()==cf then
if db.Timestamps['chatframe'..i] then
text = string.format('%s %s', date('%X'), text)
self.hooks[frame].AddMessage.orig(frame, text, red, green, blue, id)
return
else
self.hooks[frame].AddMessage.orig(frame, text, red, green, blue, id)
return
end
end
end
end
The problem was simple. First it checks if we are in the right Frame. then it checks if we have timestamps for this frame. But for any Frame besides ChatFrame1 the first check already fails, and we get to the "else" where it simply adds the message and returns, without ever checking timestamps. So simple fix :) - First check the Frame, and only if we have the right frame, check for timestamp and output
I added a commandline option /oskin to enable/disable some of the skins. Personally i love this addon, but there are some skins which i dont like.
Maybe someone else finds this useful as well :)
I will be adding options for all skins over the day, just did like half of them now.
To disable skins you have to reloadui, enabling works on the fly tho.
With idChat2_ChannelNames the Channel Names are even removed on channel join and on /chatlist .. any chance you could remove it there ? I like to check sometimes which channels i am in, and which number is which channel - in case WoW screwed them up again.
0
0
0
I will work on it when i have some time later today :)
0
I fixed this error in the SVN. No need to change your addon at all :)
0
Change idChat2_Timestamps.lua the last function (AddMessage Hook) to look like this.
function idChat2_Timestamps:AddMessage(frame, text, red, green, blue, id) local db = idChat2.db.profile text = text or '' red = red or '' green = green or '' blue = blue or '' id = id or nil for i=1,7 do local cf='ChatFrame'..i if frame:GetName()==cf then if db.Timestamps['chatframe'..i] then text = string.format('%s %s', date('%X'), text) self.hooks[frame].AddMessage.orig(frame, text, red, green, blue, id) return else self.hooks[frame].AddMessage.orig(frame, text, red, green, blue, id) return end end end endThe problem was simple. First it checks if we are in the right Frame. then it checks if we have timestamps for this frame. But for any Frame besides ChatFrame1 the first check already fails, and we get to the "else" where it simply adds the message and returns, without ever checking timestamps. So simple fix :) - First check the Frame, and only if we have the right frame, check for timestamp and output
0
frame is given to applySkin from a custom function, so if you added some skinning function, check if the frame you supply is actually valid.
0
edit:
and be sure to restart your game, since the .toc changed.
0
Maybe someone else finds this useful as well :)
I will be adding options for all skins over the day, just did like half of them now.
To disable skins you have to reloadui, enabling works on the fly tho.
0
0
0
0
0
I am getting that same error on Anub right now. But the mod seems to be working.
0
0
Please fix :)