• 0

    posted a message on Masque - Official Thread
    Quote from Torhal
    The OnEnable method for the AddOn object is fired on PLAYER_LOGIN... :)


    Doh... I was using OnInitialize. Your comment just made me realise that OnEnable is probably when the addon is meant to make bars anyhow. /facepalm.

    The joys of being a n00b.
    Posted in: General AddOns
  • 0

    posted a message on Masque - Official Thread
    Quote from Phanx
    Without seeing your actual code, it's hard to say exactly what you're doing wrong, but:

    1. You need to delay skinning your addon until after PLAYER_LOGIN. If you skin it before that, Masque's saved variables may not have loaded, so the user's saved skin choices are not yet known, so you get the default Blizzard skin.


    That was it. Excellent. I was running it in my Ace3 "OnInitialize". I suspect the reason that the built in skins were working is that Masque was loaded before my addon, but the 3rd party skins were not. Moved everything into the OnEnable(first) event handler and it works like a charm.

    Quote from Phanx
    2. Using bar:GetChildren() and wrapping it in a new table constructor is really inefficient. You should just store the buttons in a table as you create them, eg: ...


    I was wondering about that. Will keep it in mind if I need to do it a lot and it causes performance issues. Currently it's done once, to skin the bars with Masque. Hm... I wonder if I can just hook a function on the bar such that when a child is added if it's a button it gets added to the masque group. That'd save keeping track of another variable just for that.

    Quote from Phanx

    3. Semicolons at the end of lines are not neccessary or even useful in Lua. Unless you're using them because you're used to programming in a language that requires them, I'd strongly recommend omitting them to keep your code clean. Same goes for parentheses around conditions; you can just do "if Masque then" and "if msqGroup then" without them.

    I'm a Java programmer. They aren't useful for the computer's parser, but they're useful for my brain's parser :D I've already caught myself trying to use .. as a concatenator in Java!
    Posted in: General AddOns
  • 0

    posted a message on Masque - Official Thread
    Oops. That was me above. Curse does some weird things if you happen to have other accounts logged into different parts of curse :/
    Posted in: General AddOns
  • 0

    posted a message on Pitbull - Rock UI freezes entire WoW interface when opened or used
    Yeah but the problem stayed fixed *after* all the addons were re-enabled, that's what confused me lol. I guess it will remain one of those mysteries.
    Posted in: Unit Frames
  • 0

    posted a message on Pitbull - Rock UI freezes entire WoW interface when opened or used
    Oddly enough running the game without any other addons, configuring it, then logging out then back in with the other addons on seems to have alleviated this. There is still a short freeze on certain actions such as configuration mode, but this is to be expected and is acceptable. I would be interested in knowing why this works, if anyone has any ideas.
    Posted in: Unit Frames
  • 0

    posted a message on Pitbull - Rock UI freezes entire WoW interface when opened or used
    Every time I open the Rock interface for PitBull (or click an item on the Rock interface) my entire WoW locks up for varying periods of time (5 seconds to "however long it takes for the server to disconnect me). This makes it near impossible to configure the addon as it takes hours to do even the simplest things, which is a shame as this is probably the best unitframe mod out there (I don't really want to use ag as I prefer a UI for all of the options, makes things quicker for the initial setup).

    I am using Pitbull +53016.22. I have tried it in unpacked and packed mode, and with all of the extra modules removed and the same thing happens.
    Posted in: Unit Frames
  • To post a comment, please or register a new account.