• 0

    posted a message on [pkgmeta] Embeding AceGUI-3.0-SharedMediaWidgets without duplicate libraries
    Quote from Torhal
    Unfortunately, this is just how it works. You can add a .pkgmeta ignore statement for the specified folders/files, but that won't actually work until the packager is rewritten.

    Oh .. thanks for the quick answer. I'll maybe choose to hardembed AceGUI-3.0-SharedMediaWidgets then :[
    Posted in: General Chat
  • 0

    posted a message on [pkgmeta] Embeding AceGUI-3.0-SharedMediaWidgets without duplicate libraries
    Background
    I'm embedding AceGUI-3.0-SharedMediaWidgets in "ScrollingChatText" to facilitate the font options

    On a side note: I'm not actually utilising the library yet, and as Phanx suggested, I should leave it up to the Combat Text addons themselves what kind of font users want to use

    Problem
    When I embedded AceGUI-3.0-SharedMediaWidgets, it also included the \AceGUI-3.0-SharedMediaWidgets\Libs\ subfolder containing AceGUI-3.0, CallbackHandler-1.0 and LibStub

    I checked some other Addons, like Bazooka_Options, InlineAura, Grid, Prat-3.0_Libraries, Quartz and WeakAuras; they also were including the \AceGUI-3.0-SharedMediaWidgets\Libs\ subfolder

    Nobody is actually pointing to these external/duplicate libs in their .TOC or .XML files, and yet they still are there, doing completely nothing; so aren't these "orphaned" libs just a waste of 195 KB of space?

    I'm wondering why the \AceGUI-3.0-SharedMediaWidgets\Libs\ subfolder actually got packaged in, since:
    • In ScrollingChatText's .pkgmeta, I'm pointing to A instead of B

    • AceGUI-3.0-SharedMediaWidgets' .pkgmeta is located in B; but then why does it apparently still get discovered by the packager?
    [B]A)[/B] svn://svn.wowace.com/wow/ace-gui-3-0-shared-media-widgets/mainline/trunk/[COLOR="DarkRed"]AceGUI-3.0-SharedMediaWidgets[/COLOR]
    [B]B)[/B] svn://svn.wowace.com/wow/ace-gui-3-0-shared-media-widgets/mainline/trunk


    All this information is a bit much and confusing I think, but basically I just want to get rid of AceGUI-3.0-SharedMediaWidgets' unused external libs :mad:





    AceGUI-3.0-SharedMediaWidgets
    /mainline/trunk/.pkgmeta
    package-as: AceGUI-3.0-SharedMediaWidgets
    
    externals:
    	Libs/LibStub: svn://svn.wowace.com/wow/libstub/mainline/tags/1.0
    	Libs/CallbackHandler-1.0: svn://svn.wowace.com/wow/callbackhandler/mainline/tags/1.0.3/CallbackHandler-1.0
    	Libs/AceGUI-3.0: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceGUI-3.0
    


    /mainline/trunk/AceGUI-3.0-SharedMediaWidgets.toc
    ## Interface: 40000
    
    ## Title: Lib: AceGUI-3.0-SharedMediaWidgets
    ## Notes: Enables AceGUI-3.0 widgets for the 5 basic SharedMedia-3.0 types
    ## Version: 4.0.0
    ## Author: Yssaril
    ## OptionalDeps: Ace3, LibSharedMedia-3.0, Libstub, CallbackHandler-1.0
    ## X-Category: Library
    
    #@no-lib-strip@
    Libs\Libstub\Libstub.lua
    Libs\CallbackHandler-1.0\CallbackHandler-1.0.xml
    Libs\AceGUI-3.0\AceGUI-3.0.xml
    #@end-no-lib-strip@
    
    widget.xml


    /mainline/trunk/widget.xml
    <Ui xmlns="http://www.blizzard.com/wow/ui/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.blizzard.com/wow/ui/
    ..\FrameXML\UI.xsd">
    	<Include file="AceGUI-3.0-SharedMediaWidgets\widget.xml" />
    </Ui>


    /mainline/trunk/AceGUI-3.0-SharedMediaWidgets/widget.xml
    <Ui xmlns="http://www.blizzard.com/wow/ui/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.blizzard.com/wow/ui/
    ..\FrameXML\UI.xsd">
    	<Script file="prototypes.lua" />
    	<Script file="FontWidget.lua" />
    	<Script file="SoundWidget.lua" />
    	<Script file="StatusbarWidget.lua" />
    	<Script file="BorderWidget.lua" />
    	<Script file="BackgroundWidget.lua" />
    </Ui>

    ScrollingChatText
    .pkgmeta
    package-as: ScrollingChatText
    
    externals:
      Libs/LibStub:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/LibStub
        tag: latest
      Libs/CallbackHandler-1.0:
        url: svn://svn.wowace.com/wow/callbackhandler/mainline/trunk/CallbackHandler-1.0
        tag: latest
      Libs/AceAddon-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceAddon-3.0
        tag: latest
      Libs/AceConfig-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceConfig-3.0
        tag: latest
      Libs/AceConsole-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceConsole-3.0
        tag: latest
      Libs/AceDB-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceDB-3.0
        tag: latest
      Libs/AceDBOptions-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceDBOptions-3.0
        tag: latest
      Libs/AceEvent-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceEvent-3.0
        tag: latest
      Libs/AceGUI-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceGUI-3.0
        tag: latest
      Libs/AceTimer-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceTimer-3.0
        tag: latest
      Libs/LibSharedMedia-3.0:
        url: svn://svn.wowace.com/wow/libsharedmedia-3-0/mainline/trunk/LibSharedMedia-3.0
        tag: latest
    [COLOR="DarkRed"]  Libs/AceGUI-3.0-SharedMediaWidgets:
        url: svn://svn.wowace.com/wow/ace-gui-3-0-shared-media-widgets/mainline/trunk/AceGUI-3.0-SharedMediaWidgets
        tag: latest[/COLOR]
      Libs/LibSink-2.0:
        url: svn://svn.wowace.com/wow/libsink-2-0/mainline/trunk/LibSink-2.0
        tag: latest
    
    Packager Log
    2012-03-09T12:56:34.468047
        Discovered git repository: wow/scrollingchattext/mainline
        Joining all threads
        Updating git://git.wowace.com/wow/scrollingchattext/mainline.git in /media/cf-repositories/packager/git-local-checkout/wow/scrollingchattext/mainline...
        Done with git://git.wowace.com/wow/scrollingchattext/mainline.git
        Not all threads finished, remaining: Checkout <Local SvnRepository: wow/ace3/mainline>, Checkout <Local SvnRepository: wow/ace-gui-3-0-shared-media-widgets/mainline>, Checkout <Local SvnRepository: wow/libsharedmedia-3-0/mainline>, Checkout <Local SvnRepository: wow/libsink-2-0/mainline>, Checkout <Local SvnRepository: wow/callbackhandler/mainline>, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace-gui-3-0-shared-media-widgets/mainline> tag v3.4.1, Checkout <Local SvnRepository: wow/libsharedmedia-3-0/mainline> tag 4, Checkout <Local SvnRepository: wow/libsink-2-0/mainline> tag 3.0-beta2, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/callbackhandler/mainline> tag 1.0.7, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041 (0 running)
        Updating svn://svn.wowace.com/wow/ace3/mainline/trunk in /media/cf-repositories/packager/svn-local-checkout/wow/ace3/mainline...
        Updating svn://svn.wowace.com/wow/ace-gui-3-0-shared-media-widgets/mainline/trunk in /media/cf-repositories/packager/svn-local-checkout/wow/ace-gui-3-0-shared-media-widgets/mainline...
        Updating svn://svn.wowace.com/wow/libsharedmedia-3-0/mainline/trunk in /media/cf-repositories/packager/svn-local-checkout/wow/libsharedmedia-3-0/mainline...
        Updating svn://svn.wowace.com/wow/libsink-2-0/mainline/trunk in /media/cf-repositories/packager/svn-local-checkout/wow/libsink-2-0/mainline...
        Updating svn://svn.wowace.com/wow/callbackhandler/mainline/trunk in /media/cf-repositories/packager/svn-local-checkout/wow/callbackhandler/mainline...
        Done with svn://svn.wowace.com/wow/ace-gui-3-0-shared-media-widgets/mainline/trunk
        Done with svn://svn.wowace.com/wow/callbackhandler/mainline/trunk
        Done with svn://svn.wowace.com/wow/libsharedmedia-3-0/mainline/trunk
        Done with svn://svn.wowace.com/wow/libsink-2-0/mainline/trunk
        Done with svn://svn.wowace.com/wow/ace3/mainline/trunk
        Not all threads finished, remaining: Checkout <Local SvnRepository: wow/libstub/mainline>, Checkout <Local SvnRepository: wow/libstub/mainline> tag 1.0, Checkout <Local SvnRepository: wow/callbackhandler/mainline> tag 1.0.3 (0 running)
        Updating svn://svn.wowace.com/wow/libstub/mainline/trunk in /media/cf-repositories/packager/svn-local-checkout/wow/libstub/mainline...
        Done with svn://svn.wowace.com/wow/libstub/mainline/trunk
        Finished joining all threads
        Tags to handle:
            (<Local GitRepository: wow/scrollingchattext/mainline>, 'v0.2') 
        Joining all threads
        Not all threads finished, remaining: Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace-gui-3-0-shared-media-widgets/mainline> tag v3.4.1, Checkout <Local SvnRepository: wow/libsharedmedia-3-0/mainline> tag 4, Checkout <Local SvnRepository: wow/libsink-2-0/mainline> tag 3.0-beta2, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/callbackhandler/mainline> tag 1.0.7, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041, Checkout <Local SvnRepository: wow/ace3/mainline> tag Release-r1041 (0 running)
        Finished joining all threads
        /media/cf-repositories/packager/zip/wow/ScrollingChatText-v0.2.zip has local externals:
            path: Libs/LibStub, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: LibStub, tag: Release-r1041
            path: Libs/AceGUI-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceGUI-3.0, tag: Release-r1041
            path: Libs/AceAddon-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceAddon-3.0, tag: Release-r1041
            path: Libs/AceGUI-3.0-SharedMediaWidgets, repo: Local SvnRepository: wow/ace-gui-3-0-shared-media-widgets/mainline, repo subpath: AceGUI-3.0-SharedMediaWidgets, tag: v3.4.1
            path: Libs/LibSharedMedia-3.0, repo: Local SvnRepository: wow/libsharedmedia-3-0/mainline, repo subpath: LibSharedMedia-3.0, tag: 4
            path: Libs/LibSink-2.0, repo: Local SvnRepository: wow/libsink-2-0/mainline, repo subpath: LibSink-2.0, tag: 3.0-beta2
            path: Libs/AceDBOptions-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceDBOptions-3.0, tag: Release-r1041
            path: Libs/AceDB-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceDB-3.0, tag: Release-r1041
            path: Libs/AceConfig-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceConfig-3.0, tag: Release-r1041
            path: Libs/CallbackHandler-1.0, repo: Local SvnRepository: wow/callbackhandler/mainline, repo subpath: CallbackHandler-1.0, tag: 1.0.7
            path: Libs/AceConsole-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceConsole-3.0, tag: Release-r1041
            path: Libs/AceEvent-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceEvent-3.0, tag: Release-r1041
            path: Libs/AceTimer-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceTimer-3.0, tag: Release-r1041 
        Creating zip /media/cf-repositories/packager/zip/wow/ScrollingChatText-v0.2.zip... Done
        Creating zip /media/cf-repositories/packager/zip/wow/ScrollingChatText-v0.2-nolib.zip... Done
        /media/cf-repositories/packager/zip/wow/ScrollingChatText-v0.2.zip has local externals:
            path: Libs/LibStub, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: LibStub, tag: Release-r1041
            path: Libs/AceGUI-3.0-SharedMediaWidgets/Libs/LibStub, repo: Local SvnRepository: wow/libstub/mainline, tag: 1.0
            path: Libs/AceAddon-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceAddon-3.0, tag: Release-r1041
            path: Libs/AceGUI-3.0-SharedMediaWidgets/Libs/CallbackHandler-1.0, repo: Local SvnRepository: wow/callbackhandler/mainline, repo subpath: CallbackHandler-1.0, tag: 1.0.3
            path: Libs/LibSharedMedia-3.0, repo: Local SvnRepository: wow/libsharedmedia-3-0/mainline, repo subpath: LibSharedMedia-3.0, tag: 4
            path: Libs/AceGUI-3.0-SharedMediaWidgets, repo: Local SvnRepository: wow/ace-gui-3-0-shared-media-widgets/mainline, repo subpath: AceGUI-3.0-SharedMediaWidgets, tag: v3.4.1
            path: Libs/AceDBOptions-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceDBOptions-3.0, tag: Release-r1041
            path: Libs/AceDB-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceDB-3.0, tag: Release-r1041
            path: Libs/AceConfig-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceConfig-3.0, tag: Release-r1041
            path: Libs/AceGUI-3.0-SharedMediaWidgets/Libs/AceGUI-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceGUI-3.0
            path: Libs/CallbackHandler-1.0, repo: Local SvnRepository: wow/callbackhandler/mainline, repo subpath: CallbackHandler-1.0, tag: 1.0.7
            path: Libs/AceConsole-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceConsole-3.0, tag: Release-r1041
            path: Libs/AceGUI-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceGUI-3.0, tag: Release-r1041
            path: Libs/AceEvent-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceEvent-3.0, tag: Release-r1041
            path: Libs/AceTimer-3.0, repo: Local SvnRepository: wow/ace3/mainline, repo subpath: AceTimer-3.0, tag: Release-r1041
            path: Libs/LibSink-2.0, repo: Local SvnRepository: wow/libsink-2-0/mainline, repo subpath: LibSink-2.0, tag: 3.0-beta2 
        Creating zip /media/cf-repositories/packager/zip/wow/ScrollingChatText-v0.2.zip... Done
        Creating zip /media/cf-repositories/packager/zip/wow/ScrollingChatText-v0.2-nolib.zip... Done
        Successfully uploaded /media/cf-repositories/packager/zip/wow/ScrollingChatText-v0.2-nolib.zip, /media/cf-repositories/packager/zip/wow/ScrollingChatText-v0.2.zip 
    
    Packager finished: 2012-03-09T12:58:10.242776.
    Completed in 0:01:35.774729
    Posted in: General Chat
  • 0

    posted a message on ScrollingChatText
    ScrollingChatText outputs chat messages via LibSink through the following Combat Text AddOns: I've been working on it during the past 2 weeks ..

    ScrollingChatText r1 - http://www.wowace.com/addons/scrollingchattext/files/2-r20120208012924/

    Some notes:
    • If Class Colors is loaded, ScrollingChatText will hide its own options, and mention Class Colors instead.

    • The locales are kinda setup like, in a post Phanx exampled.

    • This is the first time I tried to divide an addon into multiple files, so the ordering of the code might look weird.

    • The LibSharedMedia fonts don't seem to be passed correctly to LibSink. When I looked into LibSink's code, it seems only Parrot and MSBT would get the font passed though. But I suppose users can also just configure the font in the Combat Text AddOn's own config.

    • There are an amount of problems involving (improper?) Links / UI escape sequences being broken, or not appearing at all when outputting to a Chat Channel via LibSink.

    • I'm not sure what to do about the Project License. Normally I just use Public Domain, but if other people are comitting to it, and use multiple libraries, I guess it will be a different story.
    I'm still learning about Lua and the WoW API, and I don't have any programming background, or followed any courses. I'm open for any advice and/or pointers.


    I'm also actively looking for authors that want to co-author or casually help with this addon, I will add you as an author.


    ScrollingChatText is on a Git repository, but myself I have never worked with other people on a project before though. (More likely I'll accidentally destroy the repo)
    git://git.wowace.com/wow/scrollingchattext/mainline.git



    I sadly also will be leaving to the US on the 10th of Feb for a month to attend my brother's wedding. But I will unlikely have any access to a computer or laptop (that I can install WoW on)

    -----

    Here is a preview of the Combat Text AddOn sinks: http://www.youtube.com/watch?v=zgQfTv5Gysk

    Posted in: General AddOns
  • 0

    posted a message on chat_msg_loot
    .. can you please put all of your code in Code-tags?

    like,
    I love bunnies
    Posted in: Lua Code Discussion
  • 0

    posted a message on AceTimer-3.0 'function or method name expected' error
    Quote from Phanx
    Rather than deleting your question, why not leave it viewable, and post the answer, so that other people with the same or similar problem in the future can find the answer without someone else having to post the answer again?

    This was his thread on the EU forums

    TrainAlert.lua - http://pastebin.com/wNbVC1ma
    TrainAlert.toc - http://pastebin.com/H2DVUK6T
    TrainAlert.xml - http://pastebin.com/qDtxmXfV
    TrainAlert.lua v2 http://pastebin.com/4F7D8WSg

    I couldn't help him in the end, and only tried to point out stuff that would give an error
    Quote from Torhal
    Why are you using XML when you're using AceAddon, which has :OnInitialize() and :OnEnable() members? You should probably ditch the XML and use the AceAddon functions, and either use AceEvent or make your own event handler.

    Yeah I was wondering how the heck his addon was even working. It only looks more confusing to me imho
    Posted in: Lua Code Discussion
  • 0

    posted a message on AceConfig/AceGUI overlapping controls
    I'm also having the same problem with only having Grid (4.3.0.1453) enabled. I've tried it with multiple different UI scales, and it seems to be related to it.

    In my case it doesn't seem very consistent to reproduce though.. It seems totally random to me for any of the UI scales or when it's disabled. Sometimes the GUI would overlap, and the other time it would be just fine.

    Posted in: Ace3
  • 0

    posted a message on AceDB and default profiles (Picking a bone)
    +1

    I'm also just changing the db code
    Posted in: Ace3
  • 0

    posted a message on WIP: high volume event processing library
    Quote from rowaasr13
    [...] and such things as CLEU version difference processing for our Chinese friends can easily double time wasted?

    Isn't mainland China also on Cataclysm now? Well at least on patch 4.2 I suppose ..
    Posted in: Libraries
  • 0

    posted a message on Not syndicating a project's initial file to Curse
    Now it seems that it's not just a project's initial file, since other addons were reported to also have the same problem ..

    Curse: 148585 Download buttons are missing
    Posted in: General Chat
  • 0

    posted a message on Not syndicating a project's initial file to Curse
    Hi, this is just a small question / bug report. I know this should maybe be on Curse's website support thread, but asking it here anyway

    This small addon (GuildLevelTooltip) has been approved, the project is on Release status, and the packager already pushed a new tag to WowAce.
    But the initial file is not showing up on Curse. The addon is showing up, but there are no download options. It's also not being syndicated to the "new and updated" list. (I haven't yet pushed a second file/package)



    ----- -----

    I was slightly presuming this was happening before, since for another addon (AutoConfirmRoll), only after the second push (v0.2) that file/package would show up on the Curse page; so I was assuming that v0.1 wasn't syndicated to Curse at all, since only v0.2 is syndicated ..
    Posted in: General Chat
  • 0

    posted a message on Killing blows
    Quote from myrroddin
    I used the following when I wrote MrBigglesworthDeath (dead addon, unless Ketho updated).
    [...]

    Yes, MrBigglesworthDeath is updated

    Quote from Priam_
    You can use the same event, using another value for "param2"

    function MyAddon:doCombatLogCheck(...)
    	local _, param1, param2, param3, param4, param5, param6, param7, param8, param9, param10, param11[COLOR="DarkRed"], param12, param13, param14, param15, param16[/COLOR] = ...
    	if param2 == "PARTY_KILL" and param5 == UnitName("player") then
    		self:Print("I made the killing blow on "..param9.." with "..[COLOR="DarkRed"]param13[/COLOR])
    	elseif param2 == "PARTY_KILL" and param5 ~= UnitName("player") then
    		self:Print(param5.." made the killing blow on "..param9.." with "..[COLOR="DarkRed"]param13[/COLOR])
    	end
    end

    afaik PARTY_KILL only has the base parameters




    Quote from moselekm
    How does one track killing blows and is it possible to tell which move caused the killing blow through the API? I've scoured the provided API @ http://www.wowpedia.org/World_of_Warcraft_API but couldn't seem to find anything exactly related.
    [...]

    if you want to see what spell was used for the killing blow, you could check for the overkill parameter, but it's less accurate
    • Sometimes it will fire, even if the player in question didn't die
    • There will regularly be multiple killing blows on the same unit/player/mob in e.g. battlegrounds/raids
    This example will show all killing blows done by you
    local playerName, petName = UnitName("player"), UnitName("pet")
    
    local damageEvent = {
    	["SWING_DAMAGE"] = true,
    	["RANGE_DAMAGE"] = true,
    	["SPELL_DAMAGE"] = true,
    	["SPELL_PERIODIC_DAMAGE"] = true,
    }
    
    local function OnEvent(self, event, timestamp, subevent, hideCaster, sourceGUID, sourceName, sourceFlags, sourceRaidFlags, destGUID, destName, destFlags, destRaidFlags, ...)
    	local spellID, spellName, spellSchool, amount, overkill
    	if damageEvent[subevent] then
    		if subevent == "SWING_DAMAGE" then
    			amount, overkill = ...
    		else
    			spellID, spellName, spellSchool, amount, overkill = ...
    		end
    		if overkill > 1 and [COLOR="DarkGreen"](sourceName == playerName or sourceName == petName)[/COLOR] then
    			print(format("%s killed %s with %s %s damage!", sourceName, destName, amount, subevent == "SWING_DAMAGE" and "Melee" or GetSpellLink(spellID)))
    		end
    	end
    end
    
    local f = CreateFrame("Frame")
    f:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
    f:SetScript("OnEvent", OnEvent)
    Posted in: Lua Code Discussion
  • 0

    posted a message on LibStub Repository empty?
    Ok I've just tested it uncapitalized, and now LibStub seems to be properly packaged ..
    I'm not really sure anymore why I was using a capitalized "L" :S

    .. never mind this thread, I think I'm just getting very confused with proper capitalizing
    Posted in: General Chat
  • 0

    posted a message on LibStub Repository empty?
    Is it me, or is the LibStub repo empty?



    I'm using SimpleDing as my test repository, and I've noticed that LibStub didn't get packaged
    (I'm only hardembeding LibDataBroker)

    http://wow.curseforge.com/addons/simpleding/files/12-v0-27a/

    .pkgmeta
    package-as: SimpleDing
    
    externals:
      Libs/Libstub:
        url: svn://svn.wowace.com/wow/libstub/mainline/trunk
        tag: latest
      Libs/CallbackHandler-1.0:
        url: svn://svn.wowace.com/wow/callbackhandler/mainline/trunk/CallbackHandler-1.0
        tag: latest
      Libs/AceAddon-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceAddon-3.0
        tag: latest
      Libs/AceConfig-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceConfig-3.0
        tag: latest
      Libs/AceConsole-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceConsole-3.0
        tag: latest
      Libs/AceDB-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceDB-3.0
        tag: latest
      Libs/AceEvent-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceEvent-3.0
        tag: latest
      Libs/AceGUI-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceGUI-3.0
        tag: latest
      Libs/AceTimer-3.0:
        url: svn://svn.wowace.com/wow/ace3/mainline/trunk/AceTimer-3.0
        tag: latest

    On another (maybe related?) note, are the externals case sensitive?
    I've actually been using Libstub with the "L" capitalized
    svn://svn.wowace.com/wow/[COLOR="DarkRed"]L[/COLOR]ibstub/mainline/trunk
    Posted in: General Chat
  • 0

    posted a message on mixin issues
    Quote from Priam_
    Embeds.xml
    <Ui xsi:schemaLocation="http://www.blizzard.com/wow/ui/ ..\FrameXML\UI.xsd">
      <Script file="Libs\LibStub\LibStub.lua"/>
    [COLOR="DarkRed"]  <Include file="Libs\AceAddon-3.0\AceAddon-3.0.xml"/>
      <Include file="Libs\CallbackHandler-1.0\CallbackHandler-1.0.xml"/>[/COLOR]
      <Include file="Libs\AceEvent-3.0\AceEvent-3.0.xml"/>
    </Ui>

    Aren't the libraries loaded in the wrong order? Afaik CallbackHandler should be loaded before the Ace3 libraries
    http://forums.wowace.com/showthread.php?t=17903#3
    Quote from Priam_
    When I enabled both add-ons, my own add-on suddenly worked without problem. Upon disabling both, I had the same problem.

    I think that if there are any other addons loaded before your addon which already loaded LibStub, CallbackHandler (and Ace3), then your addon wouldn't give an error anymore because the libraries were already (correctly) loaded

    But if your addon is the first (and only) addon that is loading LS, CBH and Ace3 (in the wrong order) then it would give an error again

    So I really think it's just the wrong loading order ..
    Posted in: AddOn HELP!
  • 0

    posted a message on WelcomeHome - Your first Ace3 Addon
    Quote from Phanx
    No. I don't think WoW even cares about the xmlns attribute (I've seen plenty of addons that don't include it but do, presumably, work just fine), but if it does, Blizzard certainly would not let you point it to random third-party URLs.

    ehmm I meant the xsi:schemaLocation attribute instead of the xmlns attribute

    since blizzard doesn't provide an online mirror themselves (except for the outdated download), wouldn't it still be better to just point straight to the third-party URLs?

    and as far as I can see, nobody seems to really care about it ..

    Quote from WoWPanel
    Now I have another Problem.

    My Addon don't want save the Settings, when I change the both msg's (hmsg and vmsg).
    [...]

    I couldn't find anything weird, are you sure you properly defined the SavedVariables in the .TOC?
    ## SavedVariables: WelcomeHomeDB
    Posted in: Ace3
  • To post a comment, please or register a new account.