• 0

    posted a message on LibHealComm-3.0 Official Thread
    Quote from xbeeps
    i'll merge it into main later today (currently busy painting the house!). Feel free to give Beacon of Light a shot, i haven't started on it. I did it once, but the code is gone, because when it was almost complete i found out that only effective heal carried over to the beacon, so i took it out again. As for Glyph of Healing Wave i don't think it's feasible with the current API, so i think it would be a good idea to consider how that could be accomodated for as an API change, hopefully without complicating the API too much (it's just one class and one glyph).


    I'll do the Beacon changes on the test branch and let you know when I have something.

    For the Glyph of Healing Wave, I was looking to find a general solution for those types of glyphs. I can easily see Blizzard creating new glyphs that increase the effect of a group heal on specific targets, like a glyph for PoH that also returns some of that heal to the priest, or one for Wild Growth for the druids. I'll think about it some more and share what I come up with.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Quote from xbeeps
    I did some tweaks to the initialisation after discovering the IsLoggedIn function (i wish i had found that function earlier!), and part of that was moving some of the gear detection a bit around, so it isn't called on every zoning (PLAYER_ENTERING_WORLD is called everytime you see a loading screen). I just moved the scanning function into the event handler, and changed it to use table.wipe so it reuses the table instead of throwing it away, and the increment logic was also simplified slightly. So you may want to merge 84 up also.


    I've merged everything on trunk up to patch-3-2-testing. The only difference between HEAD on those two branches is r83 on the test branch, which fixes the item IDs of the tier sets and can be merged back onto the trunk.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Beacon of Light seems fairly simple to add support for now that it counts the entire heal instead of just the amount healed, but I'm still stumped on Glyph of Healing Wave. I keep looking at the API and wondering what each function should return when Glyph of Healing Wave is being cast on yourself while Healing Wave is being cast on your target.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    One last point of clarification: the reason why there are so many entries for Tier 9 gear is because there are different versions of the same tier variant for Horde and Alliance. So it's Horde Tier 9 and Alliance Tier 9, with 10-man, 10-man (Heroic)/25-man, and 25-man (Heroic) variants. I didn't include the 25-man (Heroic) variants, called "Totally Triumphant", because WoWHead didn't list any set bonuses on that gear. I suspect that the bonuses will be identical to the rest of the Tier 9 gear, but until someone actually gets that gear and uploads the data to WoWHead, I won't know for sure.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Ah, I understand what you were thinking now. The code only identifies the healing tier gear in its tables, and actually only tier gear with bonuses that contribute to direct heals for now. It checks if you have that gear by inspecting your currently-equipped gear and seeing if it matches anything in its tables. So you could be wearing full T8 Elemental shaman gear, but since none of that gear is in the gear tables in LHC, it doesn't think you're wearing any T8 gear (with respect to healing set bonuses). I hope that clarifies how it works.

    I did two changes to the patch-3-2-testing branch. First, I synchronized patch-3-2-testing with the trunk in r82 so it could be used as a base of comparison for other changes. Second, I committed the fixed item IDs for druid and shaman tier 9 gear in r83. Please review r83 and pull it into trunk if it looks right to you. I double-checked all of the IDs in all of the tables using WoWHead and what happened was I had used the boomkin/elemental IDs for some of the sets by mistake. Hopefully all the Tier 9-wearing druids and shamans can be happier now :-)
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Quote from xbeeps
    jlam: I've merged all the way to the head of the 3.2 dev branch, but i reverted the Divine Hymn change. Have you tested it? I added it during PTR up to 3.2, and tested it on a premade priest and it produced two buffs, one of them with a rank and one without a rank. The one without a rank was the heal increasing one, hence the function in the table, so that it is not counted twice (resulting in a calculated increase of 1.21).


    Ah! That explains it. I don't have a priest leveled high enough to try that spell on (but I'm working on it), so I was going by the WoWHead description, but I see what you are describing since Divine Hymn has two effects, one of which is the actual heal while the other is a heal buff. Thanks for catching that.

    Quote from xbeeps
    Also, i think some of the item ids for the tier set for druids are wrong, but haven't checked it thoroughly. Also, it seems to not discern between different variants of the Tier sets, although the set bonuses are different, or am i missing something?


    I'll double check the item IDs for the tier sets when I get a chance. I was using the WoWHead item IDs as a reference, but it's possible I copied them incorrectly.

    The code differentiates between different tiers, but not between the ".0" and "0.5" variants within a single tier because you're supposed to be able to mix and match those pieces and still active the set bonus, which is the same across the entire tier, i.e. mixing Heroes' and Valorous Earthshatter for shamans to get the 4-pc. set bonus.

    I'll take another look at all of it tonight -- I've been testing on my shaman, who only has Tier 7 and 7.5 gear so far. Thanks for reviewing and integrating my patches!
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Quote from jlam
    r77 on the patch-3-2-testing branch contains a fix to the % healing increased by the Grace buff that was active since patch 3.1.2. That change is small and can be pulled up to the trunk.


    r78 on the patch-3-2-testing branch also contains a fix to the % healing increased by Focused Will that was active since 3.0.9 and simplifies the Divine Hymn buff to a constant (from patch 3.1.2).

    Those two minor changes should be pulled into the trunk after review.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    What's the purpose of broadcasting the version of LHC-3? Do you envision LHC one day being able to broadcast a heal event using multiple protocol versions, one for each member of the raid that has registered an LHC version that corresponds to that protocol version?
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    r77 on the patch-3-2-testing branch contains a fix to the % healing increased by the Grace buff that was active since patch 3.1.2. That change is small and can be pulled up to the trunk.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Quote from xbeeps
    I've merged up to 70 into main as is. I'll have a look at 71-72 later. Thank you for your contributions!


    Thanks, xbeeps!

    Regarding r72, I ran it last night and tested a lot on my shaman, then I created 3 alts for each of the other healing classes and at least tested that LHC-3 loaded properly and worked for the level 1 healing spells.

    PLAYER_EQUIPMENT_CHANGED seems to fire every time anything is equipped, and if you switch equipment sets, that event seems to fire for each piece of gear that gets swapped in, so that seems to be the right event to hook into for computing whether the equipped gear satisfies any set bonuses. It was cool... I equipped and unequipped my Tier 7 gear and saw the 5% bonuses reflected in the heal estimates LHC-3 was producing :-)
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Phanx, thanks for posting what you saw. I see the same thing on my shaman. Usually, the talents that say something affects "all spells" causes the improvements to be baked into the paper doll numbers, but for some reason there's a missing 5%, and the only two "all spells" talents affecting critical strike chance that I have are Thundering Strikes and Blessing of the Eternals.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    r72 includes changes to support set bonuses and 100% crit heals for all healers. If you're not interested in these changes, I recommend merging changes up to and including r70 (base changes for 3.2 and fixes for Priest talent checks) on the patch-3-2-testing branch into the trunk.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    r70 includes a bug fix for Priest talent checks. Tt was using Body and Soul instead of Empowered Healing when checking the number of talent points that were put into Empowered Healing.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    I've tested r69 of the patch-3-2-testing branch on the live server and it correctly deals with crit heals when the crit is guaranteed. That version is the best revision to merge into the trunk for a release.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Last thing I'd like to add (not sure if this is too much bloat) is to check for set bonuses that affect healing. I was thinking of a table per class that maps itemIDs to tier levels, e.g.,
    local ItemtoTier = {};
    local NumTier = {};
    local SlotIDs = {
        GetInventorySlotInfo("HeadSlot"),
        ...
        GetInventorySlotInfo("FeetSlot")
    }
    
    if (playerClass == "SHAMAN") then
        ItemToTier = {
            [31016] = 6, -- Tier 6 helm
            ...
        }
        ...
    end
    

    Then have a code block triggered by events like PLAYER_EQUIPMENT_CHANGED that does something like:
    for _, slot in ipairs(SlotIDs) do
        local t = ItemToTier[GetInventoryItemID('player', slot)];
        if (NumTier[t]) then
            NumTier[t] = NumTier[t] + 1;
        else
            NumTier[t] = 1;
        end
    end
    

    Then the class-specific GetHealSize() function could check for the Tier bonuses with:
    if (name == tChainHeal) then
        ...
        -- Tier 6 4-pc bonus boosts Chain Heal by 5%.
        if (NumTier[6] >= 4)
            effectiveHealModifier = effectiveHealModifer * 1.05
        end
        -- Tier 7 4-pc bonus also boosts Chain Heal by 5%.
        if (NumTier[7] >= 4)
            effectiveHealModifier = effectiveHealModifer * 1.05
        end
        ...
    end
    

    Would this be acceptable to add to LHC-3, or is this too much bloat?
    Posted in: Libraries
  • To post a comment, please or register a new account.