• 0

    posted a message on LibHealComm-3.0 Official Thread
    Quote from yoshimo
    how about the different spell-ids for veil of shadows.
    There are more different ids than only the one already included

        [GetSpellInfo(7068)]  = 0.25,   -- Veil of Shadow (Nefarian - Blackwing Lair)
    
    wowhead claims 22687 is the correct id he uses.

    http://www.wowhead.com/?search=Veil+of+Shadow#uncategorized-spells

    Be careful, there are different types . 75% reduce and 50%


    AFAIK, the only way to detect buffs/debuffs is by either name or texture. If there are two debuffs with the same name but different effects, I don't see a good way to differentiate between the two in the current code. At least for Veil of Shadow, the ID used doesn't matter because it still refers to the same name of the debuff.

    In the fight with dalronn and the constructor in utgarde keep, libhealcomm seems to claim that my heals are reduced to zero . i dont know which debuff it was, but i think that was wrong.

    And i think we should somehow deal with the necrotic aura that prevents all healing during the loatheb encounter in naxxramas


    I'll have to head into UK tonight and check this out. The only ability I see that would attach a debuff to a target is Debilitate, but there is no debuff tracked by LHC named "Debilitate".

    I took a look at adding Necrotic Aura but I wasn't sure if adding it would be right, just for that special case. Healers want to see their heal pre-casts before Necrotic Aura fades, but if I add it, the the heal estimates would be zero during the pre-casts and it's difficult to coordinate the heals across all the raid members who took damage. I will check next week after Naxx resets and I can test that change in the Loethab fight.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Quote from Julith
    It doesn't consider some Talents of diszipline priest when estimating the heals, it worked for me when I added the following lines to heal estimation code:

    -- Twin disciplines - increases heal/dmg of instants by 1/2/3/4/5% 
    effectiveHealBuff = effectiveHealBuff *(1 + select(5, GetTalentInfo(1,2)) * 0.01);


    LHC doesn't deal with instant cast spells, so we can ignore Twin Disciplines for now.

    -- Focused Power: - increases heal/dmg by 2/4%
    effectiveHealBuff = effectiveHealBuff *(1 + select(5, GetTalentInfo(1,16)) * 0.02);


    This is something I missed when inspecting the priest trees for talents that would affect heals. I will add this shortly.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Quote from Pastamancer
    If you're going to break trunk, please tag stable/release versions.


    I apologize if people are using the latest revision from HEAD and anything is broken. I see you fixed a typo I had introduced for the priests section. I wasn't aware that people were using HEAD directly as xbeeps had told me in a previous post that all commits were tagged as alpha before he released them on Curse.com, and that it would be okay to commit directly to HEAD with my changes. I don't see a good way to submit diffs to HEAD for wide testing before committing changes.

    What is the right way to handle this? Should we create a "release" branch that checkpoints HEAD periodically as changes are tested?
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Quote from Phanx

    As an alternative to watching the combat log, you could easily have the HoT's caster broadcast the estimated size of the first tick, and possibly the bloom amount for Lifebloom. Your client could then estimate the times of each tick based on the time the HoT was cast, and the size of subsequent ticks, doing math if necessary to calculate Wild Growth tick sizes. The caster could also broadcast when he consumed an HoT.


    This sounds very doable as I can see how the message passing might be adjusted to implement this, as well as the caching on each client. Thanks very much for this interesting suggestion -- this is what I hoped would come from brainstorming about HoTs :-) I feel that HoT tracking is a major feature missing from LHC, especially with prevalence of HoT healing, and I'd like to fix this.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Thanks for volunteering for testing. For every healing class, I'm mostly asking for a simple "does it load? does it work?" test to verify that some bookkeeping changes I had made didn't break anything. If you're using Grid or VisualHeal or any other LHC-using addon, simply copy the LibHealComm-3.0.lua file from your SVN checkout in place of the one in the addon. Then just cast each of your direct heal spells and verify that the heal estimates are in line with what you saw before.

    For paladins, you can also see if the Seal of Light changes are properly accounted for in the new code. Assuming you also have the Glyph of Seal of Light, you can see if the estimated heals with and without the Seal of Light active on the target show a difference of 5%, and also verify in your combat log that the estimated heals are in line with the actual heals.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    r27 seems stable for me on a resto shaman. I've touched code for each of the healing classes, so it should be tested on each class to ensure that it's working properly. Test-coverage-wise, I can check on a feral druid tonight, though if someone with a resto druid can check, that would be better. We also need testing on priests and paladins.

    There is one TODO item that I haven't done yet -- Improved Devotion Aura adds a 6% healing received buff to nearby raid members much like Tree of Life, and I haven't accounted for it yet. I haven't been able to check yet whether the two buffs (ToL and IDA) are correctly overwriting each other, or whether they are improperly stacking.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Not all HoTs run their full course (Chain Heal will eat Riptide, Swiftmend will eat Regrowth/Rejuv, etc.), and they can tick for different amounts per tick and number of ticks based on the spell and glyphs in-use at the time the spell was cast.

    It's certainly possible to code significant smarts into combat log parsing to try to anticipate each scenario, but this is a problem in perspective. Going this route puts all the responsibility for estimating a heal on every person who wants to know that information. Having the person with the HoT buff broadcast an incoming heal tick puts all the responsibility for estimating a heal on only one person -- and everyone interested party else just gets the information like they currently do.

    I'm assuming that it's possible to get the HoT tick information from just the buff aura, and also to differentiate between different Lifeblooms that tick for differing amounts. This is information that may need to be inferred or intelligently guessed.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    The goal of LHC is to see estimates of *incoming* heals, not the amount healed by a spell. Looking at the combat log only shows you what has already happened, not what *will* happen.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Just brainstorming about HoTs:

    It seems like the sensible thing would be for the target of the HoT to have LHC installed and track the periodic (ticking) heal from the buff and fire off events to note the incoming heal tick(s). The problem seems to be bandwidth though -- HoTs generate constant traffic, and multiplied across a 25-man raid, it would be quite a lot of events being fired.

    I'll try to look at a WWS parse to see what the events being fired would look like and guesstimate what the increased traffic might be.

    xbeeps: what are your thoughts on HoTs?
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Regarding the interaction of Purification and Improved Chain Heal, I'm going by the WoWWiki Chain Heal page which describes the combined effect as additive. It's difficult to test because the difference is quite small, though I guess that means if it's wrong, it's not off by much.

    I'm fixing up some of the Paladin heal estimates and updating them for WotLK at the moment, and also cleaning up the bookkeeping a bit so that the multitude of factors that affect each heal estimate can be tracked more easily.

    I'll post again after I've done some more testing to let you know when I think my changes are ready for release.

    Thanks for letting me work on this project.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    Regarding the Paladin heal estimates, one factor that isn't currently taken into account is "Seal of Light" combined with "Glyph of Seal of Light", which increases the effect of healing spells by 5%.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    I have made some shaman updates to LHC:

    (1) Fix Tidal Waves calculation as it's a passive bonus, not a buff bonus.
    (2) Add new totems (relics) from WotLK.

    I notice that the druid "Tree of Life" buff isn't accounted for, which increases healing effects by 6%. I will add this after some testing with a resto druid.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    What is the best way to contribute new code to this project? I have fixed up the Shaman code to handle the effects of Tidal Waves, Riptide, and Glyph of Lesser Healing Wave on the Shaman healing spells. Is it possible to commit directly to the SVN repository?
    Posted in: Libraries
  • To post a comment, please or register a new account.