I have modified my copy of BankItems to run on Retail, and have modified a separate version to run on Classic.
I am not the author of BankItems. I sent a message to the author on Sept 7, no reply so far.
My question is about whether and how I could make my two versions available to the general WoW population. What are the rules for making public a modified version of an addon that someone else wrote, and that doesn't seem to have been recently maintained by that author? I looked for guidance from CurseForge but haven't found any place to even ask the question. So I'm asking it here.
I'm the current maintainer of the Recap combat stats addon.
- Curse Premium
Member for 14 years, 2 months, and 8 days
Last active Mon, Jan, 11 2021 07:45:15
- 0 Followers
- 34 Total Posts
- 0 Thanks
Oct 1, 2019Posted in: AddOn HELP!
I have modified my copy of BankItems to run on Retail, and have modified a separate version to run on Classic.
Oct 1, 2008My reply to Xinhuan is several months late, but still:Posted in: General AddOns
From Xinhuan's first list of possible DPS calculations, Recap uses choice A, time of first damage to last damage.
However, if Recap has seen this mage do damage with a fireball since the last reset, then Recap will use time from successful cast of first fireball to last damage. If the cast starts at -3, is successful at -1, and takes 1 second for the fireball to reach the target, then the time that Recap uses is 18 seconds, for a DPS of 290.3. This choice is not on Xinhuan's list.
Similarly, from Xinhuan's second list of possible DPS calculations, Recap uses choice A. However, if Recap has seen this mage do damage with a fireball since the last reset, then Recap will use time from successful cast (even though it was resisted 1 second later) until last damage, 18 seconds, for a DPS of 233.8. This choice is not on Xinhuan's list.
Sep 11, 2008DPS numbers can be misleading. Comparing DPS numbers across combat meters can be doubly misleading. Always treat DPS numbers with caution.Posted in: General AddOns
As Elsia has noted, it is all in how different combat meters measure the time that a person, or a person + pet, is in combat.
I find that Recount generally seems to have shorter times in combat, and hence higher DPS numbers, than Recap. Hence it is interesting that H0PE gives an example with Recap having the higher DPS number.
I'm going to give a concrete example for a warlock, and explain how Recap does its calculations with "Merge Pets On", in hope that Elsia will use the same example to show how Recount's time and DPS calculations differ. Like H0PE I'm curious about the differences.
Time 00:00 -- a battle begins as the tank pulls the mobs.
Time 00:02 -- the warlock enters combat (their non-combat buttons dim), although neither the warlock nor the warlock's felguard has done anything yet.
Time 00:04 -- the warlock sends in the felguard which immediately damages a mob. Recap will start the timer for the warlock + pet combination.
Time 00:06 -- the warlock begins casting direct damage spells.
Time 00:12 -- the felguard dies, the warlock continues casting spells. Recap continues the timer for the warlock + pet combination.
Time 00:16 -- the warlock stops doing damage, and spends the next ten seconds banishing a mob. The warlock has no DoTs active during this time. Recap continues the timer.
Time 00:26 -- the warlock summons a new felguard and sends it into combat.
Time 00:27 -- the warlock resumes doing spell damage.
Time 00:36 -- the warlock dies and the new felguard de-spawns. Recap continues the timer.
Time 00:44 -- the final tick of the warlock's last DoT. Recap stops the timer for the warlock+pet combination.
Time 01:50 -- battle ends, everyone leaves combat.
Both Recap and Recount will come up with the same total warlock + pet damage. Let's say it is 20,000.
In this example, Recap starts the timer when the felguard does the first damage, and continues the timer even when the warlock stops doing damage to do some important banishing for a while in the middle of the battle. Recap also continues the timer after the death of the warlock because the warlock still has DoTs doing damage. Recap does nothing special in response to the death of one felguard and the later summoning of a second felguard.
Total length of combat for the entire party is 110 seconds. Recap considers that the warlock + pet combination was doing damage for 40 seconds. So Recap will calculate 20,000 / 40 to give a value of 500 DPS for the warlock + pet combination.
To avoid complication I've omitted one little Recap quirk from the above, a quirk which could on occasion slightly lengthen the warlock's time in combat, and so slightly lower their DPS.
Hawksy (maintainer of Recap)
Sep 11, 2008The two deaths for a priest before and after the Spirit of Redemption have identical texts from Blizzard. A combat meter would have to use a rule of thumb to try to count the first but not the second. It is complicated because sometimes the combat meter will see only one of the two messages so you can't simply divide the number of deaths by two. The combat meter would also have to figure out the right thing to do if a priest dies, is resurrected, and immediately dies again. There would usually be four death messages close together, but sometimes there might only be three, or even only two.Posted in: General AddOns
Petition Blizzard to change the two before and after events to be different.
May 30, 2008I've just upgraded to sRaidFrames from CTRA, and it is mostly good.Posted in: Unit Frames
One thing I miss from CTRA is that the buff icons were small and arranged in a little square of four, and the debuff icons were larger. That made it easier to see who had a debuff for dispelling and healing purposes. Any chance of getting a size difference between buff icons and debuff icons?
If the buff icons were in a little square of four they could stay visible all the time and the debuff icons would be additional and to their left. I would like to see that feature from CTRA, since at the moment the debuff icon appears in the same general location as the buff icons and is as a result not as distinctive as it could be. Such a feature would also allow me to see at the same time a debuff plus whether or not a Renew was active.
Also, any chance of showing raid icons (e.g. skull) as if they were debuffs?
May 27, 2008Posted in: General AddOnsQuote from kaimon »
I have to admit that I did not unterstand everything Xinhuan and Hawksy postetd, but I got that the defined "time in combat" is important. And I understnad tha t you can't compare different addons. But some questions are still there:
1. How could it be possible, that someone using recap whispers me that I did 900 dps in a bossfight if my recap shows 600?
Without being able to see the two settings and two displays directly it is hard to tell for sure.
Things to check (you may already have all of these covered):
If the other person is looking at "Last Fight" and you are looking at "All Fights", or vice versa, then the DPS numbers will be different.
If you are both looking at "All Fights", and if one of you did not Reset at the same time as the other, then the DPS numbers will be different.
If you have different settings for Merge Pets.
If one copy of Recap is successfully merging a pet and the other is not (this can happen occasionally in some situations due to Blizzard sending different combat log messages to the pet owner than they send to others). For example in a ZA run our mage summoned 30 Water Elementals and my copy of Recap successfully assigned all of them to the mage. But I know that sometimes my copy of Recap will miss assigning a Water Elemental correctly. Update: the mage's copy of Recap also successfully assigned all of those Water Elementals to the mage.
If one of you is looking at the "DPS" column and the other is looking at the "DPS+" column.
There are some other unlikely situations that could lead to different numbers.
2. How come webstats (using different combat time definitions) reports the warriors dps nearly identical with recap and mages with 200 dps difference? And 30% difference seems to be a bit much just for combat time measurement.
I can't answer that. I would need to read up on how webstats measures combat time, and check a particular combat log in detail. When I have checked a combat log in detail against Recap (which I do occasionally) they match up.
A tank will tend to be in most fights right from the start to the finish, and so webstats and Recap are likely to measure very similar combat times. A mage is likely to have a much more variable participation, and if webstats and Recap use different time definitions then they could easily produce different DPS numbers.
3. I have "merge pets" enabled, but "waterbolt" doesn't show up among my mages details. So - where is the elementals damage?
The pet details will be listed after your mage details. On the main Personal Details panel you should see "Water Elemental: Waterbolt" following your mage details. On the popup Outgoing Spells and Abilities tab you should see "Water Elemental: Waterbolt" following your mage details.
Please understand I very much appreciate your work. I am just getting frustrated while trying to improve my gameplay. Sometimes I end up with 400 dps, sometimes 600, sometimes 800 (all with recap) ... and I can't find any relation to what I am doing.
Without knowing more about the exact circumstances I can't tell for sure.
If in one fight you need to do a lot of polymorph, then your DPS will be low for that fight. If in another fight you do no polymorph, plus you get the Heroism buff, then your DPS will be very high.
May 25, 2008Xinhuan has summarized well.Posted in: General AddOns
You should always be cautious comparing DPS between combat addons, because every one of them calculates time (and hence DPS) differently. As long as you stick to one combat addon you'll be comparing apples with apples. You'll get used to it, and won't usually need to know the details of how the DPS is calculated. If you compare DPS from two different combat addons, then you will be comparing apples with oranges. Be cautious. If the difference between DPS numbers matters to you then you'll have to do some research, find out exactly why they are different, and decide if you prefer one calculation over another.
I do not know how webstats calculates DPS.
Recap calculates time during a battle from the first damage that a combatant does until the last damage that a combatant does. If the battle is 120 seconds, and if a combatant waits 15 seconds before starting damage, and if that combatant dies 20 seconds before the end of the battle and has a dot that lasts another 5 seconds, then the combatant will have been doing damage for 90 seconds as far as Recap is concerned.
The Recap column labelled "DPS" will be based on this. The Recap column labelled "DPS+" is different. That column is based on the time that the first combatant does damage until the time that the last combatant does damage, and so it will give a lower number for combatants who wait before doing DPS, or who die before the end of combat.
If someone stops DPS in the middle of a battle to do something else important (e.g. cast crowd control, or die and get battle ressed, or go afk to answer the telephone) then Recap will show them with a lower DPS than if they did non-stop damage. There is at least one combat addon (I can't remember which one) that will pause a combatant's timer if they stop doing damage for any reason in the middle of a fight.
There are some additional choices made by Recap that are less obvious. Recap treats a miss as if it had done damage (think about it). Recap counts damage from the time a combatant successfully casts a spell that will do damage, so that if a mage opens with a fireball then Recap will include the flight time of the fireball. If a fight is an insta-kill, Recap will increase the time for that fight from 0 seconds to 1.5 seconds. Starting with version 4.07 Recap omits 'friendly fire' damage when calculating DPS.
If Merge Pets is on, Recap treats the combatant plus their pets as a single combatant. The combat time is from the first damage done by any of them until the last damage done by any of them. This will give a different (and usually slightly lower) number for DPS than if you measured them separately then added the DPS numbers together.
Every combat addon calculates DPS differently. None of them is 'right', because there are good arguments for every method. The method used by one combat addon might suit your own personal needs and preferences more than the method used by another combat addon.
I believe that since patch 2.4 you can not change the combat log range. I believe that all addons will use Blizzard's "everything visible" range. I believe that if you put the old style combat log range statements in your Config.wtf file Blizzard will ignore them.
May 24, 2008Additional question probably related to XCode:Posted in: AddOn HELP!
When I tried to upload Recap using XCode earlier this week the result was a new Recap folder (with the updated files) nested inside the main WoWAce Recap folder, rather than an update of the existing files. So version 4.07 was there, but nested inside the older version 4.04. To avoid confusion I deleted the nested folder.
When I tried to upload directly to trunk it told me that it couldn't because there was already a Recap folder there.
Afterwards I noticed that the Import command in XCode appears to want to add a new folder to SVN. I could not find any setting in XCode to overwrite an existing folder with new contents. Is there such a setting, and if so where would I find it, or what would I do to enable it?
In the meantime what I did yesterday was to delete the existing Recap folder on WoWAce; wait until the delete had been packaged and Recap disappeared from files.wowace.com; and then upload a new one. I'm sure this isn't optimal.
May 21, 2008There are a couple of seconds of activity, then I get:Posted in: AddOn HELP!
Error: 175002 (RA layer request failed) Description: CHECKOUT of '/wowace/!svn/ver/66903/trunk/Recap': 403 Forbidden (http://dev.wowace.com)
May 21, 2008Hi Folks,Posted in: AddOn HELP!
I'm having trouble updating Recap on the SVN.
Is there anyone who already has SVN working who would be willing to volunteer to keep an eye on Recap on curse (the main site) and upload copies of new versions from there to WoWAce?
Since the version currently on WoWAce (v 4.04) is quite out of date and is causing trouble for people using WoWAceUpdater, can anyone advise me how to go about deleting Recap from WoWAce for the moment until I can get my update process working? Alternatively, is there anyone who can delete Recap for me?
I have been trying to use the Subversion repository from within XCode (Mac OSX) to update Recap. I can authorize and I can download the current WoWAce version of Recap fine, but when I try to update I'm getting errors. The errors might be generic, or they might be XCode-specific, I don't know. Is there anyone able to work with me (via PM) to help me get the upload process working?
May 8, 2008Posted in: AddOn HELP!Quote from Funkydude »
Step 1, Patience?
I though I had that covered. I'm a fairly patient kind of guy. I had been waiting for nearly two months (first email March 11).
Anyway, the post seems to have had the desired effect. I got a reply yesterday, for which many thanks.
May 7, 2008I'm the author of Recap.Posted in: AddOn HELP!
I would like to be able to upload Recap to WoWAce.
Another user had been doing this but appears to have been afk for a month, and the Recap version on WoWAce is now badly out of date.
I have entered my name on the SVN Rules page.
I have sent several emails to [email]firstname.lastname@example.org[/email] but have received no reply.
What step(s) am I missing?
- To post a comment, please login or register a new account.