• 0

    posted a message on AceAddon-2.0 setting wrong metadata name/titles
    Aha. Yes, normally I run with embedded libs, and so far none of the containing addons have apparently been updated. Grabbing the standalone versions did it. Thanks for the advice!

    (I'm curious as to what the bug was, if the explanation won't drive me insane.)
    Posted in: Libraries
  • 0

    posted a message on AceAddon-2.0 setting wrong metadata name/titles
    So after the 3.0.2 patch today, I was doing the usual update mod routine and noticed something bizarre. I use sRaidFrames, which has a minimap icon. Mousing over this icon drops down the standard menu, except that the title of the menu is not "sRaidFrames" but "Widest Audience". WA is a completely unrelated addon which does not use any libraries, Ace or otherwise.

    The new ace'd ClearFont2 minimap icon also uses the same minimap dropdown library. Mousing over that icon shows the correct menu, but the title "Bartender4". And so on.

    I did some quick tests with the Lua tables created by LibStub/AceAddon, specifically the fields set by AceAddon:InitializeAddon(). Here's what I found.

    sRaidFrames.title == "Widest Audience" -- title field, wrong addon
    sRaidFrames.name == "WidestAudience" -- name of addon and .toc file, wrong addon
    GetAddOnMetadata("sRaidFrames", "Title") == "sRaidFrames -Ace2-" -- correct results

    ClearFont.title == "Bartender4"
    GetAddOnMetadata("ClearFont2", "Title") == "ClearFont2 -Ace2-" -- etc

    The bit of :InitializeAddon that removes the colorized "-Ace2-" text seems to be working, anyhow.

    Anybody have thoughts or comments before I go digging deeper? Much of the standard Ace2 library code is murky to me. Also, sRaidFrames has not (as of this writing) been updated for 3.0.2, but Bartender4 was relatively recent, and the ClearFont2 zip was the one posted here a few hours ago.
    Posted in: Libraries
  • 0

    posted a message on Outlining the differences between Ace2 and Ace3
    Quote from Mikk
    Please see http://www.wowace.com/wiki/Differences_from_Ace2_to_Ace3 where we outline the major differences between Ace2 and Ace3 from a developer perspective.


    That page no longer exists (redirects to front page). I mention it only because this thread is stickied.
    Posted in: Ace3
  • 0

    posted a message on /dev/null 2.4 troubles
    I'm running 2.4.2a r73392. I'm posting here because the only /dev/null threads shown by the forum search are for 2.0, some two years ago.

    I have the iGen option turned on, which turns off General chat when zoning into an instance. (It doesn't /leave the channel, it only removes it from the active channel filters for the chat window.) That part works fine.

    The bug is that it sometimes does not re-enable General chat when leaving the instance. I often find myself out in a zone or in a city, wondering why it's so quiet, only to find that General (and LocalDefense) have been turned off. Normal zoning out through the instance portal, via hearthstone, or via a mage portal, all work fine. It's the "unusual" cases which seem to get it screwed up: rezzing at a spirit healer after dying in an instance, or logging into a full instance which then puts you at your inn, etc.

    I've fiddled with devnull code once before, recently, to filter out NPC chat when inside Blackrock Depths -- a special case which I'll undo once Brewfest is over :-) -- but I haven't really looked at what's happening with the General chat toggle. There's stuff involving other Ace libraries which are unfamiliar to me. Before I go digging deeply, is there anybody more familiar with this addon who might have advice?
    Posted in: AddOn HELP!
  • 0

    posted a message on BigBrother
    Here you go, and sorry it took so long.

    This patch has both of my local mods to BigBrother; I didn't try to generate separate diffs, but they don't overlap so if you don't like the other change it's easy to undo. I should also mention that nothing here is localized, and it's tested only as far as "it works for me, the way I use it".

    The main part is the addition of a 'notraid' sub-option, which takes a list of names, and toggles ignoring those names when reporting CC breaking to /raid chat: "/bb settings polyoutput notraid TankA TankB TankC" for example. These names are saved in the current profile.

    The other unrelated change is to the consumable check. By default, if everybody has flasks/elixirs/food/etc and there is nothing to report, then nothing at all is printed. Normally I'm a big fan of the Unix "if you have nothing to say, then say nothing" school of software design, but this has caused problems when a raid leader is expecting me to use "/bb quickcheck whisper", because there's no way for the leader to distinguish "everybody's buffed" from "farmbuyer's afk and not doing his job". :-) So I added a kludge to send a message even when all the buffs being checked are present.

    edit: diff is against r81041, which is current as I type this.

    --- BigBrother.lua.81041orig	2008-09-03 09:59:48.000000000 -0400
    +++ BigBrother.lua	2008-09-03 10:19:50.000000000 -0400
    @@ -125,6 +125,7 @@
     CheckFlasks = true,
     CheckElixirs = true,
     CheckFood = true,
    + PolyOutNotRaidTanks = {},
     })
     
     -- ACE options menu
    @@ -286,6 +287,32 @@
           set = function(v) addon.db.profile.PolyOut[3] = v end,
           map = { [false] = "|cffff4040Disabled|r", [true] = "|cff40ff40Enabled|r" }
          },
    +      notraid = {
    +       name = "Not to Raid",
    +       desc = "Toggles names to ignore when reporting CC breaks in raid chat.",
    +       type = 'text',
    +       usage = "Name1 Name2 Name3...",
    +       get = function()
    +           local t = ""
    +           for n,_ in pairs(addon.db.profile.PolyOutNotRaidTanks) do
    +            t = t .. " " .. n;
    +           end
    +           t = strtrim(t, ", ")
    +           return (t=="") and "None" or t;
    +          end,
    +       set = function(v)
    +           -- This only works for command-line usage, toggling each
    +           -- name given. Fiddling with the drop-down minimap fields
    +           -- is left to people who care about that kind of thing.
    +           for n in string.gmatch(v, "(%a+)") do
    +            if addon.db.profile.PolyOutNotRaidTanks[string.lower(n)] then
    +             addon.db.profile.PolyOutNotRaidTanks[string.lower(n)] = nil
    +            else
    +             addon.db.profile.PolyOutNotRaidTanks[string.lower(n)] = true
    +            end
    +           end
    +          end,
    +      },
          guild = {
           name = L["Guild"],
           desc = L["Reports result to guild chat."],
    @@ -453,6 +480,9 @@
      else
       SendChatMessage(Pre..": "..table.concat(List, ", "),Where)
      end
    +  return true
    + else
    +  return false
     end
     end
     
    @@ -480,6 +510,7 @@
     local MissingFlaskList={}
     local MissingElixirList={}
     local MissingFoodList={}
    + local sent = false
     
     for unit in RL:IterateRoster(false) do
      if self.db.profile.Groups[unit.subgroup] then
    @@ -493,13 +524,13 @@
      for i, v in ipairs(buffs) do
       local t = self:BuffPlayerList(v,MissingFlaskList)
       if Full then
    -    self:SendMessageList(v, t, Where)
    +    sent = self:SendMessageList(v, t, Where) or sent
       end
       totalFlaskCount = totalFlaskCount + #t
      end
      
      if Full then
    -   self:SendMessageList(L["No Flask"], MissingFlaskList, Where)
    +   sent = self:SendMessageList(L["No Flask"], MissingFlaskList, Where) or sent
      end
     end
     
    @@ -508,7 +539,7 @@
      for i, v in ipairs(elixirs) do
       local t = self:BuffPlayerList(v, MissingFlaskList)
       if Full then
    -    self:SendMessageList(v, t, Where)
    +    sent = self:SendMessageList(v, t, Where) or sent
       end
       totalElixirCount = totalElixirCount + #t
      end 
    @@ -528,20 +559,28 @@
       end
      end
     
    -  self:SendMessageList(L["Only One Elixir"], MissingElixirList, Where)
    -  self:SendMessageList(L["No Flask or Elixir"], MissingFlaskList, Where)
    +  sent = self:SendMessageList(L["Only One Elixir"], MissingElixirList, Where) or sent
    +  sent = self:SendMessageList(L["No Flask or Elixir"], MissingFlaskList, Where) or sent
     end
     
     --check for missing food
     if self.db.profile.CheckFood then
    +  local t
      for i, v in ipairs(elixirs) do
    -	local t = self:BuffPlayerList(SpellName(35272), MissingFoodList) -- Well Fed
    -	local t = self:BuffPlayerList(SpellName(44106), MissingFoodList) -- "Well Fed" from Brewfest
    -	local t = self:BuffPlayerList(SpellName(43730), MissingFoodList) -- Electrified
    -	local t = self:BuffPlayerList(SpellName(43722), MissingFoodList) -- Enlightened
    +   t = self:BuffPlayerList(SpellName(35272), MissingFoodList) -- Well Fed
    +   t = self:BuffPlayerList(SpellName(44106), MissingFoodList) -- "Well Fed" from Brewfest
    +   t = self:BuffPlayerList(SpellName(43730), MissingFoodList) -- Electrified
    +   t = self:BuffPlayerList(SpellName(43722), MissingFoodList) -- Enlightened
      end
    -  self:SendMessageList(L["No Food Buff"], MissingFoodList, Where)
    +  sent = self:SendMessageList(L["No Food Buff"], MissingFoodList, Where) or sent
     end 
    +
    + -- If nothing triggered an alert, don't leave the user waiting and
    + -- wondering. This use of SendMessageList is a kludge, but it allows easy
    + -- reuse of the 'Where' parameter without adding new code.
    + if not sent then
    +  self:SendMessageList("All Buffs", {"Present"}, Where)
    + end
     end
     
     function addon:BuffPlayerList(buffname,MissingBuffList)
    @@ -572,14 +611,16 @@
      return format
     end
     
    -local function sendspam(spam)
    +local function sendspam(spam,src)
     	if not spam then return end
     	for a, b in ipairs(addon.db.profile.PolyOut) do
     		if b then
     			if a == 2 and GetNumPartyMembers() ~= 0 then
     				SendChatMessage(spam, "PARTY")
     			elseif a == 3 and GetNumRaidMembers() ~= 0 then
    -				SendChatMessage(spam, "RAID")
    +				if src and not addon.db.profile.PolyOutNotRaidTanks[string.lower(src)] then
    +					SendChatMessage(spam, "RAID")
    +				end
     			elseif a == 4 and IsInGuild() and (GetNumPartyMembers() ~= 0 or GetNumRaidMembers() ~= 0) then
     				SendChatMessage(spam, "GUILD")
     			elseif a == 5 and IsInGuild() and (GetNumPartyMembers() ~= 0 or GetNumRaidMembers() ~= 0) then
    @@ -646,7 +687,7 @@
     				end
     
     				if spam then
    -					sendspam(spam)
    +					sendspam(spam,srcname)
     				end
     			end
     		end
    Posted in: Raid AddOns
  • 0

    posted a message on oRA2
    A suggestion/proposal/etc for a feature in oRA3: vote proposals and vote taking that isn't limited to yes/no responses like the current /ravote is. Ideally, a popup window with the choices, where the raider can select a radio button. I realize this would require everyone in the raid to have the addon, but that's not uncommon already.

    It might be too much work, I have no idea, I don't know the effort involved in creating graphical elements.

    I couldn't find an oRA3 page anywhere, so maybe this is the wrong place for proposals.
    Posted in: Raid AddOns
  • 0

    posted a message on BigBrother
    Quote from gweniver »

    My guild has been using BigBrother for a while now and we've been finding it very useful for both CC break and food/flask reporting.

    I do have a feature request though. Is there anyway to filter out a defined list of players who do not show up as CC breaks?

    Our MT is usually the one who breaks CCs once he is ready to tank. I would like to be able to filter his name out from generating a message.

    Thanks!


    I have a patch which does this. I'll post it later.

    Also, bug report: running "/bb quickcheck whisper" without having a target, whispers the user. It's a little surprising. I would have expected the addon to check for a target and print a message if there wasn't one.


    Posted in: Raid AddOns
  • 0

    posted a message on sRaidFrames: Alternative CTRA raid frames
    "Delete this set" does not work for the builtin "Set: by role" filter. The set is removed from the running addon, but the change is not preserved and so the set comes back on the next login.


    Posted in: Unit Frames
  • 0

    posted a message on WAU crashes
    Quote from JamusPsi »

    I loaded it up in visual studio and grabbed the innerexception. A method being invoked on a new thread is throwing an exception (which is therefore unhandled, and causes the application to die). The inner exception seems to be that a domain cannot be resolved- wdnaddons.com

    I suspect that wdnaddons.com is an ad site, but the method which retrieves the advertisements does not check for the dns record to be successfully queried. Adding wdnaddons.com to a dummy ip in my hosts file fixed the crash.


    Nice detective work. They say on the IRC channel that kolie (who's doing WAU maint now) has been informed. Hopefully we get a fix soon.
    Posted in: Updaters
  • 0

    posted a message on Bartender3 - Action Bar AddOn for WoW 2.0
    Using r76596, enabling a previously-disabled special bar gives this error:

    Error: attempt to index local 'bar' (a nil value)
    AddOn: Bartender3
    File: Bartender3.lua
    Line: 293
    Count: 1
    Interface\AddOns\Bartender3\Bartender3.lua:293: in function `ToggleBarEnabled'
    Interface\AddOns\Bartender3\Options.lua:300: in function `setFunc'
    ...dOns\TankPoints\libs\Waterfall-1.0\Waterfall-1.0.lua:2511: in function `ToggleChecked'
    ...dOns\TankPoints\libs\Waterfall-1.0\Waterfall-1.0.lua:2418: in function <...dOns\TankPoints\libs\Waterfall-1.0\Waterfall-1.0.lua:2415>


    Looking at the code, the fix is simply to re-assign 'bar' like it was a couple lines earlier, now that the right-hand value will be useful.
    Posted in: General AddOns
  • 0

    posted a message on Bartender3 - Action Bar AddOn for WoW 2.0
    Makes sense. Thank you!
    Posted in: General AddOns
  • 0

    posted a message on Bartender3 - Action Bar AddOn for WoW 2.0
    What, exactly, is the difference between "enable/disable" and "show/hide"?

    The tooltips don't say anything more, and the wiki page doesn't say anything at all.
    Posted in: General AddOns
  • 0

    posted a message on Omen2
    Quote from Certus »

    Are there plans/is there already a tool in Omen2 or a related addon that will show average threat for a specified period of time (say a full raid or certain fights?) I believe there was a tool in Omen before (ETPS) that did this and I cannot find anything in the current Omen2. There are other addons out there that require KTM but me and my guild prefer Omen. I have the latest update of Omen2 as of today. Would really like to see this or another type of reporting so I can more effectively switch my gear around between different levels of EH and TPS generation. Thanks!


    EstimatedTPS is the addon you want to get in this case.
    Posted in: Raid AddOns
  • 0

    posted a message on Omen2
    Quote from yoshimo »

    Farmbuyer , may i ask you why you quoted me? ;) to stress the importance of my questions? ;)


    I started to write a reply, got distracted, and then everything went downhill from there. :-) Complete mis-post, and I've deleted it.
    Posted in: Raid AddOns
  • 0

    posted a message on RatingBuster
    Quote from Haz-Mat »
    But, is there a reason why my enhancement shammy only gets rated on spell damage? RatingBuster ignores anything else, making it useless for him.

    What am I doing wrong?


    I think the default settings for shaman are to look at caster stats rather than melee stats. Have you changed RB to check for anything in particular? RB will not (for example) notice a respec and alter accordingly.

    Try "/rb win" and toggle on the melee stuff. If that still doesn't fix it, post here and somebody will figure it out. :-)
    Posted in: General AddOns
  • To post a comment, please or register a new account.