CurseForge and Overwolf are joining forces!
Awesome More Information
  • 0

    posted a message on LibHealComm-4.0
    Quote from Adirelle
    With my piece of code I also realized that the GUID->unit map may return something like raidN or raidpetN but oUF unit->frame map contains data only for partyN or partypetN (or conversely, I don't clearly remember). So basically I think unit->frame maps just won't work: you have to scan all frames and check if UnitIsUnit(unit, frame.unit). This also solves possible issue when the same unit is displayed more than one. (I'm realizing I could just drop my GUID->frame map and find another solution)


    I found this as well when creating oUF_HealComm4. As it is an optional extra on top of any oUF layout(s) then I had to scan every frame to make sure all the appropriate frames get updated. My own oUF layouts can have the player shown simultaneously in 4 places typically (player, targetoftarget, raid and MainTank frames).

    I still need to optimise the code some more, but for the moment it has acceptable performance. Feel free to borrow any ideas from what I've done so far, and if you have any suggestions for improvements then send me a PM.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-4.0
    Just managed to get an error when using the latest alpha (b2.6-1-ge8ad1e2).

    I was exiting Violet Hold and the group was disbanded when the loading screen was shown. Upon Dalaran loading then BugSack did it's little 'uh oh' and the following was reported:

    [2009/09/20 10:14:57-3475-x1]: LibHealComm-4.0-25:2183: table index is nil
    LibHealComm-4.0-25:2213: in function `?'
    LibHealComm-4.0-25:2368: in function <...F_HealComm4\libs\LibHealComm-4.0\LibHealComm-4.0.lua:2367>
    
      ---
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-4.0
    I've noticed that when casting Prayer of Healing the group members get incoming heals, but not their pets.
    Although the tool-tip only mentions party members the heal does also affect the pets of those party members.

    I suspect identifying which party members currently have a pet is not going to be simple, but it would be nice if you could look into adding this.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-4.0
    Quote from xbeeps
    Small thing, the toc file has the wrong path and spelling for CallbackHandler-1.0, so it can't load unless something else has pulled in CallbackHandler-1.0.


    I notice that this issue has been fixed, but the LibHealComm-4.0 still seems to include 2 copies of LibStub. As CallbackHandler-1.0 has LibStub embedded within it's folder structure (and loaded from it's .xml), it's not necessary to embed LibStub individually as well.
    Posted in: Libraries
  • 0

    posted a message on BadBoy: An extremely minimal spam blocker & reporter
    I also recently got a whisper from a level 55 DeathKnight. I didn't copy/paste the message, but the above post looks identical to the one I received.
    Posted in: General AddOns
  • 0

    posted a message on LibHealComm-4.0
    Thanks for the suggestions Adirelle, I'll take a closer look when I'm not at work.

    The previous oUF_HealComm allowed each oUF frame to specify a .ignoreHealComm flag to disable showing the incoming heal bar. With it being possible to have the same unit shown on player frame, target frame, targetoftarget frame, raid frame, maintank frame and maintanktarget frame I don't necessarily want all of them to show the incoming heal bars.
    Posted in: Libraries
  • 0

    posted a message on LibHealComm-4.0
    I've taken the existing oUF_HealComm addon and updated it to use LibHealComm-4.0 and everything seems to work fine, although I have 1 concern.

    Currently I am getting the GUIDUnitMapTable on every heal update, which is a kludge, instead of only getting an updated version of the table when it has changed.
    Looking at the code the GUIDUnitMapTable updates on initialisation of LibHealComm-4.0 and on the UNIT_PET, PARTY_MEMBERS_CHANGED and RAID_ROSTER_UPDATE events. While I could also listen for these events and update afterwards, I would need some nominal delay to avoid race conditions and ensure the table has been updated before I get it again.

    Would it be more elegant for LibHealComm-4.0 to fire another event whenever it makes changes to the GUIDUnitMapTable? Then any addon using LibHealComm-4.0 could listen for that event as the trigger to grab the updated copy.


    You can see how I have updated oUF_HealComm here: http://github.com/Evilpaul/oUF_HealComm4/tree/master
    Posted in: Libraries
  • To post a comment, please or register a new account.