• 0

    posted a message on RaidBuffStatus
    1.73 has temp wep buffs. It has range issues so can only inspect close people. It is experimental so let me know of problems.
    Posted in: Raid AddOns
  • 0

    posted a message on Scanning gear
    So you use CheckInteractDistance(name, 1) and call NotifyInspect(name)? Is that the difference?

    But I don't understand how that fixes the problem. CheckInteractDistance makes sense but NotifyInspect is a call that tells the server to load information about a player like gear and talents then send an event when it is ready. You are not waiting for that event. Is this an undocumented purpose of NotifyInspect?
    Posted in: Lua Code Discussion
  • 0

    posted a message on Gratuity-2.0 and range and reliability
    Elkano: I don't think notifyinspect will help at all. It also would need waiting for inspectready.

    Pach: Thanks. BTW I notice you are missing a couple:
    L["^(Sharpened %(%+%d+ [^%)]+%+%d+ [^%)]+%))"], -- Sharpened (+xx Crit Rating and +xx Damage) [Adamantite Sharpening Stone] +14 and +12
    L["^(Weighted %(%+%d+ [^%)]+%+%d+ [^%)]+%))"], -- Weighted (+xx Crit Rating and +xx Damage) [Adamantite Weightstone] +14 and +12
    Posted in: Lua Code Discussion
  • 0

    posted a message on RaidBuffStatus
    Quote from dogsalad »

    Could you add Amplify Magic to the list of checked buffs to assist our Mages when we're doing the Bloodboil fight?


    Done. It will be in 1.72.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    Quote from Opi »

    I like this addon so much and I like the simple and intuitive UI.
    Whenever you need german translation please contact me :)


    Now please. Just download the latest version. Look in the deDE file. All the lines that start with -- need translations. My email address is in the readme file. Email me the updated version of the file. And then every so often in future check the file again for needed translations.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    Half of what you want is implemented in pally power. There is also zomgbuffs.

    In my lunch break just now I've worked out a bunch of rules and checks for pally buffs like rogues should never have wiz and priests no might and other rules that look at how many paladins and stuff like that. I'll see if I can add those features in tonight.

    RBS needs to be simple and work out of the box without config like now. zomgbuffs is the complete opposite. I don't want RBS to become like that. So it will never let you pick who is dps and other manual things.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    Quote from cerbul »

    can this addon check if all raid players have the number of blessings from paladins equal to the number of paladins in the raid?

    and one more thing, can it check any rogues have blessing of wisdom or any tank blessing of salvation? (tank checked through talents)



    Not yet. I've not worked on the paladin blessings checking yet.

    One of the problems is that it might be correct for a tank to have salvation. For example 3 tanks for trash and only 1 for the boss so the other 2 put on dps gear and have salvation. Paladin blessings is such a dynamic thing changing all the time according to the encounter. Plus tanks who don't need salvation should get the addon called Damnation which auto-removes salvation. There are situations where a lock or mage must not have salvation because they are tanking eg Leo or King. Also warriors will sometimes get wisdom because when we buff pets it goes on the warrior. It's been a bug for a long time in WoW.

    It will be able to check some things like wiz on rogues.
    Posted in: Raid AddOns
  • 0

    posted a message on Gratuity-2.0 and range and reliability
    I am trying to use Gratuity for detecting temporary weapon buffs. The idea is simple - inspect other players weapon slots for phrases like "sharpened".

    I tested the idea. I made a party of 2 then moved 95 yards apart. Worked perfectly. Then when trying in a raid in BT it would detect almost no one. I tried in heroic MT and it would only spot mine even when the entire group were within 10 yards. I tried in a raid in shatt and it seemed to have about 20 yards range but was unreliable as in it would not detect the other player until I inspected them.

    I just don't understand what conditions it will work or not or how to detect if those conditions are met. Is there an inspect per second limit or a delay or a callback after calling G:SetInventoryItem(unit.unitid, v) before I can do G:Find(buff)?

    I have seen there is an API for self inspection of temp wep buffs (GetWeaponEnchantInfo()) but I want to inspect others. To use that I would need a helper addon. Which seems a bit of an overkill. Any ideas?
    Posted in: Lua Code Discussion
  • 0

    posted a message on Adding a button causes taint error when opening the frame
    Solved.

    I can live with the options window not being open able during combat. I used PLAYER_REGEN_DISABLED which is called just before the ui is locked. Now I can resize and hide and show what I need as I leave and enter combat.
    Posted in: Lua Code Discussion
  • 0

    posted a message on RaidBuffStatus
    Quote from Nirek »

    PLAYER_REGEN_DISABLED is called as combat starts before the ui locks down.


    Perfect! Thanks! Now it works - it can resize to just the items one wants when in combat.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    Bad day for RBS today.

    The temporary weapon enchants code did not work. It missed most of them in a raid. In a party the range seems to be 100 yards but in a raid more like 15 and thus useless. I could make a helper addon that people install and use a more reliable API call like GetWeaponEnchantInfo() but it is self only. Currently I look at the tool tip text from the weapons. This is not going to be easy to solve.

    I added code to do the window resizing on entering combat. But it would not work as doing things like hiding action buttons and resizing and other things are protected and can't be done in combat. The reason ooc can do it is it only shows bars which have no function such as when you click on them. One possibility is to have 2 windows with one out of sight always and swap on entering combat. I don't know. This is not going to be easy to solve.

    Frustrating. If anyone users or developers has any ideas I would be interested.
    Posted in: Raid AddOns
  • 0

    posted a message on Adding a button causes taint error when opening the frame
    Thank you for your answers.

    The addon has a main dashboard window that gives information on well fed, afk, mana and others. My intention was to have the dash resize to a smaller window with only the stats needed during combat. The stats are shown as text on secureactionbuttons. When this would not work for me I surmised that the same problem would occur if I tried to open the options window when in combat. I was right. I thought if I could solve that existing problem it would help me solve the original goal.

    So. Perhaps the buttons don't need to be secureaction? I only did that as I looked at other author's code. Where can I get a list of the templates to use.

    Eventually the addon will allow spell casting from these buttons. In that case will they need to be secure?

    Is there somewhere I can read more about the restrictions when in combat?

    Is there some work around?
    Posted in: Lua Code Discussion
  • 0

    posted a message on Adding a button causes taint error when opening the frame
    I have a problem when in combat and I try to open a frame. I get Interface action failed because of an AddOn. Taint log says the frame:Show() is tainted.

    I narrowed it down to this code:

    addon.button = CreateFrame("Button", name, addon.optionsframe, "SecureActionButtonTemplate")
    addon.button:Hide()
    addon.button:SetWidth(20)
    addon.button:SetHeight(20)
    addon.button:SetNormalTexture(icon)
    addon.button:SetHighlightTexture("Interface\\Buttons\\UI-Common-MouseHilight")
    addon.button:SetPoint("TOPLEFT", addon.optionsframe, "TOPLEFT", x, y)

    If I don't do this and don't have the button the options frame will be allowed to open in combat.

    How is adding the button causing taint?

    I have searched on the topic and found stuff about hooksecurefunc() but it does not seem to be relevant here.

    To see the problem in action download the latest RaidBuffStatus and be in a group or raid, enter combat then click the top right button to open the options window. It won't open.

    I stumbled upon the problem when I was trying to add the ability to hide some buttons and resize the main frame when entering combat.

    I am really stuck.
    Posted in: Lua Code Discussion
  • 0

    posted a message on RaidBuffStatus
    Brilliant idea.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    I finished temp weapon buff checking today. I tried it with a few buffs and it seems to work now. This is in version 1.71. I will release it after testing in BT this weekend.

    It currently only expects the player to have one buff per hand.
    Posted in: Raid AddOns
  • To post a comment, please or register a new account.