• 0

    posted a message on RaidBuffStatus
    It would be nice if some other users tried RBS with taint switched on.

    So "/console taintLog 1" in game. It will make a taint log file inside the Logs directory inside the wow directory.

    Then after exiting the game after using RBS in a raid or a party look at the log file. Is there loads of stuff from RBS?
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    Quote from Zidomo »

    Happened again last night with the latest r77936. This time the raid was over 4.5 hours and the taint.log file was 164MB :( :


    Last time testing this for now; hope you can fix the problem. I'll PM you my addon list later (or post it here) if wanted.


    Please post here your addon list. I will again try to replicate.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    Quote from Neo »

    Is there a way to stop group 6 being checked?

    Our raids consist of group 1-5, group 6 being reported is rather annoying as 6-8 are the spare groups.


    There will be options in the future to allow you to configure this.

    In the mean time edit the core.lua file. Search for "hack". Change "if subgroup > 6 then" to "if subgroup > 5 then".
    Posted in: Raid AddOns
  • 0

    posted a message on Minimap icon howto
    Is there a howto for adding a minimap icon? I am the author of RaidBuffStatus, an ace 2 addon. I want to add a simple minimap button. I've done a fair amount of googling and searching on this forum and looking at source code from others. I have been unable to work it out.

    I've seen a few people use fubar and tablet. They seem a huge overkill for a simple button. However are they the recommended way? I've tried an example for fubar and I got no error but no icon appeared.

    Perhaps someone can point me in the right direction please?

    Thanks.
    Posted in: Lua Code Discussion
  • 0

    posted a message on RaidBuffStatus
    Quote from Athariel »

    Suggestion: is it possible to only whisper those who have improved buffs via Ctrl+Click?


    It does that already. Automatically.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    I tried with the German language pack and was able to replicate the pala blessing error. I have fixed that and released 1.81g. I was unable to replicate the other error. Please try again with the latest version.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    Quote from danielbarron »

    That is very strange. It should only happen if you were trying to change options during combat. I checked the code last night and the only times this can happen is when entering and leaving combat. Also when the buff options are changed. And it should not be every second.

    I'll look tonight and see if I can replicate it.


    I can't replicate it. Perhaps some rogue addon is doing something naughty like simulating a "PLAYER_REGEN_ENABLED" event. Sorry I don't know what to suggest.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    I said there "was" a problem not there "is" a problem :)

    I was able to fix it myself. But I'll look at what you have posted to double check.

    My main point was in future translations anything like a specific text that must match in-game text don't use escaping. But messages like chat messages or button text etc should be escaped.

    I don't believe there are more problems with German. Most of the others are not fully translated so have not had this problem.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    Quote from Zidomo »

    Just started using RaidBuffStatus again on my priest. r75836, standalone libs. That version just set a new record here for the size of a taint.log file after a 3-hour raid: 55MB :D.

    I never executed the mod throughout the raid, but it was active.

    From the top:
    6/7 20:27:55.546 An action was blocked in combat because of taint from RaidBuffStatus - soulstone:Hide()
    6/7 20:27:55.546 Interface\AddOns\RaidBuffStatus\Core.lua:3455 AddBuffButtons()
    6/7 20:27:55.546 Interface\AddOns\RaidBuffStatus\Core.lua:3694
    6/7 20:27:55.546 pcall()
    6/7 20:27:55.546 Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:298 TriggerEvent()
    6/7 20:27:55.546 Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:372
    6/7 20:27:55.546 An action was blocked in combat because of taint from RaidBuffStatus - flask:Hide()
    6/7 20:27:55.546 Interface\AddOns\RaidBuffStatus\Core.lua:3455 AddBuffButtons()


    That is very strange. It should only happen if you were trying to change options during combat. I checked the code last night and the only times this can happen is when entering and leaving combat. Also when the buff options are changed. And it should not be every second.

    I'll look tonight and see if I can replicate it.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    Quote from Carylon »

    OK, i checked the file, German special are masked so I sticked to this method and corrected some minor faults. I also changed one translation as "kann zaubern: somemightyspellhere" sounds weird. :-)
    I sent the file via e-mail and I attached it to this post.


    I got the email thanks. I have merged it into my working copy. However there was a problem. Where the translation has to match in-game text like a zone name or weapon buff it must be in ASCII. The non-English chars such as A with dots need to be as is rather than escaped. Messages like "Player is missing Blessing of Light" can and should use escaping.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    Quote from HunterZ »

    1. Yeah the Bloodberry Elixir tooltip sucks.


    It was already there just commented out. It will be not commented out in the next version.

    Quote from HunterZ »

    3. Yeah I think I unchecked all the combat checks as a workaround. As for profiling, PerformanceFu and Option House both have options to enable CPU profiling, as well as the ability to report addon usage while profiling is enabled. A couple of notes, though: Profiling can't be toggled on-the-fly; a reloadui will be triggered when you toggle it. Also, profiling itself incurs a large amount of overhead; personally I find it hard to play with it enabled (reduces me to single-digit FPS usually) but it does help to identify CPU hogs.


    Thanks for the info.

    Quote from HunterZ »

    4. Doh, thanks! I thought I tried that but I must have not, or maybe I just assumed it didn't because it wasn't mentioned in the tooltips.


    In the next version is a fake buff button. It's only purpose is to give help info.

    Quote from HunterZ »

    5. I was thinking that jncl would probably add Skinner support if I asked. That would just leave scaling.


    That would be interesting.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    I don't know. Just follow the convention of the existing file. It's best to email me the lua file as pasting on the forum corrupts lots of letters and all I see is ? eg "Kann zaubern Segen der K?nige". Email address is in the readme file that comes with the addon.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidBuffStatus
    1. Ok. Easily fixed. I thought that was only for the island and not the instances.

    2. It's on the todo list.

    3. You can disable all the buff checks in combat in the options window. That's not quite a complete disable but I will add a complete one to the todo list. Please tell me how one does profiling. I would love to know how efficient rbs and other addons are.

    4. Shift click on a buff (like in XRS) is what you are after. Also Ctrl will whisper the people.

    5. Skinning etc is on the todo list.

    6. Thanks :)
    Posted in: Raid AddOns
  • 0

    posted a message on Gratuity-2.0 and range and reliability
    I seem to have fixed it using:

    if _G.InspectFrame and _G.InspectFrame:IsShown() then
    return -- can't inspect at same time as UI
    end
    if not CanInspect(unit.unitid) then
    return
    end
    NotifyInspect(unit.unitid)

    But why I don't know. And spamming the server with NotifyInspect() seems bad. But it works. I don't like code that I don't understand why it works. I am not registering the event so when it gets fired I ignore it.
    Posted in: Lua Code Discussion
  • To post a comment, please or register a new account.