Having done some investigation into the problem which lead to the problem described by Cerelex and NooK, it seems that the GetTalentInfo() API call returns nil when (I assume) calls too early in the player login process. As I used this to check whether the player themselves has Improved Scorch, when a player would first install Scorchio!, they would be flagged from the outset on the blacklist.
So, I've hardcoded setting the player to false on the blacklist when they run Scorchio! for the first time. I've added a class check so only mages can run Scorchio!, to save complication here, and I'll blythly assume that only Imp. Scorch mages will run the addon, or else non-talented mages will go to the blacklist settings and tick themselves!
New commit made this afternoon:
17:44 01/05/08 0.70.5
- Hardcoded setting player as false in the blacklist on start up, to save any confusion.
- Added class check. Scorchio! will now only run on characters who are mages.
- Curse Premium
Member for 11 years, 1 month, and 5 days
Last active Tue, Jun, 12 2018 16:20:28
- 0 Followers
- 126 Total Posts
- 0 Thanks
May 1, 2008So Scorchio! picks up only the first scorch, to start the bars? Or it counts up to 5, and then doesn't pick up further scorches? Which version are you using (click on the icon, give me the version number in the Test Bars anchor there, click the icon again to make it go away)?Posted in: General AddOns
(On Preview: If Celerex had the same issue you did, you have the same solution as he did - read back further upthread - he was erroneously blacklisted.)
Apr 30, 2008I've made a couple of small commits to 0.70:Posted in: General AddOns
15:06 30/04/08 0.70.4
- Fixed bug in RaidIcon handling. Should hopefully fix the RaidIcon Persistence bug discussed in the forums.
- Added french localisation. (Thanks nico!)
Please test the raid icons in action now - they're off by default in the options, so tick them and see if they work for you.
And if anyone else wants to write some localisation files, or keep the existing files up to date, then please do so! It would be very helpful to me and to the community as a whole.
0.70 introduced the following phrases which aren't localised in any of the existing DE, KR or FR files:
["Raid Icon"] = true,
["Show Raid Icons"] = true,
["Show Raid Target Icons on Bars"] = true,
["Icon Position"] = true,
["Change the position of the Raid Target Icons"] = true,
Knock yourselves out! :-)
Apr 29, 2008Strictly, yes, they should be - and in fact, they are. But the blacklist is really a hangover from pre-2.4 days, when Scorchio! did all the work itself in terms of keeping track of the scorch stacks. Now that the AURA_DOSE_x messages contain the number of stacks, Scorchio! uses that to continually update it's calculations. So, if you're on the blacklist now, your Scorch cast is ignored, but the fact that you successfully updated the scorch stack isn't.Posted in: General AddOns
Apr 27, 2008Cool - thanks for the feedback. I want to get the 0.7x strand (as) bug-free (as possible) quickly now so I can start work on 0.8 for which I have lots of interesting ideas. But there are a few bugs still to squash so if people keep notifying me when they find something amiss, we can get this fixed up soon and move on!Posted in: General AddOns
Apr 27, 2008Hmmm... 71663 was a fix today to solve that exact bug, which was due to a typo. Make sure you actually do have 71663, and do a search in core.lua for SCORCHSTACKS, which shouldn't be there - it should be SCORCHSTACK with no final "S"...Posted in: General AddOns
I'll do some further testing tomorrow to make sure nothing can call that function with a nil parameter.
Edit: I've made a new commit which totally omits the offending check for the time begin. r71835, version 0.70.2
Apr 25, 2008OK, as no-one complained about anything show-stopping in RC2, I've committed it to trunk:Posted in: General AddOns
13:00 25/04/2008 0.70
- Added Raid Target Icons and configuration options.
- Reworked "Receive data from combat log events in range". Switching this off will now only parse messages created
by you, or where it affects a mob you have in your scorchTable. This is useful in busy zones where you're
soloing and the new combat log methodology will bring up bars for people scorching mobs from miles around!
- Replaced fake test bars with real triggered bars for placement/configuration. These will trigger
"Vulnerability Expired" messages, but not "Rescorch" messages.
- Reverted changes to automatic blacklist creation.
- Fixed bug in target colour customisations.
- Fixed bug in COMBAT_LOG_EVENT_UNFILTERED which could occasionally cause an error "table index is nil".
- Fixed/reverted changes to SSYN handling.
- Merged SetStacks() and UpdateTableScorch() and refined logic.
- Standardise and contextualise variable names.
- Massive code tidy up (ongoing process).
This version still displays the Raid Icon Persistence Bug I've mentioned in the last few posts - I honestly don't think that it's an error in my code. It's easy to reproduce - just toggle the anchors on and off and on again...
If it annoys you, turn the RaidTargetIcons off once and for all in the baroptions menu. If you're raiding and using the icons as usual, you shouldn't notice any issues so long as the icons are updated on new mobs each pull. If you alternate between marked pulls and non-marked pulls though, you might find you get persistence of icons from the marked pulls to the non-marked pulls.
As usual, let me know if you find anything (else) not working as you'd expect.
Apr 24, 2008I'm actually just reworking the UpdateTableScorch stuff because having had this discussion today, I noticed that some of the changes made to trunk while I was away basically broke/ignored sync'ing completely - ie: receiving a SSYN from another Scorchio!-enabled mage was all-but-ignored.Posted in: General AddOns
What happens now is:
You get a SPELL_DAMAGE or an SSYN and, if the mob exists in your table, the scorchstack is incremented by 1 (up to a maximum of 5). If it didn't exist, a new mob is created and the scorchstack set to 1. (A SSYN received with 0.8 seconds of a SPELL_DAMAGE from the same caster is ignored as a likely duplicate.)
You get an AURA_APPLIED, sent the count to 1.
You get an AURA_APPLIED_DOSE, set the count to arg13.
You get a STAC and you set the count to the STAC argument.
This way, Scorchio! tracks scorches as it was always intended to, whether it gets that information from the combat log or syncs, but it now uses the AURA_x events to correct its internal calculations if needs be.
Before I fixed the breakages, it was possible to miss the SPELL_DAMAGE at 5 stacks (for whatever reason) and the bar wouldn't be reset to 30 seconds, so you'd be notified of a vulnerability fade when it hadn't happened. (This might be what Codex noticed.) Also, by not starting a new mob when the SPELL_DAMAGE / SSYN was received introduced an error in the timer of about 0.5 seconds (depending on latency) as the counter was not started until the AURA_x message was parsed. These things are fixed in RC2.
I hope to have RC2 on my website later today - these changes are bigger than I'd hoped (but discovering the sync mess was a bug I couldn't ignore) and so I'm unlikely to commit today - I'd like my beta testers to play RC2 tonight/tomorrow first! :-)
Edit: RC2 now uploaded : http://www.benzo8.org/downloads/scorchio-0-70RC2.rar
Apr 24, 2008Thanks Sent_ - looks like a neat function. What I've done in RC2 is to build an array of all Scorch's Ranks' SpellIDs - pulled from thott - and now check SPELL_DAMAGE against that, so even if people cast a lower rank of scorch, it's picked up and sync'd. (Fire Vulnerability doesn't have different ranks and so the AURA_x checks for 22959 were fine. In fact, with the changes to log range and the fact that Scorchio! pulls the Fire Vulnerability stack information from the combat log, so long as you see the AURA_x event, your Scorchio! bars will be accurate, even if the whole SPELL_DAMAGE section of the add-on was completely broken - it might be the case that that section, and all the sync'ing, is now reasonably superfluous...)Posted in: General AddOns
Anyhow, if no-one found any show-stopped bugs with RC1, I'm going to commit RC2 later today...
Apr 23, 2008@Xinhuan: Yes, it's strange indeed. I don't know if you had a look with the RC1 posted above, but it's easy to reproduce, even if you're not a mage - just click on the scorchio icon to show the test bars, click it again to turn them off, then click it once more - both bars will now have a moon, when the code specifies only the second bar should have it. If you now actually go out and scorch something, that bar will have the moon too... Gah!Posted in: General AddOns
@Codex: No, Scorchio! will parse what it can from the log even if you're the only mage with the addon. Now the logging range has been increased to "what you can see", this should pretty much work even if you're the only mage in the room, but it's obviously an inexact science and things may go wrong still! With more people in the group running Scorchio!, what they see will be sync'd with you, hopefully covering those odd occasions when something goes wrong.
@RoboStac: I'll look into the lower level scorch thing. It will probably be better to look for each rank's code, as using the word "Scorch" breaks localisation... Thanks again for stepping in, and the kind words.
Apr 23, 2008I'm releasing an RC of Scorchio! today. This is a beta release, and not on the svn yet.Posted in: General AddOns
Please do not install this if you do not want to play with beta quality software!
It includes the RaidTargetIcon Persistence Bug mentioned in the previous post and as such RaidTargetIcons are disabled by default. If you wish to test them, please activate them in the options. If you choose to use them, please test them thoroughly and report back anything which may help track down the bug.
Otherwise, this is a leaner, neater release of the 0.62 version in Trunk with some bugfixes.
Download the RC1 from : http://www.benzo8.org/downloads/scorchio-0-70RC1.rar, back up your old Interface/AddOns/scorchio folder, install the RC1 and test it! If this all goes well, I hope to commmit to Trunk by the weekend..!
Apr 23, 2008Posted in: General AddOnsQuote from Xinhuan »
Since patch 2.4, you may embed pictures - aka textures - into a fontstring object.
The format of an embedded texture in a piece of text is as follows:
I've come across a strange persistence problem with this - it works fine the first time, but then any new CandyBars receive the same icon unless a new icon is specified. Changing the texture while the CandyBar is active sometimes (though not always) clears it. Coding in a kludge to change the textures programmatically at bar creation time had unexpected results - occasionally leaving an icon on the screen with no bars! Writing the icon string to a debug text line would leave the icon scrolling up and then out of the text box, leaving it on the screen!
This seems to be reasonably buggy at the moment - not sure if it's a Blizzard error, a CandyBar-2.0 error or a LibSharedMedia-3.0 error, but I think, for the time being, I'm going to have to do this another way.
Apr 23, 2008Posted in: General AddOnsQuote from Codex »
Cant figure out how to hide the number picture on the side of the bar. I cant figure out that slash command
/scorchio baroptions iconshow off
/scorchio baroptions icon inconshow off
/scorchio baroptions icon off
/scorchio baroptions icon iconshow
It's a toggle and works just like most other Ace/FuBar based addons.
Quote from Codex »
Also, why does it sometimes say my imp scorch expire b4 they really do?
Simply, because it doesn't pick up a reapplication of scorch when it should. Either someone else scorches the mob who isn't using the addon and slips through the Combat Log parsing, or some other factor stops it from registering when a new scorch is applied and it doesn't reset the timer. It shouldn't happen, but it does sometimes - being told to reapply your scorch before it runs out is probably better than being told when it's too late, isn't it?
- To post a comment, please login or register a new account.