• 0

    posted a message on svn issue - Inconsistent line ending style
    Commit failed (details follow):
    While preparing
    'C:\Users\Public\Development\Warcraft\SVN\Ace\ArkInventory\ArkInventory.lua'
    for commit
    Inconsistent line ending style

    did something change on the server again?

    i'd already uploaded about an hour and a half ago but the files never turned up in the web interface to tag, modified them and re-uploaded and the above happened.
    Posted in: General Chat
  • 0

    posted a message on What do all the errors in FrameXML.log mean anyway?
    Quote from Phanx
    If they're using the WowAce/CurseForge packager to generate their nolib zips, they have no excuse for not also using the no-lib-strip tags.


    curse is the only place with no lib versions of mods, the other sites dont seem to care about it.

    i was asked nicely if i could "fix" mine, luckily the people at curse made it pretty simple or i wouldnt have bothered changing anything because it has to work everywhere, not just from curse.

    although you may want to consider putting in some basic examples for the no lib toc thing cause it took me a bit to figure out how its actually used (i know its simple once you realise whats happening, its just not entirely obvious what youre supposed to do with them at first glance)

    btw, if the author doent use dismebedded libs then they wont know that this issue even exists (i didnt).
    Posted in: General Chat
  • 0

    posted a message on Localization and Parameterized Strings
    Quote from Morsker
    I'm considering parameterizing them like this:

    "%s Faded on $m"
    "Use %s Soon!"

    This would decrease the burden on translators, especially when new spells are added. I'd like a second opinion from people with more experience though. Is this sort of parameterization useful, or is it not general enough? For example, maybe in some language "Hot Streak" and "Brain Freeze" have different genders, and verbs match the gender, so the same "Use %s Soon!" wouldn't be appropriate for both. Does that ever happen, or is the parameterization fine?


    i tend to put those in the actual localization string and just let translators sort out where everything goes. eg;

    L["CONFIG_CONTROL_SAVE_TEXT"] = "save %1$s data for this character (%2$s) so that you can view it while on another character (or offline)." -- %1$s = location name, %2$s = character name
    translators can then rearrange the entire sentence so its grammatically correct in their language, moving the parameters around as needed, like this (it was chinese but i dont think the forums can handle it)

    L["CONFIG_CONTROL_SAVE_TEXT"] = "???????? (%2$s) ? %1$s ???????????????????? (????)?"
    and your string.format( ) will always come out right regardless of language.

    string.format( ArkInventory.Localise["CONFIG_CONTROL_SAVE_TEXT"], ArkInventory.Global.Location[loc_id].Name, ArkInventory.Global.Me.info.name )
    Posted in: Lua Code Discussion
  • 0

    posted a message on Detect addons loaded
    you might also want to check that the mod actually has a SetProfile function, before you try to call it.
    Posted in: Lua Code Discussion
  • 0

    posted a message on ChocolateBar, do you like chocolate?
    Quote from yess
    Why do you want the icon when there is nothing tracked?

    to give the user something to click on to bring up the menu. when items are being tracked then there are (multiple) item icons and counts being displayed as text, so its obvious where it is. when nothing is being tracked then its harder to find because the text was being set to "", all that was left was the object icon.

    Why not just set the text to "no currency tracked"

    i presume if theyre not tracking anything then i shouldnt take up a lot of real estate with excessive text, displaying just the object icon seemed to be a more reasonable choice.

    leaving the icon at nil, and just putting it all into the text works pretty well for now. not sure i want to play with toggling the launcher/data feed thingy if display mods arent expecting that potential change.

    as torhal mentioned above, perhaps if/when the standard is changed. if the user could pick from icon display choices of; never, always, only when no text ("" in this case), only with text. then i could set and forget an object icon and let the user decide how/when they want it displayed - anything that then looks weird is then their problem and not mine.
    Posted in: Data Broker AddOns
  • 0

    posted a message on ChocolateBar, do you like chocolate?
    Quote from Torhal
    Except that by doing so, you aren't allowing the users of the plugin to decide (via options in their display AddOn) whether or not they -want- to see an icon.


    the flip side is that its my object, i dont have to supply an icon if i dont think one is required, the api doesnt force me to do that (nor should it).

    if they turn it off and theres no text (because nothing is being tracked at the moment) then nothing gets displayed at all and finding the location to right click for the menu to kick in (to pick something to track) might prove difficult (which is a major problem)

    if they turn it on and there is text then they get an extra icon they probably wont want (which is only a minor visual problem).

    i dont think theyll have an issue with the way ive done it but if someone can supply a workaround thats consistent and usable for both cases then im happy to recode it to work that way instead.

    i just dont think it can be done at the moment because display mods only have a yes/no choice to display the icon, it would need more choices, like once you chose to display the icon another input is required; always display, only display when there is text, only display when there isnt text. (or add all those to the top level choice if thats easier)
    Posted in: Data Broker AddOns
  • 0

    posted a message on ChocolateBar, do you like chocolate?
    Quote from Torhal
    EDIT: You could designate a "not-tracking" icon, and switch to that instead.


    thats what i was trying to do, but with the .icon, i suppose i can just leave the icon as nil and add the non tracking icon as a texture in the .text instead. that should work.
    Posted in: Data Broker AddOns
  • 0

    posted a message on ChocolateBar, do you like chocolate?
    Quote from yess
    Text is a required field.


    text is always there, its never nil, it might be "" though, its the icon i'm setting to nil.

    i was doing this because i was adding multiple textures in the text so didnt need the icon as well when it had text. ie i had the icon set only when i didnt add any text.

    if im tracking a currency then theres no icon, except the icon never goes away when i set it to nil - but only if it was previously set.

    if i do a uireload then the icon doesnt appear, if i then untrack all currencies (so the icon is set) then the icon comes back (working correctly), if i then track a currency (so the icon is set to nil) then the icon doesnt go away (this is the problem), its still there even though ive set it to nil.

    i've tried nil and false (which are fine for no icon) and "" (which isnt, it leaves an empty space where an icon should go)

    sorry this is long, i just wanted to try and clarify it properly.

        self.text = ""
        local hasText = false
        
        -- expand all token headers
        local numTokenTypes = GetCurrencyListSize( )
        
        local name, isHeader, isExpanded, isUnused, isWatched, count, currencyType, icon
        
        for j = numTokenTypes, 1, -1 do
            name, isHeader, isExpanded = GetCurrencyListInfo( j )
            if isHeader and not isExpanded then
                ExpandCurrencyList( j, 1 )
            end
        end
        
        numTokenTypes = GetCurrencyListSize( )
        
        for j = 1, numTokenTypes do
            
            name, isHeader, isExpanded, isUnused, isWatched, count, icon = GetCurrencyListInfo( j )
            
            if not isHeader then
                if ArkInventory.db.char.option.ldb.tracking.currency.tracked[name] then
                    self.text = string.format( "%s  |T%s:0|t %d", self.text, icon or ArkInventory.Const.Texture.Missing, count or 0 )
                    hasText = true
                end
            end
            
        end
        
        if hasText then
            self.icon = nil
        else
            self.icon = ArkInventory.Global.Location[ArkInventory.Const.Location.Token].Texture
        end
    Posted in: Data Broker AddOns
  • 0

    posted a message on Saved Variables
    you havent got any set or get functions;

    lensflare = {
        name = "Lens Flare",
        type = "select",
        arg = "lensflare",
        values = {
            ["Strong"] = "Strong",
            ["Lens01"] = "Lens01",
        },
        order = 40,
        get = function( info )
            return db.lensflare or "Lens01"
        end,
        set = function( info, v )
            if v ~= db.lensflare then
                db.lensflare = v
                -- do stuff to update with the new value
            end,
        end,
    }
    Posted in: Lua Code Discussion
  • 0

    posted a message on New and broken stuff with Cataclysm
    Quote from Adirelle
    I reported the live behavior. Can't tell for PTR. I can check beta.


    on live the itemID is always nil. its causing errors in blizzards own code because they use that to generate the chatlink.

    you would hope they chose a better way to reference things than their position in a local list (which they seem to like doing a lot).
    Posted in: Lua Code Discussion
  • 0

    posted a message on New and broken stuff with Cataclysm
    Quote from Allara
    GetWeaponEnchantInfo() appears to return 9 arguments now (up from 6), the last 3 being for the thrown weapon.


    rogues can apply poison to their thrown weapon now.
    Posted in: Lua Code Discussion
  • 0

    posted a message on New and broken stuff with Cataclysm
    IsFlyableArea( ) is broken (again) for wintergrasp. its returning nil even when theres no battle in progress.
    Posted in: Lua Code Discussion
  • 0

    posted a message on UISpecialFrames
    seems to have changed on live, my mod worked on the beta servers but now wont close any of its windows when you hit escape on the live servers.

    is there a new way of flagging frames as "special"?

    nvm. my mod by itself if fine. must be another mod screwing it up.
    Posted in: Lua Code Discussion
  • 0

    posted a message on problems with curse.com
    still broken from home, works from work. who is curses hosting provider so i can email them and ask them too look at the issue (looks like peak10.com)?

    curse client also fails to find the update server.
    Posted in: General Chat
  • 0

    posted a message on problems with curse.com
    Tracing route to wow.curse.com [68.64.47.204]
    over a maximum of 30 hops:

    1 <1 ms <1 ms <1 ms adsl.lan [192.168.1.254]
    2 15 ms 14 ms 14 ms lns20.syd6.internode.on.net [150.101.199.159]
    3 14 ms 13 ms 13 ms te3-3.cor2.syd6.internode.on.net [150.101.195.9]
    4 172 ms 172 ms 172 ms gi6-0-0-114.bdr1.syd7.internode.on.net [150.101.195.205]
    5 171 ms 172 ms 171 ms pos5-0.bdr1.sjc2.internode.on.net [203.16.213.162]
    6 172 ms 172 ms 172 ms sjp-brdr-03.inet.qwest.net [63.146.26.173]
    7 228 ms 238 ms 228 ms atx-edge-03.inet.qwest.net [67.14.14.142]
    8 229 ms 228 ms 228 ms 63-233-83-254.dia.static.qwest.net [63.233.83.254]
    9 231 ms 230 ms 232 ms 68.64.33.45
    10 229 ms 229 ms 229 ms 68.64.47.204

    Trace complete.


    Tracing route to media.curse.com [65.254.218.140]
    over a maximum of 30 hops:

    1 <1 ms <1 ms <1 ms adsl.lan [192.168.1.254]
    2 13 ms 14 ms 14 ms lns20.syd6.internode.on.net [150.101.199.159]
    3 14 ms 13 ms 14 ms te3-3.cor2.syd6.internode.on.net [150.101.195.9]
    4 195 ms 194 ms 195 ms gi6-0-0-111.bdr1.syd7.internode.on.net [150.101.120.225]
    5 172 ms 172 ms 172 ms pos5-0.bdr1.sjc2.internode.on.net [203.16.213.162]
    6 172 ms 172 ms 173 ms sjp-brdr-03.inet.qwest.net [63.146.26.173]
    7 228 ms 228 ms 229 ms atx-edge-03.inet.qwest.net [67.14.14.142]
    8 229 ms 228 ms 228 ms 63-233-83-254.dia.static.qwest.net [63.233.83.254]
    9 231 ms 230 ms 231 ms 68.64.33.45
    10 * * * Request timed out.
    11 * * * Request timed out.
    12 * * * Request timed out.

    Tracing route to static.curse.com [65.254.218.140]
    over a maximum of 30 hops:

    1 <1 ms <1 ms <1 ms adsl.lan [192.168.1.254]
    2 14 ms 14 ms 14 ms lns20.syd6.internode.on.net [150.101.199.159]
    3 14 ms 14 ms 14 ms te3-3.cor2.syd6.internode.on.net [150.101.195.9]
    4 195 ms 194 ms 195 ms gi6-0-0-111.bdr1.syd7.internode.on.net [150.101.120.225]
    5 171 ms 172 ms 171 ms pos5-0.bdr1.sjc2.internode.on.net [203.16.213.162]
    6 173 ms 172 ms 172 ms sjp-brdr-03.inet.qwest.net [63.146.26.173]
    7 228 ms 228 ms 228 ms atx-edge-03.inet.qwest.net [67.14.14.142]
    8 230 ms 228 ms 229 ms 63-233-83-254.dia.static.qwest.net [63.233.83.254]
    9 231 ms 230 ms 230 ms 68.64.33.45
    10 * * * Request timed out.
    11 * * * Request timed out.
    Posted in: General Chat
  • To post a comment, please or register a new account.