• 0

    posted a message on LibTalentQuery-1.0
    I made changes to store the unitname rather then the unitid when necessary. If a unitid cannot be returned, it will return the unitname of the unitid queried.
    Posted in: Libraries
  • 0

    posted a message on GridLayoutPlus
    Quote from borbes »

    We need to see unit frames for the tanks, and their target. GridLayoutPlus and any other grid add-on I've found will only get the tanks, not their targets.


    The only thing useful that I could see being done on this front is making the raid icon of a unit's target available as the center icon, and the name available as text (as Maia said). Then it would be easy to assist the correct unit.

    This would be a new status module addon that an author would need to tackle, and not something added to GridLayoutPlus.

    Remember, Grid is not meant to be an all-purpose unit frame...
    Posted in: Unit Frames
  • 0

    posted a message on Grid
    Were you testing performance with plain vanilla Grid, or with any 3rd party modules?
    Posted in: Grid & Grid2
  • 0

    posted a message on GridLayoutPlus
    Quote from borbes »

    I know it's been mentioned, but ora2 main tank targets is really needed for DPSers. It would be wonderful if it could be added to this.


    Hmm, have you checked off "Show Tanks" when using oRA2? Support has been in for a while.
    Posted in: Unit Frames
  • 0

    posted a message on GridLayoutPlus
    Are you saying you are changing the order of "Tank, Melee, Healer, Ranged"? If so, I misunderstood. I will think about adding an option to have the user set that from the options menu.

    I still need to work out certain scenarios where the layout needs to be refreshed when using Role layout sorting. This is my number one priority, but I haven't had any free time.
    Posted in: Unit Frames
  • 0

    posted a message on LibHealComm-3.0 Official Thread
    oRA2 does this. I suppose it's possible (although it might not be necessary) to create a lib specific to resurrects. I don't think it should be in HealComm though. Let's not bloat libraries. I'm not sure if all the addons that use HealComm need the resurrect info. VisualHeal definately doesn't.

    2 mods that could possibly use a resurrect lib is oRA2 and SmartRes off the top of my head.
    Posted in: Libraries
  • 0

    posted a message on GridLayoutPlus
    Quote from Margot »

    Maybe I'm missing this in the options somewhere, but I just can't find it..

    I edited this block in the lua to change the role ordering:
    if (GridLayoutPlus.db.profile.layoutSorting == "ROLE") then
    ...
    end

    This worked fine, it just means I have to change it every time I update. :)


    Not sure what this is for. It works just by changing the layout sorting in the layout options menu.

    Quote from Margot »

    The other question I had was regarding the sorts of things that GridDynamicLayout does, like checking for Bear Form, Righteous Fury to determine a tank (because a non-specced druid might be doing it, or a non-specced Paladin). Is this out of the question for LayoutPlus in the future?


    I don't like it so I don't plan to code it. I don't want to compete with GridDynamicLayout and I think if you want that functionality you should use that mod. I mostly coded the Role sorting just because I was interested in using it and it looked like a challange.
    Posted in: Unit Frames
  • 0

    posted a message on LibTalentQuery-1.0
    I will rework my library to store the unit name. The only problem I'm having is getting the unitid afterwards. I see in DogTag, ckknight is basically going through all the possible unitids and seeing if there is a UnitName match. In doing that, there needs to be a preference in what gets returned. For example, in my addon GridLayoutPlus, it sorts a raid by unit roles (tank, melee, healer, ranged), and it's expecting the unitid to be a raidx unitid, not target, or mouseover.

    My current thinking is that I will have a boolean argument (isStrict) that is passed to :Query(unitid, isStrict). That flag will determine if the unitid that is returned is of the same type (or maybe the exact same unitid, not sure yet) that was sent in originally.

    Thoughts?
    Posted in: Libraries
  • 0

    posted a message on GridLayoutPlus
    I'm sorry for all the errors. I don't test with embedded so I haven't been getting errors. I made the changes and the structure should be the way it should be...
    Posted in: Unit Frames
  • 0

    posted a message on GridLayoutPlus
    Ok I converted over to using a library I created called LibTalentQuery-1.0. In my testing I find it's causing less problems then when I had all the code in GridLayoutPlus.lua.

    Let me know how it works for you.
    Posted in: Unit Frames
  • 0

    posted a message on Hijacking of INSPECT_TALENT_READY
    I committed a library today (LibTalentQuery-1.0) to address these problems. LibTalents does not seem to have been made with this purpose in mind.

    Discussion:
    http://www.wowace.com/forums/index.php?topic=11828.msg188399#msg188399

    Wiki:
    http://wowace.com/wiki/LibTalentQuery-1.0
    Posted in: Lua Code Discussion
  • 0

    posted a message on LibTalentQuery-1.0
    Wiki:
    http://wowace.com/wiki/LibTalentQuery-1.0

    Problems with blizzards talent query api:

    • When the INSPECT_TALENT_READY event is fired, it doesn't tell you which unit it's ready for.
    • Because of 1 you can not query multiple units at once.
    • If two addons call NotifyInspect() at the same time, neither addon knows if the INSPECT_TALENT_READY event is "theirs".

    This library attempts to fix this problem by providing:

    • A callback "event" that will provide the unitid of the unit which the talents are ready for.
    • A queueing system the will only do one NotifyInspect() at a time on a unit who is visible and connected.
    • A secure hook on NotifyInspect that will take preventive measures to stop another addon from confusing a query.

    I am using it in a Grid module called GridLayoutPlus which sorts raid unit by Role (tanks, melee, healers, ranged).

    This is my first library so I might have made some mistakes, and I welcome any input to fixing and improving the library.
    Posted in: Libraries
  • 0

    posted a message on GridLayoutPlus
    I am working on creating a Library out of the talentquery portion. In doing so I think I fixed a couple of problems. I'm stil working on some bugs but I should be able to upload the new library and the updated GridLayoutPlus within the next few days.
    Posted in: Unit Frames
  • 0

    posted a message on GridLayoutPlus
    Were you testing in AV? Sounds like it. The server name is not available on some units if they are extremely far away. I'll look into a fix today for some of these issues.
    Posted in: Unit Frames
  • 0

    posted a message on Grid/Targetting and PoM
    Grid will never show enemy targets. Use oRA2 for that. Grid is not an all purpose unit frame addon. It's focus is on showing raid members in a compact area.

    The closest thing we could do in Grid is to make a status module that shows the name of the units target in text2. Problem with that is that most enemy npc's names are much larger then 4 or 5 characters :( (unless you change the width and text length).

    Hmm... Another thought would be to use the center icon to show the raid icon of the unit's target. You could easily see who is targeting to wrong mob. Hmm, that could have potential...
    Posted in: Grid & Grid2
  • To post a comment, please or register a new account.