• 0

    posted a message on Poppins - Official Thread
    Littledeath: I will add a space-replace function in some time, until then try to avoid using spaces :)

    Ydrisselle:
    The thing is, this profile page is delivered by AceDB, it is not really *that* implemented in the addon by now.
    It could be easy to fix. If you got time before I do you might just check what happens if you immediately relog after copying a profile. If then is all fine it is not much of a problem to add.
    Posted in: General AddOns
  • 0

    posted a message on Poppins - Official Thread
    Commited some more bug fixes (sorry for spamming).
    Actually I have the hopes this should make the addon error free for now (not refering to bugs, but error messages).
    If the addon still gives errors to you or behaves unexpectedly, feel free to report back.
    Posted in: General AddOns
  • 0

    posted a message on Poppins - Official Thread
    I am pretty confident I fixed that error now, check the repository.
    Please report back.
    Posted in: General AddOns
  • 0

    posted a message on Poppins - Official Thread
    If you already read it, forget about what I wrote - I get the error msg when I disable the module (with bf installed).
    I will have a look if there is a quick fix. (Sorata come back and do some real fixes please :) )
    Posted in: General AddOns
  • 0

    posted a message on Poppins - Official Thread
    Not without changing the source code yet ;)
    Since it has been requested some times now I have put it on my todo list.
    Hopefully Sorata will not kill me for messing with his code all the time ;)
    Posted in: General AddOns
  • 0

    posted a message on Poppins - Official Thread
    Okay, I had another look at the ButtonFacadeSkins module and extended the quick hack to a slow fix (I hope).
    Let me know if there are any problems with the module now.
    Posted in: General AddOns
  • 0

    posted a message on Numen (a totem button addon) - Official Topic
    Sounds like a now smaller invisible frame over your PopButtons.
    Sorry I do not have any other ideas about that than Aviana.

    There is an addon called Where is my cow here on wowace with which you can show what frame your mouse is over.
    You might consider temporarily installing it to find out if our guess was right.

    I had this once with Autobar, which I would call a usual suspect on these things because it creates 32 buttons per default even for class bars which use 4 or 5 only. If you do not change the number of buttons there is quite a huge invisible frame hanging around. But this is just an example, I do not intend to call Autobar Mr. Evil I use and like it myself :)
    Posted in: General AddOns
  • 0

    posted a message on Poppins - Official Thread
    @Phanx:
    Well, this is basically caused by me doing a hotfix. The thing is, the names are used as AceDB keys, which does not seem to like spaces there very much. The moment Buttonfacades Standard packages template renamed a skin to include a space the option menu was not available at all anymore. I just did a quick fix (well, more a quick hack one could claim...) for bringing the options menu up again by replacing spaces with _ breaking the skins with spaces. Source is commented - I did not want to go any deeper cause I believe Sorata wanted to work on the module anyway, so I dunno *shrugs*

    @Toadkiller
    I have seen keybound on Bartender4, liked it very much and had instandly thought this gotta be a library :)
    I have Poppins supporting LibKeybound-1.0 working (afaik) flawlessly on my local hd, but I am unsure about if that is a thing I should branch before commit and wait for approval. So there is a good chance you can count Poppins to the LibKeyBound-1.0 supporting addons soon :)
    Well, I guess I will branch it tomorrow or so and hope Sorata drops by soon.
    Posted in: General AddOns
  • 0

    posted a message on Poppins - Official Thread
    Ah now I can reproduce.
    I think it is a leftover from before Sorata used LibStickyFrames.
    I commited a quick fix, *but* there is a drawback:
    In ?around? mode you currently have to set up one more popbutton than is shown.

    Example 1:
    You set up four popbuttons in "up" mode then change to ?around?.
    Only the first three are shown.
    You click add popbutton.
    All four are shown although there exists an invisible fith.

    Example 2:
    You create a button and immediately change to ?around?.
    One popbutton is shown.
    You create another popbutton.
    Still only popbutton1 is shown.
    You create another popbutton.
    popbuttons 1 and 2 are shown.

    I do not know if my fix introduces this or if this behaviour was just masked by the former error.
    I am sorry I cannot provide a better quality fix, I left a note for Sorata in the source code.

    The first two errors, although not nice to have them, should do no harm for the moment.
    Posted in: General AddOns
  • 0

    posted a message on Poppins - Official Thread
    Quick interims report:
    I have tried to reproduce that error by creating empty buttons and popbuttons then change skin to gear in BF (the failing function only gets called if the button is a round one) but this error is not thrown. Deleted Buttons do not remain in unlocked here even. Strange.
    Unfortunately I can not find out if the function ?SetFramePoint?is part of the wowapi, wowwiki gives no matches. If it is not, the nil could be explained by well, the function not existing. I secretly suspect there should be a LibSticky function call instead of this function, but why am I not getting this error then? Have you done the exact same as I above? Maybe you can try changing the steps and see if the error is thrown in any case or only if you do some specific step-by-step.
    What happend when the error was thrown? Did the buttons actually go round and were still functional? Or did they break?
    Sorry for the many questions, I am in the dark here not getting the error ;)

    I think the chat going green at least is the supposed behaviour of libstickyframes-2.0 to anchor things at the chat frame.
    Posted in: General AddOns
  • 0

    posted a message on Poppins - Official Thread
    @Phanx
    I am trying to find that out, the code is pretty confusing to me since it is not documented and I am getting crazy finding out where the hell button.id comes from and what it does since it actually appears only one time in the whole code (some heritage thingie from SecureStuff I can not find docu on?), why self.hooks does not immediately overwrite the just called SetCooldown and such questions.

    What I found out and seems to make sense code wise:
    Currently first duration is shown, then the cooldown.
    Works nice with Mana Tide and the elementals (shorter duration than cd), works not nice with grounding totem.
    I suppose I will have to change the function to first compare duration and cd, then first show the shorter one, then the longer one or even...a more distinguishing approach. Will take a while though cause of the confusion mentioned ;)

    The code is (for me) quite more complicated than Numens since there are many things hardcoded inside Numen so you can see more easily what is going on.
    For example I have no idea how to implement right click to destroy totems inside the totem module, I fear it will be more than those three to four lines in Numen so do not hold your breath.

    Another question would be what SharedTimers does or shall do, I can not really get the hold of it.
    Maybe related, the PopButtons cooldowns/durations show only on Air Totems for me: I do not have any clue why since in the code there are basically only references to the slots - should work for all of them.

    I guess we will just have to wait on that until Sorata gives me some hints on this or implements/fixes those things himself.
    Posted in: General AddOns
  • 0

    posted a message on Poppins - Official Thread
    What shall this picture show? The chat in the wrong place?
    What does no more Poppins mean? Do the Buttons not show anymore?

    For me, it actually works, but the ButtonFacade Module is still throwing errors (which I will not attempt to fix since I do not know what Sorata is doing there).

    If you have not played in a while, chances are there are wrong values in your db since there have been some changes lately (LibStickyFrames-2.0 should be present and the ButtonFacadeSkins Module).

    Please try the following:
    First delete Poppins.lua and .bak from your WTF/<something>/Savedvariables (or move it).
    Check back in the game. Check if the addon works (the buttonfacadeskins module will be throwing errors, there just should not be errors from any other .lua like PopButtons.lua).

    If you disable the buttonfacadeskins module then the addon should not throw any errors (use the BF menu instead).

    I am sorry but I am not able to fix this, I do not have any idea what this module actually is about. You will have to wait for a Sorata aproved fix on that.

    This chat frame placing behaviour is strange, though, I have not had any problems with that.
    The chat going green on unlook being normal libsticky behaviour i think.

    Edit: Just found out some files were moved around some weeks ago too.
    Maybe you try a "clean" update like deleting the Poppins folder, then do a fresh install via WAU.
    Posted in: General AddOns
  • 0

    posted a message on Poppins - Official Thread
    Ah now I understand (hopefully).
    I have added the reverted cooldown as an option of the TotemTimers Module, please have a look.
    Dunno about the text yet...

    Am I the only one missing the Cooldown of the Totems (like first cooldown is shown then duration)?
    I liked this pretty much with grounding totem. I wonder if there is another solution you people use or if I shall have a look if it is possible to bring it back in. Or is it better in some cooldown-ready-notification addon?

    I have added a quick and dirty hack for the options menu failing if there is a BF skin with a space in it.
    Since "DreamLayout" seems to be "Dream Layout" now well, isup all BF users should have this problem.
    Noted though:
    I do not like this sort of fixes and hope Sorata comes with a real solution.
    It is just temporary to leave the addon in a working state with BF.

    edit: why the hell is my english getting worse the more I use it?
    Posted in: General AddOns
  • 0

    posted a message on Poppins - Official Thread
    Ah, you mean cooldown overwriting duration? I will have a look at that.
    Posted in: General AddOns
  • 0

    posted a message on Numen (a totem button addon) - Official Topic
    I have gotten to skin the Buttons but eliminated the cooldown and got those annoying marked on active borders with that I think ;P
    Was hell of a lot more reqs to support Bf than I had thought.

    I had tried to port Numen to Ace3, but getting rid of AceOO just got over my skills I got to admit.
    Sorata has basically done that (working^^), plus making it general.
    Options etc. were all finished (basically no prob to use AceConfig3 and AceDB3 in Ace2 Addons because they are Libstubbed).

    In the long term I would vote for improving the Totem Module inside Poppins to get the features of Numen (well, the ones that actually have to do with the buttons themselves). "Automatic" Totem Setup and destroying totems on right click should be doable inside such a module.
    The reason I would vote for this is basically: Less work. There is a main dev which is well, at least a lot better than myself and one had to look only for totem related stuff inside a module.

    The other options would be a) ignoring the other addon and continue dev or b) manually porting the nice stuff of Poppins like the Ace3 stuff and AceOO-less prototyping over to Numen which would induce possible work anytime Poppins gets updated.

    Noted: For the long term and my point of view.

    Short-term related Numen actually works fine, just to mention that :) Besides, anyone is free to do what he wants it is just me saying I will not try to get things like Bf support to Numen because I would too much feel reinventing the well like now.
    Posted in: General AddOns
  • To post a comment, please or register a new account.