Quote from MistsI've attached the buff/debuff files for mage and paladin, I hope there isn't too much missing (and not sure I got the alliance-only paladin spells right), but anyway it's a start. :)
Couple of things I noticed regarding the paladin stuff:
- RBM doesn't show the cooldown for Holy Shock. I haven't looked through the code but I suppose you scan the 3rd line of the tooltip for a time. The problem with Holy Shock is that it has 2 ranges, 1 each for friends/enemies, so the cooldown is on the 4th line. I'm not aware of any other spells with the same cooldown, so it might be easier to treat it as an exception, but anyway that's your call!
- Sacred Shield is actually 2 buffs: one that lasts 30 seconds and the other is a proc on hit. They both have same name, but different icons and can be on at the same time. RBM shows only one of them, and I can't find the spell ID for the proc. In my testing if both buffs were active, the procced buff was always shown, not sure if that's consistent or just happened for me. When the procced buff duration is shown in RBM, the icon is still the one from the normal buff. I hope my explanation is not too messy...
There's also Divine Favor cooldown not being shown, but since it's same idea as Combustion for mages, it's probably fixed already in the new version.
Thanks again for your time!
Thanks, I'll merge those in. I'll take a look at holy shock since I scan the tooltips a similar way in the next version. Divine Favor should be fixed. Sacred Shield poses a problem that's probably not worth fixing unfortunately; however, I might be able to hardcode an exception for it.