the talent Spirit Weapons now applies on stormstrike and windfury too. [Source]
i recognised that i don't generate as much threat as omen reports so i looked up this file:
No, this is not the problem. "Physical" always included SS and WF (just tested it myself to be sure). The problem is this IsTwoPointThree field in Shaman.lua:
self.schoolThreatMods["Physical"] = self.Melee
[...]
self.IsTwoPointThree = ThreatLib.WowVersion >= 2 and ThreatLib.WowMajor >= 3
[...]
local SpiritWeaponsModifier = (self.IsTwoPointThree and 0.3) or 0.15
The point is, that self.IsTwoPointThree is set true, AFTER the whole ThreatModifier calculations, so it's still false when the SpiritWeaponsModifier is set, which results in the old 0.15 modifier.
But as I just tested, even moving it before the call to Shaman:Melee doesn't fix it. This field seems always to be false in Shaman:Melee, even if you set it to true earlier. But well, easy fix, just delete the whole 2.3 check. Who needs it anyway?
local SpiritWeaponsModifier = (self.IsTwoPointThree and 0.3) or 0.15
==>
local SpiritWeaponsModifier = 0.3
if info.isCrit then
if self.meleeCritReduction > 0 and element == "Physical" then
threat = threat - self.meleeCritReduction
elseif self.spellCritReduction > 0 and element ~= "Physical" then
threat = threat - self.spellCritReduction
end
end
The variable threat is later on modified with all your threat-mods.
Just got this thing and read that it's supposedly -1000 threat on spell crits, but it doesn't seem to have any effect on the the threat Threat-1.0 is reporting.
Any idea how I might get this thing working with Threat-1.0?
if trinket1ID == 30621 or trinket2ID == 30621 then
self.meleeCritReduction = 150
self.spellCritReduction = 1000
end
But the thing is that it just doesn't work.
It doesnt work, because the function to detect it doesnt work:
if trinket1ID == 30621 or trinket2ID == 30621 then
DEFAULT_CHAT_FRAME:AddMessage("Prism of Inner Calm active");
self.meleeCritReduction = 150
self.spellCritReduction = 1000
end
It never gets to my added Print statement, but if I change it to:
if trinket1ID == "30621" or trinket2ID == "30621" then
DEFAULT_CHAT_FRAME:AddMessage("Prism of Inner Calm active");
self.meleeCritReduction = 150
self.spellCritReduction = 1000
end
It works, so thats the problem, the item id is a string, not a number.
Omen-2.1r44409\Omen.lua:599: invalid option in `format'
Threat-1.0\Threat-1.0\ThreatKLHTMSupport.lua:97: in function `func'
Threat-1.0\Threat-1.0\ThreatKLHTMSupport.lua:65: in function <...\AddOns\Threat-1.0\Threat-1.0\ThreatKLHTMSupport.lua:62>
Threat-1.0\Threat-1.0\ThreatKLHTMSupport.lua:82: in function <...\AddOns\Threat-1.0\Threat-1.0\ThreatKLHTMSupport.lua:69>
<in C code>: ?
AceEvent-2.0-40601 (AceEvent-2.0):269: in function `TriggerEvent'
AceEvent-2.0-40601 (AceEvent-2.0):910: in function <Interface\AddOns\AceEvent-2.0\AceEvent-2.0.lua:903>
0
No, this is not the problem. "Physical" always included SS and WF (just tested it myself to be sure). The problem is this IsTwoPointThree field in Shaman.lua:
The point is, that self.IsTwoPointThree is set true, AFTER the whole ThreatModifier calculations, so it's still false when the SpiritWeaponsModifier is set, which results in the old 0.15 modifier.
But as I just tested, even moving it before the call to Shaman:Melee doesn't fix it. This field seems always to be false in Shaman:Melee, even if you set it to true earlier. But well, easy fix, just delete the whole 2.3 check. Who needs it anyway?
0
http://trac.wowace.com/ticket/1527
http://trac.wowace.com/ticket/1532
Would be nice, because it sucks to apply them every time after an update.
0
No, this is not necessary:
The variable threat is later on modified with all your threat-mods.
0
It doesnt work, because the function to detect it doesnt work:
if trinket1ID == 30621 or trinket2ID == 30621 then DEFAULT_CHAT_FRAME:AddMessage("Prism of Inner Calm active"); self.meleeCritReduction = 150 self.spellCritReduction = 1000 endIt never gets to my added Print statement, but if I change it to:
if trinket1ID == "30621" or trinket2ID == "30621" then DEFAULT_CHAT_FRAME:AddMessage("Prism of Inner Calm active"); self.meleeCritReduction = 150 self.spellCritReduction = 1000 endIt works, so thats the problem, the item id is a string, not a number.
0
0
Me and others get the same error since 44409.