the talent Spirit Weapons now applies on stormstrike and windfury too. [Source]
i recognised that i don't generate as much threat as omen reports so i looked up this file:
No, this is not the problem. "Physical" always included SS and WF (just tested it myself to be sure). The problem is this IsTwoPointThree field in Shaman.lua:
self.schoolThreatMods["Physical"] = self.Melee [...] self.IsTwoPointThree = ThreatLib.WowVersion >= 2 and ThreatLib.WowMajor >= 3 [...] local SpiritWeaponsModifier = (self.IsTwoPointThree and 0.3) or 0.15
The point is, that self.IsTwoPointThree is set true, AFTER the whole ThreatModifier calculations, so it's still false when the SpiritWeaponsModifier is set, which results in the old 0.15 modifier.
But as I just tested, even moving it before the call to Shaman:Melee doesn't fix it. This field seems always to be false in Shaman:Melee, even if you set it to true earlier. But well, easy fix, just delete the whole 2.3 check. Who needs it anyway?
local SpiritWeaponsModifier = (self.IsTwoPointThree and 0.3) or 0.15 ==> local SpiritWeaponsModifier = 0.3