• 0

    posted a message on Official Threat-1.0 error reporting and discussion thread
    Quote from Sudo »

    the talent Spirit Weapons now applies on stormstrike and windfury too. [Source]
    i recognised that i don't generate as much threat as omen reports so i looked up this file:

    No, this is not the problem. "Physical" always included SS and WF (just tested it myself to be sure). The problem is this IsTwoPointThree field in Shaman.lua:
    self.schoolThreatMods["Physical"] = self.Melee
    
    [...]
    
    self.IsTwoPointThree = ThreatLib.WowVersion >= 2 and ThreatLib.WowMajor >= 3
    
    [...]
    
    local SpiritWeaponsModifier = (self.IsTwoPointThree and 0.3) or 0.15

    The point is, that self.IsTwoPointThree is set true, AFTER the whole ThreatModifier calculations, so it's still false when the SpiritWeaponsModifier is set, which results in the old 0.15 modifier.
    But as I just tested, even moving it before the call to Shaman:Melee doesn't fix it. This field seems always to be false in Shaman:Melee, even if you set it to true earlier. But well, easy fix, just delete the whole 2.3 check. Who needs it anyway?
    local SpiritWeaponsModifier = (self.IsTwoPointThree and 0.3) or 0.15
    
    ==>
    
    local SpiritWeaponsModifier = 0.3
    Posted in: Libraries
  • 0

    posted a message on Official Threat-1.0 error reporting and discussion thread
    Whats up with Antiarc? If he is not avaible at this time, could maybe some other one with access apply these both fixes please:

    http://trac.wowace.com/ticket/1527
    http://trac.wowace.com/ticket/1532

    Would be nice, because it sucks to apply them every time after an update.
    Posted in: Libraries
  • 0

    posted a message on Official Threat-1.0 error reporting and discussion thread
    Quote from dr_AllCOM3 »

    It does work, but the values are affected by Salvation.
    You have to substract 30%,

    self.meleeCritReduction = 105
    self.spellCritReduction = 700

    should be right.

    No, this is not necessary:
    if info.isCrit then
    		if self.meleeCritReduction > 0 and element == "Physical" then
    			threat = threat - self.meleeCritReduction
    		elseif self.spellCritReduction > 0 and element ~= "Physical" then
    			threat = threat - self.spellCritReduction
    		end
    	end

    The variable threat is later on modified with all your threat-mods.
    Posted in: Libraries
  • 0

    posted a message on Official Threat-1.0 error reporting and discussion thread
    Quote from Menelgor »

    Prism of Inner Calm...

    Just got this thing and read that it's supposedly -1000 threat on spell crits, but it doesn't seem to have any effect on the the threat Threat-1.0 is reporting.

    Any idea how I might get this thing working with Threat-1.0?

    edit: here's the mechanic for the spell crit reduction: http://www.wowhead.com/?spell=38328
    and here's the melee one: http://www.wowhead.com/?spell=38329

    edit II: After looking up the libraries again I noticed this thing in the ThreatClassModuleCore.lua:

    -- Prism of Inner Calm, see http://www.wowhead.com/?item=30621

    self.meleeCritReduction = 0
    self.spellCritReduction = 0

    if trinket1ID == 30621 or trinket2ID == 30621 then
    self.meleeCritReduction = 150
    self.spellCritReduction = 1000
    end


    But the thing is that it just doesn't work.

    It doesnt work, because the function to detect it doesnt work:

    	if trinket1ID == 30621 or trinket2ID == 30621 then
    		DEFAULT_CHAT_FRAME:AddMessage("Prism of Inner Calm active");
    		self.meleeCritReduction = 150
    		self.spellCritReduction = 1000
    	end


    It never gets to my added Print statement, but if I change it to:
    	if trinket1ID == "30621" or trinket2ID == "30621" then
    		DEFAULT_CHAT_FRAME:AddMessage("Prism of Inner Calm active");
    		self.meleeCritReduction = 150
    		self.spellCritReduction = 1000
    	end

    It works, so thats the problem, the item id is a string, not a number.
    Posted in: Libraries
  • 0

    posted a message on Omen - Bug Reports and Suggestions
    Me too.
    Posted in: Raid AddOns
  • 0

    posted a message on Omen - Bug Reports and Suggestions
    Quote from Elbereth »

    Today in Karazhan:
    Omen-2.1r44409\Omen.lua:599: invalid option in `format'
    Threat-1.0\Threat-1.0\ThreatKLHTMSupport.lua:97: in function `func'
    Threat-1.0\Threat-1.0\ThreatKLHTMSupport.lua:65: in function <...\AddOns\Threat-1.0\Threat-1.0\ThreatKLHTMSupport.lua:62>
    Threat-1.0\Threat-1.0\ThreatKLHTMSupport.lua:82: in function <...\AddOns\Threat-1.0\Threat-1.0\ThreatKLHTMSupport.lua:69>
    <in C code>: ?
    AceEvent-2.0-40601 (AceEvent-2.0):269: in function `TriggerEvent'
    AceEvent-2.0-40601 (AceEvent-2.0):910: in function <Interface\AddOns\AceEvent-2.0\AceEvent-2.0.lua:903>

    Elbereth.

    Me and others get the same error since 44409.
    Posted in: Raid AddOns
  • To post a comment, please or register a new account.