Should be fixed now. Was a small change i made but then didn't need anyway but forgot to change it back. :)Quote from
I'm getting this error. I've reinstalled the mod along with deleting the LUA's. I've been trying to duplicate it but it seems to only happen when i'm not paying attention.
[2007/12/22 13:33:11-395-x2]: PallyPower-2.01.00\PallyPower.lua:1632: attempt to index local 'unit' (a nil value) <string>:"*:PreClick":1: in function <[string "*:PreClick"]:1>
- Registered User
Member for 13 years, 10 months, and 13 days
Last active Fri, Oct, 4 2013 14:29:48
- 0 Followers
- 140 Total Posts
- 0 Thanks
Dec 22, 2007Posted in: General AddOns
Dec 20, 2007I'm in the progress of adding a few options to disable the auto buff feature in case someone don't wanna look at the button. But I'm having some troubles hiding the button. I simply call :Hide() on it but it only works if it haven't already been positioned and shown. So once it has been show, i can't hide it before the ui reload.Posted in: General AddOns
It inherit from the Header used from the other buttons. Also i set the following attributes when i show it:
autob:SetAttribute("ofspoint", "*:" .. pointOpposite)
Does anybody know what might be preventing me from hiding this secure button? I don't fully understand all about secure templates so my guess that would be the reason I'm missing something. :)
Edit: I added the new version with the options. Also made one just for you oodyboo so you don't have to wait for all people to be in range to buff greater blessings. Only thing that doesn't work well is hiding the button.
Dec 15, 2007Does it sound reasonable to assume that if there are less than 4 players in a group, it's not supposed to be considered part of the raid? So if there are 1-3 players in a group of a raid they are almost always standby people who are not supposed be stopping the buffing process?Posted in: General AddOns
Also where are people in your raids being stadby waiting? Are they in org/if/shat or are they waiting outside the instance? Because i could add a few checks so it skips people in capitals.
Dec 14, 2007oodyboo > I have thought quite a bit about that too. Right now it skips people if they are afk as that is often the case when people are standby. I'll try to look a bit more into if I'm able to guess who are standby. At first i had it ignoring offline people but then over time people actually were more offline for fixing a mod/having a bief disconnect than being permanently offline, and for those cases i didn't think it was wise to still buff the group. Also about being in a different zone that might also have some bad consequences if people are corpse running. One thing i have thought about is to check if they are in ogr/shat and conclude that they are standby from that. :)Posted in: General AddOns
Maybe ignore people who are like 3 or less players in a group, since i guess nobody doesn't have full groups in raids except people being standby. :)
Just a small question, anybody knows why normal BoL can't override greater BoL even when the greater has less than 10 min left like other blessings? Maybe i should build this into normal blessings as it waste quite a few clicks.
Dec 13, 2007A guildy got this error while using the new version of PP.Posted in: General AddOns
Line 1732 goes:
elseif (not UnitIsAFK(unit.unitid)) then
I did a bit of testing and no matter what i gave UnitIsAFK it doesn't throw any errors but just return nil. Anybody got any idea what might have caused this error? unit is the unit table from RosterLib.
Dec 12, 2007Posted in: General AddOns
But not sure it's possible to hide a frame when entering combat, is it?Quote from Aznamir »
It is possible to hide and show frames in combat, but they must be created and configured before entering combat. The current method with secured templates allows to hide or show player buttons on events (cursor over the class button), but it would be hard to override it.
I think for that person it would be ok to hide player and class buttons using options in the configuration menu and leave only the new 'autobuff' button visible. I haven't tried this beta yet, so I don't know whether you hide it as well or not.
And no i never hide the auto buff button. Should there be an option to hide it always? I have also had a guildy mention that maybe i should hide it when not grouped?
Dec 12, 2007Posted in: General AddOns
Do you mean the new auto buff button or what frame? If that's the case I don't think that's possible as frames can't be hidden/shown in combat as far as i know (not quite sure if it's possible to hide only).Quote from Mummha »
Do you plain to make any function that hides the frame while in combat?? Would be great!
Also, I uploaded yet another version where i added penalties to units where greater blessings failed also so it doesn't get stuck when buffing greater blessings just because one player is out of line of sight. I haven't tested it in a raid yet, but planning on doing that tonight.
Dec 11, 2007Posted in: General AddOns
Ever since normal blessings was introduced, the timer for blessings never counted players who was buffed with a greater blessing but had a different normal blessing assigned in addition. I don't really wanna make the timer count a greater blessing when you have marked it as a normal blessing should be buffed instead. So unless you have a suggestion how it should handle the situation isntead feel free to explain :)Quote from Morgalm »
Nice work but one little complaint. I noticed now when you buff with greater buffs on a class with only 1 player in it who also has a lesser buff set or if all players of that class have a lesser buff set there is no timer for the greater buff. The button still looks like the player was never buffed even though the greater buff was applied. I like to start a fight with kings on most mana users and if it is a mana intensive fight I will buff them with small wisdom part way through the fight. As I say I just find myself rebuffing classes I already buffed prefight because there is no timer.
Dec 11, 2007I finally got the time to make the changes i wanted to automatically buffing greater blessings. Now it only buffs a class if all players are in range. It still picks the class with the player who got the shortest time left. There are a few exceptions to when it might still buff a class when not all players are in range which are when the player out of range is afk or have a special normal blessing assigned and thus doesn't need the greater.Posted in: General AddOns
So feel free to help test it by downloading it from here.
Also if nobody reports any errors or post any complaints/suggestions, i will update the official version soon.
Dec 6, 2007Posted in: General AddOnsQuote from Menju »
Heya! Are there any plans to add some type of blessing presets that we can save for future use that would populate the blessings automatically?
I don't think i will as too many things change each time in order to make it work well.
Quote from S3nsenmann »
i love Pallypower, its really great, but one Question would it be possible to give Warriors the Option for Salvation?
Often when i'm in groups with a feral druid tank and an offwarrior, they want salvation and I need another place in my Bars :p
I think i actually made that possible in the latest version.
oodyboo > I think i see what you mean the problem about greater blessings is. But the change to avoid buffing when not all players for one class isn't in range isn't simple so it will be at least a few days before i look into it. :)
Dec 5, 2007oodyboo > There are currently two "blacklist" features built in. If someone has been buffed within the last 20 sec, 5 min is added to the buff time when evaulating who got the shortest time left. And if the person was the one previously buffed, it adds 10 min. This means that if buffing someone who was out of line of sight, they have lower priority the next 20 sec, but if nobody else really need a buff, it might still try. Also range check should be included.Posted in: General AddOns
However i'll test greater blessings a bit more myself before i comment on that as i haven't tried it in raids yet. It should ignore people out of range when considering what classes needs a rebuff, but i might have made a mistake. Also the 5 min limit should prevent buffing the same class.
I haven't been able to produce the errors you are talking about where it repeat doing greater blessing on one class so if you could explain that problem maybe a bit more detailed. Also i don't see any problems when spamming the button too fast besides maybe it will lower the priority for those that fail becaise of GCD a bit.
Edit: Seems like there was some error in the range checking since i tried to make it more accurate. But should be fixed now. :)
Dec 4, 2007By request of a guildy i added support for greater blessings too. When you right click or press the shortcut, it will work like before. When you left click or press ctrl/alt/shift + shortcut it will cast a greater blessing on the group where a member that is supposed to get a greater blessing has less than 25 min left on his blessing. It picks the group where a member has the shortest time left on his blessing first. This feature is meant for doing a rebuff before a boss. I added the limit with 25 min to avoid going in cyckles like it's possible with normal blessings since it cost regents.Posted in: General AddOns
So this should basically be another addition that people can use if they like but can avoid by right click or using the shortcut :)
Dec 4, 2007There are two situations where i still think it's quite usefull. While clearing trash some buffs just runs out or some people die, and simply just press the button between packs so the blessings are kept up without too much trouble. So also for people who lost their greater blessing. And it's quite usefull in some long fights still such as MH trash where you often get out of combat briefly.Posted in: General AddOns
The main reason i made it so that i just cycles through the buffs instead of only buffing those without blessings is that sometimes right before a boss, some people decide to spend 5 min on dicussing changes and with quite a few people having a special blessing assigned it wasn't that easy to make sure they all got rebuffed again when you were about to start.
Actually i have thought of something similar to your idea with having a button for every normal blessing assigned to a button so it was easier to rebuff in long fights, but that can exist just fine together with this auto rebuff.
But if too many people don't like this auto rebuff feature please say so, so it doesn't annoy many people if i end up including it in the official version :)
- To post a comment, please login or register a new account.