Traced this to being from a right-click menu on a party member unit frame, which uses unitid's like "player1", etc
Turns out a fix for ItemBonusLib to work for mods like this was really just for 'target' and 'player', so it was still messing around with the InspectFrame when it wasn't either of those.
I reverted back to using my own implementation of the ItemBonusLib:GetUnitEquipment functionality like I had before. I've tested this a good bit with the way you were inspecting before as well as the other ways, and it seems to be working so far.
Thanks for all the bug reports, Zidomo =D
Also, it's worth noting that things this will work: /script Spyglass:SetInspectUnit('mouseover')
Or basically any similar valid unitID. I may get around to adding a bind for this or something ... who knows xD
- Registered User
Member for 16 years, 9 months, and 4 days
Last active Fri, Oct, 4 2013 21:29:47
- 0 Followers
- 21 Total Posts
- 0 Thanks
Feb 9, 2008The Pawn error was a mix of me being good and not forcing the InspectFrame to load, not considering if it -had- been forced to load, and the Pawn author forcing the InspectFrame to load just to attach the button :DPosted in: General AddOns
I've got a fix going up for this after I rethink how I'll store data.
Nov 23, 2007_ForgeUser72795 posted a message on Official Threat-1.0 error reporting and discussion threadClassModules/Warrior.lua:166: attempt to index local 'rank' (a number value)Posted in: Libraries
When passing rank as a number to SunderArmor.
local ranknum = tonumber(rank:match("%d+"))should be removed, as GetLinearThreatGuess does type checking.
Nov 8, 2007I added the FuBar menu options to the dropdown menu, so you can hide the text/icon and such now.Posted in: General AddOns
The dressing room should now work in all cases (it didn't work before when you were not in inspect range). I also fixed the closing it with escape.
Barabas: can you reproduce the error with the most recent version? I may have fixed it while fixing the other errors :D
Nov 2, 2007Sorry for the bugs and delay, I thought I re-tested enough after the last set of changes. I'll get on these when I get home later tonight. I'll also get the text hiding and dressing room working.Posted in: General AddOns
Also, for inspecting people w/out them knowing, I can look into maybe inspecting someone through, say, mouseover.
Oct 30, 2007Would a naming scheme help as well? Such as BaconLib being under Libraries and containing information on the library while Bacon-1.0 would be under API_Documentation and contains the API information.Posted in: Libraries
Or, since the <Library>Lib scheme isn't always the case (or make it the case for the wiki?), have Bacon and Bacon-1.0
That API formatting looks awesome, too. Long method strings while not producing any 'wtf' between chair and keyboad. Would be nice to see some change to the autodoc'd formatting, much less the autodoc being used.
Oct 30, 2007Posted in: General AddOnsQuote from Fistandantilus »would it be possible to have a keybinding for spyglass for example in superinspect i pressed "I" to inspect someone that would be great
Just added that in. Thanks for the suggestion. :D
Oct 30, 2007Posted in: LibrariesQuote from tekkub »That's exactly how it's intended to be used. The libraries category would be used for base page for multi-file libraries, like SpecialEvents. The API Docs cat would be for any page that provides actual documentation. Many Pages mix both together (and make for really nasty reading)... those really should be split apart, but meh. There's only so much cleanup of other people's nasty page I can handle before I go nuts(er).
Permission (for me) to go nuts? xD
Quote from tekkub »For what it's worth, the Libraries cat is supposed to be a sub-cat of Addons, where API Docs are kinda their own separate (and more useful) cat.
Already made Libraries a sub-category of Addons, but also made API_Documentation a sub-cat of Libraries and Addons as there are a few addons with API Documentation to them (Parrot, RatingBuster, etc)
Oct 29, 2007This has been bugging me for a while: what should be the difference between articles in Category:Libraries and articles in Category:API_Documentation ?Posted in: Libraries
It seems some libraries are in Libraries, some are in API_Documentation, and a lot are in both at the same time. This can be a headache if you're new to the WoWAce library scene and trying to find documentation on libraries you may or may not know exist.
I personally see Category:API_Documentation as a category of articles that will show me how to use the libraries, while Category:Libraries is a category of articles about what the libraries have to offer, etc (like an Addon page).
Does anyone else have any similar concerns/ideas?
Oct 29, 2007Posted in: General AddOnsQuote from Fistandantilus »
just an issue i have here is that as soon as i right click a portrait ingame and choose "inspect" from dropdown, all my frames are gone ^^
would it be possible to have a keybinding for spyglass for example in superinspect i pressed "I" to inspect someone that would be great
Fixed that, it was a direct result of me trying to 'trick' the InspectUI the 'wrong way' heh.
I'll get to keybindings later tonight.
Oct 28, 2007Posted in: General AddOnsQuote from m0j0 »
hmmm... when I target someone and then press the spyglass icon on my FuBar, it inspects me, not my target.
Fixed. I had to rework the logic for selecting the 'unit' to inspect. I've double-checked all scenarios for this, and it should work fine now.
Oct 26, 2007Spyglass is an addon that enhances the Blizzard inspection interface. It provides a summary of the inspected player's equipment and allows you to load an inspected player's equipment from anywhere.Posted in: General AddOns
- Summary of inspected player's equipment
- Load any inspected player's equipment from anywhere
- Optionally save inspected equipment across sessions
Post any suggestions to this thread. I try to stay in the IRC channel, if you want to get in touch with me there.
Oct 12, 2007In ItemBonusLib:GetUnitEquipment, could you add something to conditionally disable hiding the Inspect frame? It can get in the way if the library is being used with the inspect frame itself. Simply re-showing the frame causes errors as well.Posted in: General AddOns
- To post a comment, please login or register a new account.