• 0

    posted a message on StatBlocks v1: Official Thread
    Quote from Stan »
    oh and the CasterStats block has no X/Y settings :)


    Added. The other stuff seems like it would change some of the design ideals of the addon and that's not my place to add.
    Posted in: General AddOns
  • 0

    posted a message on StatBlocks v1: Official Thread
    Here's a patch to color Money's label with the standard gold/silver/copper colors. I didn't want to just commit this straight away cause it kinda changes a lot, so I'll leave it up to you.

    Index: StatBlocks_Money.lua
    ===================================================================
    --- StatBlocks_Money.lua	(revision 74435)
    +++ StatBlocks_Money.lua	(working copy)
    @@ -6,10 +6,15 @@
     local SB_MONEY = SB:NewModule("Money", "AceEvent-3.0")
     local L = LibStub("AceLocale-3.0"):GetLocale("StatBlocks", true)
     
    +local COLOR_COPPER = "eda55f"
    +local COLOR_SILVER = "c7c7cf"
    +local COLOR_GOLD = "ffd700"
    +
     local defaults = {
     	profile = {
     		scale = 1,
     		color = { r = 1, g = 1, b = 1 },
    +		labelcolor = false,
     		pos = { x = 0, y = 0 },
     		lock = nil,
     		align = "CENTER",
    @@ -35,14 +40,25 @@
     					get = function() return self.db.profile.lock end,
     					set = function(_, v) self:Lock(v) end,
     					order = 1,
    +					width = "full", -- force the colors onto their own line
     				},
     				color = {
    -					name = L["Color"],
    +					name = L["Value Color"],
     					type = "color",
     					get = function() return self.db.profile.color.r, self.db.profile.color.g, self.db.profile.color.b end,
     					set = function(_, r, g, b) self:Color(r, g, b) end,
     					order = 2,
     				},
    +				labelcolor = {
    +					name = L["Label Color"],
    +					type = "toggle",
    +					get = function() return self.db.profile.labelcolor end,
    +					set = function(_, v)
    +						self.db.profile.labelcolor = v
    +						self:UpdateBlock()
    +					end,
    +					order = 3,
    +				},
     				scale = {
     					name = L["Scale"],
     					type = "range",
    @@ -51,7 +67,7 @@
     					step = 0.01,
     					get = function() return self.db.profile.scale end,
     					set = function(_, scale) self:Scale(scale) end,
    -					order = 3,
    +					order = 4,
     					width = "full",
     				},
     				x = {
    @@ -59,17 +75,17 @@
     					type = "input",
     					get = function() return self:GetX() end,
     					set = function(_, x) self:SetX(x) end,
    -					order = 4,
    +					order = 5,
     				},
     				y = {
     					name = L["Y Position"],
     					type = "input",
     					get = function() return self:GetY() end,
     					set = function(_, y) self:SetY(y) end,
    -					order = 5,
    +					order = 6,
     				},
     				align = {
    -					order = 6, type = "select", 
    +					order = 7, type = "select", 
     					name = L["Font Align"],
     					values = {LEFT = L["LEFT"], CENTER = L["CENTER"], RIGHT = L["RIGHT"]},
     					get = function() return self.db.profile.align end,
    @@ -108,6 +124,10 @@
     	local silver = floor((current - (gold * 10000)) / 100)
     	local copper = mod(current, 100)
     
    -	self.font:SetFormattedText("%ig %is %ic", gold, silver, copper)
    +	if self.db.profile.labelcolor then
    +		self.font:SetFormattedText("%i|cff%sg|r %i|cff%ss|r %i|cff%sc|r", gold, COLOR_GOLD, silver, COLOR_SILVER, copper, COLOR_COPPER)
    +	else
    +		self.font:SetFormattedText("%ig %is %ic", gold, silver, copper)
    +	end
     end
     
    Posted in: General AddOns
  • 0

    posted a message on StatBlocks v1: Official Thread
    The options between each module need some standardization.

    Clock doesn't have an alignment option, almost every other module does.

    Most modules' color options are "Value Color" then "Label Color" and those two options are on the same line. Memory reverses the order. DPS and MeleeStats have them on different lines.

    The modules in the tree aren't in any specific order. Should probably be alphabetical by name.

    I'd also like to request that Money have an option color the 'g', 's' and 'c' labels their respective colors. This could be in place of the standard "Label Color" option.

    Coloring Durability on a gradient from Red (0%) to Green (100%) would also be appreciated.
    Posted in: General AddOns
  • 0

    posted a message on LibBars-1.0 and bar recycling
    Looks good. Thanks for fixing it.
    Posted in: Libraries
  • 0

    posted a message on Cutup: A collection of Rogue addons
    Quote from luxus »

    one question.. why the combopoints still visible when i change the target..? i sometimes get it wrong and think i have 3 combo points on my target and smash the s'n'd button and nothing happens because the points on my old target


    Should be fixed.
    Posted in: General AddOns
  • 0

    posted a message on LibBars-1.0 and bar recycling
    I could be mistaken, but I believe there's currently an issue with the way LibBars-1.0 recycles its bar frames. This became apparent once barPrototype:SetColorAt was implemented.

    I used this new method to set my bars to the corresponding RAID_CLASS_COLOR value, which worked fine, but then once another LibBars-based addon, Hourglass, created a new bar, it would have the same color as the last bar of mine that expired.

    Attached is an example using my addon, RaidCooldowns, and the example addon FlashFrames. I ran RaidCooldown's test function, waited for a few to expire, and then re-added more bars to FlashFrames. As you can see, bars 4 and 6 used both the color and the font from RaidCooldowns.

    I'm not sure if this is a bug in LibBars or if it's working as intended and thus the responsibility of any addon using the library to reset the color and font of every bar it creates.
    Posted in: Libraries
  • 0

    posted a message on LibBars-1.0 r72899+
    New changes work great, good work.
    Posted in: Libraries
  • 0

    posted a message on Cutup: A collection of Rogue addons
    Ace3 branch went up the other day, did most of the conversion today, as well as adding a new module, Bleeder, which is just like Julienne but for Rupture.
    Posted in: General AddOns
  • 0

    posted a message on LibBars-1.0 r72899+
    LibBars-1.0:
    Let's try adjusting the update rate based on the max time of the bar and the
    bar width, in pixels. Since the bar can't shrink/grow in increments greater
    than one pixel, there's no point in updating more often than every maxVal /
    width seconds.


    While this is a good idea, it created a bit of an aesthetic issue on bars with long timers, maybe 5+ minutes, I'm unsure of the exact margin. Since 1 second may move the bar less than 1 pixel, the timer doesn't update until it does. This results in the time countdown skipping multiple seconds at a time and it looks like it's lagging.
    Posted in: Libraries
  • 0

    posted a message on Hourglass - A lightweight oCD/CooldownTimers2 improved remake.
    Minor inaccuracy in the chainedCooldown table. Preparation only resets Evasion, Sprint, Vanish, Cold Blood, Shadowstep and Premeditation.
    Posted in: General AddOns
  • 0

    posted a message on RaidCooldowns_Display
    Nothing against oRA2, I use it and love it, but it only tracks 4 spells and my raid leader wanted others. And CTRA is... CTRA.
    Posted in: Raid AddOns
  • 0

    posted a message on RaidCooldowns_Display
    It'll be fine once LibBars is stable enough to make it to the trunk. I would've put RCD in branches as well but I didn't feel like explaining to my guild how to get it :)
    Posted in: Raid AddOns
  • 0

    posted a message on RaidCooldowns_Display
    The LibBars-1.0 folder included in libs is the embedded version of the library and cannot be run as a standalone addon. You'd have to get the full folder from the branch folder at http://svn.wowace.com/wowace/branches/LibBars-1.0/

    Notice the .toc file.
    Posted in: Raid AddOns
  • 0

    posted a message on anti murloc chat spam blocker
    I wrote a simple addon that did this a while back because it annoyed me too.

    http://tsigo.googlecode.com/svn/trunk/MurlocHammer/

    Only blocks 'murloc' and only in Trade. Don't ask for updates or a zip file download or anything, I have no plans to update this.
    Posted in: Addon Ideas
  • 0

    posted a message on Chatter- Ace3 chat mod (was Chatterbox)
    Did something change with Chat Font between yesterday and today? Yesterday I ran Chatter for the first time. I changed the font face and size, it updated instantly, worked perfectly.

    Now, changing the font size via the tab menu does nothing, and changing it via the Chatter options only changes the font size of the first 4 lines of the chat frame, and I have to reload UI for it to update completely.
    Posted in: General AddOns
  • To post a comment, please or register a new account.