It would be nice if PallyPower could treat Pets as Warriors and vice-versa at the blessing assignment level, as WoW does. I keep seeing Paladins setting different greater blessings for pets than for warriors on accident and then wondering why PallyPower freaks out.
Not all pets are treated as warriors, though I think all hunter pets are. To be honest, this sounds more like PEBKAC rather than something PallyPower should handle.
No, got some error with the attached version. Might be some disparity between our versions as I edited some stuff too.
I just got an idea: did you make that change in both places where UnitBuff is called for buffs in ScanAuras? Just before the first while loop and inside the while loop. Your problem might come from changing only the first call, the one outside the loop.
I made your change to the auras.lua but it only shows the cooldown on the shortest time left. If I blow 2+ cooldowns all other are shown without spiral until it is moved up to the shortest time left cd.
It works fine for me, I attach my auras.lua if you wanna check what's the difference. I have a couple of other things changed too, I hope it works fine. :)
I use an ancient and simple addon called "Aggro" to show when I get aggro myself. All it does is scan party/raid targets, check if "player" or "pet" are targetted, and pop a big "AGGRO" in the middle of the screen.
This addon shows correctly when I become Sathrovarr's target, Grid through LibBanzai never did. The code it uses is very similar to LibBanzai:
if (UnitCanAttack(unit,"player") and UnitIsUnit(unit.."target","player")) then
Jerry said in the Grid thread that the return value of UnitExists or UnitCanAttack might be bugged for this mob, so maybe the order of parameters in UnitCanAttack matters in this case? The line above uses mob->player, whereas LibBanzai uses player->mob. It shouldn't make a difference, but maybe it's an obscure bug just for Sathrovarr.
I actually meant to verify this this week, but I forgot before raid time, if I manage to remember before next week's Kalecgos I'll post here the results.
I also noticed the cooldown spiral not showing, maybe it has something to do with the new skin on aura icon?
Quoting myself, but I found out why the cooldown spiral doesn't show: when the changes were backported form the WotLK branch to live, the UnitBuff return values weren't changed. So there's an extra return value, deleting it shows the cooldown properly.
The setup mode and aura splitting are great, thanks for adding those!
Now for the bug report :p : when changing party padding ("Group" tab) in setup mode, it exits setup mode and says in chat frame that it detected a group change. I guess this is not intended?
I also noticed the cooldown spiral not showing, maybe it has something to do with the new skin on aura icon?
I posted this earlier, but bumping: would you mind assigning playerClass before the call to self:ScanSpells() in OnEnable? "Show school" option doesn't work in the current version, I've sent you a PM about a month ago but maybe you didn't see it.
There's another thing that needs fixing for this option to work properly: in Heatsink:SPELL_UPDATE_COOLDOWN() there's "schoolName" in a couple of places, however that should be "school".
A different problem is chained cooldowns not working, for example Cold Snap. There are 2 things needed to fix this in UNIT_SPELLCAST_SUCCEEDED():
- add another parameter so the function becomes Heatsink:UNIT_SPELLCAST_SUCCEEDED(event, unit, spellName)
- remove id and use "chainedSpellName" as argument to GetBar(): local bar = self.cooldown:GetBar(chainedSpellName)
Chained cooldowns work with those fixes.
And another bump for the paladin Turn Evil/Undead:
Maybe I misunderstand the issue, but doesn't this mean that spell reflect needs to be treated different in Threat-2.0? And actually it is treated like a special case, I just have a question mark on what happens if SPELL_DAMAGE is processed before SPELL_MISSED.
I don't know if this makes a difference for Threat-2.0, and I also can't confirm or deny if Omen shows the correct threat since I play a healer.
But it looks to me like cleuHandlers:SPELL_DAMAGE needs self.SpellReflectSources[srcGUID] to be assigned before its value is checked in cleuHandlers:SPELL_DAMAGE, and if SPELL_DAMAGE event is fired before SPELL_MISSED, then the threat from spell reflected Void Blast is ignored. Of course, I could be misinterpreting the way Threat-2.0 works.
Yeah, the TinyGratuity experiment failed miserably, reverting to libgratuity-3.0 for the time being.
For what it's worth, I haven't had issues with TinyGratuity after the fixes on the 14th July (r78405, prior to changing to LibGratuity-3.0). Used to get the "line 902" error, which is unrelated to TinyGratuity, once playerClass was assigned before ScanSpells the error went away and I had no further issues with the addon. I'm using TinyTip as tooltip addon.
djsmeg, the second error you posted is due to playerClass being assigned in PLAYER_ENTERING_WORLD instead of OnEnable, as per my post above (I guess you use "Show School" option too). You can move it in Heatsink.lua if you wanna have it working before durcyn gets the chance to fix it.
No idea about the other 2, I don't run those tooltip addons myself.
Thanks for keeping this updated and moving it to trunk! :)
There's an issue with school lock cooldowns though since the 12 July changes. On counterspell I get the screen full of bars instead of only the school (the option is checked). I haven't had much time to look through the Heatsink code, but one thing I noticed is that the new function FindCooldown returns true for each spell in spellbook. So all spells including those without cooldown are added to the watch list and you get a huge list if you're counterspelled/pummeled/etc. Would be great if you can have a look at this issue.
Also a few other changes/additions I'd like to see when you get the chance:
A small feature request: could you separate spacing into vertical and horizontal? The reason for this being that it's possible to place icons outside the unit frame with a plugin. For example if I place 1 icon on the right side, I would need horizontal spacing > 0 and vertical spacing == 0, or similar.
While I like the indicators and the whole Grid functionality as it is, I sometimes want a little bit more, for example more that 1 icon for each unit. Only way I found to do this without cluttering the frame itself is to place those on the outside, between units. Right now I hardcoded into Grid 0 vertical spacing, but would be nice to have it as an option in the core addon.
0
Not all pets are treated as warriors, though I think all hunter pets are. To be honest, this sounds more like PEBKAC rather than something PallyPower should handle.
0
I just got an idea: did you make that change in both places where UnitBuff is called for buffs in ScanAuras? Just before the first while loop and inside the while loop. Your problem might come from changing only the first call, the one outside the loop.
0
It works fine for me, I attach my auras.lua if you wanna check what's the difference. I have a couple of other things changed too, I hope it works fine. :)
0
This addon shows correctly when I become Sathrovarr's target, Grid through LibBanzai never did. The code it uses is very similar to LibBanzai:
Jerry said in the Grid thread that the return value of UnitExists or UnitCanAttack might be bugged for this mob, so maybe the order of parameters in UnitCanAttack matters in this case? The line above uses mob->player, whereas LibBanzai uses player->mob. It shouldn't make a difference, but maybe it's an obscure bug just for Sathrovarr.
I actually meant to verify this this week, but I forgot before raid time, if I manage to remember before next week's Kalecgos I'll post here the results.
0
Quoting myself, but I found out why the cooldown spiral doesn't show: when the changes were backported form the WotLK branch to live, the UnitBuff return values weren't changed. So there's an extra return value, deleting it shows the cooldown properly.
Basically in aUF_auras.ScanAuras(self):
should be:
0
Now for the bug report :p : when changing party padding ("Group" tab) in setup mode, it exits setup mode and says in chat frame that it detected a group change. I guess this is not intended?
I also noticed the cooldown spiral not showing, maybe it has something to do with the new skin on aura icon?
0
0
I posted this earlier, but bumping: would you mind assigning playerClass before the call to self:ScanSpells() in OnEnable? "Show school" option doesn't work in the current version, I've sent you a PM about a month ago but maybe you didn't see it.
There's another thing that needs fixing for this option to work properly: in Heatsink:SPELL_UPDATE_COOLDOWN() there's "schoolName" in a couple of places, however that should be "school".
A different problem is chained cooldowns not working, for example Cold Snap. There are 2 things needed to fix this in UNIT_SPELLCAST_SUCCEEDED():
- add another parameter so the function becomes Heatsink:UNIT_SPELLCAST_SUCCEEDED(event, unit, spellName)
- remove id and use "chainedSpellName" as argument to GetBar(): local bar = self.cooldown:GetBar(chainedSpellName)
Chained cooldowns work with those fixes.
And another bump for the paladin Turn Evil/Undead:
groupedCooldown:
I attached the fixed Heatsink.lua if it makes it easier.
Thanks in advance. :)
0
True, but the source and the target in SPELL_DAMAGE are the same, the mob whose spell was reflected. In the log file it shows like this:
8/5 19:46:02.977 SPELL_DAMAGE,0xF1300064AC000C32,"Void Sentinel",0xa48,0xF1300064AC000C32,"Void Sentinel",0xa48,46161,"Void Blast",0x20,13411,32,0,0,0,nil,nil,nil
Maybe I misunderstand the issue, but doesn't this mean that spell reflect needs to be treated different in Threat-2.0? And actually it is treated like a special case, I just have a question mark on what happens if SPELL_DAMAGE is processed before SPELL_MISSED.
0
Looking through one of our saved logs from M'uru, the event order is sometimes weird. Normally is:
SPELL_CAST_START
SPELL_MISSED ...,REFLECT
SPELL_DAMAGE
Sometimes the order is:
SPELL_CAST_START
SPELL_DAMAGE
SPELL_MISSED ...,REFLECT
I don't know if this makes a difference for Threat-2.0, and I also can't confirm or deny if Omen shows the correct threat since I play a healer.
But it looks to me like cleuHandlers:SPELL_DAMAGE needs self.SpellReflectSources[srcGUID] to be assigned before its value is checked in cleuHandlers:SPELL_DAMAGE, and if SPELL_DAMAGE event is fired before SPELL_MISSED, then the threat from spell reflected Void Blast is ignored. Of course, I could be misinterpreting the way Threat-2.0 works.
I can PM you the log file if it helps.
Edit: clarity.
0
For what it's worth, I haven't had issues with TinyGratuity after the fixes on the 14th July (r78405, prior to changing to LibGratuity-3.0). Used to get the "line 902" error, which is unrelated to TinyGratuity, once playerClass was assigned before ScanSpells the error went away and I had no further issues with the addon. I'm using TinyTip as tooltip addon.
0
No idea about the other 2, I don't run those tooltip addons myself.
0
playerClass = select(2, UnitClass("player"))Otherwise ScanSpells is called before this variable is assigned a value and Heatsink errors out if you have the "Show school" option enabled.
And lastly, one thing I forgot for paladin spells:
groupedCooldown:
0
Thanks for keeping this updated and moving it to trunk! :)
There's an issue with school lock cooldowns though since the 12 July changes. On counterspell I get the screen full of bars instead of only the school (the option is checked). I haven't had much time to look through the Heatsink code, but one thing I noticed is that the new function FindCooldown returns true for each spell in spellbook. So all spells including those without cooldown are added to the watch list and you get a huge list if you're counterspelled/pummeled/etc. Would be great if you can have a look at this issue.
Also a few other changes/additions I'd like to see when you get the chance:
* instead of:
should be:
Reason for this being the paladin Holy Shock matches the current expression and shows up as "Shocks".
* add paladin bubble to groupedCooldowns:
* add paladin Holy school:
schoolGroups:
["PALADIN"] = { [L["Holy"]] = spellname(635), -- 635 Holy Light },schoolSpells:
["PALADIN"] = { [spellname(20473)] = L["Holy"], -- 20473 Holy Shock [spellname(642)] = L["Holy"], -- 642 Divine Shield [spellname(498)] = L["Holy"], -- 498 Divine Protection [spellname(31842)] = L["Holy"], -- 31842 Divine Illumination [spellname(20216)] = L["Holy"], -- 20216 Divine Favor [spellname(26573)] = L["Holy"], -- 26573 Consecration [spellname(633)] = L["Holy"], -- 633 Lay on Hands [spellname(2812)] = L["Holy"], -- 2812 Holy Wrath [spellname(24275)] = L["Holy"], -- 24275 Hammer of Wrath [spellname(879)] = L["Holy"], -- 879 Exorcism [spellname(2878)] = L["Holy"], -- 2878 Turn Undead [spellname(10326)] = L["Holy"], -- 10326 Turn Evil [spellname(31789)] = L["Holy"], -- 31789 Righteous Defense [spellname(1022)] = L["Holy"], -- 1022 Blessing of Protection [spellname(1044)] = L["Holy"], -- 1044 Blessing of Freedom [spellname(31884)] = L["Holy"], -- 31884 Avenging Wrath [spellname(20271)] = L["Holy"], -- 20271 Judgement [spellname(2812)] = L["Holy"], -- 2812 Holy Wrath [spellname(853)] = L["Holy"], -- 853 Hammer of Justice [spellname(19752)] = L["Holy"], -- 19752 Divine Intervention [spellname(6940)] = L["Holy"], -- 6940 Blessing of Sacrifice },Those additions also need:
in the localization file.
Thanks in advance!
0
A small feature request: could you separate spacing into vertical and horizontal? The reason for this being that it's possible to place icons outside the unit frame with a plugin. For example if I place 1 icon on the right side, I would need horizontal spacing > 0 and vertical spacing == 0, or similar.
While I like the indicators and the whole Grid functionality as it is, I sometimes want a little bit more, for example more that 1 icon for each unit. Only way I found to do this without cluttering the frame itself is to place those on the outside, between units. Right now I hardcoded into Grid 0 vertical spacing, but would be nice to have it as an option in the core addon.
Thanks in advance!