Authors CurseForge

Quote from egingell »

You're code will only execute once and will die because of syntax. For testing equality, you need to use a double-equal (==).

Once you fix that error, you will get another error because you have an "end" where no "end" belongs. You actually have three "end" statements where they don't belong.

This is far from fixed for use, but I fixed the syntax errors for you:

if UnitExists("target") == exists then
  UIParent:SetAlpha(1)
else
  UIParent:SetAlpha(0.5)
  -- a,d -- not sure what this is here for. ???
  ChatFrame1:SetAlpha(1)
end

local frame = GetMouseFocus()
frame:SetAlpha(0.9)

Just to hammer the point home, if you don't register any events, put in an OnUpdate somewhere, or hook any functions, your code will only run once. Unless, of course, you execute if manually.

P.S. Setting the alpha of UIParent supersedes all other frame's alphas (except WorldFrame). In other words, 0.5 will be as opaque as the ChatFrame1 will ever get if UIParent's alpha is set to 0.5.

Quote from Starinnia »

Technically, the first line should probably be something more like:

if UnitExists("target") then

'exists' is never defined anywhere, and that function returns true or false already, so you really don't need any further comparison.

ChatFrame1:SetParent("WorldFrame")

if UnitExists("target") then
  UIParent:SetAlpha(1)
else
  UIParent:SetAlpha(0.5)
  ChatFrame1:SetParent("WorldFrame")
end

local frame = GetMouseFocus()
frame:SetAlpha(0.9)

if UnitExists("target") = exists
  then UIParent:SetAlpha(1)end;
  else UIParent:SetAlpha(0.5) a,d ChatFrame1:SetAlpha(1) end;
end

local frame = GetMouseFocus()
   frame:SetAlpha(0.9)
end

Quote from cdsboy »

I'd love to hear any comments you have!

Quote from Phanx »

Try to center the bottom panel art... currently it's too far up and to the right, leaving uneven spacing between its edges and the buttons inside it. Likewise, move the trinket buttons down to line up with your action bars, and put the same border on them that you're using on your action bars (and every other button).

Quote from Phanx »

Because you didn't read my post. I didn't tell you to add that line. I told you to change a specific line, and showed you what that line looked like for me after I changed it.

Change "fill = true" to "fill = false" in the settings table. Honestly if you can't figure things like this out, oCD may not be for you.

Quote from Phanx »

I'm guessing that you mean "move", not "replace"... and you have to change the first line in the PLAYER_LOGIN function in ocd.lua. Mine looks like this:

self.group = self.display:RegisterGroup("oCD", "TOPLEFT", "UIParent", "CENTER", -162, -252)

I have absolutely no idea how oCD is scaling these values or anchoring the icons, as I haven't looked through the code, but the actual visible distances are nearly double what I had to use in the code. Experimentation is key.

function addon:PLAYER_LOGIN()

  self.group = self.display:RegisterGroup("oCD", "TOPLEFT", "UIParent", "CENTER", -2, -2)
	register = self.bars.register
	self:parseSpellBook(BOOKTYPE_SPELL)

	self.bars.setMinMax(defaults.min, defaults.max)
	self.bars.setTextPosition(defaults.textPos)
end

Quote from Phanx »

Some rearranging from my last screenshot.

Solo, casting, target:


Visible addons: ButtonFacade (with Rothar skin), Grid (modified for thicker border), InfiniBar, MiniMapster (modified for additional cleanup), Poppins (branch version), oCD, oUF, PhanxChat, Quartz, SatrinaBuffFrame, ShieldsUp (unreleased).

I'll get a raid combat screenshot tomorrow.

I'm not entirely satisfied... probably, either unit frames will get pushed down further, or the action bars will get moved over to the center again. oCD will probably get moved too.