• 0

    posted a message on Shadowed Unit Frames [official]
    I also have a similar problem with reloading messing up the layout. It's been that way since I started using SUF which was v3.4.4 for WoW 4.3. Entering config mode and back out fixes it. The new version didn't help.



    The left is normal, the right is after a reload (not in combat). The frames start at the bottom and grow up.

    ---------------------------

    Also: When people enter the group, the last one is never shown. For instance, when in a battleground and the 10th player joins, there will only be 9 frames for the whole time. The problem there is probably something to do with the fact that when GROUP_ROSTER_UPDATE occurs, the unit IDs are valid, but the information for them might not be available for a few seconds, like name, class, etc. Tidy Plates has a similar problem which I fixed by using an OnUpdate with a 2 second timer, which continues until the info is available for all the units.

    ---------------------------

    And another: Since patch 5.1, the report player away function on the drop down menu doesn't work, and gives an addon blocked error and popup to disable SUF. Why Blizzard would protect that is beyond me.
    Posted in: Unit Frames
  • 0

    posted a message on LibDataBroker-1.1 not-really-official thread
    Quote from Tekkub
    It makes more sense as a separate spec to me. There's no reason to try to cram every possible feature into one spec, and status bars do not fit the "data source" spec... that is designed around displaying textual data, not graphical bars. It's not hard for your addon to just provide two different DOs, one for each spec.

    Besides, as a separate spec, it's easier to track what displays support it.


    Thanks for your comments, I was hoping you would reply... unfortunately those aren't the comments I was looking for. :(

    There's no reason to try to cram every possible feature into one spec
    Is there an actual reason not to?

    status bars do not fit the "data source" spec
    Well the plugin would still be a "source" of "data" for the display, whether it was displayed as text or a bar.

    designed around displaying textual data, not graphical bars
    But a picture is worth a thousand words. ;)

    The idea I had was to include everything from the current "data source" spec, just add the statusbar part. To make just a status bar spec without the parts already in the "data source" spec would be of no interest to me at all. Hence, what we are doing really is just adding to the current spec.

    It's not hard for your addon to just provide two different DOs, one for each spec
    Might not be hard, but I wouldn't do it, I'd just tell people to get a better display. I think it would be very messy, not to mention that displays that support both would now have two entries for each plugin.

    Besides, as a separate spec, it's easier to track what displays support it.
    I'm not seeing it. They either support statusbars or they don't, the user most likely wouldn't even know what a spec is.


    Quote from Elkano
    Wouldn't it make more sense to add fields like minValue, currentValue, maxValue to the spec which a display can use for creating a statusbar but for other representations, too? Meaning I wouldn't nail it to the bar representation since a display could also choose to display the data as cooldown on the icon or as simple "currentValue / maxValue" text or such. The color would then also be associated with the data and it's up to the display (or the user configuring it) to choose on how to use it eg for the bar itself or for the text.
    Thanks for your comments.

    a display could also choose to display the data as cooldown on the icon
    Thats also a very good idea.

    or as simple "currentValue / maxValue" text or such
    Problem is, I would want it to display both, the bar and the text. Also the text would mostly be far more complex than the simple "current / max" text I put in that sample XP bar.

    The color would then also be associated with the data and it's up to the display (or the user configuring it) to choose on how to use it eg for the bar itself or for the text.
    About half the plugins I've made already adjust the text color based on different values. We could do something like that, but I have a feeling it would make things too complicated for the average user, and most of them would just use the default settings of the display.

    Giving people what they want is nice (allowing them the ability to configure it themselves), but what's even better is giving them something they didn't even realize they would want (making such a good configuration to start with, that it's better than what they would have done, and they don't need to change it).

    We need somethingValue, somethingRed, somethingGreen, and somethingBlue. The other stuff is just making it way more complicated than it needs to be, as would adding a whole new spec. If we make a new spec, we have to go through all the stuff again: does label mean this or this , what does text in this spec mean...

    Simple is always best.
    Posted in: Data Broker AddOns
  • 0

    posted a message on LibDataBroker-1.1 not-really-official thread
    Take a look at this quick plugin I made:

    [PHP]
    local LDB = LibStub("LibDataBroker-1.1")

    local Broker = CreateFrame("Frame")

    Broker.obj = LDB:NewDataObject("Broker XP Bar", {
    type = "data source",
    icon = "Interface\\Icons\\SomeIcon",
    label = "XP",
    text = " ",
    barValue = 0,
    barR = 0,
    barG = 0,
    barB = 1,
    } )

    local function UpdateXP()
    local xp, max, rest = UnitXP("player"), UnitXPMax("player"), GetXPExhaustion("player")
    Broker.obj.text = format("%s / %s (%i%%)", xp, max, xp / max * 100)
    Broker.obj.barValue = xp / max
    Broker.obj.barR = rest and 0 or 1
    end

    Broker:SetScript("OnEvent", UpdateXP)

    Broker:RegisterEvent("PLAYER_ENTERING_WORLD")
    Broker:RegisterEvent("UPDATE_EXHAUSTION")
    Broker:RegisterEvent("PLAYER_XP_UPDATE")
    Broker:RegisterEvent("PLAYER_LEVEL_UP")[/PHP]

    This will work just fine in most display addons, right now. Of course the status bar parts will just be ignored.

    I think it would be simplest to just add to the current "data source" spec. This has a number of advantages, such as being backward compatible with all the current display addons. Plugin authors who wanted to update their plugins to add a statusbar could do just that, instead of having to make two versions so people still using a display that hasn't been updated could use the same version. It would also be less confusing as label would still be label, and text would still be text, etc.

    As far as the barMin and barMax attributes, I thought about it, and don't see a real need for them. It could just use a normalized value from 0 to 1.

    For borders and placement and stuff like that, it would probably be best to let the display handle all that according to what the user wanted. For instance, using Fortress, I would set mine up so the bar was the full size of the block, use the blocks border for the bar border, set the backdrop color to a much darker shade of the bars color, center the text on the bar, and set the icon to the left of the block. I doubt if many people would want a statusbar with a border inside a block with another border. Being able to change the bar texture using shared media textures would be great though.

    What do you think?
    Posted in: Data Broker AddOns
  • 0

    posted a message on LibDataBroker-1.1 not-really-official thread
    Hmmm, is this thread still alive? Anyway, I have an idea for adding to the spec which I think could be quite useful for many things.

    How about a Status Bar?

    Maybe something like this:

    Broker.obj = LibStub("LibDataBroker-1.1"):NewDataObject("Broker StatusBar", {
    type = "data source",
    icon = "Interface\\Icon",
    label = "StatusBar",
    text = format("%i %%", someValue / maxValue * 100),
    barMin = 0,
    barMax = 100,
    barValue = function() return someValue / maxValue end
    barR = 0,
    barG = 0,
    barB = 1,
    } )

    Any Comments?
    Posted in: Data Broker AddOns
  • To post a comment, please or register a new account.