Authors CurseForge

Thank you very much, pigmonkey! :)

I'll get some time tomorrow to fix those little other issues.

@louis:
The problem with hit-cap is unfortunately a bit difficult to fix. It is because for simplicity i am assuming that difference between +1 stat and +0 is the same as the difference between -1 stat and +0. Some methods for a quick fix would be:

1) make it aware of any stat-caps and 0 the value if you are exceeding it
2) add a -1 value in addition to the +1 values
3) complete calculation for every item

Quote from lymphatik »

It tell me to use 2x [Runed Living Ruby] (they are red gem whereas corruptor only get yellow socket)

And by using Runed Living Ruby + Veiled Noble Topaz I get a better score, thanks to the socket bonuus.

You dont get the socket bonus with Runed Living Ruby + Veiled Noble Topaz, because like you already said that the item got only yellow sockets.
Im trying to look into you other described errors.

@shadd
Fixed.

Updated ItemValue and ItemBonusLib to support ignore armor stat.

ItemValue_DrDamage should now work properly with non-generic spelldamage, if not please give me the spellname.

Added "IGNOREARMOR" bonusname and pattern used by many hyjal/bt items (Boundless Agony f.e.).

You can always set your profile to "Char" or "Class" instead of the global "Default", but setting the profile to char or class by default (at least for IV_DrD) would be useful. Though i couldn't commit the spell exist check yesterday.

@teedog
The "ItemValue-r43005\ItemValue.lua:796" error is fixed.

The "ItemValue-r43005\ItemValue.lua:1480" error shouldnt be possible at all, could you enable debugging and get me the chatframe output of an item that generates this error?

@Cold-Phoenix
Can't reproduce this error, looks like an invalid spellname or spellrank, what are you using?

Fixed in r43005.

@reevus
Sorting will be definitely possible soon.

@Astaldo
Just disable statpoints and weappoints, the group will add them together even if they are disabled.

Haste rating doesn't work for any item atm because of 2 missing patterns in ItemBonusLib, expect it to be fixed soon.

Haste and Spellhaste rating pattern seem to be missing:

{ pattern = "Improves haste rating by (%d+).", effect = "CR_HASTE"},
{ pattern = "Improves spell haste rating by (%d+).", effect = "CR_SPELLHASTE"},

Externals error is fixed now.

Quote from Azide »

Is the "Best" [Item Modifications -> Jewels -> Best] option currently broken?

Its at the moment not functionally but it will be in a few days with the multiple default jewels.

Fubar plugin and the new /itemvalue command should take care of this issue.

The main reason for the short command /iv is because /iv bj [link] (the new best jewels syntax) is just fast to type.

This will work (at least for me) with WoW 2.1.2.6803 (current version):

-- BUFF - Big Ugly Fat Fellow (or Fucker) The US Airforce nickname for the B-52 bomber.

DreamBuff = AceLibrary("AceAddon-2.0"):new("AceEvent-2.0", "AceConsole-2.0")
-------------------------------------------------------------------
local _G = getfenv(0)

local zoom1 = 3
local zoom2 = -zoom1

function DreamBuff:OnEnable()
	DreamBuff:SkinButton(TempEnchant1, 0.8, 0, 1, 1)
	DreamBuff:SkinButton(TempEnchant2, 0.8, 0, 1, 1)
	
	for i=1, BUFF_MAX_DISPLAY do
		local button = _G["BuffButton"..i] or CreateFrame("Button", "BuffButton"..i, BuffFrame, "BuffButtonTemplate")
		DreamBuff:SkinButton(button, 0, 0, 0, 0.6)
	end
	
	for i=1, DEBUFF_MAX_DISPLAY do
		local button = _G["DebuffButton"..i] or CreateFrame("Button", "DebuffButton"..i, BuffFrame, "BuffButtonHarmful")
		DreamBuff:SkinButton(button, 0, 0, 0, 0.6)
	end
end

function DreamBuff:SkinButton(Button, cR, cG, cB, cA)
	local ButtonName = Button and Button:GetName()
	if not ButtonName or _G[ButtonName.."BG"] then return end
	
	local background = CreateFrame("Button", ButtonName.."BG", Button)
	background:SetBackdrop({
		bgFile = "Interface\\Tooltips\\UI-Tooltip-Background",
		tile = true,
		tileSize = 1,
		edgeFile = "",
		edgeSize = 0,
		insets = {left = 0, right = 0, top = 0, bottom = 0},
	})
	
	background:SetBackdropColor(cR, cG, cB, cA)
	background:ClearAllPoints()
	background:SetPoint("TOPLEFT", Button, "TOPLEFT")
	background:SetPoint("BOTTOMRIGHT", Button, "BOTTOMRIGHT")
	background:SetFrameLevel(0)
	
	if _G[ButtonName.."Border"] then 
		_G[ButtonName.."Border"]:Hide()
		_G[ButtonName.."Border"].SetVertexColor = function(self, cR, cG, cB, cA)
			background:SetBackdropColor(cR, cG, cB, cA)
		end
	end
	
	_G[ButtonName.."Icon"]:ClearAllPoints()
	_G[ButtonName.."Icon"]:SetPoint("TOPLEFT", ButtonName.."BG", "TOPLEFT", zoom1, zoom2)
	_G[ButtonName.."Icon"]:SetPoint("BOTTOMRIGHT", ButtonName.."BG", "BOTTOMRIGHT", zoom2, zoom1)
	_G[ButtonName.."Icon"]:SetTexCoord(0.07, 0.93, 0.07, 0.93)
end

Edit: Optimized a bit

ItemValue_DrDamage is ready for testing (http://files.wowace.com/ItemValue_DrDamage).

Just enter a spell name and the rank.
If you set Update Mode to "Saved Values" you can save your raidbuffed values f.e.

Note that all values are scaled based on the value of spelldamage (which always gets a value of 1).

Screenshot:

Externals should be fixed now, thanks.