Authors CurseForge

I was noticing this issue as well but wasn't able to track it down to any specific addon. While I'm not happy that there's a bug, I'm glad it's not my bug.

I pretty sure that a marker on a non-combat pet shows up on your unitframes, as long as it's your "target", "targettarget", "focus", etc.

It's just that there's no unitID like "raidcompanionX" or "raidcritterX" like there is for "raidpetX" so you can't include non-combat pets in party/raid frames.

I'm really not sure what you call an issue with DBM... It uses specific markers to specific things during an encounter and as there can only be one marker on a unit at a given time, their previous marker gets overwritten. Using the non-combat pet makes it easy to use a static marker for a player's position. That way if there's ever an offtank you need to run to for some reason, you just have to look for (hypothetically) diamond and don't have to worry about their marker having been replaced.

Quote from lilsparky

since they don't affect game play, there's no reason to be able to select them or target them or anything, right? so a lack of an api is just a reflection of this.

While they don't affect combat, I wouldn't say that they don't affect gameplay. It's a common technique to pull out a non-combat pet and put a raid marker on him to mark a player's location. The non-combat pet won't have his marker replaced/changed by DBM (provided you use a marker DBM doesn't use for that encounter).

Quote from Tekkub

Someone is probably after a "help me harass people that have pets out in a raid because I'm an asshole raid leader" addon.

...or... somebody wants to iterate through the raids non-combat pets and see if any of them have markers on them and then associate those markers with players. Maybe that somebody wants to do this so when they broadcast healing assignments for a specific tank they can also include that tank's non-combat pet's marker in the message thankyouverymuch Thomas Hobb-, er Tek. ;)

@egingell: I believe you're right and those are only for combat pets. I think Blizzard technically calls them "companions" but I haven't found any sort of API reference to them other than functions that pull them out and put them away.

Is there a unitId for a player's non-combat pet? I want to be able to iterate through a raid and check to see if each player has a non-combat pet out, and it they do, see if there is a raid target icon on the pet.

Thanks.

Quote from Ammo

Sorting is personal. Order of blizzard maintanks is random.

I just want to make sure I'm understanding correctly...

Calling GetSortedTanks returns PersonalTanks+BlizzTanks in the order defined in your oRA3 window. However, there's no way to get only Blizz tanks from oRA3, and even if there was, there's no way to guarantee a consistent ordering across all members of the raid?

Also, not to be argumentative, but where is the "Sorted" part in "GetSortedTanks()"? It almost seems like it should be called "GetListedTanks()" because if I'm reading you correctly, there's no actually sorting going on.

It also might be nice to have a function called "GetBlizzardTanks()" that only returns Blizzard tanks, as opposed to all tanks. Likewise, there could be a similar function called "GetPersonalTanks()" that would return only private tanks.

Just a quick question regarding the sorted list for main tanks: does calling GetSortedTanks return both private and public main tanks, or just public? If it's both, is there any way to get only public main tanks? Also, is the order of public main tanks the same for everybody running oRA3?

Bartender4 has options for this.

Have you verified that "name" is actually a player name and not a UnitID like "raid1", etc?

@Greltok:

The only thing I can think of is that for whatever reason your inspect flag isn't getting set properly. Have you tried using a different (possible less elegant) method for setting that?

if (UnitIsUnit("player",name)) then
     InspectFlag = false;
 else
     InspectFlag = true;
 end

I'm also assuming that you're setting "playerName" someplace outside the function. Is it possible you're having a problem with variable scoping that's resulting in "playerName" always being nil inside the function?

@Greltok:

I don't see why you're always getting your talent info back, but there is one thing I did notice. I found that when trying to get the current talent info from another player I had to request a specific talent group from the player otherwise it always recalled the first spec.

Use GetActiveTalentGroup() to find out which spec they're using, then GetTalentTabInfo(tab,inspect,isPet,talentGroup).

I don't know how many people you tested with, but if their first spec is the same as yours, it may appear that you keep getting your spec back but you're not.

Also, my personal opinion is that if this lib is just a queuing system for talent inspections, I'd rather do it myself.

Quote from yssaril

v4 has release notes and i don't think they will take the time to add an entirely new feature to an "old" program that is being replaced "soon"

I don't really care if the release notes are in the client or available on the web.

Ya know what drives me bonkers? WHen CC installs an update to itself and doesn't provide any release notes. I know they're mostly bug fixes and such and most development is directed at 4.0, but I'd still like to see them.

Quote from Torhal

Ok, latest version has tooltip:SetCellColor().

Do SetLineColor, SetColumnColor, and SetCellColor set the background color of their respective areas, or the text color?

What are the paths for the single-textures for the raid target icons? I can't seem to find them anyplace and would prefer to not have to slice them up myself.

Thanks.