that way if btndata isn't passed it will default to the defaults as well as making it easier to remove buttons as you are storing the reference to the button and not the btndata.
dammit, when self and any other modifier key is down SecureButton_GetModifierPrefix(button) returns just "self-" and not "self-ctrl" etc, anyway around this other than forgetting about self and using alt?
Bugs:
AOE mode doesn't work (at least when solo)
If you don't have oRA loaded you get an error when trying to go into Healer mode (should probably default to Blizzards MTs if the selected MT addon isn't loaded).
Well the mod I made modifys UnitDebuff so that you can see how much Hunters Mark has stacked since you can't see this normally and in order for Unit Frames and other addons to update the stack count I need to manually make it update and this seemed like the cleanest, fastests way to do that.
First of all I know this is generally a bad idea but because of what I needed the mod to do I thought this was the best way to go around it.
I obviously want a fast and cheap way to do this and I'm wondering if it's possible to improve what I've come up with below:
local _G = _G
local GetFramesRegisteredForEvent = GetFramesRegisteredForEvent
local select = select
local UnitGUID = UnitGUID
local units = { target = true, focus = true, }
function addon:UpdateAuras(GUID)
if not GUID then return end
_G.event = "UNIT_AURA"
for i=select("#", GetFramesRegisteredForEvent("UNIT_AURA")), 1, -1 do
local frame
for unit in pairs(units) do
if UnitGUID(unit) == GUID then
frame = frame or select(i, GetFramesRegisteredForEvent("UNIT_AURA"))
_G.arg1 = unit
frame:GetScript("OnEvent")(frame, "UNIT_AURA", unit)
end
end
end
_G.event, _G.arg1 = nil, nil
end
Also, is it a bad idea to trigger this event during an different event or should I wait till the next OnUpdate?
SPELL_SUMMON has the standard spell prefix and an empty postfix argument structure, adding to first post.
I have yet to find a way to create SPELL_CREATE events, any hints welcome. My guess is that it also has an empty postfix but this is not verified at all.
Yes, Antiarc and me optimized the whole Blizzard_CombatLog to use a lot of local upvalues instead, its quite apparent that the last commit was almost a direct .diff file generated from my last commit without edits to remove some of my comments.
Hmm, Zeksie, what are you trying to do? I'll get back to Antiarc and Alexander about un-local-ing some of those things.
Would
function globalFunction()
end
local globalFunction = globalFunction
work?
Also, its probably best not to rely on the combatlog functions since its LoD
There are two new combat log events for the next test realm update:
SPELL_SUMMON
SPELL_CREATE
These are sent with the guid and name of the creature or object that is created by a spell (along with who cast it, naturally)
guid = UnitGUID("unit")
Returns a string representing a unique identifier for the given unit. This is the same string that is used in the combat log to identify a unit.
0
that way if btndata isn't passed it will default to the defaults as well as making it easier to remove buttons as you are storing the reference to the button and not the btndata.
0
0
How do I go about adding the SELFCAST modifier?
Edit: Ok I've got:
and while self+click selfcasts works, self+ctrl+click tries to selfcast Healing Touch on me, any help? (selfcast is alt)
0
AOE mode doesn't work (at least when solo)
If you don't have oRA loaded you get an error when trying to go into Healer mode (should probably default to Blizzards MTs if the selected MT addon isn't loaded).
0
0
I obviously want a fast and cheap way to do this and I'm wondering if it's possible to improve what I've come up with below:
Also, is it a bad idea to trigger this event during an different event or should I wait till the next OnUpdate?
0
Maybe Healthstones / Spellstones / Firestone / Mana Gems / Food etc
0
0
No idea what UsesGUID does, it always returns false. I've tried:
and they all return false.
0
Would
work?
Also, its probably best not to rely on the combatlog functions since its LoD
0
http://forums.worldofwarcraft.com/thread.html?topicId=2968233433&postId=49757555677&sid=1#473
From the looks of it it'll be sent like this :)
0
Also, please add LibSharedMedia-2.0 to the optional dependencies :)
0
Actually we have that on live (though maybe its not documented). GetQuestLogRewardTitle got added though.
Decided to see what they removed as well:
0
0
http://forums.worldofwarcraft.com/thread.html?topicId=2968233433&postId=47749334207&sid=1#416