Sorry for the lack of updates, I've been sick these last 2 weeks and had course work to do.
I've got it mostly working, just need to do positioning, ButtonFacade support, macro support, and allowing you to drag spells/items/macros into the buttons (which will be possible in combat).
Hi,
I've come back to WoW for WotLK and while I won't use it, I'll rewrite Poppins for the new 3.0 secure frames if someone will maintain it for me. So far I've found the new secure frames to be far easier to learn, easier to write and provide more flexibility.
So, checked it out and I gotta say... it is great, it is beautiful! you?ve done a terrific job Sorata :)
Since I basically was doing the same thing (just...not working ;) ) I have some ideas for example for modules.
Would you mind a feature commit now and then or would you prefer branching/code posting or whatever suits you?
I personally do not see much of a point in maintaining Numen any longer, from what I can tell from my memory there is basically only the Mana tide announce missing (easily replaceable by for example SpellAnnounce) and the automatic button creation (well, 5 minutes). But it is mainly Avianas child, just speaking for myself.
Thanks :)
If you want to make a new module you can obviously go ahead and make one and add to the trunk. If you want to add any features the any of the non-module then I'd prefer you branche it and ask (unless I've said I'll do it eventually). If you want to modify any of the modules, you can without asking but only if its a feature that changes the buttons in someway, I don't really want something like the Mana Tide announce as that can be done entirely without the addon even loaded. If you want to do any bug fixes you are free to do so.
Unfortunatly I have done something very stupid and had an idea for a Buff button addon (already commited the framework for it i /branches/Buffalo3/Sorata (waiting on permission to use the name)) which looks and acts alot like Poppins and is easy to use from the user perspective but VERY customisable from a module perspective. Why is this a stupid thing? Because addon ideas don't stop bugging me until I write them and they spawn more ideas.
(Very) Minor thing but in your options table I noticed that you are creating a new function for every option when you could technically use 1 function for each.
On my local copy I've updated the options to removes all dynamically created functions and replace them with a reference to a local function. Below is a diff patch of it:
I second the above request, because I would like the popup buttons to be on top of my UnitFrames instead of covered by them.
And I have another request:L
After my update today, my buttons -using the Apathy skin- are too close together for my taste when I stick them together. I can adjust the padding between the pop-up buttons now, wich is great. However it would be great if the padding between stickied groups of buttons was configurable aswell.
Great mod btw :)
Already had this planned for last night, I'm going to move the ButtonFacadeSkins module to ButtonFacade and letting you add padding for buttons.
Quote from highend »
Hi,
Small feature request:
It'll be nice if we could adjust the frame strata (per Button). All popup buttons share the same strata as their respective main button (so the strata has only to be set for this button).
Regards,
Highend
Sure
Quote from Philosound »
Arghs, why do I see this this late?
Been sitting on porting Numen to Ace3 for a while ;)
Well then *trying out the plugin and inspecting the code*
Sorry :) This was really done to checkout Ace3 and I decided to make is useable for all classes. I personally don't use it for anything more than Numen did :P
Hah no idea yet. I just accidentally looked at your forum and was gonna mention LibStickyFrames until I saw that it was already using it! Soon as I switch to 2.0 Ill let you know what I think. I am assuming the stuff u added generalizes it to handle buttons and not just bars.
I renamed the forum 2.0 and moved the wiki to 2.0 as well.
It should work with any frame. I've been using LibStickyFrames since I started working on Poppins and I noticed that there was a long list of stuff that hadn't been added yet and it hadn't been updated in awhile so I though I'd start adding the things I wanted from it. I was also unhappy with just having a single :Register to register all frame settings so I started rewriting the API for it as well.
Changes:
[list
[list][*]Insets are taken into account when checking overlapping.
[*]Overlays are created by the mod and recycled when not in use
[*]Grouping can be added, its potentially very powerful I think
[*]Overlays are coloured based on whether the frames are enabled or not, hidden or can be attached to when being dragged
[*]Callbacks is moved to CallbackHandler-1.0
[*]Callback for clicking on an overlay which allows the mod to decide whether to enable, disable or hide
[*]Assuming the frame isn't anchored, when insets are updated the positioning of the frame is updated along with any frames attached to it
[*]Shows hidden frames temprarily when the sticky group is set and hides them when the sticky group is unset.
[/list]
Thanks for your work on LibStickyFrames. If you could document your changes and mention them here: http://www.wowace.com/forums/index.php?topic=9752.0
and http://www.wowace.com/wiki/LibStickyFrames-2.0
it would help other authors to switch to 2.0 etc. Yes I know documentation sucks but there u go. I almost added group dragging to 1.0, I will add them to 2.0 instead and switch AutoBar to use that.
Np, I have actually just finished documenting the file. I'll upload that to the svn now and start adding it to the wiki. If you have any suggestions for improvements or any critisism I am more than happy to listen :)
Why do you need multiple callbacks? Just save the passed settings to your database. I'd rather not complicate the system unless there's a good reason.
Well I've got one in my addon that saves the changes and then I have a module that updates the buttons insets depending on what skin is used. I was able to hook it once I realised Buggrabber wasn't printing error messages to the chat frame.
I've just noticed that you can't register more than one callback per addon, any chance you could change that?
something like this should work:
local callbacks = {}
local function fireSkinCB(SkinID,Gloss,Backdrop,Addon,Group,Button)
local args = callbacks[Addon]
if args then
for arg, callback in pairs(args) do
callback(arg and arg,SkinID,Gloss,Backdrop,Group,Button)
end
end
end
function lib:RegisterSkinCallback(AddonID,callback,arg)
local arg = callback and arg or false
callbacks[AddonID] = callbacks[AddonID] or {}
callbacks[AddonID][arg] = callback
end
Just wondering, would making the button/buttons parent not parent the UIParent frame (and therefore not take it's scale into account) and then allowing the user to set the buttons scale "fix" this or at least make it look better?
Abit late now but you could have reset any buttons that were attached to another button (there is a new option in the button options to do this), after that you can place them again and it should work.
I'm happy with the API and functionality of LibStickyFrames-2.0 now and I'm going to get back to work on adding a few of the requested features I've been putting off.
0
I've got it mostly working, just need to do positioning, ButtonFacade support, macro support, and allowing you to drag spells/items/macros into the buttons (which will be possible in combat).
0
I've come back to WoW for WotLK and while I won't use it, I'll rewrite Poppins for the new 3.0 secure frames if someone will maintain it for me. So far I've found the new secure frames to be far easier to learn, easier to write and provide more flexibility.
0
Thanks :)
If you want to make a new module you can obviously go ahead and make one and add to the trunk. If you want to add any features the any of the non-module then I'd prefer you branche it and ask (unless I've said I'll do it eventually). If you want to modify any of the modules, you can without asking but only if its a feature that changes the buttons in someway, I don't really want something like the Mana Tide announce as that can be done entirely without the addon even loaded. If you want to do any bug fixes you are free to do so.
Unfortunatly I have done something very stupid and had an idea for a Buff button addon (already commited the framework for it i /branches/Buffalo3/Sorata (waiting on permission to use the name)) which looks and acts alot like Poppins and is easy to use from the user perspective but VERY customisable from a module perspective. Why is this a stupid thing? Because addon ideas don't stop bugging me until I write them and they spawn more ideas.
0
Update LibAbacus-3.0, I think that will probably fix it
0
On my local copy I've updated the options to removes all dynamically created functions and replace them with a reference to a local function. Below is a diff patch of it:
0
Or possibly update the countdown only once a second and only update the other stuff based on the current update
0
0
Already had this planned for last night, I'm going to move the ButtonFacadeSkins module to ButtonFacade and letting you add padding for buttons.
Sure
Sorry :) This was really done to checkout Ace3 and I decided to make is useable for all classes. I personally don't use it for anything more than Numen did :P
0
It should work with any frame. I've been using LibStickyFrames since I started working on Poppins and I noticed that there was a long list of stuff that hadn't been added yet and it hadn't been updated in awhile so I though I'd start adding the things I wanted from it. I was also unhappy with just having a single :Register to register all frame settings so I started rewriting the API for it as well.
Changes:
[list
[list][*]Insets are taken into account when checking overlapping.
[*]Overlays are created by the mod and recycled when not in use
[*]Grouping can be added, its potentially very powerful I think
[*]Overlays are coloured based on whether the frames are enabled or not, hidden or can be attached to when being dragged
[*]Callbacks is moved to CallbackHandler-1.0
[*]Callback for clicking on an overlay which allows the mod to decide whether to enable, disable or hide
[*]Assuming the frame isn't anchored, when insets are updated the positioning of the frame is updated along with any frames attached to it
[*]Shows hidden frames temprarily when the sticky group is set and hides them when the sticky group is unset.
[/list]
List tags are malformed.
0
Np, I have actually just finished documenting the file. I'll upload that to the svn now and start adding it to the wiki. If you have any suggestions for improvements or any critisism I am more than happy to listen :)
0
Can you elaborate?
Try updating LibStickyFrames-2.0
0
Well I've got one in my addon that saves the changes and then I have a module that updates the buttons insets depending on what skin is used. I was able to hook it once I realised Buggrabber wasn't printing error messages to the chat frame.
0
something like this should work:
local callbacks = {} local function fireSkinCB(SkinID,Gloss,Backdrop,Addon,Group,Button) local args = callbacks[Addon] if args then for arg, callback in pairs(args) do callback(arg and arg,SkinID,Gloss,Backdrop,Group,Button) end end end function lib:RegisterSkinCallback(AddonID,callback,arg) local arg = callback and arg or false callbacks[AddonID] = callbacks[AddonID] or {} callbacks[AddonID][arg] = callback endEdit: You also can't hook it :(
0
0
Abit late now but you could have reset any buttons that were attached to another button (there is a new option in the button options to do this), after that you can place them again and it should work.
I'm happy with the API and functionality of LibStickyFrames-2.0 now and I'm going to get back to work on adding a few of the requested features I've been putting off.