• 0

    posted a message on Skillet - the lilsparky branch
    Quote from lilsparky
    yeah, i know. the queue is really in need of some love. what you can do in this case is revert to the normal crafting window (hold shift when firing up skillet) and then do a quick manual craft that way.
    .


    I love you!!!!!!!!!!

    I had no idea about this. I craft glyphs almost every day and every single time I end up needing to craft extra ink somewhere along the way because packet loss causes skillet to craft an extra glyph or five. I look forward to never having to reloadui for the default tradeskill window or clear a queue of 700 glyphs again. I could seriously send you an e-kiss right now. I had figured some day I'd modify skillet to always prioritize crafting mats before crafting end products, but this is an entirely acceptable alternative. Now if I could just get it to buy my ink for me more often than randomly once every few days, I'd be at serious risk of being banned for using too much automation. :p
    Posted in: General AddOns
  • 0

    posted a message on Skillet - the lilsparky branch
    Quote from lilsparky
    thanks for the tip about the LoadAddon thing. that'll help me debug things.


    There's nothing left to debug really. I forgot that you aren't the sole original author of Skillet. You'll see what's happening as soon as you look at the code, but I'll quote it to save you the trouble.

    	if (not IsAddOnLoaded("Blizzard_TradeSkillUI")) then
    		LoadAddOn("Blizzard_TradeSkillUI");
    	end
    
    
    
    	self.BlizzardTradeSkillFrame = TradeSkillFrame
    	self.BlizzardTradeSkillFrame_Show = TradeSkillFrame_Show
    
    	TradeSkillFrame_Show = DoNothing
    


    This is in the initialization function, so if it happens to execute before this PLAYER_LOGIN business, it will fail with a null return. Thus, blizzard tradeskill will load after this and the function will point to the default blizzard function. For now, I've just moved the above code so that it doesn't run until I tell it to once my ui is loaded. Not an acceptable solution, but it "just works."
    Posted in: General AddOns
  • 0

    posted a message on Skillet - the lilsparky branch
    Quote from Burnum
    Fixed the wrong Engineering items by dumping all my skillet.lua saved vars.

    Numbers2 I'm in the same boat, I get both windows 100% of the time now. Never saw it do that before 3.2


    Just use this command if it really starts to get on your nerves. Otherwise wait until someone fixes it the right way.
    /script TradeSkillFrame_Show = DoNothing
    Posted in: General AddOns
  • 0

    posted a message on Skillet - the lilsparky branch
    Disregard all that.
    Quote from "wow forums green post" »
    Patch 3.2 broke Blizzard's LoadAddOn(), and it now only works post-PLAYER_LOGIN, not before that. Looking into this further.


    I don't know wow well enough to code an acceptable workaround for this, but I expect I'm in the minority. For now I've just moved the function changing code to a place where it really shouldn't be.
    Posted in: General AddOns
  • 0

    posted a message on Skillet - the lilsparky branch
    At least for me, this appears to have stopped working:
    TradeSkillFrame_Show = DoNothing

    "Do Nothing" never gets printed to chat (yes debugspam is uncommented), and "/script TradeSkillFrame_Show()" still shows the default blizzard frame. DoNothing() functions as intended when called with "/script DoNothing()". Also, if I run the offending code with /script, everything works as it should.

    I don't know anything about lua or wow's api so I don't really know what's wrong. I'm just sharing my observations.
    Posted in: General AddOns
  • 0

    posted a message on Skillet - the lilsparky branch
    Quote from lilsparky
    still investigating this. i haven't seen the dual window problem since patch day. maybe i'll try changing my window hiding code...


    You get props if you manage to fix something you yourself can't reproduce. Since it does it for me 100% of the time now, why not clue me in on what you're thinking of changing and I'll play around with it a bit?
    Posted in: General AddOns
  • 0

    posted a message on Skillet - the lilsparky branch
    Quote from lilsparky
    okay, so ink of the sea can be converted to any other ink at the vendor? can you buy inks with cash or is it only ink for ink? if it's just ink for ink, then i wouldn't call that a purchasable item. it wouldn't be hard to add a special "recipe" that converts ink of sea into another ink (one recipe per ink).


    Right. All of the "lesser" inks can each be purchased for one ink of the sea. Purchases can't be made with gold. Does skillet currently have any automatic conversions like this that I can use as a reference for doing inks? If so, I assume it would be as simple as copying some code, changing some item id's, and replacing a /use function with whatever function is used to purchase from a vendor.
    Posted in: General AddOns
  • 0

    posted a message on Skillet - the lilsparky branch
    Quote from Oddible
    I'm having all of my items scramble sorted. Inks are mixed in with glyphs, some headings exist some don't post 3.2.


    Using what sorting? I haven't noticed any scrambling yet and I've so far used none, lsw profit, difficulty, and alphabetical with both blizzard and no grouping since 3.2.
    Posted in: General AddOns
  • 0

    posted a message on Skillet - the lilsparky branch
    Quote from Burnum
    not hiding the standard profession window in 3.2


    For me it did that somewhat frequently even before 3.2. Now it does it almost always.



    What would be involved in getting Skillet to understand the purchase of inks from the vendor for inscription? I assume it would consist mostly of additions to libperiodictable, but I haven't quite figured it out. Nothing I do gets it to add the inks to my shopping list instead of the pigments, and it keeps adding them to the queue to be crafted. I've given up for now so as not to waste too much time on it in case it's a lot more complicated.

    What really has me stalling is the fact that two times in the one week I've been a scribe I've actually seen the "Buy Reagents" button at the ink vendor. It's been completely random and I haven't been able to recreate it. I don't remember if it was the same ink both times, but I think it was. It only added the one ink even though every time I go I need at least one of almost all inks.

    I know you've said you aren't a scribe, sparky, so in case you wonder why this matters to us: scribes don't actually buy low level herbs to mill into pigments, we don't buy or sell pigments to make into inks; we only buy northrend herbs to mill into pigment and make into ink of the sea, and then trade those inks 1:1 at the vendor for the lower level inks we need. Unfortunately inscription is somewhat unique in this and a few other ways, so it would take a bit of inscription-specific work to both LSW and Skillet to make the crafting process as fluid for inscription as it is for other professions. This would be a great first step though and I plan to do as much of the inscription-specific work as I can.
    Posted in: General AddOns
  • To post a comment, please or register a new account.