• 0

    posted a message on Fubar_DPS
    Quote from Antiman »

    Hey Knagh, have you tried to get in touch with Rophy to make sure it's ok to commit the changes to his addon? I'm going to send him an e-mail, and also request SVN access so I can get these changes committed ASAP, but I thought I would check with you to make sure you haven't already done the footwork. :-)


    Nope. I got as far as asking about svn access on #wowace, and decided that, from the responses I got, noone really cared about getting it working, only about getting it working _in the right way_...While my philosophy was more: get a stake in the ground, *then* make it "right"....(cos that goalpost's going to change) </rant :)>

    Which is why I posted here, and left it at that. Feel free to beat your head against that particular wall :) Maybe you'll get a better response than I did.
    Posted in: FuBar AddOns
  • 0

    posted a message on Fubar_DPS
    Quote from Antiman »

    Since Knagh hasn't posted in a month, and because no changes have been committed to FuBar_DPS, I've gone ahead and taken Knagh's FuBar_DPS.lua and removed ParserLib from it, as well as cleaned up the CombatLog parsing and such. I've tested it and everything seems to work as expected, and I can't find any other events being triggered that would indicate that the DPS/HPS calculations will be off by a great deal, so I'm going to post my changes here. If nobody objects in a day or two, I'll go ahead and commit them into SVN.

    Note that because .toc files can't be attached to posts, I added a .txt extension to that file; just remove it and everything will be fine.

    Thanks to Knagh for figuring out the solution!


    Looks nice to me :)

    I like the refactoring you've done - some of it I'd thought about, other stuff I hadn't . Always good to see other people's take on coding :)

    I've only used it on one toon so far, but not seen any issues. I should probably have run them side-by-side, now I think of it. Oh well.
    Posted in: FuBar AddOns
  • 0

    posted a message on Fubar_DPS
    Excellent. Thanks for the feedback.

    I am fairly sure I have left one of the damage-reporting events out, but I haven't seen it being triggered for me yet. I'm not sure what causes it to get fired - it might mean that the numbers are a little off, that's probably about it.
    Posted in: FuBar AddOns
  • 0

    posted a message on Fubar_DPS
    OK. I got round my issues - it was me being silly with lua, not the API being incorrect ;D

    This is a *very* hacky 'get it working' solution, hence why I'm posting it here, rather than putting it in the svn.

    Use at your peril!

    I would be happy to hear all criticism of my crappy coding. Especially anything that makes it better.

    I intend to follow a suggestion to remove ParserLib from it completely, and I believe that once that's done it can be svn'd.
    Posted in: FuBar AddOns
  • 0

    posted a message on Fubar_DPS
    Just a follow-up. I did a bit of digging in the source, and it is (obviously) because of the changes in 2.4 that remove the CHAT_MSG_(COMBAT|SPELL)_* events and replace them with the COMBAT_LOG stuff.

    I've been trying to figure out how this works, but so far the API docs and what I'm seeing don't quite tally for some reason. Will keep tinkering unless someone fixes it first :D

    I have a feeling that it might be possible to use the (also new) combat log filtering API, but I haven't had the courage to examine that too deeply!
    Posted in: FuBar AddOns
  • 0

    posted a message on Fubar_DPS
    I also find that it is not working - the DPS (etc) values are not being calculated, and remain at 0.0
    Posted in: FuBar AddOns
  • To post a comment, please or register a new account.