• 0

    posted a message on AutoBar by Toadkiller (official thread)
    Just want to confirm the bug above. It causes ItemPriceTooltip, Outfitter, and EnhTooltip to bug in their hooking code because GameTooltip:SetBagItem() is being called with a nil as the first argument.
    Posted in: General AddOns
  • 0

    posted a message on prat error
    I have committed a fix for this error. Update again in a few minutes.
    Posted in: AddOn HELP!
  • 0

    posted a message on Prat 2.0 Chat Mod Framework (Official Thread)
    Getting the following error:

    [2008/04/14 11:15:31-3139-x1]: Prat-2.0 68549.69597\Prat.lua:1363: bad argument #1 to 'strfind' (string expected, got nil)
    Prat-2.0 68549.69597\Prat.lua:1363: in function <Interface\AddOns\Prat\Prat.lua:1351>
    (tail call): ?:
    (tail call): ?:
    (tail call): ?:
    Interface\FrameXML\ChatFrame.lua:1889: in function <Interface\FrameXML\ChatFrame.lua:1882>:
    (tail call): ?:
    (tail call): ?:
    <string>:"*:OnEvent":1: in function <[string "*:OnEvent"]:1>


    The fix is probably just checking if arg1 is a string at line 1363 in Prat.lua. I will commit the fix soon if nobody objects.

    Edit: Committed fix.
    Posted in: General AddOns
  • 0

    posted a message on Enforcing use of svn:externals
    Quote from Pachelbel »

    And while I appreciate you going in and fixing the issue, wouldn't it be easier to simply contact the author (when a contact address is available) and give them the chance to fix it first, instead of trying to fix all the addons yourself?


    Yea, it might be. That's in part why I wrote this. But I don't see any straight-forward way of contacting the author of Palatank. I think there really needs to be a forum thread for all addons on the SVN. Or at least an author should include contact details in his addon. I can see that he releases on Curse. But I'm not personally going to go the round-about way of contacting him there about this issue.
    Posted in: Libraries
  • 0

    posted a message on Standard options for profile management
    Quote from Snago »

    Imo "Default" should be the default profile and addons that have a good reason to use character specific profiles should have to specify this themselves.


    I agree, but it has already been voted down: http://jira.wowace.com/browse/ACE-114

    Posted in: Ace3
  • 0

    posted a message on Question about the BAG_UPDATE event
    The reason it works using AceEvent_FullyInitialized is probably just that this event is fired very late. I think you could just as well start a timer and do your stuff after 2-3 seconds. That would be about as safe or unsafe. :P But since AceEvent_FullyInitialized is already there, it seems fine to just use it. Just remember that if you plan to rewrite to Ace3 at some point, you will need to come up with something else as Ace3 does not have this special event.
    Posted in: Lua Code Discussion
  • 0

    posted a message on Enforcing use of svn:externals
    There seems to be some new authors who have not read up on how to use svn:externals to avoid checking in copies of libraries that already exist on the SVN. Just now I noticed that the addon Palatank has checked in a bunch of Ace2 libraries without any use of svn:externals. I don't know how to contact the author about this as there seems to be no forum thread for his addon.

    This is not the first time and it will likely not be the last. I have attempted to correct such mistakes a few times before. But I'm not the "police" of the SVN in any way. Someone with a more "official" status ought to delete those libraries from said addon.

    Should the use of svn:externals be enforced better than it is now? Is there too little or too poor documentation about what to do and what not to do on the SVN? And should an author be forced to make a forum thread for his addon so that we at least have a way of contacting him about such problems?

    Posted in: Libraries
  • 0

    posted a message on When are your bags ready to be read after login?
    Quote from Thaoky »

    Also Bam, Tekkub is right, only saving item id's will usually be enough, the only thing that it will not provide is the full itemString containing enchants+jewels.


    Well, my original intention was to save all information that GetItemInfo returns so as to be sure that I could handle the item properly later on. But I've changed my code since then. It is after all not very often that the cache gets cleared.
    Posted in: Lua Code Discussion
  • 0

    posted a message on Question about the BAG_UPDATE event
    Basically the same subject was discussed in this thread: http://www.wowace.com/forums/index.php?topic=11401.0

    As you can see I did some investigation into when and how many BAG_UPDATE events get called during login. I specifically wanted to know when valid information could be retrieved. Since then I've changed my code to not needing more than just the item-id (or item-string rather).

    The excessive amount of BAG_UPDATEs only fire when the client cache has been cleared. As this doesn't happen often, I don't think you need to worry too much about the number of events during login. And as others have mentioned, if you throttle event handling appropriately using OnUpdate somehow, there should be no trouble at all since the majority of the extra BAG_UPDATE events are fired even before the first OnUpdate is ever called.

    A very simple example of such throttling code could be this:

    do
     local frame = CreateFrame("Frame")
     frame:Hide()
     local bags = {}
     frame:SetScript("OnUpdate", function(self)
      for bagId in pairs(bags) do
       bags[bagId] = nil
       -- handle update for bagId
      end
      self:Hide()
     end)
     frame:SetScript("OnEvent", function(self, event, bagId)
      bags[bagId] = true
      self:Show()
     end)
     frame:RegisterEvent("BAG_UPDATE")
    end


    In practice you will probably not need to handle updates this often. So you could insert a timer to throttle it even more.
    Posted in: Lua Code Discussion
  • 0

    posted a message on MouseLook - official thread
    Quote from ugh »

    Ah, I misunderstood. (Is it obvious that I don't use this mod?)


    This version of MouseLook does what you think it does. :) I guess Trimble has taken the opposite approach so to speak. Both are of course valid. But I think they cater to very different playing styles.

    Btw, the best mouselook-mode I've seen in a game was the one in Star Wars Galaxies. It was sort of a combination of the two modes mentioned above. That is, there was a small area in the center of the screen where the mouse could move freely. When you moved the mouse to the edge of that area, your char turned. You would exit this mode by right-clicking IIRC. The result was that you often did not have to worry about what mode you were in. Most of the time the things you want to click will be right in front of your char anyway. :)
    Posted in: General AddOns
  • 0

    posted a message on ItemPrice-1.1 (official thread)
    Sadly, I have been unable to mine from the armory lately. For some reason the website becomes "busy" shortly after starting to mine prices. I hope this is not some deliberate action by Blizzard to prevent datamining. Anyone have more knowledge, please do share.

    Edit: I was able to mine from the EU Armory. Quite strange because that one has always been problematic in the past. I will commit once servers are up and running again.
    Posted in: Libraries
  • 0

    posted a message on Adding your project to SVN - A better process
    Quote from Ackis »

    How can you set this up auto magically with Tortoise?


    No idea, sorry. I'm on Mac. :P
    Posted in: Lua Code Discussion
  • 0

    posted a message on MouseLook - official thread
    But how does that help? The code above does not block the mouseclick from being sent to another frame. For example an action button will usually perform its action if any mouse button is clicked on it. Or am I missing something? :P

    Posted in: General AddOns
  • 0

    posted a message on MouseLook - official thread
    Thanks. That's not an implementation I like very much though. Checking for mouseover (not cheap by itself) on maybe 100 or more frames every 0.1 second is nasty. Of course, without profiling I can't say for sure if it is a performance problem. But it doesn't sound nice. Even worse is it that the frames to check seem to contain not only Blizzard frames but also specifically named addon frames. That's something I really want to avoid as it will break at some point for sure.

    I'm still hoping I or someone can come up with a better idea. If not, I think I have to say that my version of MouseLook simply is different and doesn't have that feature. Sorry. I think the old version by Trimble still works, right? If not, he could maybe be convinced to update it. :)

    P.S. Remember that you can still toggle mouselook with a key-binding no matter what frame you are mousing over. You just cannot use mouse-clicks.
    Posted in: General AddOns
  • 0

    posted a message on MouseLook - official thread
    Quote from neuron »

    can't really do that without screwing up my other software :/, I use the thumb button all day.


    Doesn't it allow bindings on a per-program basis? Mine does.

    Quote from neuron »

    Is there no way to hook that with a mouse button?


    Now we are actually back to a request from the start of the thread. :) My view on this is still as I replied in "reply #4". That is, I could hack into Blizzard's unit frames (no idea how difficult that is) and probably make it work. But it is really the responsibility of the unit-frame author to allow customizations of mouse-clicks.

    This problem isn't really restricted to MouseLook. You will notice that all frames with mouse enabled will "consume" any mouse-clicks - regardless of wether the click does something useful on the frame or not. But if someone can think of a way to do this that does not require changing attributes on other frames, I would love to know about it.

    Posted in: General AddOns
  • To post a comment, please or register a new account.