• 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Quote from Tomber
    Version r57 adds new customization settings for bar configurations. These were motivated by seeing how ButtonFacade sometimes scales the icon so it looks too small with respect to the bar (as well as by the fun there is to be had playing with configurations). In any case, there is now considerably more flexibility independent of whether ButtonFacade is loaded.


    You must have read my mind, looks stunning!
    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    I've managed to pull the updates from svn, seems the packager is choking on an addon in the queue atm. Buttonfacade support looks great! As to modules, I'm not sure. The idea of custom conditionals is interesting, but there again what you have in there already is pretty comprehensive! I guess there's some mileage in importing setups with bar groups for classes, ie focused on buffs/debufss that they are interested in only and maybe using the notifications for spell rotations. But that's only really for those too lazy to actually spend a bit of time setting it up themselves... What I would be interested in however is some way of plugging modules in that add timers for other things outside the scope of the addon or aren't currently supported. Examples might be raid cds, respawn timers, pvp orientated stuff for enemy cds or diminishing returns, etc; as well as totem timers which I would happily take a crack at myself once the api is exposed and documented.
    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Quote from Tomber
    I am currently working on ButtonFacade support. It has been a learning experience but I am getting close. At the moment, I am planning on just having one skin that will be used for all bar groups and, if ButtonFacade is loaded, will apply it to the icons in all bar groups. You will use ButtonFacade's UI to change the skin and there will not be any settings within Raven itself to enable or disable it for bar groups. Does that seem like an okay approach?


    That sounds pretty standard to me and I'm glad you're going to let buttonfacade handle the config, those addons I've seen where they've tried to do it themselves normally make an absolute mess of it. Having had a poke around in Bartender4's code it would seem that setting up the ability to skin groups seperately should be fairly straightforward if you did decide to give it a go. From what I can see all it does is iterate through bar groups and register each one with Buttonfacade seperately. However I'm not a great coder, pretty much limited to hacking functionality in as needed or fixing annoying but obvious bugs and the odd broker feed.
    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Quote from Tomber
    Could this by accomplished by being able to individually set the alpha for any bar in a custom bar group?

    If a condition can be specified for any bar in a custom bar group, what should that condition control? Fade or flash or not show at all? I think all of these are possible.


    Aye sorry was mashing the terminology, doesn't need to be set from the condition perse. What I meant was the ability to control the alpha or indeed flashing state of any bar individually on custom bar groups. Currently the only way of doing this is using the generic timer options, which whilst good don't allow the level of fine tuning that using notifications for say spell rotations might require. However it might be better if it is in the conditions, rather than part of the options for the bar, seeing as the finer points of timer control for instance are condition based already.
    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Quote from Tomber
    This is interesting. Do you envision this on a per-bar basis or per-bar group? Currently bar groups support conditional on/off as well as combat fading and include all the "plumbing" needed to generalize fading to be based on arbitrary conditions. Adding support on a per-bar basis might provide greater flexibility but would only work for custom bar groups.


    More on a per bar basis. For example on my lock, because I suck at remembering the spell rotation otw, I have a notifications bar setup showing debuffs running out/in need of being applied. Currently when they're running out they're appearing as flashing icons with the timer underneath, and then just as a solid icon when they're not present. It would be nice to have the timers at a slightly lower alpha than the icons to show me when something needs reapplying, just so that the stuff that must be put back up is more noticeable.
    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Quote from Tomber
    Here is my current list:
    3) Consider integrating "special target debuff filtering" which basically means merging bars for equivalent debuffs (e.g., Mangle and Trauma). I'm not sure this is necessary since it can be done with conditions/notifications. It would ease setup at the cost of more preset info that has to be kept up-to-date.


    I would personally say it's probably not necessary, as I'm in the process of setting it up myself and it's fairly easy to do. I think if you went down the route of providing it as standard you might have code overhead as some extra filtering would probably be needed. For example as a boomkin I'm not interested in armour reduction.

    4) One of my testers found a strange bug (or maybe an artifact from an old wtf file, not sure yet) with custom bars that somehow get blank labels. I haven't been able to reproduce this so I'm doing code inspections to see if I can identify what could cause it.
    I'll keep an eye open for this, but I haven't seen it at all.

    5) I'm thinking about how to add ButtonFacade support to icons. I might switch icons from Textures to Buttons, for example. I could then apply highlights like I do for action buttons to indicate things like whether they were cast by the player (which seems potentially quite useful).
    PhanxBuffs has ButtonFacade functionality, might be worth taking a peek at the code?

    That is pretty much everything. I think that I've either completed all the other requested features or included them on the above list. I spent some time thinking about TotemTimers and Inline Aura and didn't come up with anything else that I wanted to add to Raven. Let me know if I have missed anything or if you don't think any of the items on the list are worth the work. Thanks.
    TotemTimers has my vote still and I could see the use for Inline Auras, even if I wouldn't use it myself. The only other things I can see as being useful are:

    a) Having a bar that displays what tracking type you currently have active. Something which EBB, SimpleBuffBars, amongst others support. I'm not fussed about having the click support to change tracking which the previous provide as well, but it would be nice to see what is being tracked without reverting back to a minimap button /shiver.

    b) The ability to control the alpha of bars/icons depending on conditions. I'm guessing this is possible as there are fade options based on time already.

    Other than that all I would say is that for an alpha this has been one of the most bug free I've seen, pretty much feature complete from the word go and something I would highly recommend.
    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Thx for the update, have dl and will check it out. Can I just ask what you're still planning on adding in and tweaking still?
    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Quote from Tomber
    Craxziz, I found a bug in the Eclipse code by inspection that exactly matches the symptoms but the fix hasn't been verified by boomkin testing yet. Also, let me know if the notification icon is working better for you, thanks.


    The eclipse cds are working a treat again ty. Run a few spec swaps on different toons to see if I can bug the notification icons, so far they've all been the right icons. Will let you know if I get anymore glitches with the icons, but looking good atm.
    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Quote from sayntavarice
    For icon only, how about cooldown numbers on the icon, or maybe something can be done to let omnicc use the frames.


    You can already achieve this. Select the bar group and switch to the layout tab. Under icon arrangement settings is an option to offset the timer text. Just change the value of the offset so that the timer appears over the icon. Screenshot below shows a rather large version of an icon cd as an example.

    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Quote from Tomber
    This release also includes a fix reported by my boomkin tester to the same problem Craxziz just reported (line 599 attempt to index bs, a number value) that was introduced in the Eclipse detection code with the buff management changes. I haven't heard back if the fix works so I have my fingers crossed. Let me know Craxziz if you see any more issues with Eclipse.


    Just quickly blasted a training dummy to test the fix. The error is gone and lunar eclipse shows up properly, however no cd bar is generated for solar eclipse now, though this is error free.
    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Me again...

    Thank you for the timer format update, it's great not having to do copy pasta everytime I update now :)

    I ended up with the following error in voa25 tonight on my druid, which caused all bar groups to freeze. After running voa10 as well and watching when it happened with a little more care it's linked to when Lunar Eclipse procs, when the eclipse is over everything works fine again. Solar eclipse works fine and error free.

    930x Raven-r44\Main.lua:599: attempt to index global 'bs' (a number value)
    Raven-r44\Main.lua:738: in function `UpdateCooldowns'
    Raven-r44\Main.lua:256: in function `Update'
    Raven-r44\Main.lua:79: in function <Raven\Main.lua:79>
    
    Locals:
    self = <table> {
     updateActionbar = false
     testOrder = <table> {}
     modules = <table> {}
     CooldownTable = <table> {}
     lockSpells = <table> {}
     OptionsTable = <table> {}
     ReleaseBarGroup = <function> @ Raven\Bars.lua:389:
     SetDefaultModulePrototype = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:423:
     updatePlayer = false
     IsEnabled = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:465:
     IsDuplicateLabel = <function> @ Raven\Options.lua:685:
     RegisterMessage = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:118:
     UnregisterMessage = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:181:
     Update = <function> @ Raven\Main.lua:247:
     DefaultProfile = <table> {}
     ResetOptions = <function> @ Raven\Options.lua:91:
     db = <table> {}
     InitializeLayouts = <function> @ Raven\Bars.lua:83:
     LockBarGroups = <function> @ Raven\Bars.lua:369:
     TopOptionsTable = <table> {}
     FinalizeBars = <function> @ Raven\Bars.lua:61:
     UpdateBarGroup = <function> @ Raven\Bars.lua:305:
     OnEnable = <function> @ Raven\Main.lua:69:
     LayoutTemplate = <table> {}
     UpdateHighlights = <function> @ Raven\Highlights.lua:287:
     OnInitialize = <function> @ Raven\Main.lua:58:
     UnregisterAllEvents = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:202:
     InitializeBarGroup = <function> @ Raven\Bars.lua:265:
     UpdateCooldowns = <function> @ Raven\Main.lua:659:
     conditionTests = <table> {}
     UNIT_PET = <function> @ Raven\Main.lua:143:
     HideBars = <function> @ Raven\Bars.lua:73:
     InitializeTalents = <function> @ Raven\Main.lua:164:
     OnProfileChanged = <function> @ Raven\Profile.lua:72:
     GetName = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:298:
     OnProfileShutDown = <function> @ Raven\Profile.lua:78:
     name = "Raven"
     ldb = <table> {}
     Disable = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:328:
     SetConditionDefaults = <function> @ Raven\Profile.lua:225:
     updatePet = false
     InitializeWeaponBuffs = <function> @ Raven\Main.lua:341:
     Print = <function> @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:54:
     updateCooldowns = false
     eclipseTab = 1
     PLAYER_TARGET_CHANGED = <function> @ Raven\Main.lua:148:
     highlights = true
     runeTypes = <table> {}
     PLAYER_TALENT_UPDATE = <function> @ Raven\Main.lua:137:
     DebuffTable = <table> {}
     CleanupProfile = <function> @ Raven\Profile.lua:87:
     UnregisterEvent = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:181:
     UpdateAuras = <function> @ Raven\Main.lua:471:
     SetDefaultModuleLibraries = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:381:
     runeIcons = <table> {}
     GetIconForBar = <function> @ Raven\Options.lua:665:
     EnableModule = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:346:
     baseName = "Raven"
     IterateEmbeds = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:456:
     SetIconDefaults = <function> @ Raven\Profile.lua:211:
     Printf = <function> @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:69:
     myClass = "DRUID"
     SetDimensionDefaults = <function> @ Raven\Profile.lua:231:
     InitializeBars = <function> @ Raven\Bars.lua:42:
     DisableModule = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:364:
     SPELLS_CHANGED = <function> define
      ---
    Also on my notifications bar which I have setup in icon only mode, I occasionally get an incorrect spell icon show up. This corrects itself after the spell is cast, so maybe there is a caching issue? Whilst I haven't been reliably able to reproduce it, it does appear to happen more often than not after switching from the spec originally logged in as to a different one. In the screenshot below the icons for innervate and typhoon are correct, but the icon that is showing up as moonkin form should actually be force of nature.




    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Quote from Tomber
    BTW what texture is that you are using that has the round corners so I can test with it myself?


    Texture is called "round", it's one that can be found in the statusbars that come as part of Sharedmedia.
    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Ok just dl r41 and will play with it some, I'm raiding again on Monday so that should give it a good run. Noticed a couple of "new" issues tonight whilst raiding, best illustrated by the attached screenshot.

    Firstly spell names on the bars weren't being concatenated but were being wrapped, leading to some rather ugly looking text on bars.

    Secondly when bars are ticking down and the backdrop is being shown it doesn't look overly neat with rounded textures. It looks like the foreground texture is shrinking and the background texture is expanding to fill the gap. This leads to some gaps between the two textures. Contrast this to how ora3 cd bars are shown depleting to the right of the screenshot. This isn't by far the worst I've seen them but was the only screenshot I had with a different addon generating bars for comparison.




    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Quote from brimstone2
    Thanks a lot for your work on icon mode Tomber.

    A small request: would it be easy to implement the option to show timers longer than 59" as 1m, 2m, etc?

    Thanks again


    Have a fiddle around with nest.lua at line 638. This is where the timer formating occurs. t is the time in seconds, so divide by 60 to get minutes. I customise my timers and just copy and paste in the changes as and when it updates.
    Posted in: General AddOns
  • 0

    posted a message on Raven: Auras, Cooldowns and Notifications
    Hmm how odd, the buffs have decided to show up now. I've not actually changed anything other than enter a raid zone and come back out.
    Posted in: General AddOns
  • To post a comment, please or register a new account.