Authors CurseForge

Slightly modified example from your wowwiki link

function MyMod_ChatFrame_AddMessage(self, msg, ...)
 if msg:match("item:12345")
  return;
 end
 return self:MyMod_Orig_AddMessage(msg, ...);
end

function MyMod_HookAllChatFrames()
 local _G = getfenv()
 for i=1,NUM_CHAT_WINDOWS do
  local cf = _G["ChatFrame"..i]
  cf.MyMod_Orig_AddMessage = cf.AddMessage;
  cf.AddMessage = MyMod_ChatFrame_AddMessage;
 end
end

Quote from finagle »

Edit:
And magically it starts working again without any additional changes or reboots etc...

Server problems, probably.

True, maybe this one is safer. It's limited to 200 queries each run. I was able to query over 2500 items per click if I waited some time between clicks. If you click it too fast you will get disconnected.

/script LLID=(LLID or 25) LLQ=0 while (LLQ<200 and LLID<34500) do if not GetItemInfo(LLID) then GameTooltip:SetHyperlink("item:"..LLID) LLQ=LLQ+1 end LLID=LLID+1 end DEFAULT_CHAT_FRAME:AddMessage("Scanned up to itemID: "..LLID)

Even easier:

Paste this into a macro and click it once every 3 seconds or so until the numbers reach 35000

/script if not LLA then LLA=25 LLB=1025 else LLA=LLB+1 LLB=LLA+1000 end
/script for i=LLA,LLB do if not GetItemInfo(i) then GameTooltip:SetHyperlink("item:"..i) end end
/script DEFAULT_CHAT_FRAME:AddMessage(LLA..","..LLB)

I've only looked at the wdb files for a few seconds at most, but they're not just plain text. Someone would have to determine the structure first.

Try the --scan flag with Ludwig

As Lewzephyr said, FreeRefills will take items from the bank just like it buys from a vendor as long as the feature is enabled.

Great, thanks!

I've always thought that this might be a good idea for a library; something to simply translate enchantIDs into their corresponding enchant/item, or the reverse.

I updated the excel file with 2.2 gems starting at the row labeled 3206

GemHelper is a great addon :)

Unfortunately that code isn't very useful for finding new gems. It will only find items which you have already seen.

I have an excel spreadsheet that I've lazily maintained for JewelTips which includes most known gems including bogus ones like [Red Bryanite of Strength stuff] (id = 23234, enchantid = 2686) It also includes permanent enchant items like armor kits and some regular enchants too.

It's attached.

Thanks :)

Once a function is securely hooked using the hooksecurefunc function, is there a proper way of unhooking it?

Currently, I'm just re-hooking it to an empty function like so:

function Addon:OnEnable()
 hooksecurefunc("SendAddonMessage", function(...) return self:SendAddonMessage(...) end)

 if ChatThrottleLib then
  hooksecurefunc(ChatThrottleLib,"SendAddonMessage", function(_, _, ...) return self:SendAddonMessage(...) end)
 end
end

--Used for "unhooking" secure functions
local function nop() end

function Addon:OnDisable()
 hooksecurefunc("SendAddonMessage", nop)
 if ChatThrottleLib then
  hooksecurefunc(ChatThrottleLib,"SendAddonMessage", nop)
 end
end

Quote from Tatia »

will the changes show as a bump in the version number as my wau still showing r33816 >30days since last change?

Yah, apparently the update was rolled back or something. I'll try again shortly.

Use an addon like GemHelper or Sniff out all the ones you can find on wowhead to get all known gems into your local cache, and make sure that barbaric Legstraps are cached locally, then run this code to make a table holding enchantIDs indexed by the itemID of their corresponding Gem.

itemIDtoEnchantID = {}
local itemLink = "|cff0070dd|Hitem:27773:0:%d:0:0:0:0:0|h[Barbaric Legstraps]|h|r"

for enchantID=1,4000 do
 local gem1Link = select(2, GetItemGem(itemLink:format(enchantID), 1) )
 if gem1Link then
  local itemID = gem1Link:match("item:(%d+):")
  itemIDtoEnchantID[tonumber(itemID)] = enchantID
 end
end

http://www.wowwiki.com/API_GetItemGem

Quote from Ellipsis »

you'll lose a little functionality, but gain a ton of performance.

This is what you will have to aim for with many of your current addons.

I suggest replacing Outfitter with ClosetGnome. Consider replacing Prat with something simpler if you don't use all of Prat's features. mumble and PhanxChat are some that I have tried. MobHealth isn't important for raiding. I have a hard time believing that it could possibly be accurate when you have 20 people nuking a single mob. Turn off Cartographer and BugSack and RatingBuster and those types of things during raids.

I went ahead and committed your changes and some other small tweaks now that the svn is back online. Thanks for sharing the fixes.