with the current 2.4 version of glowfosho, you cannot link any items into trade/guild/party etc with enchants on them, you can try but the enchant will not show.
Maybe this addon will help with that problem: LinkBugFixer
Saeris doesn't appear to support his LootLink anymore. He's working on LinksList now. I will probably post an update to the branch that I have on wowinterface soon. Hope you don't mind if I use your fix Xinhuan, thanks :)
Many of the OnEnter methods don't appear to be repainting the tooltip ( GameTooltip:Show() ) after adding information to it. This results in tooltip information extending below the bottom of the tooltip's border. BankItems_Button_OnEnter is an example. I have verified that the bug lies with BankItems on a new character with only BankItems loaded.
If another addon (eg. ItemPriceTooltip) adds information to the tooltip after BankItems does and calls :Show(), then you won't notice the bug.
I've been playing with a version of RatingBuster which uses OnTooltipSetItem instead of TipHookerLib and after you mentioned that info is added twice, I noticed the problem.
Additionally hooking OnTooltipCleared, then using a flag which is set in OnTooltipSetItem and cleared in OnTooltipCleared seems to fix this problem.
Example from RatingBuster:
-- OnEnable() called at PLAYER_LOGIN
function RatingBuster:OnEnable()
-- Hook item tooltips
self:HookScript(GameTooltip, "OnTooltipSetItem")
self:HookScript(ItemRefTooltip, "OnTooltipSetItem")
self:HookScript(GameTooltip, "OnTooltipCleared")
self:HookScript(ItemRefTooltip, "OnTooltipCleared")
-- Initialize playerLevel
playerLevel = UnitLevel("player")
-- for setting a new level
self:RegisterEvent("PLAYER_LEVEL_UP")
-- Events that require cache clearing
self:RegisterEvent("CHARACTER_POINTS_CHANGED", clearCache) -- talent point changed
self:RegisterEvent("UNIT_AURA", 1) -- fire at most once every 1 second
end
function RatingBuster:OnTooltipSetItem(tooltip, ...)
--Call the original method
self.hooks[tooltip].OnTooltipSetItem(tooltip, ...)
if (not tooltip.RatingBusterDone) then
local name, link = tooltip:GetItem()
tooltip.RatingBusterDone = true
if link then
self.ProcessTooltip(tooltip, name, link)
end
end
end
function RatingBuster:OnTooltipCleared(tooltip, ...)
tooltip.RatingBusterDone = nil
end
Thanks for all the extra information, I had heard of other addons having problems with information displaying twice, but of course I never ran into it in my own addons.
Obviously you are already aware of the varying frequency at which tooltips are updated by Blizzard frames and by addons, but let me share my experience from making JewelTips.
Originally, JewelTips was written using TipHookerLib. After making tekkub sad, I did some research into what the correct way is. Looking at tekKompare's code directed me towards hooking the "OnTooltipSetItem" method of both GameTooltip and ItemRefTooltip. They don't even need to be secure hooks. This provided me with the exact same functionality that TipHookerLib provides without adding any of the overhead. TipHookerLib was written before WoW 2.0.3 simplified tooltip hooking with new methods. These methods may not be useful in all situations, for example, an addon might want to hook GameTooltip.SetTradeSkillItem so that they can know to use GetTradeSkillReagentInfo to find the quantity. Some addons which create their own tooltip object might not have information added to them using this method whereas TipHookerLib may purposely hook their methods.
As you've said, different frames/addons update the tooltip at different intervals. The default Character Frame constantly updates the tooltip while mousing over an item. If you're using an addon which replaces the character frame, then it might only update the tooltip OnEnter when you first mouse over the item. Same thing goes for bag slots. You can reduce the impact of your addon by caching all the final information you're adding to the tooltip and only load the new information when the item link for the tooltip changes. BankItems_AddTooltipData is fairly hefty with all the successive string concatinations.
0
0
I don't know why, but Ace2 is not running on your machine.
0
0
Sure.
0
0
Maybe this addon will help with that problem: LinkBugFixer
0
yoshimo, let me know if you figure out what those are.
0
0
0
0
Many of the OnEnter methods don't appear to be repainting the tooltip ( GameTooltip:Show() ) after adding information to it. This results in tooltip information extending below the bottom of the tooltip's border. BankItems_Button_OnEnter is an example. I have verified that the bug lies with BankItems on a new character with only BankItems loaded.
If another addon (eg. ItemPriceTooltip) adds information to the tooltip after BankItems does and calls :Show(), then you won't notice the bug.
0
Additionally hooking OnTooltipCleared, then using a flag which is set in OnTooltipSetItem and cleared in OnTooltipCleared seems to fix this problem.
Example from RatingBuster:
0
0
Originally, JewelTips was written using TipHookerLib. After making tekkub sad, I did some research into what the correct way is. Looking at tekKompare's code directed me towards hooking the "OnTooltipSetItem" method of both GameTooltip and ItemRefTooltip. They don't even need to be secure hooks. This provided me with the exact same functionality that TipHookerLib provides without adding any of the overhead. TipHookerLib was written before WoW 2.0.3 simplified tooltip hooking with new methods. These methods may not be useful in all situations, for example, an addon might want to hook GameTooltip.SetTradeSkillItem so that they can know to use GetTradeSkillReagentInfo to find the quantity. Some addons which create their own tooltip object might not have information added to them using this method whereas TipHookerLib may purposely hook their methods.
As you've said, different frames/addons update the tooltip at different intervals. The default Character Frame constantly updates the tooltip while mousing over an item. If you're using an addon which replaces the character frame, then it might only update the tooltip OnEnter when you first mouse over the item. Same thing goes for bag slots. You can reduce the impact of your addon by caching all the final information you're adding to the tooltip and only load the new information when the item link for the tooltip changes. BankItems_AddTooltipData is fairly hefty with all the successive string concatinations.
There are improvements to be made.
0
The bug occurs when you don't have RollCall and somehow receive an addon message on an unguilded character.