CurseForge and Overwolf are joining forces!
Awesome More Information
  • 0

    posted a message on Threat-2.0 - Righteous Defense Fix
    Quote from Xinhuan »

    Hi Reynard, I have looked over it, and applied your fix to Threat-2.0 on the SVN. Thanks!


    No problem, glad to help :-)
    Posted in: Libraries
  • 0

    posted a message on Threat-2.0 - Righteous Defense Fix
    Just to note: in writing this fix, I didn't look through the entire Threat library - only the Paladin module, and the Warrior equivalent. So if any of the above assumptions are wrong, particularly about the target argument in the cast handler being the raid member off whom the paladin is taunting rather than the mob, or if there's any other reason that this hasn't been fixed before or is unfixable, feel free to scream at me :-)
    Posted in: Libraries
  • 0

    posted a message on Threat-2.0 - Righteous Defense Fix
    Hey all,

    As was mentioned in one or two of the Omen threads, Threat-2.0 doesn't register the Paladin Righteous Defense taunt on the aggro table; the taunter's threat remains unaffected. This, of course, leads to significant problems on certain boss fights - particularly Brutallus - since the raid basically has no idea of the tanks' true threat as the fight progresses. The issue arises due to the taunt spell being cast on a friendly player rather than the mob itself; Threat-2.0 attempts to account for this by defining separate handlers to check for the cast of the spell:

    	function Paladin:CastRighteousDefense(spellID, target)
    		self.RighteousDefenseCastTime = GetTime()
    	end


    ... and to apply the threat change if the Righteous Defense debuff appears on the taunted mob within 1 second of the cast, thereby ignoring resists:

    	function Paladin:RighteousDefense(spellID, target)
    		if GetTime() - self.RighteousDefenseCastTime < 1 then
    			local targetThreat = ThreatLib:GetThreat(UnitGUID("targettarget"), target)
    			local myThreat = ThreatLib:GetThreat(UnitGUID("player"), target)
    			if targetThreat > 0 and targetThreat > myThreat then
    				self:SetTargetThreat(target, targetThreat)
    			elseif targetThreat == 0 then
    				local maxThreat = ThreatLib:GetMaxThreatOnTarget(target)
    				self:SetTargetThreat(target, maxThreat)
    			end
    		end
    	end


    The problem occurs because, by the time the debuff appears on the mob, it has already turned to target the taunter. The call to UnitGUID in the second function above therefore returns the taunter's own threat as "targetThreat", compares it to "myThreat", finds that the two are identical, and does nothing.

    To fix this, I made a couple of very small changes. In the cast handler function, the "target" argument - which is actually the raid member that Righteous Defense has been cast on, rather than the mob - is recorded at the moment the taunt is cast:

    	local tauntOffTarget = nil
    
    	function Paladin:CastRighteousDefense(spellID, target)
    		tauntOffTarget = target
    		self.RighteousDefenseCastTime = GetTime()
    	end


    In the mob debuff handler function, the saved "tauntOffTarget" is used instead of "targettarget", ensuring that the paladin's threat is properly compared against that of the raid member off whom he taunted:

    	function Paladin:RighteousDefense(spellID, target)
    		if GetTime() - self.RighteousDefenseCastTime < 1 then
    			local targetThreat = ThreatLib:GetThreat(UnitGUID(tauntOffTarget), target)
    			local myThreat = ThreatLib:GetThreat(UnitGUID("player"), target)
    			if targetThreat > 0 and targetThreat > myThreat then
    				self:SetTargetThreat(target, targetThreat)
    			elseif targetThreat == 0 then
    				local maxThreat = ThreatLib:GetMaxThreatOnTarget(target)
    				self:SetTargetThreat(target, maxThreat)
    			end
    		end
    	end


    I've tested this fix and it works perfectly. I've no idea if there's a more elegant way to incorporate it into the Threat-2.0 framework, but I thought I'd pass it along. The issue should be addressed one way or another though, as it makes taunt-fights kind of a pain in the ass :-)
    Posted in: Libraries
  • 0

    posted a message on Omen - Bug Reports and Suggestions
    Hey all,

    I'm having a problem with Omen, in that my own threat never seems to appear on it; it apparently does, however, transmit my threat to others correctly. I know that people have reported problems similar to this due to the Rock libraries, but it's been happening for me for quite some time, and having recently gone Prot it's become more of a pressing issue. If I /reloadui it sometimes starts recording my threat properly, but always stops working again soon afterwards (usually after I move to a different zone). I've got the latest versions of Threat, Omen and all libraries installed, and have tried changing all the options which could conceivably be causing it. Does anyone have any idea what could be wrong?
    Posted in: Raid AddOns
  • 0

    posted a message on ag_UnitFrames - suggestions, requests and temp fixes thread
    Hey guys,

    Posted a few days ago about a problem where AGUF wouldn't update the target when switching targets while in combat. This is becoming a major problem, since it sometimes switches the name on the AGUF frame to the new target but retains the old target's HP and mana meters, meaning that I can't tell if they need heals, etc. While I love the AG frames, I'll be forced to switch back to Nurfed or Blizz default if I can't fix this problem, since it's actually affecting my ability to play. Does anyone have any idea what might be causing this?

    Thanks,
    Reynard.
    Posted in: Unit Frames
  • 0

    posted a message on ag_UnitFrames - suggestions, requests and temp fixes thread
    Hey all,

    Love the frames, but I'm having one very annoying problem. Basically, whenever I enter combat, the target frame gets "stuck" on whatever it was when combat began - that is, it won't change when I select a different target. If I have nothing selected at the moment combat starts, then no target frame appears no matter whom I select. Once combat ends, the frames go back to working fine. Any idea why this might be, or is it a known issue?
    Posted in: Unit Frames
  • To post a comment, please or register a new account.