- Curse Premium
Member for 14 years and 15 days
Last active Wed, Mar, 2 2016 10:57:33
- 0 Followers
- 471 Total Posts
- 0 Thanks
Nov 29, 2007Posted in: FuBar AddOnsQuote from Rav »
EoS Code works nice, thx.
AV not. Perhaps a local thing ? (use deDE Client)
Do you have changed the function as described in Reply #8?
If you have Glory-2.0 r56019 you have to change two functions to fix AV and EotS win/lose counting:
Reply #8 for AV and Reply #9 for EotS in this thread
According to the locals that are already in Glory-2.0 this fix should work with all languages. But I can not test other languages.
VICTORY_TEXT0 and VICTORY_TEXT1 are localized blizzard globals.
Nov 29, 2007Eye Of The Storm fires no unique event [version 2.3.0 build 7561] (correct me if I am wrong) when a faction wins, so the only way to record win/lose is to check for score. Because the UPDATE_WORLD_STATES event fires after a faction has reached the goal of 2000 we need some time check to prevent the recording of more than 1 win/lose. This time is set to 125 seconds (120 seconds is standard time before auto zone out from bg).Posted in: FuBar AddOns
- GetWorldStateUIInfo returns sometimes nil so we need to check that
- GetWorldStateUIInfo index for Alliance in Eye Of The Storm is 2 !!!
- GetWorldStateUIInfo index for Horde in Eye Of The Storm is 3 !!!
- new code marked with NEW CODE
- tested code below with client version 2.3.0 build 7561
To count wins/losses in Eye Of The Storm change Glory-2.0 r56019 'function events:UPDATE_WORLD_STATES()' and add one local var for timecheck
The whole function should look like:
local countOnce = GetTime() -- NEW CODE function events:UPDATE_WORLD_STATES() -- NEW CODE START if Glory:IsInEyeOfTheStorm() then local AllianceScore = select(3, GetWorldStateUIInfo(2)) local HordeScore = select(3, GetWorldStateUIInfo(3)) if AllianceScore then AllianceScore = AllianceScore:match("(%d+/%d+)") end if HordeScore then HordeScore = HordeScore:match("(%d+/%d+)") end if AllianceScore ~= "2000/2000" and HordeScore ~= "2000/2000" then countOnce = GetTime() end if countOnce > GetTime() then return end if AllianceScore == "2000/2000" then if not isHorde then IncreaseBattlegroundsWins(Glory) else IncreaseBattlegroundsLosses(Glory) end countOnce = GetTime() + 125 end if HordeScore == "2000/2000" then if isHorde then IncreaseBattlegroundsWins(Glory) else IncreaseBattlegroundsLosses(Glory) end countOnce = GetTime() + 125 end end -- NEW CODE END local resData = BattlefieldZoneResourceData[Glory:GetActiveBattlefieldZone()] if resData and Glory:GetNumAllianceBases() and Glory:GetNumHordeBases() then -- Common local goalResources = resData[table.getn(resData)] -- Alliance resources = Glory:GetAllianceScoreString():match("(%d+)/") bases = Glory:GetNumAllianceBases() if resources and bases and (resources ~= Glory.aLastResources or bases ~= Glory.aLastBases) then Glory.aResourceTTV = (goalResources - resources) / resData[bases] Glory.aLastResources = resources Glory.aLastBases = bases Glory.aLastUpdate = GetTime() end -- Horde resources = Glory:GetHordeScoreString():match("(%d+)/") bases = Glory:GetNumHordeBases() if resources and bases and (resources ~= Glory.hLastResources or bases ~= Glory.hLastBases) then Glory.hResourceTTV = (goalResources - resources) / resData[bases] Glory.hLastResources = resources Glory.hLastBases = bases Glory.hLastUpdate = GetTime() end end end
use at your own risk
make sure you change MINOR_VERSION on your modified Glory-2.0 (line 18 r56019) if you have other addons that uses Glory-2.0
Nov 27, 2007Posted in: General AddOnsQuote from Elkano »
well, you said yourself what it is that makes me pissed: "I commited a (...) version of your addon"
When getting your SVN account you signed that you wouldn't do such things without asking the author first. Also it's not polite.
Besides that, I told you what you did wrong: "The externals are set on the ItemDB folder and not a libs subfolder..."
There was no libs folder on svn before your commit, the externals are set on the addon's root folder. Since you didn't change these they are still in place and thus also the old path gets a checkout. That was what I meant when I said "not knowing what you do", it was not about the svn usage itself.
Quote from Elkano »
Would you mind to not touch other peoples addons without asking, especialy when not knowing what you do...
The externals are set on the ItemDB folder and not a libs subfolder...
Elkano, you know what?
You are not polite. You are ignorant and arrogant.
I think YOU did not read the rules and guidelines for svn usage on this website!
Sure the guidelines are not rules, sure you can have the same effect with different methods, but I follow the guidelines and the rules posted on this site for my commits to wowace-svn. And I made two little mistakes that I posted here in this thread, but this mistakes has no effect nor has it destroyed or killed anythin you ever committed. The opposite is the truth: I corrected an error you made! and if you are not able to correct your mistake for more than 44 days...you better say thanks!
And now the really really important uber-extraordinary difference:
Create or not create a libs folder is the question. (read svn guideline!)
LibInventory-2.1 [url]http://svn.wowace.com/wowace/trunk/LibInventory-2.1[/url] LibStub [url]http://svn.wowace.com/wowace/tags/LibStub/1.0/[/url]
libs/LibInventoryLib-2.1 [url]http://svn.wowace.com/wowace/trunk/LibInventory-2.1[/url] libs/LibStub [url]http://svn.wowace.com/wowace/tags/LibStub/1.0/[/url]
so the only really important thing is how you set svn propset. And it doesn't matter if you use your or my externals, the effect is the same: a libs folder with the externals, with one little difference:
tarrrraaa LibInventory not LibInventoryLib
my externals = NO ERROR
your externals = NOT WORKING and ERRORS because of a invalid path (libs/LibInventoryLib-2.1):
the toc of your r51750 commit: libs\LibInventory-2.1\lib.xml
embeds.xml of your r52025 commit: libs\LibInventory-2.1\lib.xml
even the r54195 and r54198 commits from funkydude did not correct this
I repeat this as long as you say to me: 'not knowing what you do'!
So, why do you 'get pissed'? because someone corrected your bug in your addon? Or do you not like the libs folder(read svn guideline!)? Or do you 'get pissed' because I made 2 little errors in my commit that has no effect on usage? Why did you not correct your bug (44 days!)?
It's because I corrected your mistake in your addon without asking. I bet that's it! And that is ignorant!
The only person who should feel 'pissed' is me, because I just wanted to help. And what do I get? arrogant-ignorant do-not-change-my-addon-whine. (DAMNED I committed a WORKING lib-embedded version of your addon - I changed not a single byte of your code! (read svn rules!))
Ahh...one thing I do not understand: why do you not just revert my commit to your addon? revert to the not-working r54198 version. Hope that makes you happy.
Have a nice day.
btw: I will never ever touch an addon from you! Hope that makes you happy too.
Nov 27, 2007the event for alterac is CHAT_MSG_MONSTER_YELLPosted in: FuBar AddOns
change 'function events:CHAT_MSG_MONSTER_YELL(text)' Glory-2.0 r56019
(new code marked with NEW CODE)
The whole function should look like:
function events:CHAT_MSG_MONSTER_YELL(text) if Glory:IsInAlteracValley() then -- NEW CODE START if text:lower():find(VICTORY_TEXT0:lower()) then if isHorde then IncreaseBattlegroundsWins(Glory) else IncreaseBattlegroundsLosses(Glory) end elseif text:lower():find(VICTORY_TEXT1:lower()) then if not isHorde then IncreaseBattlegroundsWins(Glory) else IncreaseBattlegroundsLosses(Glory) end end -- NEW CODE END if not text:lower():find(VICTORY_TEXT0:lower()) and not text:lower():find(VICTORY_TEXT1:lower()) then events:BattlefieldObjectiveEventProcessing(text) end end end
use at your own risk
Nov 26, 2007Hey Elkano: SORRYPosted in: General AddOns
Unless you can answer my question in the post above yours, it's better to say thanks.
Because I commited a WORKING lib-embedded version of your addon!!!
download r54198 and r56050 and try both
The lib-embedded ItemDB version <=r54198 was buggy aka just not working unless the foldername is changed - with nasty errors bypassing buggrabber because of a invalid path!
AND: I know what I do!
and I'm ^^really really sorry that I made 2 little mistakes:
the first one had a ;) - two missing s in a changlog-text is not really important or?,
the second one, well tell me why it has the old /libs/LibInventoryLib-2.1 folder in it. (say 'svn update *' command was missing! and I say, correct that's is blablub)
Remember: I COMMITED A WORKING VERSION WITH JUST 2 DUMB MINOR MISTAKES ( and I am dumb enough to post this little errors here...hellwell what a mistake )
Nov 26, 2007I fixed the invalid path to the LibInventory-2.1 library.Posted in: General AddOns
It works :)
I made 2 mistakes: :(
1. wrong changelog text:
ItemDB: fixed externals: lib/LibInventory-2.1/ not lib/LibInventoryLib-2.1/
ItemDB: fixed externals: libs/LibInventory-2.1/ not libs/LibInventoryLib-2.1/
2. strange externals thing happens:
- first I deleted the libs folder
- than md libs
- than svn add libs
- than I created a externals.txt file:
LibInventory-2.1 [url]http://svn.wowace.com/wowace/trunk/LibInventory-2.1/[/url] LibStub [url]http://svn.wowace.com/wowace/tags/LibStub/1.0/[/url]
- than svn propset svn:externals -F externals.txt libs
- than svn ci -m "changlogtext"
and here is the strange thing:
ItemDB r56050 has now 3 folders in libs/:
libs/LibInventoryLib-2.1 - this is the wrong old one
anybody knows why?
Nov 25, 2007http://www.wowwiki.com/API_GetBattlefieldWinner - Note from Shadowed:Posted in: Libraries
Currently in Patch 2.3.0 this is broken and returning nil when nobody has won, and 255 if someone has won regardless of faction or team
Nov 23, 2007_ForgeUser136437 posted a message on WoW Mod Search Engine - Searches WoWAce/Curse/WoWI/WoWUIPosted in: General ChatQuote from Mikma »
Go Fin! <3 I'll stick with his site.
Yes! Go Fin!
simple pure html (just one little script line to avoid hijack)
ok there are some problems with linebreaks in comments and minuses, points or so in addonnames
Nov 23, 2007According to http://www.wowwiki.com/API_GetBattlefieldWinner this seems to be a known bug.Posted in: FuBar AddOns
Glory-2.0.lua r56012 uses this GetBattlefieldWinner function. That's why it's not recording any wins or losses.
Here is a little Glory-2.0 fix:
in Glory-2.0.lua r56012 change the following lines:
Line 1705: --[[ Line 3011: --events:RegisterEvent("CHAT_MSG_BG_SYSTEM_NEUTRAL") Line 3023: events:RegisterEvent("UPDATE_BATTLEFIELD_STATUS")
Line 1705: ---[[ Line 3011: events:RegisterEvent("CHAT_MSG_BG_SYSTEM_NEUTRAL") Line 3023: --events:RegisterEvent("UPDATE_BATTLEFIELD_STATUS")
This just removes the commented out part of the event CHAT_MSG_BG_SYSTEM_NEUTRAL and it's function. This function uses blizzards global variable VICTORY_TEXT0 / VICTORY_TEXT1 to IncreaseBattlegroundsWins or IncreaseBattlegroundsLosses instead of GetBattlefieldWinner.
If you have other addons that uses Glory-2.0 make sure your modified version is the newest one:
Line 18: local MINOR_VERSION = "$Revision: 56012 $"
Line 18: local MINOR_VERSION = "$Revision: 99999 $"
use at your own risk
The Glory-2.0 library authors ckknight, Elkano or hyperactiveChipmunk should change the svn version.
Someone change Glory-2.0 but did not fix this bug. I changed line numbers in the fix above for Glory-2.0 r56012.
Nov 20, 2007I fixed this nil bug (FuBar_DurabilityFu r55548)Posted in: FuBar AddOns
if self.db.profile.showPopup and not stop and not repaired and not self.db.profile.autoRepairEquipment then showPopup(GetRepairAllCost()) end
The popup call is currently not checking if you have enough money:
this should changed to
if self.db.profile.showPopup and not stop and not repaired and not self.db.profile.autoRepairEquipment then local money = GetMoney() local cost = GetRepairAllCost() if cost >= money then showPopup(cost) else no-money-warn end end
I commit only the simple fix above because I don't know if the FuBar_DurabilityFu author want me to change more than a simple fix...
Nov 17, 2007_ForgeUser136437 posted a message on [Grid] Modules: Threat,RaidIcons,MTs / Indicators: Text3,SideIconsPosted in: Grid & Grid2Quote from z1n »
If a Person in the Raid gets marked with a Skull/Icon in a Bossfight because of any Debuff - is it possible to see this icon with this Plugin? (And the Debuffincon is wandering around of course from time to time)
You can see the raid icon (if set to an icon indicator) or the text (like Star, Skull or so) (if set to a text indicator).
GridStatusRaidIcons has 2 Statuses: 'Raid Icons: Player' and 'Raid Icons: Player Target'. Use the first one on an icon indicator and you have what you want.
If you want more icon indicators try GridIndicatorSideIcons (4 extra icon indicators - and the one from Grid in the middle).
- To post a comment, please login or register a new account.