• 0

    posted a message on DrDamage - Official Thread
    I'm going to assume that only each tick can crit. The chance to crit is applied to each tick and not to the whole thing. I added a "canDotCrit = true" to Corruption in the Warlock file, but there'll have to be some logic thrown in somewhere to calculate it.

    Anywhere we have a spell like this, getting your crit rate to show up in the tooltip, and a comparison of crit to damage (and haste), is the eventual plan.


    Blizzard just became changed like mindflay into a normal critting spell.

    The problem with Pandemic and Shadowform is that they're talents that make spells that otherwise can't crit into being able to crit.

    I suppose temporary hack could be to set canCrit = true, critmultipier = 1.0 and then let pandemic modify the critmultiplier into 1.33/1.66/2.0

    However that won't work for shadowform since shadowform applies the crit% as a damage%. I got no idea how to get that to show up in the tooltips.

    - Also, Poleaxe Specialization currently doesn't verify if your equipped weapon is an axe or a polearm and just applies the damage bonus at all times. In the future I'll implement a check, but for now this should be ok. Afterall, who takes poleaxe spec and then doesn't use a polearm/axe? =P

    An arms warrior that is tanking. Traditionally there are almost no Axe tanking weapons, but I've heard WotlK will have some.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Here I was thinking that was a paladin specific problem.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Newest version of priest for 3.0.3

    -Added the crit to dot damage for shadowform
    -Doubled the coefficient for vampiric touch
    -removed the spam that checks if Twisted Faith is working
    -properly made Penace into a 2 sec cast 3 hit spell.

    the 302 file is for patch 3.0.2
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    I'm not an expert but I think you need a self.calculation["Devastate"] for it and it should be in the warrior.lua not aura.lua because even though other warriors can benefit it's still only warriors.

    I'd recommend going to #drdamage on freenode and ask the experts. They seem to be afk atm though.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    The act of defining the spell should be enough to make it show up. Odd that it doesn't.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from rothomp3
    Just wanted to add a report that I am successfully seeing numbers (using SVN to get the add-on from the clone repository), even on my Paladin (though they're hideously inaccurate for the discussed obvious crazy complicated Paladin reasons).

    "It's working" non-bug reports can sometimes be just as useful as others, so I thought I should post, heh.


    The paladin should be reasonably accurate for:
    Holy Light
    Flash of Light
    Holy Wrath
    Excorsism

    Aslong as you have no talents....
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Vouksh said he was working on warrior, hopefully he'll post up a working file soon.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from tebugg
    u r doin a good job on the priest lua, but the numbers r still off. my priest is lvl 54.

    mind blast rank 8 is 429-454dmg + i have 163 spell dmg. drdmg shows 533.
    flash heal rank 6 = 658-779. drdmg shows 878.
    greater heal rank 3 = 1450-1623. drdmg shows 1874.

    those r just a couple i thought i'd let u know that i checked for u. if u want to know the other spells let me know.


    You sure that is what the spells land for? Because your numbers look like the base damage.

    Numbers aren't expected to be correct right now. The important thing is that you're even seeing numbers. That's all we care about at this stage. We'll worry about accuracy a bit later when we've got the addon itself working in general.

    While I can live with the priest numbers being off by a bit I did spent a lot of hours trying to get them into the right general area.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    I think this priest works, don't shoot me if it doesn't.

    Things to fix:
    1) Need to check that grace is your own
    2) Figure out how exactly misery works
    3) Figure out how exactly borrowed time works
    4) get coefficients for: Penace, Mind Sear, Divine Hymn and any coefficient that might have been changed
    5) Get the level bonus to damage for various spells
    6) Probably alot of other things that I can't remember.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from jokeyrhyme
    Guys, try to be more careful where you are committing to. Noticed a few commits to the original DrDamage (which is really frowned upon without the author's consent). Remember, all of our changes are going into the clone only.

    If you don't want to have to mess with repositories, then the easiest thing to do would be to attach your class file to a post here. Obviously it's best if you can test it out with the latest version of the clone.
    Well, dally made the clone private so we can't commit to there, I guess I could always create a secondary clone that's public for everyone and you can merge in things from there.

    Forum attachments with zipfiles are so annoying compared to rightclick->commit

    I'm closing in on the finish-line with the Warlock stuff. Sorry for the slow going, got a fair bit on. 90% of Affliction talents and 90% of Destruction talents are being calculated somewhat reliably. I'm having some issues with Demonology because of all the extra branching that it needs.

    I need advice with how to handle Master Conjuror. This talent effects the weapon enchants (self-only) given by using Master Spellstone or Master Firestone. Does general code need to be inserted somewhere to ignore these enchants so that Warlock-specific code can handle them (and their talent boost)? Or are these already handled on a class-by-class basis? I couldn't find GetWeaponEnchantInfo() anywhere in the Rogue or Shaman code, so are these automatically pulled into the ActiveAuras table?


    I think you might want to apply the code in two places
    1) add it in auras together with all the other oils
    2) add warlock specific code in warlock.lua along the lines of
    if activeauras=["stone"] then raise damage of these spells by 1%

    It would be really neat if you could use the same code that talents use.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    I've made a non crashing priest.lua that has enabled mind flay to crit. Havn't touched spell ranks or talents yet, planning to do that tommorow. I committed it to the mainline if you want to put it into your clone.
    Posted in: General AddOns
  • 0

    posted a message on LilSparky's Workshop -- Official Thread
    Havn't actually used your addon or skillet before today, just thought it looked odd in the cooking tab 0/#/#/# for spice bread.

    Also does skillet have to spam my general chat with it's "Skillet auto-rescan: o seconds" messages?
    Posted in: General AddOns
  • 0

    posted a message on LilSparky's Workshop -- Official Thread
    You can download it here:
    svn://svn.wowace.com/wow/skillet/lilsparkys-clone/trunk

    However that requires an SVN client.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Hmm, maybe I should give the other classes some work then, got both a lvl 70 mage and priest that wouldn't mind having their numbers fixed. In theory they should be easy, add new ranks, add new talents, done. Or so I hope.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    That would mess up healing figures and things like Consecrate which don't use AP at all.


    The thing is that consecrate DOES use AP since last patch, only spells not using AP anymore is the "pure" spells aka healing spells, excorsism and holy wrath.

    'd like to avoid cluttering up the Melee/Caster files with class-specific cases wherever possible. We're just gonna have to really search for a solution. It was working pre-3.0, and I really can't imagine that these calculations are catastrophically broken. It must just be a few incorrect variables somewhere. Maybe Blizzard changed an API call that these calculations use, and now they're trying to do math on nil variables. Or something similarly easy to fix, but hard to spot... I hope so at least.


    The paladin class got fundementally changed

    1) Most dps abilities now scale off both AP and spellpower
    2) seals only have 1 rank
    3) seals scale differently then they did before
    4) They completely changed judgement and split it into 3 new spells
    5) They changed the judgement effect of all the seals(and their damage scaling)
    Posted in: General AddOns
  • To post a comment, please or register a new account.