looks like the latest build incorporates a 1/1000 time change, but I'm still having "stuttering" when anyone joins/leaves/dies/dc's. Sucks since I love Pitbull.
What type of CPU use you?
I guildmate uses an 3 GHz Quad-Core Intel and was virtually "freeze free" after the 1/300 change. I'm using an 2.4 GHz Dual-Core and get rid of the problem around 1/600 - 1/900.
Maybe, LibDogTag-3.0 is too CPU-hungry and you can't eliminate the freezes on slower system.
I finaly solved the problem by extending ckknight's LibDogTag-Changes from r76872 and r77057.
r76872
LibDogTag-3.0 - Make fontstring updates somewhat lazy. Don't allow more than 1/300 of a second to be used per-frame.
In most situations, this will have absolutely no effect, but this will mostly affect situations where absolutely every fontstring issues an update request, at which point it may take multiple frames to update all your data, but it won't freeze things anymore (hopefully).
r77057
LibDogTag-3.0 - Change the lazy fontstring updating a bit to be a bit more efficient.
There is an new check in Events.lua Line 575...
local finish_time = GetTime() + 1/300
I decreased the 1/300 to 1/600, 1/900 and finally to 1/999 and all lag freezes are gone.
The first introduction (with 1/300) of the "fix" reduced my freeze spikes from 5+ seconds to 2 seconds. The are again shorter with 1/600 and are gone with 1/900. I decreased the value to 1/999 and run two sunwell raids.
Everything was fine, also if an raidleader shuffle the complete raid. I got multiple 2 second freezes with 1/300 value for 20-30 seconds if 5-10 players get an disconnect (telco failure) and come back later. This doesnt happens with 1/999 and also massive raid changes wont freeze the system with 1/999.
One sideeffect may be an reduced frame rate with very long dogtags on all 25 raid frames.
The following DogTag reduced my framerate from 45+ to 15 and was not usable on all 25 raid frames. But I can use them very well in 10 person raids.
if HasAura(\"Freezing Trap Effect\") or HasAura(\"Polymorph\") or HasAura(\"Sap\") or HasAura(\"Gouge\") or HasAura(\"Seduce\") or HasAura(\"Banish\") or HasAura(\"Fear\") or HasAura(\"Howl of Terror\") or HasAura(\"Intimidating Shout\") or HasAura(\"Entangling Roots\") or HasAura(\"Cyclone\") or HasAura(\"Hibernate\") or HasAura(\"Psychic Scream\") or HasAura(\"Blind\") or HasAura(\"Repentance\") then\n (Outline \"*Crowd Control*\" Gray AuraDuration(\"Freezing Trap Effect\"):FormatDuration(\"s\"):Paren AuraDuration(\"Polymorph\"):FormatDuration(\"s\"):Paren AuraDuration(\"Sap\"):FormatDuration(\"s\"):Paren AuraDuration(\"Gouge\"):FormatDuration(\"s\"):Paren AuraDuration(\"Seduce\"):FormatDuration(\"s\"):Paren AuraDuration(\"Banish\"):FormatDuration(\"s\"):Paren AuraDuration(\"Fear\"):FormatDuration(\"s\"):Paren AuraDuration(\"Howl of Terror\"):FormatDuration(\"s\"):Paren AuraDuration(\"Intimidating Shout\"):FormatDuration(\"s\"):Paren AuraDuration(\"Entangling Roots\"):FormatDuration(\"s\"):Paren AuraDuration(\"Cyclone\"):FormatDuration(\"s\"):Paren AuraDuration(\"Hibernate\"):FormatDuration(\"s\"):Paren AuraDuration(\"Psychic Scream\"):FormatDuration(\"s\"):Paren AuraDuration(\"Blind\"):FormatDuration(\"s\"):Paren AuraDuration(\"Repentance\"))\nend) (if HasAura(\"Domesticate\") then\n (Outline \"*Mind Control*\")\nend)
Maybe we see an official LibDogTag-3.0 with my 1/900 or 1/999 change.
Please post your feedback here if you test this change.
Today, I "hacked" Pitbull-77449 to use LibDogTag-2.0 instead of LibDogTag-3.0 and all Freezes are gone. This shows that LibDogTag-3.0 is the real source of this freezes and not Pitbull.
Pitbull.lua
1. Modify Line 690: local DogTag = Rock("LibDogTag-3.0") -> local DogTag = Rock("LibDogTag-2.0")
2. Delete Line 691: Rock("LibDogTag-Unit-3.0")
3. Modify the Lines 3263-3265 and 6185-6187
-- if not WoW24 then
-- DogTag:SetColorConstantTable(self.colorConstants)
-- end
to:
DogTag:SetColorConstantTable(self.colorConstants)
Pitbull_MetaLayout.lua
I used the complete Pitbull_MetaLayout.lua from r65405 to get the old 2.0 DogTags.
Okay, I've done some hacking to increase performance. Mind testing with the latest version of PitBull, LibDogTag-3.0, and LibDogTag-Unit-3.0?
Ok, the promised test wasnt done on thursday but I was able to join an 25 raid on friday. I used LibDogTag-3.0 r77057, LibDogTag-Unit-3.0 r77434 and Pitbull r77449.
The behavior was the same as on my last tests on monday. I got several mini freezes on different events.
- raid player is dying
- raid player releasing corpse
- raid player re-enter instance
- raid player changed group in raid (moved from group 1 to 6 for instance)
Currently, I use only dogtags which are compatible with LibDogTag-2.0 and most are very simple default versions of pitbull. I have one more advanced dogtag-3.0 with several "HasAura" tags but this text was disabled on all frames at this test raid.
Is there an chance to see an "config switch" to force pitbul using LibDocTag-2.0 instead of 3.0? Most dogtags are compatible to 2.0 and this can help to verify the source of the freeze problem.
Seeing as you mentioned your testing on Monday, I assume it was before the changes I made. That's why I asked you to update those addons and libraries before testing again. If you could test with those, that'd be useful.
The test was done Thuesday around 21:00 GMT and I updated all ACE modules right before I started.
Anyway, I will do another test tomorrow and will update all modules before I start.
Okay, I've done some hacking to increase performance. Mind testing with the latest version of PitBull, LibDogTag-3.0, and LibDogTag-Unit-3.0?
My latest testing on monday/thuesday was done with the latest LibDogTag-3.0 and Pitbull version. I used this versions for nearly one hour until I reverted.
There are several mini lag spikes. They are around 1 second and occur on different events...
- raid player is dying
- raid player releasing corpse
- raid player re-enter instance
- raid player changed group in raid (moved from group 1 to 6 for instance)
If only one (1) event triggers, its like an short "hicks" and you wont experience it if you are lazy. But if you have 3-5 players dying and they release their corpses one after another you get an "freeze chain" of multiple short freezes and this is an real problem.
The current combination of LibDogTag-3.0 and Pitbull is much better than the first release of LibDogTag-3.0 + Pitbull. The freezes where around 3-5 seconds short after the release. They are now 1 second or shorter but still very anoying and an real problem if you heal and must react. Most 25 raid fights are dynamic and fast reaction & movement is crucial. Short freezes can be the reason for an wipe chain and therefore is Pitbull currently no option for 25 raids.
EDIT: I can do further tests and maybe tweak your changes to improve performance, but I need some hints what I can do.
That's what it's starting to sound like. I'm assuming that you installed without externals. If that's the case, check your Addons directory and make sure there's a directory called LibPeriodicTable-3.1. Inside that folder there should be several subfolders for consumables, gear, tradeskills, etc. Assuming all that is there, go ahead and log into WoW and at the character select screen, click the Addons button and make sure that LibPeriodicTable-3.1 is configured to load.
If that doesn't work, try installing the FBoH_PeriodicTable addon with externals, and see if that helps. Beyond that, I'm pretty much out of ideas, but let me know if it's still not working and I'll try to make something up... ;-)
I deleted all LibPeriodicTable-3.1 folders and reinstalled them -> Same Problem
I deleted the FBoH_PeriodicTable and reinstalled the version with externals -> This works
FBoH_PeriodicTable seems to work only when the libs are in the FBoH_PeriodicTable Addon directory.
If you installed without externals, make sure you have LibPeriodicTable-3.1 installed as well. If you already have that installed, let me know and I'll take a closer look at my code. :-)
I have LibPeriodicTable-3.1 r75432 installed. I have no glue what cause this problem.
I have an problem with FBoH_PeriodicTable. I cant select any PT category. There is only one entry called "No Value" available. Whats nessesary to use PT categories as filter?
We tried to track this probem down and this are our results...
* It was not possible to reproduce the freeze problem in an Altarac Valley battle group.
* Disabled Raidframes = No Spikes
* DogTag seems to be related to the issue. I was able to reduce the lag spikes from 5-10 seconds to 1-3 seconds after I hide most of the text messages on my frames. The lag was almost away (no lag freeze or only an very short "hick") after hiding ALL text messages.
* Recount/SWStats increase the freeze duration and produce an permanent lag, but no freeze until someone disconnect/login/zonein/change group
Currently, I'm using only the Charactername and the "Absolute" HP Tag on my frames. All other text parts are hidden. This reduce the freeze duration enough to prevent serious impact to my raid performance. But its still tricky when I need to react very fast and the freeze "trigger".
I tried grid as an alternativ raidframe with disabled pitbull raidframe, but I wasnt happy. The HP bars seems to have an delayed update and it feels laggy. The freezes are the same as with the minimized dogtag's.
0
What type of CPU use you?
I guildmate uses an 3 GHz Quad-Core Intel and was virtually "freeze free" after the 1/300 change. I'm using an 2.4 GHz Dual-Core and get rid of the problem around 1/600 - 1/900.
Maybe, LibDogTag-3.0 is too CPU-hungry and you can't eliminate the freezes on slower system.
0
r76872
r77057
There is an new check in Events.lua Line 575...
I decreased the 1/300 to 1/600, 1/900 and finally to 1/999 and all lag freezes are gone.
The first introduction (with 1/300) of the "fix" reduced my freeze spikes from 5+ seconds to 2 seconds. The are again shorter with 1/600 and are gone with 1/900. I decreased the value to 1/999 and run two sunwell raids.
Everything was fine, also if an raidleader shuffle the complete raid. I got multiple 2 second freezes with 1/300 value for 20-30 seconds if 5-10 players get an disconnect (telco failure) and come back later. This doesnt happens with 1/999 and also massive raid changes wont freeze the system with 1/999.
One sideeffect may be an reduced frame rate with very long dogtags on all 25 raid frames.
The following DogTag reduced my framerate from 45+ to 15 and was not usable on all 25 raid frames. But I can use them very well in 10 person raids.
Maybe we see an official LibDogTag-3.0 with my 1/900 or 1/999 change.
Please post your feedback here if you test this change.
0
The "Hack" was not hard.
Pitbull.toc
1. Modify X-Embeds: LibDogTag-2.0, LibDogTag-Unit-3.0 -> LibDogTag-2.0
Pitbull.lua
1. Modify Line 690: local DogTag = Rock("LibDogTag-3.0") -> local DogTag = Rock("LibDogTag-2.0")
2. Delete Line 691: Rock("LibDogTag-Unit-3.0")
3. Modify the Lines 3263-3265 and 6185-6187
-- if not WoW24 then
-- DogTag:SetColorConstantTable(self.colorConstants)
-- end
to:
DogTag:SetColorConstantTable(self.colorConstants)
Pitbull_MetaLayout.lua
I used the complete Pitbull_MetaLayout.lua from r65405 to get the old 2.0 DogTags.
0
Ok, the promised test wasnt done on thursday but I was able to join an 25 raid on friday. I used LibDogTag-3.0 r77057, LibDogTag-Unit-3.0 r77434 and Pitbull r77449.
The behavior was the same as on my last tests on monday. I got several mini freezes on different events.
Currently, I use only dogtags which are compatible with LibDogTag-2.0 and most are very simple default versions of pitbull. I have one more advanced dogtag-3.0 with several "HasAura" tags but this text was disabled on all frames at this test raid.
Is there an chance to see an "config switch" to force pitbul using LibDocTag-2.0 instead of 3.0? Most dogtags are compatible to 2.0 and this can help to verify the source of the freeze problem.
0
I have no auras enabled on my raid frames.
0
The test was done Thuesday around 21:00 GMT and I updated all ACE modules right before I started.
Anyway, I will do another test tomorrow and will update all modules before I start.
0
My latest testing on monday/thuesday was done with the latest LibDogTag-3.0 and Pitbull version. I used this versions for nearly one hour until I reverted.
There are several mini lag spikes. They are around 1 second and occur on different events...
- raid player is dying
- raid player releasing corpse
- raid player re-enter instance
- raid player changed group in raid (moved from group 1 to 6 for instance)
If only one (1) event triggers, its like an short "hicks" and you wont experience it if you are lazy. But if you have 3-5 players dying and they release their corpses one after another you get an "freeze chain" of multiple short freezes and this is an real problem.
The current combination of LibDogTag-3.0 and Pitbull is much better than the first release of LibDogTag-3.0 + Pitbull. The freezes where around 3-5 seconds short after the release. They are now 1 second or shorter but still very anoying and an real problem if you heal and must react. Most 25 raid fights are dynamic and fast reaction & movement is crucial. Short freezes can be the reason for an wipe chain and therefore is Pitbull currently no option for 25 raids.
EDIT: I can do further tests and maybe tweak your changes to improve performance, but I need some hints what I can do.
0
I'm reverted to Pitbull-65405 and everything is fine.
0
0
I deleted all LibPeriodicTable-3.1 folders and reinstalled them -> Same Problem
I deleted the FBoH_PeriodicTable and reinstalled the version with externals -> This works
FBoH_PeriodicTable seems to work only when the libs are in the FBoH_PeriodicTable Addon directory.
0
I tried this line and nothing happens. Is there an way to check LibPeriodicTable-3.1 is loaded? Maybe the lib is installed but not loaded.
0
I have LibPeriodicTable-3.1 r75432 installed. I have no glue what cause this problem.
0
0
0
* It was not possible to reproduce the freeze problem in an Altarac Valley battle group.
* Disabled Raidframes = No Spikes
* DogTag seems to be related to the issue. I was able to reduce the lag spikes from 5-10 seconds to 1-3 seconds after I hide most of the text messages on my frames. The lag was almost away (no lag freeze or only an very short "hick") after hiding ALL text messages.
* Recount/SWStats increase the freeze duration and produce an permanent lag, but no freeze until someone disconnect/login/zonein/change group
Currently, I'm using only the Charactername and the "Absolute" HP Tag on my frames. All other text parts are hidden. This reduce the freeze duration enough to prevent serious impact to my raid performance. But its still tricky when I need to react very fast and the freeze "trigger".
I tried grid as an alternativ raidframe with disabled pitbull raidframe, but I wasnt happy. The HP bars seems to have an delayed update and it feels laggy. The freezes are the same as with the minimized dogtag's.
I use the following addons...