• 0

    posted a message on DrDamage - Official Thread
    Quote from acirac
    Some of the tables in the Priest.lua data files have duplicate index numbers and thus cause errors. For ex.: Prayer of Healing has 2 indexes both numbered [6], Circle of Healing has 3 indexes numbered [5], Prayer of Mending has 3 numbered [1].


    Well isn't that embarrassing. I'm not sure how I missed that.

    It's fixed in the latest alpha and will be in the next beta build.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from poolcue32
    I just installed DrDamage since wotlk release, I used it in bc, and its not working on all my toons.
    My 78 paladin has no tooltips, no numbers on the actionbar, all the menus dont even show up on the mini map icon.
    70 warrior has all the same issues, but has all the mini map menus.
    70 warlock 42 mage has a few numbers on the actionbar, no tooltips and the menus look normal.
    the same sporatic results on the rest of my low level alts as well.
    Problem persists with no other addons loaded.
    I read a few pages back and didnt see anything relevant, sorry if its been posted about.


    It sounds to me like you're using the incorrect version. Please not that the DrDamage Curse page lists the latest RELEASE as 1.4.0 (which is old). You need to scroll down to the files list and grab the latest beta (as of this post it's 1.6.0b-4). Please also make sure that if you are using the curse client that you either set it to download beta versions (I think you can do this, I haven't used CC in a long time, so my memory is a bit fuzzy), or set it to ignore DrDamage altogether, and download the beta version yourself.

    If after doing this your issues persist, let me know.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from HunterZ
    DrDamage 1.6.0b-4 does not appear to be taking into account the +hit% from Hunters' Focused Aim talent.


    Thanks.

    It's in the alpha version now, and will be in the next beta release.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from xentropy
    Crit talent modifiers are still wrong (as per my post a page or two back) in the beta release. Will make people think crit is worth a LOT more than it is with those 250%+ crits. :)


    Sorry, I've gone through just now and set the crit damage modifiers to HALF the percentage shown in the blizzard tooltips (except for melee classes).

    Assuming Blizz is consistent in multiplying the value in the tooltip and the standard crit damage modifer (0.5), this should produce the right value.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    UPDATE:

    Beta version is up on curse. Please read the known issues on the curse page!

    Also, I'd just like to ask that users be aware that this is early-beta quality. It is 99% working, though numbers can be up to 10% inaccurate with talents. This can only be fixed through testing to locate the exact calculation issues.

    I'm releasing it now because Wrath is 2 days away and I'd very much like to get to 80 ASAP. I will have little time to do any extensive work on DrDamage during this time (though I will fix any show-stopping bugs!), and felt it wouldn't be fair to leave users without some kind of DrDamage functionality for another 2 weeks.

    I welcome bug reports and inaccuracy reports, as long as they are detailed (please see the DrDamage curse page for information on submitting bugs).

    Please be kind with the bug reports, and remember, this is only an early beta! =)
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from sr1030nx
    I was just going through the pally seal info because i just got Seal of the Martyr, and noticed that the info seems to be off.

    You have Seal of the Martyr/Seal of Blood listed as doing ppm which is not correct, the seal goes off everytime you hit, like SoR.

    I also believe that Seal of Vengeance/Seal of Corruption is no longer a proc, it should be going off everytime you hit now as well.

    Will you be adding support for glyphs in at all?

    Btw great job on updating the mod, thanks a lot.


    Paladins are tricky because their abilities work so much differently than all the other classes. They also work in ways that aren't well documented. Other than shamans, they're the only class that really has to worry about procs at all, and this kind of information isn't well documented. I also don't play a paladin as my main, so I must admit, I'm nowhere near an expert on the paladin class. As such, I apologize for any issues that arise with paladin abilities, and I'm sure there are many.

    I'll go back and fix SoV/C and SotM/SoB to remove ppm.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    DrDamage r746:
    Ok, I've added support for 4.2.0-beta1 and 4.2.0-beta2 versions of BT4. DrDamage is still backwards compatible with the 4.1.2 version of BT4.

    I did a quick test and it seemed to work with both versions. Let me know if you come across any further issues.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from xentropy
    The ice shards bonus for mages (frost's +100% critical strike BONUS damage) is currently calculated incorrectly, adding 100% to the damage of crits (as in 250% total damage) instead of only adding 100% to the bonus (50% being the normal crit bonus, doubling that gives you 100%, plus the 100% normal hit = 200% total damage). Changing the:
    [GetSpellInfo(11207)] = { [1] = { Effect = (1/3), Spells = "Frost", ModType = "critM", }, },

    line near the end to:
    [GetSpellInfo(11207)] = { [1] = { Effect = (1/6), Spells = "Frost", ModType = "critM", }, },

    in my local Mage.lua fixed the issue (and seems to calculate fine then even with the chaotic skyfire diamond meta and other crit modifiers), but I'm not sure if this is just an issue with Ice Shards specifically or whether it's an issue with the way all crit bonus damage modifiers are handled by DrDamage, so I thought I'd let you know so it can be looked into further.

    Edit: In fact, seeing that Burnout's bonus is listed at 0.1 per talent point and it also only affects the bonus damage, not total crit damage, I suspect it would also give improperly large crit calculations. (Should be 175% crits fully talented, but you'd see 200% in-game based on 0.5 from 5 points since it's the same bonus type as Ice Shards in the code.) Spell Power in arcane is also similarly broken. This issue may not be limited to mages since every one of our crit talents is wrong.

    Edit2: Looks like Ruin is correct (0.1 per point, total 100% BONUS damage with 5 points), but Elemental Fury for shamans says 0.5, which if it works like the others would be per point, when it should be 0.5 total from 5 points, so should be 0.1. I suspect elemental shamans are seeing insane crit damage numbers on their tooltips. :) Ha! Yeah just tested and logging on my level 22 shaman and manually overriding to give myself 5/5 Elemental Fury tells me my lightning bolts hit for 128 and crit for 511. That's 400% damage crits. I wish! That 0.5 in the shaman.lua for Elemental Fury should be 0.1.

    Edit3: So to summarize, Elemental Fury in the shaman.lua needs to be changed from a CritM modifier of 0.5 to 0.1 Also, in the mage.lua, Ice shards should be changed from 1/3 to 1/6, Burnout from 0.1 to 0.05, and Spell Power from 0.25 to 0.125. In druid.lua, Vengeance should be changed from 0.2 to 0.1. Priests and warlocks are already correct. I am not familiar enough with melee classes to be comfortable checking their crit damage modifiers. Just search for CritM and modify the Effect = X value on that same line according to which talent it's referring to (named in a list above). I'd do it myself but don't know how to check in files and such.


    Thanks for the info. I'll go through a double check each crit damage talent to make sure it's giving the appropriate bonus.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from Eatsbrains
    Ok, I think I was able to localize the problem, but at the same time, I am not sure if this will cause any problems in the long run. The release notes from the wowace page for Bartender4 4.2.0 Beta 2 do not show everything that the alpha release notes did, so here is a copy of the release notes I got from my git client:


    Seeing as how the error on line 136 referred to a nil value, I modified the DrDamage.lua file line 136 from
    local func = function(button) return button.Secure:GetActionID() end

    to
    local func = function(button) return button:GetActionID() end

    which seemed to fix all the problems. I tested it solo in combat to make sure that no errors occurred and nothing seemed to happen. My lua coding knowledge is fairly limited, so feel free to tear this post apart.


    Yep, I located the issue a little earlier and it's fixed in my internal build. I'll upload it shortly. Thanks.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from canislupus01
    [2008/11/09 11:16:06-2888-x1]: DrDamage-1.5.0\DrDamage.lua:136: attempt to index field 'Secure' (a nil value)
    <in C code>: ?
    AceEvent-2.0-91091 (AutoBar):368: in function <...ce\AddOns\AutoBar\libs\AceEvent-2.0\AceEvent-2.0.lua:345>
    

    Hi, Dally, thank you for your hard work and patience.

    I'm getting this error with the latest r745 build with Bartender4 installed. Just letting you know, in case it's helpful. Also worthy of note: I am not getting any text display on my Bt4 buttons yet, even with the latest build. If I have missed something obvious by not reading the entire thread, I apologize, but I thought this information might help.

    Again, thank you for putting up with everyone.


    I've noticed that a lot of the bug reports where the issue has been "using the files from curse", has generally involved the files being in a folder called DrDamage-1.5.0\. By default, as far as I'm aware, the latest builds of DrDamage should be in a folder simply called DrDamage.

    Can you verify that you don't have the Curse Client installed? And if you do, please make sure it's not set to update DrDamage (or it will automatically overwrite the alphas with the old beta from Curse).

    The reason why I suspect this to be an issue is that I have been using Bartender4 since I started working on DrDamage, and I have never seen this issue.

    I've also noticed that there is a new beta version of BT4 available (4.2.0-beta1 and 2). I'm using the release version 4.1.2 at the moment. If after checking the Curse Client stuff you still have an issue, try using BT4 4.1.2. If you still have an issue after all this, let me know.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from Watch
    Hi there, i'm getting this bug when i log on my priest, after which no numbers show on the actionbar (at least using Bartender4):

    Date: 2008-11-08 20:26:29
    ID: 51
    Error occured in: Global
    Count: 1
    Message: ..\AddOns\DrDamage\Data\Priest.lua line 27:
       attempt to index global 'baseSpell' (a nil value)
    Debug:
       ...ace\AddOns\Quartz\libs\AceEvent-2.0\AceEvent-2.0.lua:261: TriggerEvent()
       ...ace\AddOns\Quartz\libs\AceEvent-2.0\AceEvent-2.0.lua:925:
          ...ace\AddOns\Quartz\libs\AceEvent-2.0\AceEvent-2.0.lua:923
       [C]: ?
       ...ace\AddOns\Quartz\libs\AceEvent-2.0\AceEvent-2.0.lua:264: TriggerEvent()
       ...ace\AddOns\Quartz\libs\AceEvent-2.0\AceEvent-2.0.lua:910:
          ...ace\AddOns\Quartz\libs\AceEvent-2.0\AceEvent-2.0.lua:903


    self.Calculation["PRIEST"] = function ( calculation, ActiveAuras )
    -->	if ActiveAuras["Shadowform"] and baseSpell.School == "Shadow" then
    		calculation.dmgM = calculation.dmgM + 0.15
    	end
    end


    I suspect the change in the AURAS-section from
    self.PlayerAura[GetSpellInfo(15473)] = { School = "Shadow", Value = 0.15 }
    to
    self.PlayerAura[GetSpellInfo(15473)] = { ModType = "ActiveAura", ActiveAura = "Shadowform" }
    could be partially responsible.

    Or it could be because there's no spell in self.Calculation["PRIEST"], thus nowhere to get baseSpell-values from


    My mistake. The fix is very simple. I'll upload it now. Thanks.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Update: I'm almost done my final pass on the classes. Once that's done, I'll post a beta to curse.

    However, I would like to mention a potential problem:

    I live in a very large house with 13 other students. Recently, someone contracted a virus, which led to our ISP cutting one of our two internet connections. Someone had the bright idea of funneling everyone into the remaining internet connection (without tracking down the virus first!). So I'm on an internet connection designed for 4 people, with 13 other people, and a virus running around. Our internet has been throttling us all day for over-usage, and I've spent most of the day without a viable internet connection. We have failed to track down the virus so far, despite repeated scans on most computers. I'm told that if our ISP discovers the virus causing problems again they will cut our internet access for 30-days, non-negiotiable.

    I will do my best to get the 3.0.3 changes uploaded and a beta out before that happens, but if it does happen, it could be at any moment.

    I'd like to take this opportunity to express just how much I hate people who don't take proper care of their computers.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from n4th4ni3l
    Are there any plans/possibilietes to add Glyph of Healing Touch to calculations? I have it currently on my druid and since it cuts heal amopunt by half tooltip is pretty incorrect now.


    Glyphs are on the TODO list, but don't expect them anytime soon as there are far more pressing issues to sort out first.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from rothomp3
    OK, I don't know if you're ready at all for any Paladin bug reports from people with talents but here's something anyway :P

    Using revision 742, I now have numbers and tooltips on most skills, even full talented Prot. Hammer of the Righteous doesn't, but I'm sure you just haven't gotten to it yet.

    On with the actual bug: the damage listed on the tooltip for Seal of Corruption is just increasing steadily but slowly as I play. Right now it's up to 973389. That would be pretty nice, but definitely seems to constitute a bug of some sort.

    Also, the coefficients for Pally healing spells (untalented) are off, they were increased by more than other class' were after the spellpower change. Flash of Light receives 100% of Spell Power untalented, and Holy Light gets 166%.


    I'll take a look at Seal of Corruption.

    I was under the impression that all healing coefficients were modified to use 188% of spell power (to make up for the change from +healing/+damage -> spell power).

    Can you provide a link to a source for your "100/166% healing" information? It would help greatly.
    Posted in: General AddOns
  • 0

    posted a message on DrDamage - Official Thread
    Quote from dday0612
    Hello all,

    Thanks in advance for any help you can give me. I am new to this add on and having a problem. The add on works great with my warlock, but I get on with my shaman and it does not work at all.

    I got the most recent file instead of the curse.com one.

    /snip


    I'm 99% confident you're not using the latest version. The first error points to a line that is absolutely working. The second error points to a line that couldn't possibly cause that error, and the third error you posted points to a line of code that is just a comment in the code (and therefore couldn't cause that error).

    It's possible you may have the curse client and it's overwriting any alpha versions you download with the old beta versions on curse? I'm not sure what the issue is, I can only conjecture, but regardless, can you please double and triple check that you have r740 from the wrath-clone branch?
    Posted in: General AddOns
  • To post a comment, please or register a new account.