• 0

    posted a message on Tank Warnings
    Hello,

    I've just released the first release candidate of Tank Warnings. It's very similar to the old Tankalyze and in fact pretty much inspired by it, even copied several of the messages etc.

    Some of you guys might ask why I didn't provide changes to Tankalyze and/or fix it etc, well, I tried, I looked at the old Tankalyze code, started to convert it to Ace3 and fix several problems or code I didn't think it was the best, and in the end I was making a whole new addon, plus, added a couple of new features in that I found myself doing through macros (like BigWigs timers) in the mix, also providing support for Paladins and Death Knights, and ended up making a whole new one which I'll pay more attention to and of course add new better features if users request them.

    The purpose of this thread is just a feedback issue and an alert to all tanks and developers out there to point out everything you guys see fit. My main programming language isn't Lua, therefore any hints and tips to perfect anything are more than welcome.

    Only thing I ask is to post bugs in the bug tracking only, feature requests are ok here, but try to add them to the tracking system also to keep myself organized.

    Best regards,
    Posted in: General AddOns
  • 0

    posted a message on do end closures
    Oh lovely, thank you guys for all the feedback
    Posted in: Lua Code Discussion
  • 0

    posted a message on do end closures
    Thank for all the answers, sounds a good way of using easy to identify function names without being afraid of name clashes in the file scope as Arrowmaster has pointed.

    Best regards,
    Posted in: Lua Code Discussion
  • 0

    posted a message on do end closures
    Thank you very much, was what I was thinking, still, I have a strange feeling as there is something behind the reason some authors use do/end, for instance in Classtimer example, as Adirelle as pointed out very well, the author references the local MouseUp in a closure which will be used in a meta table, is there any performance advantage doing it the same way he did ?

    To simplify the example (unless you guys want to check out Classtimer.lua)

    local bars
    do
            local function MouseUp()
                    ...
            end
    
            local framefactory = {
                __index = function(t,k)
                    ...
                    -- reference MouseUp here for instance
                    aframe:SetScript('OnMouseUp', MouseUp)
                end
            }
    
            bars = setmetatable({}, framefactory)
    end
    Is the above better performance wise than:

    local MouseUp()
            ...
    end
    
    local framefactory = {
            __index = function(t,k)
                ...
                -- reference MouseUp here for instance
                aframe:SetScript('OnMouseUp', MouseUp)
            end
    }
    
    local bars = setmetatable({}, framefactory)
    The only reason I can think of that would make the first example faster than the second is that the table inside the do/end closure holds less function names thus the search for MouseUp in that scope might be a bit faster than on the file scope is this correct ? or are there more advantages ?
    Posted in: Lua Code Discussion
  • 0

    posted a message on do end closures
    Hello,

    I'm currently writing an addon, and lua is not a language I'm proficient so i've been spending a bit of time reading some code from widely known addons.

    Although I understood the majority of the code I saw and still see, there is something causing me some confusion, as in, what's the benefit (if there is one performance wise or another one) or if it's just something related to variable scopes (and why is it's purpose by keeping them in a private scope), which is the usage of do end closures.

    For instance this small example taken from Classtimer
    do
            local function MouseUp()
                ...
            end
            ...
    end
    or for instance the do/end sandbox with tioptionsm/OnUpdate functions.

    From what I understood reading the PIL, the usage of do end blocks while defining functions (sandboxes as they call them) are mainly to isolate variables, trapping them inside a local scope to prevent them from being called globally (PIL used an example when you redefine a function), in the example above I can't understand what benefit there is in creating a sandbox could someone either point me to the right direction (manual or discussion) or enlighten me a bit ?

    Thanks,
    Posted in: Lua Code Discussion
  • 0

    posted a message on CPU Usage issues
    After spending a great deal of time around this problem, I recently found what was causing my FPS loss, and it wasn't the addons, it was CPU Throttling.

    I has to be WoW causing the throttling either on purpose or accident, but I had to disable CPU Throttling completely to fix the issue, only drawback I have now is that I don't know my CPU temp, but, at least for me that isn't an issue at all, I know it's cool enough, and because of this there shouldn't be any reason why the throttling was happening.

    I have an Intel Pentium D with Hyperthreading btw, (Disabled CPU Throttling in the BIOS)

    Best regards,
    Posted in: Ace3
  • 0

    posted a message on CPU Usage issues

    I honestly would love that :) but unfortunately, i can't afford a new one yet :(

    This one has served me well, and, i had no problems before 2.4 :S

    Best regards,
    Posted in: Ace3
  • 0

    posted a message on CPU Usage issues

    Honestly, i don't get it anymore....

    I cleared everything, WTF, Interface, Cache, couldn't notice any big FPS changes, stood around 40~50 all the time.

    Returned everything back again (with the exception of cache ofc), and started to enable addons (btw i ditched pitbull, switched to agUF) 1 at a time, first one in the list was agUF, had no problems running it for like 15 mins, after i enabled Bongos, problems started (today they started, while yesterday bongos alone had no problems), and i just gave up.....

    I'm starting to guess this is an issue with WoW and/or addon channel messaging spam, but i'm really tired of guessing as everything i try just doesn't fix and/or makes me find what the real problem is.

    I was leveling my pally last night for about 2 hours without problems (although i had some FPS losses right after i logged in for about 30 mins), today, raiding was a nightmare, and as some can imagine, ain't very good to have a tank at 1FPS every 2~3 mins.

    I really don't know what else to do...

    Thanks for all the help, best regards,
    Posted in: Ace3
  • 0

    posted a message on CPU Usage issues

    Hello,

    I'm currently raiding, and, the CPU usage is from WoW, normally, wow is using 3~5% of CPU, when i get the FPS loss issue, it just to around 20% sometimes more, so this kinda rules out the possibility of something running in BG causing the issue.

    Tested with no addons, it happens also, but, with less impact on FPS drop, wow randomly jumps up to around 20% cpu usage even with no addons running.

    Best regards,
    Posted in: Ace3
  • 0

    posted a message on CPU Usage issues

    Well, i'm starting to get embarassed, as Xinhuan theory about being OS/Hardware related seems to be more plausible than ever.

    A few days back, i changed the update state of some stuff to warn me first before doing the update, stuff like Avast and windows updater, because i can't choose when they go poll the update servers to check for updates, they keep doing it in a fixed interval, and when they did that, i had the usual WoW sluggish, so, they both were with pending updates.

    Yesterday, i updated everything, set the updating to manual, i always run wow without clutter in the BG (only thing that keeps running is Avast and Windows Defender), then i enabled most of the addons (only things disabled are raid related) and went to level my 55 pally a bit.

    A few minutes after, the FPS drop happened again, (no HD usage at all when that happens), i continued even so, i think i had like 2 or 3 more happen after, BUT, a few moments later, i think i spent like 1 or 2 hours without it happening again.

    Watching the board monitor, no issues with temp or voltage, HD IO isn't touched at all when the CPU increase happens, but watching task manager i noticed that when the FPS drop issue happens only System and WoW increase slightly the CPU used, i'm more inclined to blame the OS, probably something is polling at a regular interval.

    I'm going to raid today, going to do some more testing, tell you guys something later.

    Best regards,
    Posted in: Ace3
  • 0

    posted a message on CPU Usage issues

    Sounds fair, i must confess i didn't thought about that possibility, which i'm going to look into right now.

    The only reason i haven't thought about it was because it wasn't usual for this to happen, i did have FPS drops before, but, they were known causes (windows defender doing a scan, or avast doing an update) thus they're scheduled at lat times in the night (4~5am) and never gave me problems during raids.

    Still is a very plausible explanation, something might have changed and i recklessly discarded that possibility.

    Best regards,
    Posted in: Ace3
  • 0

    posted a message on CPU Usage issues

    Ok, so that there are no doubts about how the testing was made, let me explain thoroughly how it was done.

    I deleted all addons, and re-installed using WAU WITH externals and only installed by hand 1 or 2 that aren't in WAU.

    After that, i disabled all addons, and logged in, for 15 mins, standing still in shattrah, no FPS drop during this time.
    Next, i enabled 1 addon at a time (there was never 2 addons running at the same time, only one, with the exception of addons that break into other small ones like Pitbull or Bigwigs or Bongos, which i enabled all small ones). Logged in and waited 5 mins for each addon, or, untill the FPS drop issue happened, and marked the addons that cause the issue, and the ones that don't, so here are my findings:

    Addons causing the FPS drop issue:
    BigWigs
    ClassTimer
    CyCircled
    ErrorMonster
    Omen2
    oRa2
    Quartz
    RatingBuster
    SharedMedia
    simpleMinimap
    Skinner
    SLDataText
    Tankalyze
    TrinketMenu
    XLoot
    XRaidStatus

    Addons that do not cause the FPS drop issue:
    BigBrother
    Bongos3
    Bufallo
    ClearFont2
    ClosetGnome
    CooldownCount
    Cowtip-3.0
    Deadened
    FuBar-3.0
    Pitbull

    I haven't search the addons giving issues for a common library that causes the issue, because i truly believe it's not the addon itself.

    Can anyone point me out a fast and eficient way of narrowing down the library causing this ?

    Best regards,
    Posted in: Ace3
  • 0

    posted a message on CPU Usage issues

    True tuller, i missed that.

    After all afternoon trying to figure out who's responsable for the issue, i gave up using no externals, too much stuff to enable/disable to keep dependencies and search the one.

    So i'm atm reinstalling everything with externals, and, going to enable 1 by 1 untill i find it.

    Btw, i don't use grid, and disable Pitbull_Auras they're not the ones.

    Best regards,
    Posted in: Ace3
  • 0

    posted a message on CPU Usage issues

    Here's my latest findings,

    Addons using Ace3:
    - CooldownCount
    - Deadened
    - Omen
    - SLDataText

    I tried this, i disables all Ace3 addons and Ace3 libs and kept profiling, the addons disabled were:
    - Lib:Ace3
    - Lib:Threat-2.0
    - CooldownCount
    - Deadened
    - Omen
    - SLDataText

    I left everything else i use on, also cpu profiling enabled and !Profiler, unluckily, the random FPS drop still occurred, showing Profiler on top.

    I just disabled !Profiler and CPU profiling and the issues continue, standing still in shattrah, at random time intervals i get my FPS lowered by alot.

    At this moment i'm disabling addons 1 by 1 to try to catch the one responsable for this, but i have a feeling inside that tells me it ain't 1 only, but a combination of them, i think i can safely say i was wrong and the issue isn't Ace3 or addons using Ace3 as they're currently disabled and the issue remains.

    More news soon after the tests i'm doing.

    Best regards,
    Posted in: Ace3
  • 0

    posted a message on CPU Usage issues
    Hello,

    I don't know if this has been reported yet, but i did search, and found nothing related to it.

    Ever since 2.4 hit live, i've been having a FPS problem related to CPU usage, every 3 or 4 minutes, for about 10 seconds, my FPS drop to 4~5 outside of raids, and 1 in raids.

    Every since this problems started, i enabled cpu profiling and installed Profiler.
    Due to the way i was installing addons (WITH externals) i quickly understood that the profiling was done wrong due to embed libs, and decided to completely re-install everything, and, take advantage of it and re-do my UI.

    The first thing i noticed after doing this, was Bartender3 right in the top of CPU usage when my 10 second lag showed up, well, although i love bartender3, i decided to try out something else, so i installed Bongos3 (btw i have CyCircled fixed to skin Keyring and bags for Bongos3), and everything seemed ok, untill for my sadness, the FPS drop happened again.

    Please note, the FPS drop (caused by excessive CPU Usage for a long time) happens wether i'm in raids or not, the only diff is, in raids it actually drops to 1 sometimes even lower.

    All my Video settings are completely low with everything that might decrease FPS turned off, my audio settings are all low also.

    The following screenshot, displays Profiler when the 10~15 second excessive CPU usage happens, it's ordered by 'CPU' (current cpu usage)

    http://www.ngen.org/ss/ace3slow.jpg

    As shown above, Ace3 uses ALOT of CPU during 10~15 secs, when is stops using it, everything returns to normal.

    The following screenshot, displayer Profiler running normally, ordered by 'CPU Peak'

    http://www.ngen.org/ss/profiling.jpg

    LibDogTag-3.0 is a major CPU hogger, although the CPU increase is not noticeable to the point of being unplayable, i think it has room to improve.

    ClearFont2 had a small peak, probably when i went to configure something there, but, remains quietly obviously, has no reason at all to be CPU intensive.

    The rest are normal values (except Ace3 ofc), i don't know honestly if the blame is Ace3 or an addon using Ace3, i tried everything, 1 addon at a a time, and never have any issues with 1 addon alone, when they're all on, all hell breaks loose (which makes me believe it's another addon using Ace3).

    I'm going to make a grep around and search which addons are using Ace3 that i have installed and update this post.

    In the meanwhile, any idea on how can i narrow the issue even more in order to fix this ? because running BT/Sunwell with random 1FPS ain't very good.

    Best regards,

    Edit: removed Ace3 from the topic, as i'm almost sure this issue is not related to Ace3 alone.
    Posted in: Ace3
  • To post a comment, please or register a new account.