• 0

    posted a message on Cartographer Data Module ( unofficial)
    Quote from OrionShock »

    also those getting errors. try loading the _Notes, _Herb, _Mining, _Treasures DB with out the _Data module. i think it's freaking out because there is no established database.
    Look at the errors:
    "RegisterNotesDatabaseOLD", "table expected, got nil" = "Here, reference something that dosn't exist"

    "Cartographer_Treasure.lua", "Cannot unregister a database not registered" = "Here take my name off the list", ..."But sir your not on the list to begin with?"


    Actually what is happening is Cartographer_Data is hooking the RegisterNotesDatabase function and replacing the database that is passed in with it's own copy. The problem is that it is nil'ing out the variable that it uses for it's own copy, so if the database is disabled and then reenabled it will be using a nil pointer on the second call.

    Reproduction steps:

    In Cartographer go to the Cartographer menu and select Treasure => Enabled, to turn off that module. Then choose the same menu item again at this point you will get the error. The replacement core.lua that I posted above fixes this problem by only replacing the database the first time register is called. Since the Cartographer_*DB variable is also updated this fix will since use Cartographer_Data's database un subsequent enables and disables.
    Posted in: Map/Minimap AddOns
  • 0

    posted a message on Cartographer Data Module ( unofficial)
    Quote from OrionShock »

    problem with merging nodes is that the _data file is static and the SV file is not. you will run into the issue of overlaping nodes.

    I believe the gathering addons already take care of looking for existing nearby nodes.

    Quote from OrionShock »

    --The IDEA behind one of these things is for this "Addon" to be used in conjunction WITH the WoWheadLooter addon to provide a full circle effect.

    Use wowheadlooter to gather new nodes, Cart dosn't save them. you upload new nodes to wowhead.
    tommarow when the dataminer is run - new node appears in preform db.

    Yes, but it would be nice to be able to save stuff between updates. Have Cartographer_Data replace that data when it's updated but otherwise keep the data in the mean time. Something like this would do it. Though it could be improved to use $LastChangedRevision$ in each of the generated data files. (I also have a ugly hack in this example to fix a problem I've seen with the treasure icons).

    Cartographer_Data = {}
    
    local Cartographer_Data = Cartographer_Data
    local _G = getfenv(0)
    
    local treasure_icon = {
    }
    
    local svn_revision = tonumber(("$Revision: 46020 $"):match("^%$Revision: (%d+) %$$"))
    
    local RegisterNotesDatabaseOLD = Cartographer_Notes.RegisterNotesDatabase
    function RegisterNotesDatabaseNEW(Cartographer_Notes, name, db, ...)
    	if Cartographer_Data[name] and (not db.svn_revision or db.svn_revision < svn_revision) then
    		db = Cartographer_Data[name]
    		db.svn_revision = svn_revision
    		if name == "Treasure" then
    			-- Fix Icon's for Treasure
    			for k,v in pairs(db) do
    				if type(v) == "table" then
    					for pos,name in pairs(v) do
    						if type(name) == "string" then
    							local icon = treasure_icon[name] or Cartographer_Treasure and Cartographer_Treasure:getIcon(name)
    							treasure_icon[name] = icon
    							v[pos] = { ["title"] = name, ["icon"] = icon, }
    						end
    					end
    				end
    			end
    		end
    		Cartographer_Data[name] = nil
    		_G["Cartographer_"..name.."DB"] = db
    	end
    	RegisterNotesDatabaseOLD(Cartographer_Notes, name, db, ...)
    end
    Cartographer_Notes.RegisterNotesDatabase = RegisterNotesDatabaseNEW
    Posted in: Map/Minimap AddOns
  • 0

    posted a message on Cartographer Data Module ( unofficial)
    I noticed that Cartographer Data does not seem to handle a database being enabled and then disabled. This change to core.lua should fix this. It might be better to have this code merge in it's data instead of just blindly replace the database.

    Cartographer_Data = {}
    
    local Cartographer_Data = Cartographer_Data
    local _G = getfenv(0)
    	
    local RegisterNotesDatabaseOLD = Cartographer_Notes.RegisterNotesDatabase
    function RegisterNotesDatabaseNEW(Cartographer_Notes, name, db, ...)
    	if Cartographer_Data[name] then
    		db = Cartographer_Data[name]
    		Cartographer_Data[name] = nil
    		_G["Cartographer_"..name.."DB"] = db
    	end
    	RegisterNotesDatabaseOLD(Cartographer_Notes, name, db, ...)
    end
    Cartographer_Notes.RegisterNotesDatabase = RegisterNotesDatabaseNEW
    Posted in: Map/Minimap AddOns
  • 0

    posted a message on Baggins_ClosetGnome/Baggins_ItemRack/Baggins_Usable/Baggins_Professions
    Quote from Samasnier »

    Getting an error when I try to use the Flush or Flush&Get features:
    [2007/06/20 12:06:32-1399-x1]: ClosetGnome_Banker\Banker.lua:266: bad argument #1 to 'pairs' (table expected, got nil)
    ClosetGnome_Banker\Banker.lua:266: in function `Flush'
    ClosetGnome_Banker\Banker.lua:292: in function `func'
    Dewdrop-2.0-40744 (AHsearch):643: in function <...ace\AddOns\AHsearch\libs\Dewdrop-2.0\Dewdrop-2.0.lua:582>

    -



    I think you posted this to the wrong thread. The thread you want is probably ClosetGnome - Wear it or lose it. since I don't see a specific ClosetGnome_Banker thread.
    Posted in: General AddOns
  • 0

    posted a message on addonpkg - Perl command line svn addon updater and archiver. (Mac OS X/Windows)
    Quote from Moong »

    Is there any way to use this script to add addons with the libs still embedded?


    Yes, but you will need to edit the .addonpkg.addons file in your stage directory, and add a line for each addon that needs externals. Something like:
    addonname -extern -override -svn http://svn.wowace.com/wowace/%Branch%%Name%
    replacing addonname with the name of the addon you wish to fetch with externals. You can also add a "-nosplit" to prevent an addon from being split into modules.
    Posted in: Updaters
  • 0

    posted a message on addonpkg - Perl command line svn addon updater and archiver. (Mac OS X/Windows)
    Unfortunately the error messages indicate a problem with svn.wowace.com and not the script itself. There is nothing I can do to fix this, the only thing is to wait till the SVN server is fixed.
    Posted in: Updaters
  • 0

    posted a message on addonpkg - Perl command line svn addon updater and archiver. (Mac OS X/Windows)
    Recently the LoD addons that were embedded in BigWigs got moved to separate folders. This caused the database that addonpkg uses to keep track of the components to be out of date. The fix is to remove the .addonpkg.addons file in your staging directory and then fetching BigWigs and any of the now separate addons you need.
    Posted in: Updaters
  • 0

    posted a message on addonpkg - Perl command line svn addon updater and archiver. (Mac OS X/Windows)
    Quote from beesknees »

    I've recently run into troubles with how addonpkg installs the Ace2 set of libraries. Addonpkg splits up Ace2 separate addons called Ace2_##:


    I've uploaded a new version which should properly split the Ace2 library and many other LoD addons. Sorry that I haven't had more time of late to work on this.
    Posted in: Updaters
  • 0

    posted a message on Manufac: Retooled Professions
    In case you are interested I created a patch for Manufac and ManufacSnoop that allows it to use GetItemInfo to categorize many items that currently fall into the unsorted category automatically. I've attached the changed files to this message.

    --- orig/Manufac/Manufac.lua  2007-04-01 18:49:00.000000000 -0400
    +++ Manufac/Manufac.lua 2007-04-01 20:04:35.000000000 -0400
    @@ -21,6 +21,7 @@
     local self = Manufac
     local dewdrop = AceLibrary("Dewdrop-2.0")
     local BS = AceLibrary("Babble-Spell-2.2")
    +local BI = AceLibrary("Babble-Inventory-2.2")
     local stitch = AceLibrary("Stitch-1.1")
     local tablet = AceLibrary("Tablet-2.0")
     local PT = AceLibrary("PeriodicTable-3.0")
    @@ -41,6 +42,72 @@
        ["easy"] = "|cFF44CC44",
        ["trivial"] = "|cFFAAAAAA"
     }
    +local equiploc_to_set = {
    +    ["INVTYPE_AMMO"] = L["Ammo"],
    +    ["INVTYPE_HEAD"] = L["Head"],
    +    ["INVTYPE_NECK"] = L["Neck"],
    +    ["INVTYPE_SHOULDER"] = L["Shoulders"],
    +    ["INVTYPE_BODY"] = L["Shirt"],
    +    ["INVTYPE_CHEST"] = L["Chest"],
    +    ["INVTYPE_ROBE"] = L["Chest"],
    +    ["INVTYPE_WAIST"] = L["Belt"],
    +    ["INVTYPE_LEGS"] = L["Pants"],
    +    ["INVTYPE_FEET"] = L["Boots"],
    +    ["INVTYPE_WRIST"] = L["Bracers"],
    +    ["INVTYPE_HAND"] = L["Gloves"],
    +    ["INVTYPE_FINGER"] = L["Finger"],
    +    ["INVTYPE_TRINKET"] = L["Trinkets"],
    +    ["INVTYPE_CLOAK"] = L["Cloak"],
    +    --["INVTYPE_WEAPON"] = nil,
    +    ["INVTYPE_SHIELD"] = L["Shield"],
    +    --["INVTYPE_2HWEAPON"] = nil,
    +    --["INVTYPE_WEAPONMAINHAND"] = nil,
    +    --["INVTYPE_WEAPONOFFHAND"] = nil,
    +    --["INVTYPE_HOLDABLE"] = nil,
    +    --["INVTYPE_RANGED"] = nil,
    +    --["INVTYPE_THROWN"] = nil,
    +    --["INVTYPE_RANGEDRIGHT"] = nil,
    +    --["INVTYPE_RELIC"] = nil,
    +    --["INVTYPE_TABARD"] = nil,
    +    ["INVTYPE_BAG"] = L["Container"]
    +}
    +local type_to_set = {
    +    --[BI["Cloth"]] = nil,
    +    --[BI["Leather"]] = nil,
    +    --[BI["Mail"]] = nil,
    +    --[BI["Plate"]] = nil,
    +
    +    --[BI["Idols"]] = nil,
    +    --[BI["Librams"]] = nil,
    +    --[BI["Miscellaneous"]] = nil,
    +    --[BI["Totems"]] = nil,
    +
    +    [BI["Axe"]] = L["Axe"],
    +    [BI["Bow"]] = L["Weapon"],
    +    [BI["Crossbow"]] = L["Weapon"],
    +    [BI["Dagger"]] = L["Dagger"],
    +    [BI["Fist Weapon"]] = L["Weapon"],
    +    [BI["Gun"]] = L["Gun"],
    +    [BI["Mace"]] = L["Mace"],
    +    [BI["Polearm"]] = L["Polearm"],
    +    [BI["Shield"]] = L["Shield"],
    +    [BI["Staff"]] = L["Weapon"],
    +    [BI["Sword"]] = L["Sword"],
    +    --[BI["Thrown"]] = L["Weapon"],
    +    [BI["Wand"]] = L["Weapon"],
    +
    +    [BI["Ammo Pouch"]] = L["Container"],
    +    [BI["Arrow"]] = L["Ammo"],
    +    [BI["Bag"]] = L["Container"],
    +    [BI["Bandage"]] = L["Bandage"],
    +    [BI["Bullet"]] = L["Ammo"],
    +    --[BI["Drink"]] = nil,
    +    --[BI["Food"]] = nil,
    +    --[BI["Gem"]] = nil,
    +    --[BI["Key"]] = nil,
    +    --[BI["Potion"]] = nil,
    +    [BI["Quiver"]] = L["Container"]
    +}
     local function colors(item)
        if self.db.profile.smoothdiffcolor then
            local diff = PT:ItemInSet(item.link,"Tradeskill.Crafted."..BS:GetReverseTranslation(item.profession))
    @@ -562,6 +629,37 @@
        end
        return str
     end
    +function Manufac:LinkToSet(profession, link)
    +    local _, name, itemtype, subtype, loc, set
    +
    +    -- First check if defined explicitly
    +    _, set = PT:ItemInSet(link, "Manufac."..profession, true)
    +    if set then return set:match("Manufac%.[^%.]+%.(.+)$") end
    +
    +    -- Otherwise use item info if present
    +    name, _, _, _, _, itemtype, subtype, _, loc = GetItemInfo(link)
    +    if not name then
    +        --[[local itemid = link
    +        if type(link) == "string" then
    +            itemid = tonumber(link:match("item:(%d+)") or link)
    +        end
    +        Manufac:Print("No match for: "..itemid)
    +        --]]
    +        return L["Unsorted"]
    +    end
    +
    +    -- Try equipment location
    +    set = (equiploc_to_set[loc or ""]
    +        or type_to_set[itemtype or ""]
    +        or type_to_set[subtype or ""])
    +    if not set then
    +        --Manufac:Print("No match for: "..name..": loc: "..loc..", type: "..itemtype.."/"..subtype)
    +        return L["Unsorted"]
    +    end
    +
    +    --Manufac:Print("Found: "..name.." is "..set)
    +    return set
    +end
     function Manufac:ScanTrade(profession)
        if not self.db.profile.groups then
            self.db.profile.groups = {}
    @@ -575,12 +673,7 @@
                if skilltype~="header" and skillname then
                    local link = GetCraftItemLink(i)
                    if not self.db.profile.groups[profession][skillname] or self.db.profile.groups[profession][skillname] == L["Unsorted"] then
    -                    local _, set = PT:ItemInSet(link, "Manufac."..profession, true)
    -                    if set then
    -                        self.db.profile.groups[profession][skillname] = set:match("Manufac%.[^%.]+%.(.+)$")
    -                    else
    -                        self.db.profile.groups[profession][skillname] = L["Unsorted"]
    -                    end
    +                    self.db.profile.groups[profession][skillname] = self:LinkToSet(profession, link)
                    end
                end
            end
    @@ -590,12 +683,7 @@
                if skilltype~="header" and skillname then
                    local link = GetTradeSkillItemLink(i)
                    if not self.db.profile.groups[profession][skillname] or self.db.profile.groups[profession][skillname] == L["Unsorted"] then
    -                    local _, set = PT:ItemInSet(link, "Manufac."..profession, true)
    -                    if set then
    -                        self.db.profile.groups[profession][skillname] = set:match("Manufac%.[^%.]+%.(.+)$")
    -                    else
    -                        self.db.profile.groups[profession][skillname] = L["Unsorted"]
    -                    end
    +                    self.db.profile.groups[profession][skillname] = self:LinkToSet(profession, link)
                    end
                end
            end
    --- orig/ManufacSnoop/ManufacSnoop.lua 2007-03-22 22:25:16.000000000 -0400
    +++ ManufacSnoop/ManufacSnoop.lua    2007-04-01 19:58:25.000000000 -0400
    @@ -152,13 +152,7 @@
            )
            dewdrop:AddLine()
            for item,value,set in PT:IterateSet("Tradeskill.Crafted."..BS:GetReverseTranslation(prof)) do
    -            local _,group = PT:ItemInSet(item,"Manufac."..prof)
    -            if group then
    -                group = group:match("%.([^%.]+)$")
    -                temp[group] = true
    -            else
    -                temp[LM["Unsorted"]] = true
    -            end
    +            temp[Manufac:LinkToSet(prof, item)] = true
            end
            for k,_ in pairs(temp) do
                table.insert(temp2,k)
    @@ -181,12 +175,7 @@
                local thisgroup = arg1:sub(9)
                local prof = arg2:match("|([^%|]+)$")
                for item,value,set in PT:IterateSet("Tradeskill.Crafted."..BS:GetReverseTranslation(prof)) do
    -                local _,group = PT:ItemInSet(item,"Manufac."..prof)
    -                if group then
    -                    group = group:match("%.([^%.]+)$")
    -                else
    -                    group = LM["Unsorted"]
    -                end
    +                local group = Manufac:LinkToSet(prof, item)
                    if group == thisgroup then
                        local link,_
                        if prof == BS["Enchanting"] then
    Posted in: General AddOns
  • 0

    posted a message on UnitActionBars
    I found a slight typo in UnitActionBars as of at least revision 30979. Not sure when it first appeared.

    Main.lua:lines 213 and 494 both use uab.profile.db instead of uab.db.profile.
    Posted in: General AddOns
  • 0

    posted a message on Baggins_ClosetGnome/Baggins_ItemRack/Baggins_Usable/Baggins_Professions
    I haven't had as much time as I would like to update these lately, but I'll see if I can get Outfitter support added. I also received a update from Bleucheese that automatically creates bags for each outfit which I haven't had a chance to integrate yet.

    I've been thinking that a universal EquipmentSetLib might be the best way forward. It would recognize the equipment sets of several addons (ClosetGnome, ItemRack, Outfitter, etc) and allow them to be queried and synchronized (ala ClosetGnome_ItemRack).
    Posted in: General AddOns
  • 0

    posted a message on Baggins_ClosetGnome/Baggins_ItemRack/Baggins_Usable/Baggins_Professions
    Quote from Mal »

    I'm getting an error at Baggins_ItemRack.lua:271:AceLocale(Baggins_ItemRack): Translation "Self" does not exist.

    I've tried wiping out the WTF info and still getting this. I'm using ItemRack 1.991 and the 29078 build of Baggins_ItemRack. Any ideas?


    This should be fixed in the latest version. I haven't had a chance to test it yet though since I'm using ItemRack 2 Beta.

    Quote from FlareCDE »

    Curious, does this support the current Itemrack2 beta?


    It should, unless something has changed in the beta since the version I'm using.

    Quote from DGambler »

    Ok, I followed the below and it works perfectly... just one issue. My ClosetGnome items are showing up under "EquipSets" and "Armor" in my bag... any way to make a "negative" condition to remove CG items out of Armor?


    There are couple ways to do this. You should do only one of them.

    The first is to turn on the remove duplicates in the baggins menu (I think it's off the Item submenu, not in game right now). That option causes items to only appear once in any bag/section. The first section that matches is where items are displayed. If you followed the steps above exactly "EquipSets" should be before your other equipment and so this should just work for you.

    If you want to set items duplicated in other sections but want to just exclude your item sets from the Armor and Weapons Categories, you can do the following: ((Again, I'm doing this from memory, so the syntax might no be exactly right.))
    In the baggins menu choose "Edit Categories", expand the "Armor" category by clicking on the "+" next to it. Click on "Add Rule" to add a rule to that category. Set the rule type to ItemRack or ClosetGnome and the set to you wish to exclude. "Any" is a good choice. Finally the "Operation" should be set to "Not". Do the same for the "Weapons" Category, then "Apply" and "Close" the categories window.
    Posted in: General AddOns
  • 0

    posted a message on Request: OneBag/OneBank/OneView search / filtering.
    You might want to check out Sanity2 or Baggins.
    Posted in: Addon Ideas
  • 0

    posted a message on Baggins_ClosetGnome/Baggins_ItemRack/Baggins_Usable/Baggins_Professions
    Quote from fred »

    Could u explain for me how to add a 'set' just for pets? I'm a slow learner....:(


    If you mean a bag for your minipets that's a standard part of Baggins, and doesn't require any of these plugins. It's probably better to ask at the offical Baggins Thread, though it might be good to check out the wowace wiki entry for Baggins.

    Though to answer your question. You will need to add a "Category" with a "Periodic Table Set" rule with that set to Misc.Minipet. Then create a bag section and add that category to it.
    Posted in: General AddOns
  • 0

    posted a message on simpleMinimap, now with Ace2 goodness
    Quote from arjuna »

    funny how things work just fine here and others have so many problems with the same code.

    the huge-minimap-filling-the-entire-screen thing has been reported to me many times, but i never could replicate it very easily. the only way i could with regularity was by lowering the scale alot, moving it as far off the screen and i could get it and then increasing the scale. probably not what you're doing. it seems mods like FuBar and Titan maybe bumping the minimap off the screen unintentionally when they make room for their bars, but i don't seem to have that problem (i use FuBar, one bar at the bottom of the screen). if you can give me some insight as to why the minimap is taking over your screen i'd maybe get a better idea on how to fix it.

    scaling the minimap will crash the game if it's in the default position. strange. work-around is to move it a little. i'll get that fixed.


    I'll see if I can find a test case and write it up when I get the chance. For now here's a few more details, from memory. I get full screen issue when I switch from 28625 to 28962. My default set up is a square, which I have manually moved a bit. I think slightly down. I have a one FuBar at the top of my screen and two at the bottom of the screen. I run all my addons non-embedded with separate library addons. With 28962 the minimap takes up the entire screen. If I reset the addon, it goes back to the normal circle in the upper left. When I press the keyboard shortcut to zoom the mini map it zooms like normal but when I release it, it fills the full screen again. If I then try to reset the addon or reload the UI the game crashes. Also I use a UI scale of 0.64 as my default UI setting and run in windowed mode on a wide screen monitor. I also have a second monitor to the left of my main monitor, but none of the UI on that monitor.
    Posted in: Map/Minimap AddOns
  • To post a comment, please or register a new account.