• 0

    posted a message on Categorized/Sorting OneBag
    Quote from "Rowne" »
    I've been playing with it on Live (not Test).

    It does have a few issues but I've cleaned those up, these are probably fixed on Test. Anyway ...

    Oh Rowne, I love you so much. You see something broken and you just go in and fix it :-D.
    What I noticed was that when I sold something, the item would stay there but greyed out. What I've done is hook the containerframe button-click function. That way, whenever something is sold or the last of an item stack is used, the button clears instead of hanging around and being grey.

    I didn't see your fix for this anywhere, but I made a change that should fix this.
    Due to my own personal tastes. I've also setup InvSort to auto-open and auto-close at the vendor, bank and when the mail-frame is open.

    These are just a few minor tweaks until 1.9 goes live. I've also got MoneyFrameNuker in there as an OptionalDep.

    I'll leave these tweaks in until I get around to saving those sort things as options. Most people want that behaviour anyways.

    I've been playing around with it on my test characters until now, that's been fantastic. I just tried my main and 80 per cent of his herbs show up as Trade items, instead of Reagents.

    This is mostly because my categories for sorting probably arent the greatest. The sorting rules are in InvSortDefaults.lua. I've added the itemID, Type, and SubType to all item tool tips so you can see why things are being put into specific groups. (I don't think I used anything other than type or subtype for my rules really).

    Quote from "Rowne" »
    There's only one, humble request I have. Add a hover-timer, the way I use tabs in Firefox is that if I hover over a button for X amount of time, it switches. You can use Timex for this. Basically use OnEnter and OnLeave. Then start the timer and if the mouse leaves the button before the timer is up, remove the timer. That's the only request I have.

    Haha, maybe I should have someone write a TabMixPlus plugin for this....
    Quote from "FryGuy" »
    i have to wait for 1.9 then i guess Sad

    Looks awesome.. i can't wait.

    So far it seems to work pretty much on the live server. I've run into a few other glitches Rowne didn't notice:

    BAG_UPDATE_COOLDOWN wasn't registered, so when cooldowns started they didn't show, but if you switched to a tab that had a cooldown running already it'd be there. Also, I'm not sure if there's still strata issues with the CooldownFrame, sometimes it seems to want to load behind the item button. kinda frustrating.
    I left a hack I was experimenting with dropping items in that was causing you to move when you clicked the tab buttons if you had click to move turned on.
    ... That's all I can remember.

    Anyways, I'll throw a new beta up at http://people.ucsc.edu/~tgerdes/InvSortb2.zip

    Oh yes, on Live theres an issue with undocking windows. I'm aware theres some funky behaviour with the tab icon when it get reparented but I haven't got around to fixing that yet.
    <Edit> Stealth hack, I think I fixed the icons when undocking windows for Live. Really strange; All I had to do was reset the scale to .5, and tell it to Show even though it was already shown before reparenting (I think maybe the new parent wasn't shown so it changed it).
    Posted in: Addon Ideas
  • 0

    posted a message on Categorized/Sorting OneBag
    I've been tracking down bugs with my Inventory scanner all day that kinda makes me want to release a beta tonight now that I think I've got all the kinks worked out and it seems to stay in sync with my inventory. It's still very beta: nothing (at all) is being saved to Saved Variables so no configuration of anything. Tabs can be undocked by shift+clicking their icon and docked by clicking it again. All the subwindows are always parented to the main frame so when you close it you close them all. All undocked windows open in the same place and overlap until you move them. I haven't tested Ammo slots much, and i haven't tested Soul Shards at all (I don't have a warlock :-[).

    <EDIT> I changed the frameStrata on my cooldown frames so that they are on top of the ItemButtons. Still sort of a problem because it seems that frames can fit between the cooldown frame and the item button itself.

    Here's a link to beta release 1. Test server only (I'm using the 9th return value of GetItemInfo to get icons, never GetContainerItemInfo, it might do something on Live, but I haven't tried it).
    http://people.ucsc.edu/~tgerdes/InvSort.zip

    <EDIT> Oh yeah, I limited the ItemButtons to 100. Probably not a big problem because it should be re-using any item buttons that aren't visible if it runs out. But if you undock every window and you have more than 100 items, some might not show up. More can be added really easily in the XML
    Posted in: Addon Ideas
  • 0

    posted a message on Categorized/Sorting OneBag
    Haha, yes... I will be wanting some people to test this out once I get it running. I'm probably going to have a beta when I get all the layout type stuff I want going. I'm a lot less worried about the sorting rules for now. Those can be hacked if necessary in the lua, so it's somewhat of my last priority to make them easy to change in game.
    Posted in: Addon Ideas
  • 0

    posted a message on Categorized/Sorting OneBag
    Finals are over so I've got more time to be working on this. Here's what I'm working with so far:



    Each rule has a name and icon. These rule icons are the smaller icons near the top and they work like you'd expect tabs to. The tabls can be undocked into their own windows (as you can see with the Consumables and Reagents groups I have on the left).

    Tooltips work similar to the way OneBag handles tooltips, so I shouldn't be breaking anything that adds to item tooltips (hopefully).

    Things I still need to do before I'll post this:
    * Virtual Stacks (at least for the empty slots and for the ammo/Shard slots at the top)
    * Add a few buttons to the undocked windows
    - Undocked windows are anchored (an parented) to the main window by default. I'd like to add a way to unparent so you can keep an undocked window open all the time, and also add a way to quickly redock the window.
    * Add money display to the main frame. (Probably bottom right corner)
    * Handle Item cooldowns
    * Rarity borders like in OneBag / MyBags

    * Allow customization of the rules and sorting exceptions. (I need to learn AceGUI enough to make a nice interface for this)
    Posted in: Addon Ideas
  • 0

    posted a message on Categorized/Sorting OneBag
    Ok Ok, as long as everyone else is getting their theory out in MS Paint, I guess I will too :-)

    I feel like we've got some good ideas flowing. But I'm starting to realize, since the inventory will be sorted, what's the point in showing all the items at once? Kinda along the lines of AdvancedBags, now we've just got better bags, we know where to look for our stuff. So why not make it like a tabbed interface? It's awesome in Firefox and Gaim, why not my inventory? MS Paint, away!



    OK, So, The important things I always care about belong on the frame at all times: Empty Slots, a total count like was suggested above. Then I have Ammo in Ammo slots. This can show the total count of ammo; although I'm starting to think this might be problematic, ammo bags can hold multiple types of ammo, not sure how I'd deal with that exactly, perhaps the ammo display can grow in that sort of situation. The red border around the next ammo slot is to indicate ammo that's not in an ammo bag. I'm not sure this is really needed, but there'd be no other way to tell if it wasn't sorted differently. The last slot is the number of empty Ammo slots. The ammo slots can be replaced with Soul Shard slots; can warlocks use guns? Never played one, but I pretty sure they can't.

    Ok, so then you got your tabs showing the names of all the different groups with the current selected group highlighted. OK, so maybe you don't want to hide everything all the time. That's fine with me; then we can just undock the tab, and place it in it's own floating window.

    ... And... that's my latest idea. Woo?
    Posted in: Addon Ideas
  • 0

    posted a message on Minimap question.
    Lol... what do you mean fish info?

    ack... wait, hold your tounge on that one. Wait for me to make an Angler thread.
    Posted in: General Chat
  • 0

    posted a message on Minimap question.
    Haha, oh Rowne, where would I be without you.... Thanks for the work you've put into this: I'll put it up on the Ace Addons forum soon (this thread totally got hijacked ;-) )
    Posted in: General Chat
  • 0

    posted a message on Categorized/Sorting OneBag
    Quote from "Thirsterhall" »
    It would be nice to be able to add some custome catagories. Take a druid perhaps that has a set of armor for feral and one for healing. If they could set up a my armor catagory so eventualy in the inventory display all the amor that they switch back and forth between can be set aside and not mixed in with other armor like new drops.


    Yea, this will be easy to do with exceptions. Just put all pieces of your armor into a group. I kinda liked the EngInventory idea of putting things in a Soulbound / not Soulbound category, but that would require a tooltip scan.

    Anyways; poking around with GUI stuff and not totally likeing what I got but it gives you a bit more of a visual impression that things are getting sorted:

    http://people.ucsc.edu/~tgerdes/Sorted.JPG

    And I created a new hunter character to show the empty projectile slots get sorted too...
    http://people.ucsc.edu/~tgerdes/NewHunter.JPG

    So two things could deffinately use improvement: my default sorting rules, and my layout on the screen. Lots of space gets wasted this way with large inventories and smaller groups. Anyone have any ideas?
    Posted in: Addon Ideas
  • 0

    posted a message on Categorized/Sorting OneBag
    Ah hell, I'll give you what I'm workin with right now. It's not even close to being ready for release but I wouldn't mind some suggestions as far as where you think I'm at and where I should be going.

    http://people.ucsc.edu/~tgerdes/InvSort.rar

    If you're poking at the code:
    inv.lua sets up the Inv table and all my little metatables.
    AceInventory.lua scans the inventory. I think I've got a glitch where it sometimes doesn't scan the entire inventory on login, but it does if you do a reload.
    InvSortDefaults.lua has my rules for sorting. They can probably use some work.
    InvSort.lua is what's actually doing sorting.

    When you load this up in WoW, things that are interesting to play with are:
    /in report - prints your entire inventory in order
    /is report - prints the sorted inventory.


    The default categories I have:

    Empty slots: Empty bag slots (these have a Id of 0)
    Trade tools: Items that are used in a few trades, such as mining pick, blacksmiths hammer, etc. These are all exceptions so far, perhaps I can come up with a better way to recognise them.
    Reagents: Obvious enough. Type = Reagent.
    Trade goods: This is a pretty general category, just about everything you use to make stuff or even stuff you make (it looks like my engineering trinkets get put in here even)
    Equippable: Type = Armor or Type = Weapon. This can probably be better too
    Soulshards: obvious enough; will also have empty soulshard slots (which probably will be Id = -2)
    Quest Items: Type = Quest
    Consumables: Type = Consumable (Again this could get seperated up, food, water, potions, etc.)
    Projectiles: Type = Projectile, empty bag slots (Id = -1)
    Unknown: Everything that didn't fit in the rest of the categories.

    So if someone thinks I'm totally off on how I'm doing my sorting, I'd love to hear it; I'm not sure it's the greatest system and I'm totally open to suggestions.
    Posted in: Addon Ideas
  • 0

    posted a message on Categorized/Sorting OneBag
    And of course... Ramble has been working on the harder part.

    I'm not really satisfied with everything quite yet but i've got an auto inventory sorting type system started, and I haven't posted much on it, so I guess I'll try to explain what I've got going on so far.

    I've got one addon or module that does all the inventory scanning and tracking. It keeps track of everything in the inventory in a table, so you can look up stuff by Inv[1], Inv[50], or whatever. I've almost totally ditched the idea of knowing which item is in which bag; I hardly care. I am keeping track if a slot is an ammo slot (or a soul shard slot for 1.9; I have no warlock or shard bag to test this with when I get to workin on that bit), but that's about it. I also keep track of the Bags, Inv.Bag[1] - Inv.Bag[4] give info about the bags.

    Now I'm doin all sorts of fun stuff with meta tables, so I think this is all really efficent. When I scan a slot, I check it has the same ID as what I had there before. If not, I cache the GetItemInfo data into a hidden table if I've never seen it before. Then I set Inv[slot].Id to the item ID, and give it a link to the GetItemInfo cache. This lets me look up all sorts of info about the item, Inv[1].Name, Inv[1].Type, Inv[1].SubType, Inv[1], Inv[1].MinLevel, etc. All those values get looked up in the GetItemInfo cache, but I can also save other info in the item itself, like Inv[1].Count, and Inv.Bag[1].Size.

    And if that didn't make sense, well, I'll get my code online somewhere sometime :-[
    Anyways, this module tracks BAG_UPDATE and BAG_CLOSED events to check for changes in the inventory, and if it detects a slot changes, it passes on ACE_INVENTORY_SLOTCHANGED if the itemId changed, ACE_INVENTORY_COUNTCHANGED if the count changes.


    So then I have my sorting module. It hooks the ACE_INVENTORY events. Basically it's a list of rules and exceptions to those rules as how to sort items. Exceptions put specific items into specific categories. Rules are things like "Type" = "Quest" or "Type" = "Reagent".

    So the big thing I'm working on right now is in game modification of those rules. I'm pretty confident the rules work if they're in place, and perhaps I might put aside changing them dynamically and work on a GUI instead. ... This is gonna be my 3rd rework of MyBags; I'm not exactly sure what I want in my GUI ::sigh::

    So... maybe i'll purdy up my code a bit and try to get something to show for this weekend. I really like my Inv table; it's purdy :D
    Posted in: Addon Ideas
  • 0

    posted a message on Stealing some ideas from EngInventory
    ::grumble grumble::
    I really need to work on MyBags/OneBag.

    if only i had the time too...
    (yes, I really want to implement this sort of feature in the future too, but it's very time consuming and time is one thing I haven't really had to spend on MyBags)
    Posted in: Addon Ideas
  • 0

    posted a message on Firefox vs. Internet Explorer
    Tain: I'm the same way; I use opera at home and I still lov
    e it, but when I can't use it, firefox always seems to do the trick.
    Posted in: General Chat
  • 0

    posted a message on Firefox vs. Internet Explorer
    Quote from "Rowne" »
    Pf. Lightweights. ;3


    lol, this coming from the guy who uses a slimmer version of notepad. :lol:
    Posted in: General Chat
  • 0

    posted a message on Oh noes!
    haha, thanks for that

    :lol:

    BTW, I got a good version of the file from my girlfriend and now it's patching and at 50% so it hopefully will work now. Tomorrow will be a day of code. :D
    Posted in: General Chat
  • 0

    posted a message on Oh noes!
    /cry, it didn't work.

    Maybe (Fingers crossed) my girlfriend hasn't patched yet either and she as the old file.

    Also my roommate quit about a month ago but he still has it installed, so he might have the last patched file.


    :(


    Aw, I take it back. I want as many of you guys as possible trying to break my stuff so it gets better :-)
    Posted in: General Chat
  • To post a comment, please or register a new account.