i found an error in line 711. the following line can not work correctly:
local tex = spellIconList[settings.buffs[settings.icon or ""]]
because for self made Buffgroups you don't have the icon in your spellIconList
and the default buffgroups allready have the correct name in settings.icon so
that settings.buffs[settings.icon] would return nil.
to solve this problem you have to replace line 711 with the following:
local tex = spellIconList[settings.icon] or GetSpellTexture(settings.buffs[settings.icon])
Thanks. I appreciate that, but before i try to get into GUID-tracking i will remove all babble-references and use GetSpellInfo. Since i have to do some other projects for school as well this could take some time. when it's done i will try to get an svn-account and upload it.
PS: if the original author is reading this: try to use names with more than two letters for your variables. it would make it much easier to understand your code. :-)
@Refindor: zhCN and koKR are the blizzard-abbreviation for chinese and kroatian localisation.
what Prof_Albert meant was, that you should take a look at these in the Code/Parrot.lua (hopefully you have a lua editor, because notepad doesn't recognise the linefeeds) and try to make the same for deDE.
I personally wouldn't mind if there was no German translation, but the error-messages should disappear
there is a problem with the german translation in the Solarian module.
the german translation for "I will" unfortunately is the same as for "I become"
so the Phase2 trigger is also called, when Solarian shouts "I will crush your delusions of grandeur!"
please change the phase2_trigger to "^Ich werde eins" in the deDE locale.
I have edited the german translation a little because there were some mistakes in it (sorry for that). the new one is attached to this post.
I have also renamed it to HonorFuPlusLocale-deDE.lua to match with the addon-name.
Last but not least: the localisation still needs to be added to the Fubar_HonorFuPlus.toc
simply add the following line:
Since there wasn't much response to my post in the official Chronometer-thread
i decided to make a new one. Basicly i only changed the methods, that were called
by the parserLib with COMBAT_LOG_EVENT_UNFILTERED so you don't need the parserLib
anymore. I couldn't do a lot of testing, but it seems to work on my Druid and on
my Priest. I have not included GUID-tracking, so it will still use the name, to
identify a unit (maybe i will add that later) and it still uses Babble-spell.
Oh, and i updated the time for the nightelf-priest-spell Starshards.
Special thanks go out to the guy who updatet SorrenTimers for 2.4. I stole...
copied some of your code ;-)
To use this simply copy the Chronometer.lua into your Interface/Addons/Chronometer/Core
and the Priest.lua into Interface/Addons/Chronometer/Data
I did a German translation and some small tweaks to make it work on other languages as well:
first change line 591 to 609 in the HonorFuPlus.lua to this:
cat:AddLine(
'text', L["Arathi Basin Marks:"],
'text2', GetItemCount(L["Arathi Basin Mark of Honor"], true)
)
cat:AddLine(
'text', L["Alterac Valley Marks:"],
'text2', GetItemCount(L["Alterac Valley Mark of Honor"], true)
)
cat:AddLine(
'text', L["Eye of the Storm Marks:"],
'text2', GetItemCount(L["Eye of the Storm Mark of Honor"], true)
)
cat:AddLine(
'text', L["Warsong Gulch Marks:"],
'text2', GetItemCount(L["Warsong Gulch Mark of Honor"], true)
)
then add the following lines to the HonorFuPlusLocale-enUS.lua:
["Arathi Basin Mark of Honor"] = true,
["Alterac Valley Mark of Honor"] = true,
["Eye of the Storm Mark of Honor"] = true,
["Warsong Gulch Mark of Honor"] = true
and finally put the attached file into the Fubar_HonorFuPlus folder.
Thanks for the tip. Still isn't quite the same. so i looked through the code and tried to update
Chronometer and i think i did it. i didn't have time for proper testing, but i will upload it
anyway, so you can test it end tell me if it works as it did before 2.4
The Chronometer.lua goes into the core-folder, the Priest.lua into the data-folder.
PS: i only updated the time for starshards in the Priest.lua
PPS: not much response here. so i made a new Thread here
And i had a problem with the Black Morass Module recently.
Our team went there for heroic-daylie and the module got activated after we defeated the first portal mobs.. Now the timers were off and the boss modules didnT show up.
Maybe we should check also if someone of your group is attacking /attacke by /targetting /targetted vy the corresponding mob/boss to activate the global module? and a sync if you attack a boss and the wave-count doesnt fit yet .
I think hovering over a mob is not fail-safe for activating modules ;)
Greetings Yoshimo
same problem here.
resync after bossfight would be very nice. i think the problem with the black morass module is, that it reacts to medivh, but you don't have to target him at all. maybe you should change the trigger to one of the trashmobs you have to kill befor the event.
0
*note to self*: apply for svn account!
0
because for self made Buffgroups you don't have the icon in your spellIconList
and the default buffgroups allready have the correct name in settings.icon so
that settings.buffs[settings.icon] would return nil.
to solve this problem you have to replace line 711 with the following:
0
here is the correct deDe for Ironhand:
L:RegisterTranslations("deDE", function() return { hammer = "Hammer", hammer_desc = "Vor Hammer Warnen", hammer_trigger = "erhebt seinen Hammer bedrohlich", hammer_message = "Hammer in 3 Sekunden!", hammer_bar = "Hammer", shadow = "Schattenmacht", shadow_desc = "Warnen, wenn Eisenhand Schattenmacht bekommt", shadow_message = "Schattenmacht in 2 Sekunden!", shadowaura = "Schattenmacht bekommen", shadowaura_desc = "Warnen wenn Eisenhand Schattenmacht bekommt", shadowaura_message ="Eisenhand bekommt Schattenmacht", }and here for Gyro-Kill
L:RegisterTranslations("deDE", function() return { shadow = "Schattenmacht", shadow_desc = "Warnen, wenn Gyrotod Schattenmacht bekommt", shadow_message = "Schattenmacht in 2 Sekunden!", shadowaura = "Schattenmacht bekommen", shadowaura_desc = "Warnen wenn Gyrotod Schattenmacht bekommt", shadowaura_message ="Gyrotod bekommt Schattenmacht", }its mixed up for the other locales as well, but i only speak german and english so i couldn't correct those too.
0
the other problem is: honor is still calculated by the glory-lib, which still calculates
with the diminishing return.
0
PS: if the original author is reading this: try to use names with more than two letters for your variables. it would make it much easier to understand your code. :-)
0
what Prof_Albert meant was, that you should take a look at these in the Code/Parrot.lua (hopefully you have a lua editor, because notepad doesn't recognise the linefeeds) and try to make the same for deDE.
I personally wouldn't mind if there was no German translation, but the error-messages should disappear
0
the german translation for "I will" unfortunately is the same as for "I become"
so the Phase2 trigger is also called, when Solarian shouts "I will crush your delusions of grandeur!"
please change the phase2_trigger to "^Ich werde eins" in the deDE locale.
0
I have also renamed it to HonorFuPlusLocale-deDE.lua to match with the addon-name.
Last but not least: the localisation still needs to be added to the Fubar_HonorFuPlus.toc
simply add the following line:
to tell WoW to load that file.
0
please add it, so that it will work on German Clients
0
Since there wasn't much response to my post in the official Chronometer-thread
i decided to make a new one. Basicly i only changed the methods, that were called
by the parserLib with COMBAT_LOG_EVENT_UNFILTERED so you don't need the parserLib
anymore. I couldn't do a lot of testing, but it seems to work on my Druid and on
my Priest. I have not included GUID-tracking, so it will still use the name, to
identify a unit (maybe i will add that later) and it still uses Babble-spell.
Oh, and i updated the time for the nightelf-priest-spell Starshards.
Special thanks go out to the guy who updatet SorrenTimers for 2.4. I stole...
copied some of your code ;-)
To use this simply copy the Chronometer.lua into your Interface/Addons/Chronometer/Core
and the Priest.lua into Interface/Addons/Chronometer/Data
0
first change line 591 to 609 in the HonorFuPlus.lua to this:
then add the following lines to the HonorFuPlusLocale-enUS.lua:
and finally put the attached file into the Fubar_HonorFuPlus folder.
0
Thanks for the tip. Still isn't quite the same. so i looked through the code and tried to update
Chronometer and i think i did it. i didn't have time for proper testing, but i will upload it
anyway, so you can test it end tell me if it works as it did before 2.4
The Chronometer.lua goes into the core-folder, the Priest.lua into the data-folder.
PS: i only updated the time for starshards in the Priest.lua
PPS: not much response here. so i made a new Thread here
0
in deDE he is named Sa'at.
0
same problem here.
resync after bossfight would be very nice. i think the problem with the black morass module is, that it reacts to medivh, but you don't have to target him at all. maybe you should change the trigger to one of the trashmobs you have to kill befor the event.
0