Ugh. Yeah, those are tainted. Since it's StatFrameLib that's tainting it, I'll take a look. Thanks for the report.
As for documenting: I hadn't even thought about About TankPoints. I've just been looking at the code for so long that I forget there is anything else. I added the documentation about calculation to the code comments, in case you were wondering. This will be updated soon.
As for the uncrushability fixes: if your set is uncrushable it should be shown as uncrushable by TankPoints. Also, the hit table listed by the Melee DR tooltip should add up to 100% and not have any negative numbers.
Raid leaders, do you find yourself looking to see if anyone is flagged up in the raid? Have to turn on unit frames to see? Wish there was a zonecheck-like interface for PvP flags?
Well now there is.
oRA2_PvPDetection adds "PvP check" to the dropdown and command line for oRA2. Works even if raiders don't have the mod. If a raider does have the mod, you can see if they're permaflagged or not.
Share and enjoy,
Aliset
please post all bugs here or email them to [email]aliset@fake.domain.name[/email].
Okay, I put all of the functionality for PvP flag detection and permaflag detection into an external module called oRA2_PvPDetection.
I hope that the permaflag detection code will be considered for commit to the main line of oRA2 eventually, as that
would increase the usefulness of this mod.
Okay, I've added more docs about how EH and EHB are calculated.
Yes, EH is Ciderhelm's EH, and EHB is done according to his same notes on how he'd go about calculating it.
Also, I have fixed the bug that caused mob hit chance to be too high. I've checked out the effect on crushing blows using my trinkets and that seems to be working as well. If someone with an uncrushable set could verify that this is fixed, I would appreciate it.
Yes. It works like this. Let's say you have A, B, C, D, and E in a party. A is flagged. If E does a group heal on B, A will not receive the heal. If E does a group heal on A, E gets flagged....
So, basically, a large portion of the raid becomes un-group-healable.
I'll take a look at the calculator first, and see what I can do there. Next there's a bug with uncrushability. After that, I'll take a look at the documentation.
If you encounter bugs, either post them here or email them to me at [email]aliset@fake.domain.name[/email]. Let's get this back to WhiteTooth qualitee.
Much like we have zone check and friends, this checks for pvp flagged people. If a raider has this patch as well, you'll be notified if they're permaflagged.
0
I can say the ability to quickly and accurately tell who is flagged (or not flagged, if you need them to be) has been a boon to our raids.
0
As for documenting: I hadn't even thought about About TankPoints. I've just been looking at the code for so long that I forget there is anything else. I added the documentation about calculation to the code comments, in case you were wondering. This will be updated soon.
As for the uncrushability fixes: if your set is uncrushable it should be shown as uncrushable by TankPoints. Also, the hit table listed by the Melee DR tooltip should add up to 100% and not have any negative numbers.
0
Well now there is.
oRA2_PvPDetection adds "PvP check" to the dropdown and command line for oRA2. Works even if raiders don't have the mod. If a raider does have the mod, you can see if they're permaflagged or not.
Share and enjoy,
Aliset
please post all bugs here or email them to [email]aliset@fake.domain.name[/email].
0
I hope that the permaflag detection code will be considered for commit to the main line of oRA2 eventually, as that
would increase the usefulness of this mod.
patch: http://fake.domain.name/public/2008/ora2_pvp_participant.patch
Thanks,
Aliset
0
Yes, EH is Ciderhelm's EH, and EHB is done according to his same notes on how he'd go about calculating it.
Also, I have fixed the bug that caused mob hit chance to be too high. I've checked out the effect on crushing blows using my trinkets and that seems to be working as well. If someone with an uncrushable set could verify that this is fixed, I would appreciate it.
0
Could anyone who was having calculator problems please confirm whether or not current trunk of TankPoints works for them?
0
So, basically, a large portion of the raid becomes un-group-healable.
It's really annoying.
0
I could look into disabling this on PvP servers. Then again on a PvP server this would return blank all the time. ;-p
0
On to the next bug.
0
Thank you.
I'll take a look at the calculator first, and see what I can do there. Next there's a bug with uncrushability. After that, I'll take a look at the documentation.
If you encounter bugs, either post them here or email them to me at [email]aliset@fake.domain.name[/email]. Let's get this back to WhiteTooth qualitee.
Thanks a bunch,
Aliset
0
http://fake.domain.name/public/2008/ora2_pvp_flag.patch
Much like we have zone check and friends, this checks for pvp flagged people. If a raider has this patch as well, you'll be notified if they're permaflagged.
Aliset
0
Well now it's easy with StatFrameLib-1.0 (catchy!)
http://svn.wowace.com/wowace/trunk/StatFrameLib/StatFrameLib-1.0/
Example code is at the bottom of the file. All functions are documented...I think.
http://www.wowace.com/wiki/StatFrameLib-1.0
send bug reports to [email]statframelib@fake.domain.name[/email]. If you don't get a reply, post them here.
Share and enjoy,
Aliset
0
WhiteTooth, you my only enamled canine.
-Ali
0
I'm looking for some people to test before I merge in the branch.
You can find a .zip here: http://fake.domain.name/tankpoints.zip or if you're the svn type: http://svn.wowace.com/wowace/branches/TankPoints/aliset_effective_health.
Since WhiteTooth hasn't been around for quite a while, I'm going to merge in the code after waiting to make sure there are no glaring bugs.