Authors CurseForge

Quote from Arkayenro

potentially silly question. at any point are you disabling your mod through the interface or via a :Disable( )?

just that ace itself will unhook all your securehooks when your ace based mod is disabled (or at least it used to, not sure if it still does)

edit: stupid bloody smilies.

Nope not disabling it.

Quote from Arkayenro

mine picks up all the lootable items when you loot and queues them up so ive no need to check for alt clicking on the loot slots themselves but if thats what youre doing it shouldnt be too hard to figure out what the frame is called and hook that as well (if the setitemref hook doesnt work for that)

The reason I am trying to use HandleModifiedItemClick is because that would make it usable on any item in any frame. If I wanted to use it for like orbs or something out of the guild bank. Also it is easy to get the itemlink from it.

Quote from Arkayenro

Master and BidNotOpen are globals? any chance these are getting overwritten by another mod? or even blizzard?

you may want to put those debug print statements back in right at the top just to confirm if your hook is being called.

Well they are declared outside of the functions like this...

local Master = false;
local BidNotOpen = true;

Does that make them local to my addon? Because that was my intent. However, I have used debugs before to try to solve this issue. When it occurs my HandleModifiedItemClicks function is not called at all.

edit: Should they be declared DrunkardSK.Master and DrunkardSK.BidNotOpen?

Quote from Arkayenro

then its most likely not another addon. can we see the code for the whole DSK_HandleModifiedItemClick function?

Yes...

function DrunkardSK:DSK_HandleModifiedItemClick(item)
	if (Master) then
		if (BidNotOpen) then
			if (IsAltKeyDown() and 
				not IsShiftKeyDown() and 
					not IsControlKeyDown()) then
				ItemLink = item;
				DrunkardSK:SendCommMessage("DSKOpenBid", ItemLink, "RAID");
				BidNotOpen = false;
				DSKListFrame.closeBid:Enable();
			end
		end
	end
end

Master is set if you are masterlooter and BidNotOpen if there is not currently a bid open. I did have some debugging prints in this function at one point and I saw none of them when the hooking seemed to stop working.

Quote from Arkayenro

what are you trying to do after someone shift or control clicks on a button that youre showing an item in?

When someone alt clicks and item the addon opens up bidding on the item to the raid. So, nothing for shift or ctrl.

Quote from Arkayenro

just that youre hooking something that is used in a lot of places, on all item buttons (ie bags, bank, vault), do you really need to do that?

It seemed the best way to do what I wanted to do.

Quote from Arkayenro

do you have buggrabber (or equivalent) installed? ie could there just be a lua error after the first loot that youre not seeing?

Yes I use that. It is not an error.

Another quick question should I be setting the hook up in OnEnable rather than OnInitialize? Why?

I really doubt this has anything to do with my current issue but I am curious.

I used window's find command to find them. It feels like a poor man's grep.

Would it be bad to simply rehook the function either on command or on an event? Seems like it would be an easy work around, but I do not know if there would be bad side effects.

Ok so I added all the addons I use that hook HandleModifiedItemClick to optional dependencies and my hook still seems to stop working.

As I said earlier I set the hook up on initialize. Is there any reason it could come unhooked after zoning into an instance? Because it only ever happens on the first loot after zoning into an instance.

Cool. Thanks for the tip. I will change the hook.

And for sake of clarity what is the difference between a secure hook and a regular hook? How do I know if what I am hooking is secure or not?

Quote from egingell

No, not without narrowing down which addon it is and making sure it loads first (OptionalDeps), fix it, and/or alert the author of the faulty code.

Fun fun! Thanks for the quick reply!

I am currently doing...

DrunkardSK:SecureHook("HandleModifiedItemClick", "DSK_HandleModifiedItemClick")

inside my

function DrunkardSK:OnInitialize()

The problem I am seeing is that sometimes it seems to come unhooked. Is it possible that some other addon is hooking the same thing and overwriting my hook? If so, is there a way to stop this?

I cannot really test if it is another addon because this is my guilds raid loot distribution addon and I need my other addons running to raid. Also it does not happen all the time. It is very sporadic and simply reloading the ui fixes the issue.

Any help and/or advice would be greatly appreciated!

Could you make the text on the LDB display the current time? So while running an instance you could glance at it to see how long you have been in there.

I don't seem to be getting any warnings on anyone but Saurfang in ICC 10 (no idea about 25). And even then the Saurfang warnings do not make noises.

Edit: This isn't the same as the translation thing above. I am in the US.

Drunkard Suicide Kings is my take on a suicide kings addon. While it is not technically a rewrite/revamp of JoeHunk's "Suicide Kings" (none of his code was reused), it was certainly inspired by that addon.

My design philosophy was to make it simple. This means there is no confusing options to set. It simply works right out of the box. Setup the list and you are ready to roll. Of course due to not having options there are restrictions in place to ensure the security and integrity of the lists. The addon was written specifically for use for my own guild (Drunkard of Bloodscalp-US). Thus it may not be flexible enough for everyone. However, I am trying to implement feature requests that fit into my overall design goals.

Curse Link for downloads

Curseforge Project Link

Feel free to use this thread for any feedback. Many thanks and enjoy!

Just curious if anyone has put that they are a WoW addon author on there professional resume and how it was received.

Quote from Torhal

I'm going to make two guesses: You're using DockingStation, and haven't updated it in the past few days (double display). You're using TipTac (because of the tooltip flicker).

Yep... but it was only Currency that had this issue the other broker things were fine. Thanks for the info.