• 0

    posted a message on PallyPower - Official Thread
    As requested, a patch that shows the Greater blessing button to allow normal buffs when there is no greater blessing allocated to the pally.

    *** PallyPower.lua     2008-04-30 15:48:51.000000000 +1000
    --- PallyPower.lua.5pally 2008-04-30 15:33:55.000000000 +1000
    ***************
    *** 1203,1209 ****
        local cbNum = 0
        for classIndex = 1, PALLYPOWER_MAXCLASSES do
        local _, gspellID = PallyPower:GetSpellID(classIndex)
    !    if (classlist[classIndex] and classlist[classIndex] ~= 0 and gspellID ~= 0) then
            cbNum = cbNum + 1
            local cButton = self.classButtons[cbNum]
                cButton:SetAttribute("classID", classIndex)
    --- 1203,1210 ----
        local cbNum = 0
        for classIndex = 1, PALLYPOWER_MAXCLASSES do
        local _, gspellID = PallyPower:GetSpellID(classIndex)
    !    local normalblessingcount = PallyPower:NormalBlessingCount(classIndex)
    !    if (classlist[classIndex] and classlist[classIndex] ~= 0 and (gspellID ~= 0 or normalblessingcount>0)) then
            cbNum = cbNum + 1
            local cButton = self.classButtons[cbNum]
                cButton:SetAttribute("classID", classIndex)
    ***************
    *** 1605,1610 ****
    --- 1606,1626 ----
    
     end
    
    + function PallyPower:NormalBlessingCount(classID)
    +    local nbcount = 0
    +    for pbNum = 1, math.min(classlist[classID], PALLYPOWER_MAXPERCLASS) do
    +        local unit = self:GetUnit(classID, pbNum)
    +
    +        if unit and unit.name and
    +        PallyPower_NormalAssignments[self.player] and
    +        PallyPower_NormalAssignments[self.player][classID] and
    +        PallyPower_NormalAssignments[self.player][classID][unit.name] then
    +         nbcount = nbcount+1
    +        end
    +    end -- by pbnum
    +    return nbcount
    + end
    +
     function PallyPower:GetSpellID(classID, playerName)
        local normal = 0
        local greater = 0
    Posted in: General AddOns
  • 0

    posted a message on PallyPower - Official Thread
    Hi,

    Great addon. I love it!

    We have recently started running with 5 pallies in a 25 man raid and have a mix of Tank and DPS warriors in the raid. With 5 pallys, there are only 4 useful blessings for a warrior tank (light, might, sanc, kings). Our fifth pally can't buff a greater salvation because that will affect the tanks, so buffs a 10 min salv to the dps warriors only.

    This works well, however when there is no greater blessing assigned to the warriors, the 5th pally cannot see their class to be able to small-buff the dps warriors.

    The following patch remedies this. It allows any class to be seen when small blessings or large blessings are applicable.

    I would appreciate it if you could work this into a future revision of Pally Power. Diff is against the latest Pally Power version.

    *** PallyPower.lua    2008-04-29 23:22:11.000000000 +1000
    --- PallyPower.lua.5pally 2008-04-16 17:56:46.000000000 +1000
    ***************
    *** 1203,1209 ****
        local cbNum = 0
        for classIndex = 1, PALLYPOWER_MAXCLASSES do
        local _, gspellID = PallyPower:GetSpellID(classIndex)
    !    if (classlist[classIndex] and classlist[classIndex] ~= 0 and gspellID ~= 0) then
            cbNum = cbNum + 1
            local cButton = self.classButtons[cbNum]
                cButton:SetAttribute("classID", classIndex)
    --- 1203,1209 ----
        local cbNum = 0
        for classIndex = 1, PALLYPOWER_MAXCLASSES do
        local _, gspellID = PallyPower:GetSpellID(classIndex)
    !    if (classlist[classIndex] and classlist[classIndex] ~= 0) then
            cbNum = cbNum + 1
            local cButton = self.classButtons[cbNum]
                cButton:SetAttribute("classID", classIndex)
    Posted in: General AddOns
  • To post a comment, please or register a new account.