• 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Quote from mikeysauce »
    Okay. I have been using BT3 and CyCircled for a long time now but after doing some profiling(BT3 using 30% of CPU) I decided to check out BT4. I soon realised BT4 requires ButtonFacade to skin my bars the way that I like(Vol/Apathy). I load up BT4/BF and low and behold BT4 is using no where near as much CPU however BF is using something like 50% of my CPU(according to optionhouse cpu profiler). This may be seen as nitpicking and whatever but I just thought I would let the author know. oh and is BF supposed to be climbing in cpu usage constantly? because Cy stays at a static CPU amount(3% or so).


    Are you running with embedded libraries? If so, please dis-embed them before reporting excessive CPU usage. That said, I will look into it.

    Quote from Sorata »
    Well I've got one in my addon that saves the changes and then I have a module that updates the buttons insets depending on what skin is used. I was able to hook it once I realised Buggrabber wasn't printing error messages to the chat frame.


    Ah. Okay, now I understand. This is in Revision 73516.

    Quote from Maul »
    I would like to see a function added to LibButtonFacade.lua that would help with my custom button template -


    Done. This is in Revision 73516.
    Posted in: General AddOns
  • 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Quote from Sorata »
    I've just noticed that you can't register more than one callback per addon, any chance you could change that?


    Why do you need multiple callbacks? Just save the passed settings to your database. I'd rather not complicate the system unless there's a good reason.
    Posted in: General AddOns
  • 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Quote from zeal »
    Frame level 6 should probably be 5.


    Nope. There is an option which will change the Autocast Model layer to frame level 5. This was done quite on purpose.

    As for scaling issues: As shown in the order that zeal posted (thanks!), the order has the Icon second to the bottom. Borders are likely not disappearing behind the icons. Instead, you are probably seeing the distortion of scaling pixels below a 1 to 1 size. I suggest, if you're going for a small sized button, that you use one of the thicker bordered skins.

    Which leads me to my next request. Apathy and Entropy Thick skins. StormFX, how hard would it be to create versions of these skins with the border about twice as thick? Maybe even look into doing the same for Caith and any other thin bordered skins. This would give the eagle-eyed users some skins that would be more resistant to scale-down effects.
    Posted in: General AddOns
  • 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Quote from Maul »
    With the standard Blizz addon interface unmodified, doing anything with profiles with BF is impossible.


    I blame AceConfigDialog-3.0. I also don't have the time to fix this, so either get BetterBlizzOptions, or use /bf to access the config outside of the blizzard interface options.
    Posted in: General AddOns
  • 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Quote from Tuller »
    Your options menu is not compatible with the standard interface options menu. Fix it or remove support :P


    Works fine for me. Though I will say that I have BetterBlizzOptions installed too, so I can resize the window to a more reasonable default. Is there something specific about it that seems off to you?
    Posted in: General AddOns
  • 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Quote from Epic1337 »
    Really thankful of your work (and others too) as I've been awaiting the release of this amazing addon. The only request I have is the ability to change skin colors (ie. cyCircled), and was wondering if you had any intention of implementing this.


    Yes, this is planned. I will probably be working on it this weekend.

    Quote from Serenus »
    Disabling the main addon doesn't automagically disable the skins since it doesn't seem to consider them a dependency


    Intentional. The skins have ButtonFacade as an Optional Dependency. This does, however, remind me that I need to implement warning/error messages whenever a skin is loaded but ButtonFacade isn't.
    Posted in: General AddOns
  • 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Quote from zeal »
    What i was hoping could be done with the layers, is allowing there to be an undefined amount of layers, and allowing authors to generate as many as they wish. Then, also allow a name (or possibly a grouping as suggested) to applied to be them, so BF knows what to do with them. The ordering of the layers could be taken directly from the order in which they are specified, with BF simply filling in the "special stuff" based on the name of the layer. Grouping is probably a better choice, as combining names would be helpfull too. Eg. Gloss, Pushed. This way BF knows that layer should be effected by the gloss scaler, and the pushed state and anything else that may be added that effect those (colours for example).


    It's unlikely that I'd implement this (not impossible, just unlikely). Maybe someday far in the future when all my current ideas and projects have finally poured out of my head. Perhaps a video demonstration of what you could do with this feature would help to convince me, but I'm just not seeing enough benefit to this concept for me to implement it.

    I'd much rather give you the option to change the layering from the default, but one needs to understand how frame levels and region layer settings work. It's not just a simple number where this follows that follows those, which is why we set out to create a default layering that just works. I'm much more inclined to do this, since I can use the current settings as the "reasonable defaults" for when a skin doesn't supply the settings.
    Posted in: General AddOns
  • 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Quote from StormFX »
    Er, where exactly are you going with that? The largest a button will appear to be is the size of the largest size specified. But since some textures have transparencies around the edges, you'll never get an exact or accurate size. I don't understand the point.

    If you're a skin author, you should understand what's going on. If you're just a user, it shouldn't matter.


    I suspect it is so that Sorata can automatically adjust the padding and positioning of Poppins buttons based on the new skin chosen. I'd like to hear more opinions before I decide on this.
    Posted in: General AddOns
  • 0

    posted a message on InfiniBar-2.0 - Official Thread
    Revision 73173 contains a fix with Border coloring, which was never canceling when finished fading.
    Posted in: General AddOns
  • 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Quote from jjsheets »
    Note, I'm seeing some weirdness with the latest Revision, and am working on it at this time.


    Okay, Revision 73174 has a bugfix in. Specifically, the Gloss layer does NOT support an Alpha component, whether in the Color attribute or as the Alpha attribute. It uses, of course, the user's gloss alpha choice.

    Note... changing the skin on a large number of buttons can be slow, and this is most easily noticed when sliding the Gloss setting on the Elements page. I don't think there's any way I can speed it up any more.
    Posted in: General AddOns
  • 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Note, I'm seeing some weirdness with the latest Revision, and am working on it at this time.
    Posted in: General AddOns
  • 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Revision 73170:

    All layers besides the Cooldown, AutoCast, and Icon layers can have their color set by the skin now. As of this time, none of these are configurable by the user. I want any bugs that may exist in the basic color support to be fixed before tackling that.

    The Color attribute is now available. LBF will look for the Color attribute first, and will then use the separate Red, Green, Blue, and Alpha attributes if the Color attribute is not found (or if the corresponding component is missing from Color). Currently I have the defaults for ALL layers to be full White, so layers SHOULD have a color specified if the texture is designed to use a layer color. Defaults for certain layers will likely be the next thing added.

    The lbf:SetNormalVertexColor and lbf:GetNormalVertexColor functions are deprecated. Any actionbar addon that uses them should convert to using lbf:GetNormalTexture(button) and calling Set or GetVertexColor on the returned texture. I will be editing the Wiki to reflect these changes.

    SetVertexColor and GetVertexColor called on any of the colorable texture layers will modulate the provided color with the skin layer's color. This will result in the same coloring as if the layer texture had the skin layer color applied in the texture itself. SetTextColor and GetTextColor are the equivalents for text layers.

    I have also (hopefully) fixed the bug reported by Rabbit. I have not been able to reproduce the bug reported by zeal.
    Posted in: General AddOns
  • 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Quote from Nevyr28 »
    Just thought i'd give some more info into my profiles problem. I happened to be going through my savedvariables and noticed the one for buttonfacade has the profile names themselves but nothing that would attribute different skins associated with the profiles. I'll add what my savedvariables looks like on one of my accounts:


    Unless you're using the Bongos3_ButtonFacade module, all of the settings for your skins are stored with the actionbar addon. You may want to look at what profiles your actionbar addons are using for your various characters, rather than ButtonFacade.

    Quote from zeal »
    I got a C stack overflow at one point (funny enough, this was while just moving some button around on the default blizz bars). I'll post the error log if request, but cba right now.


    Please post it when you get time.

    The test bar appears to be bugged in some way. On initial load, even if gloss and backdrop was selected, backdrop would be grey ticked, and neither setting would actually be displaying. Also the alignment of textures was completely off (several pixel gaps between icon and border for example for blizz and my skins). Once resetting all these options and chaning the skins to the dream layout, all others would appear correctly.


    There are some issues currently with keeping the same skin settings for the buttontest module through a reload.

    The test bar is far too limited to try out all the various states and texture layers. Be easier to just force a different state (flash, disabled, equip, autocast etc. but most importantly for me, pushed) on each button in the bar, with just one which maps to your first action button for dynamic testing of all of them if you have the available class skills to achieve that.


    The test bar will obviously need some work... maybe I can get a volunteer to improve it?

    We need the ability to order the layers ourselves tbh. Right now, i'm stuck with gloss at the top, i need the states above it, but for other skins the states need to be below it. Same applies to needing flash and equip above the artwork and gloss depending on what the skin is trying to achieve.


    If no-one else objects, I can add support for this, though the ordering used now will remain the default.

    Also, with gloss seperate now and it's own alpha level scaler, i kinda of need the same (mapped to same scaler though) for various state layers which would colour the gloss or contain a gloss like alpha channel (as i use in equip, flash, disabled etc.). So they need their own gloss layers too. This would work around the above suggestion, but really full array of variable layers is what i'm asking for, as named ones are simply too limiting.


    Maybe. I'll keep this in mind, but I have a lot of work to do on the rest of the system, so don't expect this too soon.

    Also, i only tried testing with BT4, awful support it seems. No support for backdrop, the border layer was missing unless the button grid was turned on (which adds its crap default mini-backdrop texture, as cycircled would when it wasn't scaled away). With no plan to upgrade to it anytime soon, and BT3 not having support for this i can't really use this mod anyway. I know none of that is your fault though.


    There are a number of other actionbar mods that you could test your skins with. Or you could bug someone to make a module to support BT3.

    Sadly because of all the above, i'm gunna have to hold off from rereleasing my skins or adding more skins for this as i simply can't test them properly to a point i'm willing for people to use them. :/


    I'm sorry to hear that.
    Posted in: General AddOns
  • 0

    posted a message on ButtonFacade (was LibButtonSkin-1.0)
    Quote from StormFX »
    Thanks. Can you just add the Color = {} attribute for now and leave the RGBA attributes until everything's converted?


    Yep.

    JJ: Another thing I want to mention. If/when you start doing the whole color selection thing, can you simply enable the color (like the Normal layer is now) for the layers I mentioned before first? That will let me tweak the textures and have them ready before you implement the rest of the code and allow for a flawless transition. I've already got the Normal textures on most skins are ready for the changes.


    Will do. This'll push the time for the Color property back until tomorrow night (I haven't gotten a decent amount of sleep for two nights... forgot how much fun a Voidwalker is when you first get one... :p )
    Posted in: General AddOns
  • 0

    posted a message on InfiniBar-2.0 - Official Thread
    Quote from Phanx »
    Blue works, but it's hideous. Ideally I could use "White" for a lightening effect... but White doesn't do anything more than Yellow does.


    Okay, that at least verifies my assumption. I'll see what I can do.
    Posted in: General AddOns
  • To post a comment, please or register a new account.